[GitHub] [nifi] timeabarna commented on pull request #7353: NIFI-11658 Streamline using single parameter context for nested PGs

2023-06-29 Thread via GitHub
timeabarna commented on PR #7353: URL: https://github.com/apache/nifi/pull/7353#issuecomment-1614151688 Thanks @exceptionfactory and @mcgilman for your review, I've updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1591: MINIFICPP-2130 Custom cache eviction strategy for GitHub Actions

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1591: URL: https://github.com/apache/nifi-minifi-cpp/pull/1591#discussion_r1236873733 ## .github/workflows/ci.yml: ## @@ -142,6 +154,12 @@ jobs: -DENABLE_AZURE=OFF -DENABLE_SPLUNK=OFF -DENABLE_GCP=OFF -DENABLE_PROCFS=OFF

[jira] [Updated] (NIFI-11714) Add General Error Handling for Jetty Framework Server

2023-06-29 Thread Joe Gresock (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Gresock updated NIFI-11714: --- Fix Version/s: 2.0.0 1.23.0 (was: 1.latest)

[jira] [Commented] (NIFI-11714) Add General Error Handling for Jetty Framework Server

2023-06-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738774#comment-17738774 ] ASF subversion and git services commented on NIFI-11714: Commit

[jira] [Commented] (NIFI-11714) Add General Error Handling for Jetty Framework Server

2023-06-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738773#comment-17738773 ] ASF subversion and git services commented on NIFI-11714: Commit

[GitHub] [nifi] asfgit closed pull request #7447: NIFI-11714 Add Error Handler to Jetty Server

2023-06-29 Thread via GitHub
asfgit closed pull request #7447: NIFI-11714 Add Error Handler to Jetty Server URL: https://github.com/apache/nifi/pull/7447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (NIFI-11519) Sensitive Dynamic Properties do not work with Sensitive Parameter Values in DBCP

2023-06-29 Thread Emilio Setiadarma (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emilio Setiadarma reassigned NIFI-11519: Assignee: Emilio Setiadarma > Sensitive Dynamic Properties do not work with

[jira] [Updated] (NIFI-11714) Add General Error Handling for Jetty Framework Server

2023-06-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11714: Fix Version/s: 1.latest 2.latest > Add General Error Handling for Jetty

[jira] [Updated] (NIFI-11714) Add General Error Handling for Jetty Framework Server

2023-06-29 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-11714: Affects Version/s: (was: 1.latest) (was: 2.latest) > Add

[GitHub] [nifi] krisztina-zsihovszki commented on a diff in pull request #7449: NIFI-11334: PutIceberg processor instance interference due same class loader usage

2023-06-29 Thread via GitHub
krisztina-zsihovszki commented on code in PR #7449: URL: https://github.com/apache/nifi/pull/7449#discussion_r1246974701 ## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/catalog/IcebergCatalogFactory.java: ## @@

[jira] [Commented] (NIFI-11765) Upgrade to apache parent version 30

2023-06-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738736#comment-17738736 ] ASF subversion and git services commented on NIFI-11765: Commit

[jira] [Updated] (NIFI-11765) Upgrade to apache parent version 30

2023-06-29 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-11765: Fix Version/s: 2.0.0 1.23.0 (was: 1.latest)

[GitHub] [nifi] mattyb149 closed pull request #7450: NIFI-11765 Upgrade to apache parent version 30

2023-06-29 Thread via GitHub
mattyb149 closed pull request #7450: NIFI-11765 Upgrade to apache parent version 30 URL: https://github.com/apache/nifi/pull/7450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (NIFI-11765) Upgrade to apache parent version 30

2023-06-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738735#comment-17738735 ] ASF subversion and git services commented on NIFI-11765: Commit

[GitHub] [nifi] mattyb149 commented on pull request #7450: NIFI-11765 Upgrade to apache parent version 30

2023-06-29 Thread via GitHub
mattyb149 commented on PR #7450: URL: https://github.com/apache/nifi/pull/7450#issuecomment-1613629986 +1 LGTM, thanks for the upgrade! Merging to support/nifi-1.x and main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [nifi] turcsanyip commented on a diff in pull request #7449: NIFI-11334: PutIceberg processor instance interference due same class loader usage

2023-06-29 Thread via GitHub
turcsanyip commented on code in PR #7449: URL: https://github.com/apache/nifi/pull/7449#discussion_r1246952906 ## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/AbstractIcebergProcessor.java: ## @@ -117,6 +122,15 @@

[GitHub] [nifi] turcsanyip commented on a diff in pull request #7449: NIFI-11334: PutIceberg processor instance interference due same class loader usage

2023-06-29 Thread via GitHub
turcsanyip commented on code in PR #7449: URL: https://github.com/apache/nifi/pull/7449#discussion_r1246952906 ## nifi-nar-bundles/nifi-iceberg-bundle/nifi-iceberg-processors/src/main/java/org/apache/nifi/processors/iceberg/AbstractIcebergProcessor.java: ## @@ -117,6 +122,15 @@

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1584: MINIFICPP-1755 - Use std::span instead of gsl::span

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1584: URL: https://github.com/apache/nifi-minifi-cpp/pull/1584#discussion_r1246939583 ## libminifi/src/utils/LineByLineInputOutputStreamCallback.cpp: ## @@ -67,7 +68,7 @@ void LineByLineInputOutputStreamCallback::readLine() { if (end_of_line

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1577: MINIFICPP-2020 - Protect MINIFI_HOME from mutual access

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1577: URL: https://github.com/apache/nifi-minifi-cpp/pull/1577#discussion_r1246929741 ## libminifi/src/utils/FileMutex.cpp: ## @@ -0,0 +1,171 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1540: MINIFICPP-2082 Move RocksDB stats to RepositoryMetrics

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1540: URL: https://github.com/apache/nifi-minifi-cpp/pull/1540#discussion_r1246924730 ## libminifi/src/core/state/nodes/RepositoryMetricsSourceStore.cpp: ## @@ -0,0 +1,103 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (NIFI-11197) yaml and json conversion processor

2023-06-29 Thread Daniel Stieglitz (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738698#comment-17738698 ] Daniel Stieglitz commented on NIFI-11197: - [~exceptionfactory] I assume what is being asked here

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1592: MINIFICPP-2131 Refactored GetTCP

2023-06-29 Thread via GitHub
fgerlits commented on code in PR #1592: URL: https://github.com/apache/nifi-minifi-cpp/pull/1592#discussion_r1243980137 ## extensions/standard-processors/processors/TailFile.cpp: ## @@ -343,10 +331,11 @@ void TailFile::onSchedule(const std::shared_ptr , throw

[jira] [Created] (MINIFICPP-2156) PutTCP tries to read passphrase from stdin

2023-06-29 Thread Martin Zink (Jira)
Martin Zink created MINIFICPP-2156: -- Summary: PutTCP tries to read passphrase from stdin Key: MINIFICPP-2156 URL: https://issues.apache.org/jira/browse/MINIFICPP-2156 Project: Apache NiFi MiNiFi C++

[jira] [Updated] (NIFI-11761) Timed out minifi restart and kill doesn't work

2023-06-29 Thread Csaba Bejan (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Csaba Bejan updated NIFI-11761: --- Fix Version/s: 2.0.0 1.23.0 > Timed out minifi restart and kill doesn't work >

[jira] [Resolved] (NIFI-11761) Timed out minifi restart and kill doesn't work

2023-06-29 Thread Csaba Bejan (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Csaba Bejan resolved NIFI-11761. Resolution: Fixed > Timed out minifi restart and kill doesn't work >

[jira] [Commented] (NIFI-11761) Timed out minifi restart and kill doesn't work

2023-06-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738615#comment-17738615 ] ASF subversion and git services commented on NIFI-11761: Commit

[jira] [Commented] (NIFI-11761) Timed out minifi restart and kill doesn't work

2023-06-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738614#comment-17738614 ] ASF subversion and git services commented on NIFI-11761: Commit

[GitHub] [nifi] bejancsaba closed pull request #7448: NIFI-11761 Fixed MiNiFi restart issue when graceful shutdown period expires. MiNiFi restart sends bootstrap to background

2023-06-29 Thread via GitHub
bejancsaba closed pull request #7448: NIFI-11761 Fixed MiNiFi restart issue when graceful shutdown period expires. MiNiFi restart sends bootstrap to background URL: https://github.com/apache/nifi/pull/7448 -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (MINIFICPP-2155) Imporve StreamCallbacks error handling

2023-06-29 Thread Martin Zink (Jira)
Martin Zink created MINIFICPP-2155: -- Summary: Imporve StreamCallbacks error handling Key: MINIFICPP-2155 URL: https://issues.apache.org/jira/browse/MINIFICPP-2155 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1587: MINIFICPP-2135 Add SSL support for Prometheus reporter

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1587: URL: https://github.com/apache/nifi-minifi-cpp/pull/1587#discussion_r1246671763 ## docker/test/integration/features/MiNiFi_integration_test_driver.py: ## @@ -53,9 +53,9 @@ def __init__(self, context, feature_id: str):

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1587: MINIFICPP-2135 Add SSL support for Prometheus reporter

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1587: URL: https://github.com/apache/nifi-minifi-cpp/pull/1587#discussion_r1246669182 ## docker/test/integration/cluster/containers/MinifiContainer.py: ## @@ -109,12 +110,16 @@ def _create_properties(self): if not

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1587: MINIFICPP-2135 Add SSL support for Prometheus reporter

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1587: URL: https://github.com/apache/nifi-minifi-cpp/pull/1587#discussion_r124838 ## docker/test/integration/cluster/checkers/PrometheusChecker.py: ## @@ -18,7 +18,16 @@ class PrometheusChecker: def __init__(self): -

[jira] [Updated] (NIFI-11765) Upgrade to apache parent version 30

2023-06-29 Thread Bryan Bende (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bryan Bende updated NIFI-11765: --- Status: Patch Available (was: Open) > Upgrade to apache parent version 30 >

[GitHub] [nifi] bbende opened a new pull request, #7450: NIFI-11765 Upgrade to apache parent version 30

2023-06-29 Thread via GitHub
bbende opened a new pull request, #7450: URL: https://github.com/apache/nifi/pull/7450 # Summary [NIFI-11765](https://issues.apache.org/jira/browse/NIFI-11765) # Tracking Please complete the following tracking steps

[jira] [Created] (NIFI-11765) Upgrade to apache parent version 30

2023-06-29 Thread Bryan Bende (Jira)
Bryan Bende created NIFI-11765: -- Summary: Upgrade to apache parent version 30 Key: NIFI-11765 URL: https://issues.apache.org/jira/browse/NIFI-11765 Project: Apache NiFi Issue Type: Task

[GitHub] [nifi] ferencerdei commented on pull request #7448: NIFI-11761 Fixed MiNiFi restart issue when graceful shutdown period expires. MiNiFi restart sends bootstrap to background

2023-06-29 Thread via GitHub
ferencerdei commented on PR #7448: URL: https://github.com/apache/nifi/pull/7448#issuecomment-1613216957 Thanks for the update +1 from my side -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (NIFI-11759) Remove Distributed Cache Map Service Client from ListHDFS

2023-06-29 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-11759: Fix Version/s: 2.0.0 (was: 2.latest) > Remove Distributed Cache Map Service

[GitHub] [nifi] briansolo1985 commented on pull request #7448: NIFI-11761 Fixed MiNiFi restart issue when graceful shutdown period expires. MiNiFi restart sends bootstrap to background

2023-06-29 Thread via GitHub
briansolo1985 commented on PR #7448: URL: https://github.com/apache/nifi/pull/7448#issuecomment-1613154149 Thanks for your comments. I tried addressed all of them. I had to change the log message differently because with moving the related code to UnixProcessUtils the context has changed

[GitHub] [nifi-minifi-cpp] adamdebreceni opened a new pull request, #1597: MINIFICPP-2153 - Change default merge algorithm

2023-06-29 Thread via GitHub
adamdebreceni opened a new pull request, #1597: URL: https://github.com/apache/nifi-minifi-cpp/pull/1597 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[jira] [Created] (MINIFICPP-2154) Replace SecureSocketGetTCPTest with utils::net::getSSLContext tests

2023-06-29 Thread Martin Zink (Jira)
Martin Zink created MINIFICPP-2154: -- Summary: Replace SecureSocketGetTCPTest with utils::net::getSSLContext tests Key: MINIFICPP-2154 URL: https://issues.apache.org/jira/browse/MINIFICPP-2154

[jira] [Assigned] (MINIFICPP-2154) Replace SecureSocketGetTCPTest with utils::net::getSSLContext tests

2023-06-29 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink reassigned MINIFICPP-2154: -- Assignee: Martin Zink > Replace SecureSocketGetTCPTest with

[jira] [Created] (NIFI-11764) flowfile storage size mismatch

2023-06-29 Thread Giovanni (Jira)
Giovanni created NIFI-11764: --- Summary: flowfile storage size mismatch Key: NIFI-11764 URL: https://issues.apache.org/jira/browse/NIFI-11764 Project: Apache NiFi Issue Type: Improvement

[GitHub] [nifi] bejancsaba commented on a diff in pull request #7448: NIFI-11761 Fixed MiNiFi restart issue when graceful shutdown period expires. MiNiFi restart sends bootstrap to background

2023-06-29 Thread via GitHub
bejancsaba commented on code in PR #7448: URL: https://github.com/apache/nifi/pull/7448#discussion_r1246295415 ## minifi/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/command/StopRunner.java: ## @@ -112,6 +114,19 @@ private void

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1583: MINIFICPP-1719 Replace LibreSSL with OpenSSL 3.1

2023-06-29 Thread via GitHub
szaszm commented on code in PR #1583: URL: https://github.com/apache/nifi-minifi-cpp/pull/1583#discussion_r1246256189 ## extensions/standard-processors/processors/HashContent.h: ## @@ -49,21 +48,25 @@ namespace { // NOLINT HashReturnType ret_val; ret_val.second = 0;

[jira] [Created] (NIFI-11763) evaluateELString not evaluating ContextParameters

2023-06-29 Thread Dirk Hennig (Jira)
Dirk Hennig created NIFI-11763: -- Summary: evaluateELString not evaluating ContextParameters Key: NIFI-11763 URL: https://issues.apache.org/jira/browse/NIFI-11763 Project: Apache NiFi Issue

[GitHub] [nifi] ferencerdei commented on a diff in pull request #7448: NIFI-11761 Fixed MiNiFi restart issue when graceful shutdown period expires. MiNiFi restart sends bootstrap to background

2023-06-29 Thread via GitHub
ferencerdei commented on code in PR #7448: URL: https://github.com/apache/nifi/pull/7448#discussion_r1246230431 ## minifi/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/command/StopRunner.java: ## @@ -112,6 +114,19 @@ private void

[GitHub] [nifi] mark-bathori opened a new pull request, #7449: NIFI-11334: PutIceberg processor instance interference due same class loader usage

2023-06-29 Thread via GitHub
mark-bathori opened a new pull request, #7449: URL: https://github.com/apache/nifi/pull/7449 # Summary [NIFI-11334](https://issues.apache.org/jira/browse/NIFI-11334) # Tracking Please complete the following tracking

[GitHub] [nifi] briansolo1985 opened a new pull request, #7448: NIFI-11761 Fixed MiNiFi restart issue when graceful shutdown period expires. MiNiFi restart sends bootstrap to background

2023-06-29 Thread via GitHub
briansolo1985 opened a new pull request, #7448: URL: https://github.com/apache/nifi/pull/7448 # Summary [NIFI-11761](https://issues.apache.org/jira/browse/NIFI-11761) # Tracking Please complete the following tracking