[jira] [Created] (MINIFICPP-2210) controller: C2 debug command equivalent

2023-08-31 Thread Marton Szasz (Jira)
Marton Szasz created MINIFICPP-2210: --- Summary: controller: C2 debug command equivalent Key: MINIFICPP-2210 URL: https://issues.apache.org/jira/browse/MINIFICPP-2210 Project: Apache NiFi MiNiFi C++

[jira] [Assigned] (MINIFICPP-2209) Small HTTPClient refactor: preconditions and exception safety

2023-08-31 Thread Marton Szasz (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marton Szasz reassigned MINIFICPP-2209: --- Assignee: Marton Szasz > Small HTTPClient refactor: preconditions and exception

[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request, #1648: MINIFICPP-2209 Small HTTPClient refactor: preconditions and exception…

2023-08-31 Thread via GitHub
szaszm opened a new pull request, #1648: URL: https://github.com/apache/nifi-minifi-cpp/pull/1648 … safety - Remove unused header includes - Fix exception safety in curl_slist generation: no longer leaks partial slist - Rename `getCurlSList` to `toCurlSlist`, which is a function

[jira] [Created] (MINIFICPP-2209) Small HTTPClient refactor: preconditions and exception safety

2023-08-31 Thread Marton Szasz (Jira)
Marton Szasz created MINIFICPP-2209: --- Summary: Small HTTPClient refactor: preconditions and exception safety Key: MINIFICPP-2209 URL: https://issues.apache.org/jira/browse/MINIFICPP-2209 Project: Ap

[GitHub] [nifi] mattyb149 opened a new pull request, #7663: NIFI-12010: Handle auto-commit and commit based on driver capabilities

2023-08-31 Thread via GitHub
mattyb149 opened a new pull request, #7663: URL: https://github.com/apache/nifi/pull/7663 # Summary [NIFI-12010](https://issues.apache.org/jira/browse/NIFI-12010) This PR continues the work of [NIFI-11898](https://issues.apache.org/jira/browse/NIFI-11898) by defensively handling cal

[jira] [Updated] (MINIFICPP-2197) centos build very slow

2023-08-31 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2197: --- Status: Patch Available (was: In Progress) > centos build very slow > --

[jira] [Updated] (MINIFICPP-2205) install_cmake_from_binary fails with ARM64

2023-08-31 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2205: --- Status: Patch Available (was: In Progress) > install_cmake_from_binary fails with ARM64

[jira] [Updated] (NIFI-10904) Changing Font Color for Dropdown Menu When Selecting Controller Services

2023-08-31 Thread Margot Tien (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Margot Tien updated NIFI-10904: --- Affects Version/s: 1.23.2 > Changing Font Color for Dropdown Menu When Selecting Controller Services

[jira] [Resolved] (NIFI-10904) Changing Font Color for Dropdown Menu When Selecting Controller Services

2023-08-31 Thread Margot Tien (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Margot Tien resolved NIFI-10904. Fix Version/s: 2.0.0 1.24.0 Resolution: Resolved > Changing Font Color fo

[jira] [Commented] (NIFI-10904) Changing Font Color for Dropdown Menu When Selecting Controller Services

2023-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761032#comment-17761032 ] ASF subversion and git services commented on NIFI-10904: Commit b

[jira] [Commented] (NIFI-10904) Changing Font Color for Dropdown Menu When Selecting Controller Services

2023-08-31 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761030#comment-17761030 ] ASF subversion and git services commented on NIFI-10904: Commit 2

[GitHub] [nifi] mtien-apache merged pull request #7502: NIFI-10904 Changed the font color for drop down menus to avoid the app…

2023-08-31 Thread via GitHub
mtien-apache merged PR #7502: URL: https://github.com/apache/nifi/pull/7502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apac

[jira] [Created] (NIFI-12017) EncodeContent: Allow single line output for base64 and base32

2023-08-31 Thread Umar Hussain (Jira)
Umar Hussain created NIFI-12017: --- Summary: EncodeContent: Allow single line output for base64 and base32 Key: NIFI-12017 URL: https://issues.apache.org/jira/browse/NIFI-12017 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1647: MINIFICPP-2205 fix install_cmake_from_binary on ARM64

2023-08-31 Thread via GitHub
martinzink opened a new pull request, #1647: URL: https://github.com/apache/nifi-minifi-cpp/pull/1647 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1634: MINIFICPP-2146 Add support for SMB networking protocol

2023-08-31 Thread via GitHub
fgerlits commented on code in PR #1634: URL: https://github.com/apache/nifi-minifi-cpp/pull/1634#discussion_r1310138180 ## extensions/smb/SmbConnectionControllerService.cpp: ## @@ -0,0 +1,119 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI

2023-08-31 Thread via GitHub
szaszm commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1311831907 ## extensions/procfs/CpuStat.h: ## @@ -34,7 +34,7 @@ class CpuStatData { public: static std::optional parseCpuStatLine(std::istream& iss); - auto operato

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI

2023-08-31 Thread via GitHub
lordgamez commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1311766434 ## extensions/procfs/CpuStat.h: ## @@ -34,7 +34,7 @@ class CpuStatData { public: static std::optional parseCpuStatLine(std::istream& iss); - auto oper

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI

2023-08-31 Thread via GitHub
szaszm commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1311727826 ## extensions/procfs/CpuStat.h: ## @@ -34,7 +34,7 @@ class CpuStatData { public: static std::optional parseCpuStatLine(std::istream& iss); - auto operato

[jira] [Updated] (MINIFICPP-2198) GPS Extension should be correctly marked as not available on Windows

2023-08-31 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2198: --- Status: Patch Available (was: In Progress) > GPS Extension should be correctly marked as

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1631: MINIFICPP-2174 Send all cached compressed log files through C2

2023-08-31 Thread via GitHub
lordgamez commented on code in PR #1631: URL: https://github.com/apache/nifi-minifi-cpp/pull/1631#discussion_r1311624364 ## libminifi/include/core/logging/internal/LogCompressorSink.h: ## @@ -57,26 +58,44 @@ class LogCompressorSink : public spdlog::sinks::base_sink { ~LogCom

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI

2023-08-31 Thread via GitHub
lordgamez commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1311613512 ## .github/workflows/ci.yml: ## @@ -181,8 +181,8 @@ jobs: name: ubuntu-binaries path: build/bin ubuntu_20_04_clang: Review Comment:

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI

2023-08-31 Thread via GitHub
lordgamez commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1311610367 ## extensions/procfs/CpuStat.h: ## @@ -34,7 +34,7 @@ class CpuStatData { public: static std::optional parseCpuStatLine(std::istream& iss); - auto oper

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1642: MINIFICPP-2204 Fix build with clang16 and upgrade in CI

2023-08-31 Thread via GitHub
martinzink commented on code in PR #1642: URL: https://github.com/apache/nifi-minifi-cpp/pull/1642#discussion_r1311587118 ## extensions/procfs/CpuStat.h: ## @@ -34,7 +34,7 @@ class CpuStatData { public: static std::optional parseCpuStatLine(std::istream& iss); - auto ope

[GitHub] [nifi-minifi-cpp] martinzink commented on a diff in pull request #1644: MINIFICPP-2208 Fix ConfigurationTests failure on ARM64

2023-08-31 Thread via GitHub
martinzink commented on code in PR #1644: URL: https://github.com/apache/nifi-minifi-cpp/pull/1644#discussion_r1311584969 ## extensions/standard-processors/tests/unit/ConfigurationTests.cpp: ## Review Comment: The std::filesystem::temp_directory_path() simply returned /tmp

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1644: MINIFICPP-2208 Fix ConfigurationTests failure on ARM64

2023-08-31 Thread via GitHub
szaszm commented on code in PR #1644: URL: https://github.com/apache/nifi-minifi-cpp/pull/1644#discussion_r1311580302 ## extensions/standard-processors/tests/unit/ConfigurationTests.cpp: ## Review Comment: What was the issue with the original version? -- This is an auto

[jira] [Updated] (MINIFICPP-2208) ConfigurationTests fails on ARM64

2023-08-31 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2208: --- Status: Patch Available (was: In Progress) > ConfigurationTests fails on ARM64 > ---

[jira] [Updated] (MINIFICPP-2206) Use std::string_view in the ctor of Connectable's children

2023-08-31 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2206: --- Status: Patch Available (was: In Progress) > Use std::string_view in the ctor of Connect

[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1646: MINIFICPP-2206 use string_view in the ctors of Connectable's children

2023-08-31 Thread via GitHub
martinzink opened a new pull request, #1646: URL: https://github.com/apache/nifi-minifi-cpp/pull/1646 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[jira] [Resolved] (MINIFICPP-1368) Increment version number on main

2023-08-31 Thread Jira
[ https://issues.apache.org/jira/browse/MINIFICPP-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi resolved MINIFICPP-1368. -- Resolution: Fixed > Increment version number on main >

[jira] [Assigned] (MINIFICPP-2207) The HTTP request method field in HTTPClient and InvokeHTTP should be an enum

2023-08-31 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits reassigned MINIFICPP-2207: - Assignee: Ferenc Gerlits > The HTTP request method field in HTTPClient and I

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1638: MINIFICPP-1774 Set properties from command line arguments

2023-08-31 Thread via GitHub
lordgamez commented on code in PR #1638: URL: https://github.com/apache/nifi-minifi-cpp/pull/1638#discussion_r1311274597 ## minifi_main/MiNiFiMain.cpp: ## @@ -134,7 +135,93 @@ void writeJsonSchema(const std::shared_ptr &configuration, st out << minifi::docs::generateJsonSche

[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1645: MINIFICPP-2198 Correctly mark GPS Extension as unavailable on Windows

2023-08-31 Thread via GitHub
martinzink opened a new pull request, #1645: URL: https://github.com/apache/nifi-minifi-cpp/pull/1645 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [nifi-minifi-cpp] martinzink opened a new pull request, #1644: MINIFICPP-2208 Fix ConfigurationTests failure on ARM64

2023-08-31 Thread via GitHub
martinzink opened a new pull request, #1644: URL: https://github.com/apache/nifi-minifi-cpp/pull/1644 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[jira] [Updated] (MINIFICPP-2208) ConfigurationTests fails on ARM64

2023-08-31 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink updated MINIFICPP-2208: --- Epic Link: MINIFICPP-2048 > ConfigurationTests fails on ARM64 > -

[jira] [Created] (MINIFICPP-2208) ConfigurationTests fails on ARM64

2023-08-31 Thread Martin Zink (Jira)
Martin Zink created MINIFICPP-2208: -- Summary: ConfigurationTests fails on ARM64 Key: MINIFICPP-2208 URL: https://issues.apache.org/jira/browse/MINIFICPP-2208 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1499: MINIFICPP-1372 - Allow async content deletion

2023-08-31 Thread via GitHub
adamdebreceni commented on code in PR #1499: URL: https://github.com/apache/nifi-minifi-cpp/pull/1499#discussion_r1311207052 ## extensions/rocksdb-repos/DatabaseContentRepository.cpp: ## @@ -198,27 +212,63 @@ bool DatabaseContentRepository::exists(const minifi::ResourceClaim &s

[jira] [Created] (MINIFICPP-2207) The HTTP request method field in HTTPClient and InvokeHTTP should be an enum

2023-08-31 Thread Ferenc Gerlits (Jira)
Ferenc Gerlits created MINIFICPP-2207: - Summary: The HTTP request method field in HTTPClient and InvokeHTTP should be an enum Key: MINIFICPP-2207 URL: https://issues.apache.org/jira/browse/MINIFICPP-2207

[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1643: MINIFICPP-2088 InvokeHTTP should check whether it needs to run

2023-08-31 Thread via GitHub
fgerlits opened a new pull request, #1643: URL: https://github.com/apache/nifi-minifi-cpp/pull/1643 ... before it creates/retrieves the HTTP client. --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribut