[GitHub] nifi issue #3114: NIFI-5765 Fixing WriteJsonResult to use chosenDataType whe...

2018-10-30 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/3114 Thanks @ijokarumawak for the quick review! ---

[GitHub] nifi issue #3114: NIFI-5765 Fixing WriteJsonResult to use chosenDataType whe...

2018-10-29 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/3114 Follow-up commit is b/c I found the same bug in PutElasticsearchHttpRecord. I believe that's the only other occurrence. ---

[GitHub] nifi issue #3114: NIFI-5765 Fixing WriteJsonResult to use chosenDataType whe...

2018-10-29 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/3114 Template for testing on the ticket: https://issues.apache.org/jira/browse/NIFI-5765 ---

[GitHub] nifi pull request #3114: NIFI-5765 Fixing WriteJsonResult to use chosenDataT...

2018-10-29 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/3114 NIFI-5765 Fixing WriteJsonResult to use chosenDataType when writing a… …n Array value Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #3090: NIFI-3792 Adding a RetryCount processor to faciliate retry...

2018-10-17 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/3090 Hey @patricker, here's the processor I mentioned. It attempts to avert the livelock scenario by looking at the input queue if it's over a certain size/count divert FFs but there's still the chance

[GitHub] nifi pull request #3090: NIFI-3792 Adding a RetryCount processor to faciliat...

2018-10-17 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/3090 NIFI-3792 Adding a RetryCount processor to faciliate retry logic as w… …ell as penalizing a FlowFile. Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-09-18 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2813 Ah yup, totally different lol. I was thinking GenerateFlowFile but with just a writer + dynamic properties to set fields. Sorry for the confusion! ---

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-09-18 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2813 Is there a reason this processor wasn't just a part of the normal record bundle instead of being thought of as part of a larger reprocessing bundle? If it's just another file in that same nar

[GitHub] nifi issue #2813: NIFI-5084 Added GenerateRecord processor.

2018-09-18 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2813 @MikeThomsen I'm looking for the discussion on the mailing list on why this was decided to not be merged in and I can't find it. I only see the "How would we handle this?" thread[1].

[GitHub] nifi issue #2929: NIFI-5474 ReplaceText RegexReplace evaluates payload as Ex...

2018-08-02 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2929 Hey @ottobackwards, thanks for the PR. I should be able to review this around mid next week. ---

[GitHub] nifi-minifi pull request #117: MINIFI-424 Adding the ability to evaluate boo...

2018-06-13 Thread JPercivall
Github user JPercivall closed the pull request at: https://github.com/apache/nifi-minifi/pull/117 ---

[GitHub] nifi issue #2616: NIFI-5052 Added DeleteByQuery ElasticSearch processor.

2018-04-23 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2616 Hey @MikeThomsen sorry to leave you hanging but I just got super busy with my day job. I may be able to help in a couple weeks can't at the moment. ---

[GitHub] nifi-minifi pull request #117: MINIFI-424 Adding the ability to evaluate boo...

2018-04-22 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/117#discussion_r183258883 --- Diff: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java --- @@ -1176,11 +1191,18 @@ public boolean accept(final

[GitHub] nifi pull request #2637: NIFI-5085 In InvokeHttp, moving the OkHttp Response...

2018-04-18 Thread JPercivall
Github user JPercivall closed the pull request at: https://github.com/apache/nifi/pull/2637 ---

[GitHub] nifi issue #2637: NIFI-5085 In InvokeHttp, moving the OkHttp Response object...

2018-04-18 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2637 Will close, thanks for the review @mattyb149! For linkage: https://github.com/apache/nifi/commit/a0c9bebe241e8960363490cc0378f22d034f8db7 ---

[GitHub] nifi pull request #2637: NIFI-5085 In InvokeHttp, moving the OkHttp Response...

2018-04-16 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/2637 NIFI-5085 In InvokeHttp, moving the OkHttp Response object to a try w… …ith resources Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #2586: NIFI-5021 Moving nifi-elasticsearch-client-service-api to ...

2018-04-01 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2586 @bbende @MikeThomsen since there is another RC of 1.6.0, did you want to merge this in? ---

[GitHub] nifi issue #2547: NIFI-4977 Adding expression language support to the Sender...

2018-03-26 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2547 Awesome, thanks @bbende. I appreciate the review ---

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-26 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 +1 Overall looks good and works as expected. I've built with contrib check and tested using a vanilla instance. I will squash and merge to master. Thanks @MikeThomsen. ---

[GitHub] nifi issue #2547: NIFI-4977 Adding expression language support to the Sender...

2018-03-26 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2547 @bbende I've added the changes and rebased to master ---

[GitHub] nifi pull request #2547: NIFI-4977 Adding expression language support to the...

2018-03-26 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2547#discussion_r177146046 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractSyslogProcessor.java

[GitHub] nifi pull request #2547: NIFI-4977 Adding expression language support to the...

2018-03-26 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2547#discussion_r177145747 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractSyslogProcessor.java

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-25 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Looks good, was able to do a couple simple queries and aggregations. I wasn't able to test HTTPS though as I don't have access to the X-Pack. Were you able to do so @MikeThomsen? The only

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-24 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Hey @MikeThomsen, just reviewed the changes. They look good and I think we're almost there. One thing that is missing is the comment regarding pulling the results into memory. Also, I

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-22 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Hey @MikeThomsen, I'm planning on reviewing this tomorrow evening ---

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-18 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Hey @MikeThomsen, just finished up another round of reviewing. Again, mostly focused on the error handling portion. I hope my review doesn't come off in the wrong way, there is a lot

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175306495 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175306340 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175306133 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175305604 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175305459 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175305389 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175304957 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175304809 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-18 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Taking a look now. WRT: > Ok, I can do that from now on. Shouldn't they be squashed before a merge into master? Yup, they will be squashed prior to merge to mas

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175265212 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175265070 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175265049 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175264989 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175264961 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175264906 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175264876 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175264845 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175264784 --- Diff: nifi-nar-bundles/nifi-standard-services/pom.xml --- @@ -15,6 +15,18 @@ --> http://maven.apache.org/POM/4.0.0; xmlns:xsi="http:

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-17 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Thanks @MikeThomsen, looks like that fixed the NPE. Still needs the License and Notice in the client service nar. Also, it's a bit of an anti-pattern to have the logging and error handling

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175249262 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-15 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Apologises, won't be able to finish the review this evening. I reviewed the restapi nar License and Notice files they look good to go. Just need to do a bit of functional testing and verify

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-15 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 The nifi-elasticsearch-client-service-nar is missing a license and notice. ---

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-15 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Thanks @MikeThomsen I should be able to take another look later tonight ---

[GitHub] nifi pull request #2547: NIFI-4977 Adding expression language support to the...

2018-03-14 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/2547 NIFI-4977 Adding expression language support to the Sender properties… … of PutSyslog Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-12 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 I'm seeing NPE and FlowFile handling exceptions. I didn't do anything special, just using the example query. I'll attach a template. Errors from the logs below. > 2018-03-12 23

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-12 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Template for FlowFile handling exception. [FlowFile_Handling_Exception.txt](https://github.com/apache/nifi/files/1805420/FlowFile_Handling_Exception.txt) ---

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-12 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r173996495 --- Diff: nifi-assembly/pom.xml --- @@ -445,6 +445,24 @@ language governing permissions and limitations under the License. --> 1.

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-12 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Looks like the master build is failing with some check style issues, hence why your builds failed. I'll work on fixing them. ---

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-12 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Reviewing ---

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-12 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Hey @mattyb149, what's your status for this review? From a cursory look, it appears like it just needs an updated pom from @MikeThomsen and the final approval. With talks of 1.6.0 happening

[GitHub] nifi-minifi pull request #117: MINIFI-424 Adding the ability to evaluate boo...

2018-02-27 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-minifi/pull/117 MINIFI-424 Adding the ability to evaluate bootstrap properties in the… … config YAML prior to translation into flow.xml and nifi.properties Thank you for submitting

[GitHub] nifi issue #2219: NiFi-4436: Add UI controls for starting/stopping/reverting...

2017-12-21 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2219 Small bug with the visuals on nested flows: - Start with a versioned flow that contains a nested versioned flow. Both are up to date. - Make a change to the nested flow. - Notice

[GitHub] nifi issue #2219: NiFi-4436: Add UI controls for starting/stopping/reverting...

2017-12-21 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2219 Not sure if I should comment here or capture in a new ticket since this PR is so big but from the Registry Clients page, it would be nice to have an icon to click to open the Registry in a new tab. ---

[GitHub] nifi issue #2337: NIFI-4475 Changing the get(batchSize) method in StandardPr...

2017-12-14 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2337 Fantastic thanks @markap14 ---

[GitHub] nifi issue #2337: NIFI-4475 Changing the get(batchSize) method in StandardPr...

2017-12-14 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2337 Thanks for the review @markap14, I pushed out a new commit with those two changes. ---

[GitHub] nifi pull request #2337: NIFI-4475 Changing the get(batchSize) method in Sta...

2017-12-13 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/2337 NIFI-4475 Changing the get(batchSize) method in StandardProcessSessio… …n so that it checks all connections before returning nothing Thank you for submitting a contribution to Apache

[GitHub] nifi-minifi pull request #103: MINIFI-417 Upgrading underlying NiFi libs to ...

2017-12-13 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/103#discussion_r156687353 --- Diff: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java --- @@ -77,7 +77,7 @@ public final

[GitHub] nifi-minifi pull request #103: MINIFI-417 Upgrading underlying NiFi libs to ...

2017-12-12 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-minifi/pull/103 MINIFI-417 Upgrading underlying NiFi libs to 1.4.0 from 1.2.0 Thank you for submitting a contribution to Apache NiFi - MiNiFi. In order to streamline the review of the contribution

[GitHub] nifi issue #2154: NIFI-2663: Add WebSocket support for MQTT processors

2017-10-29 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2154 Hello Sebastian, yup that subclassing strategy makes sense. ---

[GitHub] nifi issue #2154: NIFI-2663: Add WebSocket support for MQTT processors

2017-09-17 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2154 @SebastianCarroll the way the test cases are set up you don't need to copy and paste the tests themselves. What you'll do is extend common/Test*MqttCommon in order to get all the junit tests. See

[GitHub] nifi issue #2004: NIFI-2162 Updating OkHttp to 3.8.1 and OkHttp-Digest to 1....

2017-09-10 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2004 Thanks for the review @trkurc, sorry it took me so long. ---

[GitHub] nifi issue #2004: NIFI-2162 Updating OkHttp to 3.8.1 and OkHttp-Digest to 1....

2017-09-09 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2004 @trkurc finally got around to adding comments. I also rebased to the latest master ---

[GitHub] nifi issue #2004: NIFI-2162 Updating OkHttp to 3.8.1 and OkHttp-Digest to 1....

2017-08-09 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2004 Thanks for the review @trkurc and sorry for the delay in my responses. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #2004: NIFI-2162 Updating OkHttp to 3.8.1 and OkHttp-Diges...

2017-08-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2004#discussion_r132318693 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -500,48

[GitHub] nifi pull request #2004: NIFI-2162 Updating OkHttp to 3.8.1 and OkHttp-Diges...

2017-08-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2004#discussion_r132318357 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/ProxyAuthenticator.java

[GitHub] nifi pull request #2004: NIFI-2162 Updating OkHttp to 3.8.1 and OkHttp-Diges...

2017-07-12 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/2004 NIFI-2162 Updating OkHttp to 3.8.1 and OkHttp-Digest to 1.13 and refa… …ctoring InvokeHttp to adjust for changes Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #1984: NIFI-4155: Expand EnforceOrder capability to cluster

2017-07-07 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1984 @ijokarumawak ah I remember seeing that come up but didn't realize it was finished. That's awesome! Definitely agree with your second statement but I'd add that we should warn the users

[GitHub] nifi issue #1984: NIFI-4155: Expand EnforceOrder capability to cluster

2017-07-06 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1984 @ijokarumawak while we are still using ZooKeeper as the only cluster state provider and using it for the cluster coordinator, are we sure we want to add this option? This goes hand-in-hand

[GitHub] nifi pull request #1922: NIFI-4075 Updating 'addRemoteProcessGroup' in Stand...

2017-06-16 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1922 NIFI-4075 Updating 'addRemoteProcessGroup' in StandardFlowSerializer … …to properly use ScheduledStateLookup Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi issue #1907: NIFI-4047: Addressed issue with inconsistent Lexical polic...

2017-06-09 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1907 +1 Contrib check build, tested the template and other potential quoting/character related issues and all worked as expected. The only thing of note that I found is that the Sql

[GitHub] nifi issue #1907: NIFI-4047: Addressed issue with inconsistent Lexical polic...

2017-06-09 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1907 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1553: NIFI-1449 - Migrate PutEmail tests from Mock class to List...

2017-05-02 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1553 Also the travis failures appear to be unrelated but there are merge conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-05-02 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r114464910 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java

[GitHub] nifi pull request #1705: NIFI-3633 Adding a try with resources so the OkHttp...

2017-04-26 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1705 NIFI-3633 Adding a try with resources so the OkHttp response is prope… …rly closed Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi pull request #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1576#discussion_r110553180 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processors/src/main/java/org/apache/nifi/processors/morphlines/ImplementMorphlines.java

[GitHub] nifi pull request #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1576#discussion_r110552745 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-nar/pom.xml --- @@ -0,0 +1,41 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1576#discussion_r110553085 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processors/src/main/java/org/apache/nifi/processors/morphlines/ImplementMorphlines.java

[GitHub] nifi pull request #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1576#discussion_r110552988 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-nar/pom.xml --- @@ -0,0 +1,41 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1576#discussion_r110552955 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-nar/pom.xml --- @@ -0,0 +1,41 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1576#discussion_r110553363 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processors/pom.xml --- @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM

[GitHub] nifi pull request #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1576#discussion_r110552730 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processors/pom.xml --- @@ -0,0 +1,110 @@ + + +http://maven.apache.org/POM

[GitHub] nifi pull request #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1576#discussion_r110553041 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processors/src/main/java/org/apache/nifi/processors/morphlines/ImplementMorphlines.java

[GitHub] nifi pull request #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1576#discussion_r110552680 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/pom.xml --- @@ -0,0 +1,35 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="

[GitHub] nifi pull request #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1576#discussion_r110552773 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processors/src/main/java/org/apache/nifi/processors/morphlines/ImplementMorphlines.java

[GitHub] nifi issue #1576: NIFI-3518 Create a Morphlines processor

2017-04-09 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1576 Sorry for the delay @WilliamNouet . I am going to look at it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110550161 --- Diff: nifi-bootstrap/pom.xml --- @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. --> nifi-ut

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110550645 --- Diff: nifi-bootstrap/pom.xml --- @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. --> nifi-ut

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110550466 --- Diff: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java --- @@ -420,15 +424,15 @@ public static Element getChild

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110550470 --- Diff: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/NotificationServiceManager.java --- @@ -420,15 +424,15 @@ public static Element getChild

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

2017-04-09 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1610#discussion_r110550270 --- Diff: nifi-bootstrap/pom.xml --- @@ -34,13 +34,26 @@ language governing permissions and limitations under the License. --> nifi-ut

[GitHub] nifi issue #1576: NIFI-3518 Create a Morphlines processor

2017-03-24 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1576 Hey @WilliamNouet, sorry for not giving an update. Been too busy with other obligations. I'll try to get back to this when I have more free time. --- If your project is set up for it, you can

[GitHub] nifi pull request #1610: NIFI-3633 Adding HttpNotificationService.

2017-03-21 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1610 NIFI-3633 Adding HttpNotificationService. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi pull request #1598: NIFI-3614 Adding "return" statement to HandleHttpRe...

2017-03-16 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1598 NIFI-3614 Adding "return" statement to HandleHttpResponse when status… …Code is not a number Thank you for submitting a contribution to Apache NiFi. In order to

[GitHub] nifi issue #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-03-05 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1328 Hey @trixpan, sorry for the delay but I just rebased it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

  1   2   3   4   5   6   7   >