[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-03-01 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r103801190 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102967741 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AbstractKiteProcessor.java --- @@ -44,8

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102966195 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/java/org/apache/nifi/processors/kite/AbstractKiteProcessor.java --- @@ -44,8

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102965258 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/pom.xml --- @@ -0,0 +1,35 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102964711 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102964118 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102963978 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102963716 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102963122 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102963040 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102962312 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102962214 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102961823 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-24 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102961547 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java

[GitHub] nifi issue #689: NIFI-2305: Do not run processors that are marked as Primary...

2017-02-14 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/689 I'm in favor of closing it, sound good @markap14? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-01-15 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1328 Hey @pvillard31, thanks for the feedback. I believe I've addressed all the comments. For the exception handling I created another relationship. The set state fail relationship will typically

[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption

2017-01-06 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1201 Hey @jskora, it appears you have check style issues. I'm not entirely sure how you pulled in the commits but are you able to rebase instead? This throws off how I normally squash/sign-off

[GitHub] nifi pull request #1397: NIFI-3286 Updating occurances of 'Scope.NODE' in De...

2017-01-05 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1397 NIFI-3286 Updating occurances of 'Scope.NODE' in Developer doc to 'Sc… …ope.LOCAL' You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi pull request #1396: NIFI-3283 Fixing typo in UpdateAttribute error mess...

2017-01-05 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1396 NIFI-3283 Fixing typo in UpdateAttribute error message You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi NIFI-3283

[GitHub] nifi pull request #1386: NIFI-3274 Adding WriteAheadLog configuration option...

2017-01-03 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1386 NIFI-3274 Adding WriteAheadLog configuration options to WriteAheadLog… …LocalStateProvider You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption

2017-01-03 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1201 Hey @jskora, sorry this has sat for so long, this PR review should have been prioritized. That said, there appear to be merge conflicts and checkstyle issues. I could resolve them for you if you

[GitHub] nifi issue #1201: NIFI-2890 Provenance Repository Corruption

2017-01-03 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1201 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1372: NIFI-3260 Official Docker Image

2016-12-29 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1372 @apiri @jdye64 had replied to my comment on the JIRA here[1] probably best to keep the convo here though. [1] https://issues.apache.org/jira/browse/NIFI-3260?focusedCommentId=15786103

[GitHub] nifi issue #1372: NIFI-3260 Official Docker Image

2016-12-29 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1372 Hey @jdye64, thanks for starting this so quickly! It will be great to have an official nifi docker image. I'm not sure the way you have it set up currently is the best solution

[GitHub] nifi pull request #1371: NIFI-1582 Fixing how failures with state are handle...

2016-12-29 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1371#discussion_r94175773 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes

[GitHub] nifi pull request #1371: NIFI-1582 Fixing how failures with state are handle...

2016-12-29 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1371#discussion_r94168049 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes

[GitHub] nifi pull request #1371: NIFI-1582 Fixing how failures with state are handle...

2016-12-29 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1371#discussion_r94167776 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes

[GitHub] nifi pull request #1371: NIFI-1582 Fixing how failures with state are handle...

2016-12-29 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1371#discussion_r94167717 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes

[GitHub] nifi pull request #1371: NIFI-1582 Fixing how failures with state are handle...

2016-12-29 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1371 NIFI-1582 Fixing how failures with state are handled and improving fl… …owfile handling You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi issue #1356: NIFI-3249 - UpdateAttribute performance improvements

2016-12-28 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1356 +1 Visually verified code and did a contrib-check build. In standalone tested many different updateAttribute configurations hitting: regular update, delete, stateful update, and stateful

[GitHub] nifi issue #1356: NIFI-3249 - UpdateAttribute performance improvements

2016-12-28 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1356 Sorry @brosander but I was a bit wrong when talking about the ordering of the Delete; I should have tested first. It appears that instead of deleting both attributes that were initially

[GitHub] nifi pull request #1356: NIFI-3249 - UpdateAttribute performance improvement...

2016-12-28 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1356#discussion_r94050652 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes

[GitHub] nifi-site pull request #9: NIFI-3258 Updating links to HTTPS

2016-12-27 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-site/pull/9 NIFI-3258 Updating links to HTTPS You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi-site NIFI-3258 Alternatively you can

[GitHub] nifi pull request #1356: NIFI-3249 - UpdateAttribute performance improvement...

2016-12-27 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1356#discussion_r93950599 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes

[GitHub] nifi pull request #1356: NIFI-3249 - UpdateAttribute performance improvement...

2016-12-27 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1356#discussion_r93949217 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes

[GitHub] nifi-minifi pull request #69: MINIFI-172 Updating last remanents of the 1.1....

2016-12-22 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-minifi/pull/69 MINIFI-172 Updating last remanents of the 1.1.0 upgrade You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi-minifi MINIFI

[GitHub] nifi-minifi pull request #68: MINIFI-128 Adjusting handling of change ingest...

2016-12-22 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/68#discussion_r93628936 --- Diff: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java --- @@ -1197,7 +1197,14 @@ public void start() throws

[GitHub] nifi-minifi pull request #68: MINIFI-128 Adjusting handling of change ingest...

2016-12-21 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/68#discussion_r93529968 --- Diff: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/ShutdownHook.java --- @@ -55,10 +55,12 @@ public void run

[GitHub] nifi issue #1345: NIFI-3234: Updated two broken links in the Encryption Conf...

2016-12-20 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1345 +1 Changes appear in line with the intended description of links. Thanks @thesolson I will merge it in. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi-minifi pull request #67: MINIFI-144 Bumping logback version to 1.1.8

2016-12-20 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-minifi/pull/67 MINIFI-144 Bumping logback version to 1.1.8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi-minifi MINIFI-144

[GitHub] nifi-minifi pull request #66: MINIFI-157 Adjusting toolkit readme to align w...

2016-12-20 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-minifi/pull/66 MINIFI-157 Adjusting toolkit readme to align with 0.1.0 features Thank you for submitting a contribution to Apache NiFi - MiNiFi. In order to streamline the review

[GitHub] nifi issue #1327: NIFI-3194: PutElasticsearchHttp should route flowfiles to ...

2016-12-19 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1327 +1 Visually verified code and did a contrib-check build. In a standalone instance, tested many different variations of misconfigured PutES processor hitting ES 2.3.3 and all worked

[GitHub] nifi pull request #1327: NIFI-3194: PutElasticsearchHttp should route flowfi...

2016-12-19 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1327#discussion_r93095656 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #1327: NIFI-3194: PutElasticsearchHttp should route flowfi...

2016-12-19 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1327#discussion_r93070719 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi issue #1327: NIFI-3194: PutElasticsearchHttp should route flowfiles to ...

2016-12-19 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1327 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1333: NIFI-3206: Add ifElse function to Expression Language

2016-12-16 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1333 +1 Visually verified code and did a contrib check build. In a standalone instance, I tested many different expressions using ifElse and all worked as expected. Thanks @mattyb149 I

[GitHub] nifi pull request #1333: NIFI-3206: Add ifElse function to Expression Langua...

2016-12-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1333#discussion_r92842330 --- Diff: nifi-docs/src/main/asciidoc/expression-language-guide.adoc --- @@ -963,6 +963,36 @@ Expressions will provide the following results

[GitHub] nifi pull request #1333: NIFI-3206: Add ifElse function to Expression Langua...

2016-12-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1333#discussion_r92838500 --- Diff: nifi-docs/src/main/asciidoc/expression-language-guide.adoc --- @@ -963,6 +963,36 @@ Expressions will provide the following results

[GitHub] nifi pull request #1333: NIFI-3206: Add ifElse function to Expression Langua...

2016-12-16 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1333#discussion_r92834377 --- Diff: nifi-docs/src/main/asciidoc/expression-language-guide.adoc --- @@ -963,6 +963,36 @@ Expressions will provide the following results

[GitHub] nifi pull request #1328: NIFI-1682 Adding RollingWindowOperation processor

2016-12-13 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1328 NIFI-1682 Adding RollingWindowOperation processor You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi NIFI-1682-rebased

[GitHub] nifi pull request #1325: NIFI-3192 Adding a check if the FlowFile is null to...

2016-12-13 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1325 NIFI-3192 Adding a check if the FlowFile is null to UpdateAttribute You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi NIFI-3192

[GitHub] nifi-minifi pull request #64: MINIFI-153 - Adding proxy settings to remote p...

2016-12-12 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/64#discussion_r92000958 --- Diff: minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/RemoteProcessGroupSchemaV2.java --- @@ -0,0

[GitHub] nifi-minifi pull request #64: MINIFI-153 - Adding proxy settings to remote p...

2016-12-12 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/64#discussion_r92008401 --- Diff: minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/RemoteProcessGroupSchema.java --- @@ -78,9 +80,14

[GitHub] nifi-minifi pull request #64: MINIFI-153 - Adding proxy settings to remote p...

2016-12-12 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/64#discussion_r92008152 --- Diff: minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/RemoteProcessGroupSchema.java --- @@ -91,6 +98,10

[GitHub] nifi issue #1318: NIFI-3173: When a template is created with multiple compon...

2016-12-12 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1318 @markap14 I hit a case where a CS wasn't preserved. I'll outline it in the same way you listed your example in the comments: G1 -- C1 | | G2 -- C2 |\ | P1

[GitHub] nifi issue #1318: NIFI-3173: When a template is created with multiple compon...

2016-12-12 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1318 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi-minifi pull request #63: MINIFI-154 Adding support for Controller Servi...

2016-12-07 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-minifi/pull/63 MINIFI-154 Adding support for Controller Services You can merge this pull request into a Git repository by running: $ git pull https://github.com/JPercivall/nifi-minifi MINIFI-154

[GitHub] nifi pull request #1290: Fix NIFI-3142: ExtractHL7Attribute processor: Route...

2016-12-06 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1290#discussion_r91182574 --- Diff: nifi-nar-bundles/nifi-hl7-bundle/nifi-hl7-processors/src/main/java/org/apache/nifi/processors/hl7/ExtractHL7Attributes.java --- @@ -196,8 +196,8

[GitHub] nifi issue #319: NIFI-1582 added state to UpdateAttribute as well as updated...

2016-12-06 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/319 @mattyb149 pushed out a new commit adding documentation on the init value requirements and clarification on the "empty" value. Thanks for reviewing documentation too! I tota

[GitHub] nifi issue #319: NIFI-1582 added state to UpdateAttribute as well as updated...

2016-12-06 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/319 @mattyb149 removed the default value, added a validation check so that it is invalid if it is configured for state but has no initial value, and added a check in the unit tests. --- If your

[GitHub] nifi pull request #319: NIFI-1582 added state to UpdateAttribute as well as ...

2016-12-06 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/319#discussion_r91147897 --- Diff: nifi-nar-bundles/nifi-update-attribute-bundle/nifi-update-attribute-processor/src/main/java/org/apache/nifi/processors/attributes/UpdateAttribute.java

[GitHub] nifi issue #1297: NIFI-3133: Ensure correct checks against Remote Group Port...

2016-12-05 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1297 +1 Visually verified code and did a contrib-check build. In a secure 3 node cluster ran through a number of tests involving RPGs, Input/Output ports and policies. I also ran a standalone

[GitHub] nifi pull request #1297: NIFI-3133: Ensure correct checks against Remote Gro...

2016-12-05 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1297#discussion_r90965006 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java

[GitHub] nifi pull request #1297: NIFI-3133: Ensure correct checks against Remote Gro...

2016-12-05 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1297#discussion_r90964122 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java

[GitHub] nifi issue #1297: NIFI-3133: Ensure correct checks against Remote Group Port...

2016-12-05 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1297 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1298: NIFI-3149 Adding proper literal support for number ...

2016-12-05 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1298 NIFI-3149 Adding proper literal support for number operators ('-' and… … '+') to ANTLR parser and UI highlighting You can merge this pull request into a Git repository by running: $ git

[GitHub] nifi issue #1296: NIFI-3145 Rewriting double validation in NumberParsing

2016-12-05 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1296 @mattyb149 I just pushed out a new commit adding the "a-f" handling and tests for it. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #1296: NIFI-3145 Rewriting double validation in NumberPars...

2016-12-04 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1296 NIFI-3145 Rewriting double validation in NumberParsing Adding more tests to TestQuery You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi issue #1288: NIFI-3140: Restored optional type handling in FetchElastic...

2016-12-02 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1288 +1 Visually verified code and did a contrib-check build. In a standalone instance I ran FetchElasticsearchHTTP with and without a "type" hitting a secure 2.3 ES instance. Al

[GitHub] nifi pull request #1276: NIFI-3095: Add EL support to Elasticsearch 2.x (and...

2016-11-30 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1276#discussion_r90293399 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #1276: NIFI-3095: Add EL support to Elasticsearch 2.x (and...

2016-11-30 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1276#discussion_r90292509 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #1276: NIFI-3095: Add EL support to Elasticsearch 2.x (and...

2016-11-30 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1276#discussion_r90289603 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #1282: NIFI-3112 Revert "NIFI-2199 - allows nifi.sh restar...

2016-11-29 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1282 NIFI-3112 Revert "NIFI-2199 - allows nifi.sh restart through ssh" This reverts commit 88d125137e3bf3faf80b522edf5cf14f99419d60. You can merge this pull request into a Git repository

[GitHub] nifi-minifi pull request #59: MINIFI-125 Migrating the Bootstrap and Resourc...

2016-11-29 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi-minifi/pull/59#discussion_r90129643 --- Diff: minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/RunMiNiFi.java --- @@ -367,11 +399,40 @@ private synchronized void

[GitHub] nifi-minifi pull request #59: MINIFI-125 Migrating the Bootstrap and Resourc...

2016-11-29 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-minifi/pull/59 MINIFI-125 Migrating the Bootstrap and Resources modules changes from NiFi 1.0 and 1.1 This does not include the changes for: variable registry and encrypted properties. Both are much

[GitHub] nifi-minifi pull request #58: MINIFI-126 Adjusting default JVM size and remo...

2016-11-28 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-minifi/pull/58 MINIFI-126 Adjusting default JVM size and removing bootstrap properti… …es relating to Java 7 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi-minifi pull request #57: MINIFI-137 Adding option to RPGs to transmit v...

2016-11-28 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi-minifi/pull/57 MINIFI-137 Adding option to RPGs to transmit via HTTP. Also corrected… … a typo that had RPGs as 'Remote Processing Groups' instead of 'Remote Process Groups' (extra 'ing'). You can

[GitHub] nifi issue #1267: NIFI-3091: Ensure that we set the appropriate size on Flow...

2016-11-23 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1267 For tracking, this PR fixes the bug that was introduced here: https://github.com/apache/nifi/commit/aa99cc68224f104ad13396e2102126db6332e5c7#diff-f010d6e495dd9553ac1c60ca175f14d7R2583 --- If your

[GitHub] nifi issue #1267: NIFI-3091: Ensure that we set the appropriate size on Flow...

2016-11-23 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1267 +1 Visually verified code and did a contrib check build. In standalone and a 3 node secure cluster I tested a flow which failed beforehand. I also reverted the change

[GitHub] nifi issue #1266: NIFI-3088: Ensure that on recovery of FlowFile Repository,...

2016-11-23 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1266 Accidentally posted the "+1" comment on the wrong ticket. Will re-post here: +1 Visually verified code and did a contrib check build. In standalone and a 3 node secu

[GitHub] nifi issue #1267: NIFI-3091: Ensure that we set the appropriate size on Flow...

2016-11-23 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1267 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1267: NIFI-3091: Ensure that we set the appropriate size on Flow...

2016-11-23 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1267 +1 Visually verified code and did a contrib check build. In standalone and a 3 node secure cluster built up a large queue of flowfiles, stopped the instances and removed the flow.xml

[GitHub] nifi issue #1266: NIFI-3088: Ensure that on recovery of FlowFile Repository,...

2016-11-23 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1266 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1264: NIFI-3086 Updated TailFile.java to deal with windows paths...

2016-11-22 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1264 +1 Fixes the windows issues. Thanks @jtstorck! I will merge it in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1264: NIFI-3086 Updated TailFile.java to deal with windows paths...

2016-11-22 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1264 Hey @jtstorck, couple of check style issues: [WARNING] src/test/java/org/apache/nifi/processors/standard/TestTailFile.java[581] (sizes) LineLength: Line is longer than 200 characters

[GitHub] nifi pull request #1260: NIFI-3084 Fixing TestPersistentProvenanceRepository...

2016-11-22 Thread JPercivall
GitHub user JPercivall opened a pull request: https://github.com/apache/nifi/pull/1260 NIFI-3084 Fixing TestPersistentProvenanceRepository and closing a str… …eam leak in RecordReaders You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #1259: Added posix guard to ignore tests on windows

2016-11-22 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1259 +1 These tests are being ignored instead of "fixed" because Windows does not support POSIX[1] and these tests rely on them in order to test some specific scenarios. Thank

[GitHub] nifi issue #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-21 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1233 +1 Visually verified code and did a contrib check build. Ran a stand-alone instance hitting an ES 5 cluster with and without the security x-pack. All comments and L changes have been

[GitHub] nifi issue #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-21 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/1233 @mattyb149 ran into two weird errors while testing the lastest update. First, I ran into this when I attempted to do a request with the wrong attribute name (and thus there were

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-21 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88926499 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-21 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88924961 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-nar/src/main/resources/META-INF/NOTICE --- @@ -242,11 +356,66 @@ The following

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-21 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88924216 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-nar/src/main/resources/META-INF/NOTICE --- @@ -229,8 +229,122 @@ The following

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-21 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88924576 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-nar/src/main/resources/META-INF/NOTICE --- @@ -242,11 +356,66 @@ The following

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-21 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88924805 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-nar/src/main/resources/META-INF/NOTICE --- @@ -242,11 +356,66 @@ The following

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88527446 --- Diff: nifi-nar-bundles/nifi-elasticsearch-5-bundle/nifi-elasticsearch-5-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,252 @@ +nifi

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88526691 --- Diff: nifi-nar-bundles/nifi-elasticsearch-5-bundle/nifi-elasticsearch-5-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,252 @@ +nifi

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88527105 --- Diff: nifi-nar-bundles/nifi-elasticsearch-5-bundle/nifi-elasticsearch-5-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,252 @@ +nifi

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88524040 --- Diff: nifi-nar-bundles/nifi-elasticsearch-5-bundle/nifi-elasticsearch-5-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,262

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88520091 --- Diff: nifi-nar-bundles/nifi-elasticsearch-5-bundle/nifi-elasticsearch-5-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,252 @@ +nifi

[GitHub] nifi pull request #1233: NIFI-3011: Added Elasticsearch5 processors

2016-11-17 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/1233#discussion_r88526373 --- Diff: nifi-nar-bundles/nifi-elasticsearch-5-bundle/nifi-elasticsearch-5-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,252 @@ +nifi

<    1   2   3   4   5   6   7   >