Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175411128
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175411050
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175407337
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2518
Had to rebase because of the commit that added `ScanHBase`. That doesn't
have visibility labels added to it yet. That needs to be done. Keeping this
ticket open because there's plenty that can
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
> I hope my review doesn't come off in the wrong way, there is a lot of
great work here and I just want to make sure the usability is top notch.
Not at all. It's all fair and g
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175296639
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -196,6
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175286408
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -137,6
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175286257
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoIT.java
---
@@ -96,6
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175286235
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -86,19
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175286234
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -169,14
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175285785
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -86,19
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
Ok. It should all be there now.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175271885
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175271865
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175271759
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175271747
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175271738
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175271547
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175271557
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175271522
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175271497
--- Diff: nifi-nar-bundles/nifi-standard-services/pom.xml ---
@@ -15,6 +15,18 @@
-->
http://maven.apache.org/POM/4.0.0;
xmlns:xsi=&q
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
@JPercivall Thanks for the feedback. I'll get to working on these. WRT:
> Lastly, it's preferred if you don't squash your commits every time. If
you don't, that allows the revie
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
@JPercivall Done.
---
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2560
NIFI-4989 Made PutMongo able to use nested lookup keys, a query paramâ¦
⦠and multiple lookup keys.
Thank you for submitting a contribution to Apache NiFi.
In order
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2517
Sorry, haven't had time. There's a merge conflict now. Can you fix that?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2540
Saw you opened a new version of this. Can you close this one?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
@JPercivall It's ready for review.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2553
@david-streamlio thanks for the link.
> Is there another car bundle that uses a Docker image for integration
testing that I can use as an example?
The Mongo package, sorta.
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174883410
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174881995
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174874403
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/pool/ResourcePoolImpl.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174881541
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2553
You should strongly consider setting up some integration tests that can be
run against a simple Docker image. All you have to do with NiFi to get that
done is add a few classes
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174881132
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174873036
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174880893
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174872527
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174878320
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/test/java/org/apache/nifi/pulsar/TestStandardPulsarClientService.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174882988
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174884957
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/PublishPulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174883778
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/PublishPulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174884531
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/PublishPulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174879831
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174872630
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174874448
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/pool/ResourcePoolImpl.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174884100
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/PublishPulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174878122
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/pool/ResourcePoolImpl.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174879028
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/pom.xml ---
@@ -0,0 +1,78 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174872872
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174879478
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174866298
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/pool/PoolableResource.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174882429
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174882522
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/ConsumePulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174884863
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/PublishPulsar_1_0.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174868443
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/pool/ResourceFactory.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174874129
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174878824
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/test/java/org/apache/nifi/pulsar/TestStandardPulsarClientService.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174865149
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/pom.xml ---
@@ -0,0 +1,40 @@
+
+
+http://maven.apache.org/POM
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174866349
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/pool/PoolableResource.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174866791
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/pool/ResourceExceptionHandler.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174865317
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/PulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2553#discussion_r174865373
--- Diff:
nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/PulsarClientPool.java
---
@@ -0,0
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2501
@pvillard31 Can you close this?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2494
@derekstraka You have a merge conflict now.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2549#discussion_r174761784
--- Diff:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2548
+1 LGTM
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2493
Pulsar looks interesting, so if you can do the rebase I'll try to help out
with the review.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2493
@david-streamlio Looks like you pulled in about 30 some commits from other
folks into this. Can you rebase the branch so that only your commits are part
of the PR?
---
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2546
NIFI-4975 Add GridFS processors
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2501
@pvillard31 @robertrbruno I checked in a new commit based on the feedback.
Please take a look when you have a min.
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2501#discussion_r174483646
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2501#discussion_r174483710
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
2/3 builds pass now.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
@JPercivall @mattyb149 Once I changed the code to use `transfer(FlowFile,
Relationship)` and not `transfer(List, Relationship)` the error stopped
happening.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
@JPercivall @mattyb149 That exception only happens for me when I stop the
processor. It happens here:
``
if (hitsFlowFiles.size() > 0) {
session.transfer(hitsFlowFi
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r174078307
--- Diff: nifi-assembly/pom.xml ---
@@ -445,6 +445,24 @@ language governing permissions and limitations under
the License. -->
1.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2150
@pvillard31 @m-hogue Think we can close the loop on this one?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2501
@pvillard31 If you have a min this is a small one that'd be good to have in
1.6. @robertrbruno wrote 95% of it, but I took his patch from Jira and made it
into a PR. We've both kicked the tires
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2530
+1 LGTM.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
Rebased and building. @mattyb149 I changed the functionality to match the
GetMongo functionality you reviewed recently. Had to spend a while getting the
build to work again.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2448
@pvillard31 I found that a catch block was suppressing a critical problem
with how I was handling the input flowfile. When I'd call `session.commit()`
after a block of results were written
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2448
@pvillard31 Done.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2448
Will do. I should have it rebased tonight unless something comes up.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2527
@bdesert When I read the commit, I wasn't sure what regression it was
actually fixing.
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2527
What sort of regression was this supposed to address?
---
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r173582090
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/FetchSolr.java
---
@@ -0,0 +1,401
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r173581872
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/FetchSolr.java
---
@@ -0,0 +1,401
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r173581678
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -66,6 +67,15
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r173485840
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/DeleteHBaseRow.java
---
@@ -103,6 +103,17
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r173484771
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r173484741
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/main/java/org/apache/nifi/hbase
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r173483953
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r173483514
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
---
@@ -385,7 +427,18
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r173482943
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r173482568
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
---
@@ -194,6 +220,12
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r173482333
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
---
@@ -141,6 +149,16
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r173482233
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java
---
@@ -255,7 +253,16 @@ public
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r173455925
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseCell.java
---
@@ -96,16 +97,18
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r173346825
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/test/java/org/apache/nifi/processors/solr/TestFetchSolr.java
---
@@ -0,0 +1,380
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r173344378
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -66,6 +67,15
901 - 1000 of 1373 matches
Mail list logo
