[GitHub] nifi pull request #3193: NIFI-5854 Added TimeUnit enhancements (microseconds...

2018-11-30 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/3193 NIFI-5854 Added TimeUnit enhancements (microseconds, decimal parsing) Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi-minifi-cpp issue #445: MINIFICPP-681 - Add content hash processor

2018-11-28 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/445 You can also look at [`CryptographicHashContent`](https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236898636 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236860010 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236860247 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236859763 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236840513 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236840020 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java

[GitHub] nifi-registry pull request #148: NIFIREG-211 Initial work for adding extenio...

2018-11-27 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/148#discussion_r236839456 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/extension/ExtensionBundleVersionMetadata.java

[GitHub] nifi pull request #3180: NIFI-5833 Treat GetTwitter API properties as sensit...

2018-11-20 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/3180 NIFI-5833 Treat GetTwitter API properties as sensitive Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #3137: NIFI-5797 : EscapedJava for FlattenJson

2018-11-06 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/3137 Can you please add some explanation for why this change is submitted, documentation, and at least one unit test? Thank you. ---

[GitHub] nifi issue #3024: NIFI-5595 - Added the CORS filter to the templates/upload ...

2018-10-06 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/3024 Verified by sending curl POST commands with a client certificate to upload a template. With the `Origin` header set to a remote domain, the request is blocked with the response "Invalid

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

2018-10-01 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2936 There are definitely inconsistencies throughout the project as this wasn't always a firm policy and there are many different contributors to the project. As you noted, we have tried to tighten

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

2018-10-01 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2936 Hi @lukepfarrar , we have a policy of not evaluating EL in password fields. Here is [an example of that review process](https://github.com/apache/nifi/pull/3020#discussion_r219712821

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-10-01 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r221672221 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi issue #3032: NIFI-5612: Support JDBC drivers that return Long for unsig...

2018-09-28 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/3032 @colindean the releases aren't on a set schedule and are decided by discussion on the d...@nifi.apache.org mailing list, but I think you're right in your feeling that a release is probably coming

[GitHub] nifi pull request #3035: NIFI-5628 Added content length check to OkHttpRepli...

2018-09-26 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/3035 NIFI-5628 Added content length check to OkHttpReplicationClient. Added unit tests. Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #2872: NIFI-5318 Implement NiFi test harness: initial commit of n...

2018-09-25 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2872 I think there should be a Maven module for the test harness which is disabled by default and can be activated with a flag like `mvn clean test -Ptest-harness`. ---

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-24 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r219954907 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/test/java/org/apache/nifi/processors/neo4j/TestNeo4JCyperExecutor.java --- @@ -0,0

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-24 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r219953983 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-24 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r219953428 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-24 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r219953286 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-24 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r219953129 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi pull request #2956: NIFI-5537 Create Neo4J cypher execution processor

2018-09-24 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2956#discussion_r219952904 --- Diff: nifi-nar-bundles/nifi-neo4j-bundle/nifi-neo4j-processors/src/main/java/org/apache/nifi/processors/neo4j/AbstractNeo4JCypherExecutor.java

[GitHub] nifi issue #3024: NIFI-5595 - Added the CORS filter to the templates/upload ...

2018-09-24 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/3024 Reviewing... ---

[GitHub] nifi issue #3020: NIFI-5625: support the variables for the properties of HTT...

2018-09-23 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/3020 Thanks for your submission. I left some comments, specifically on the `password` fields and a field containing a regex for attribute headers. `GetHTTP` and `PostHTTP` are legacy processors

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219714056 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java --- @@ -726,7

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219714049 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java --- @@ -474,8

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219714033 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java --- @@ -183,26

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219714031 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java --- @@ -211,25

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219712932 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -714,11

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219712935 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -947,11

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219712916 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -367,6

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219712927 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -632,7

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219712894 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java --- @@ -318,6

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219712848 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java --- @@ -438,8

[GitHub] nifi pull request #3020: NIFI-5625: support the variables for the properties...

2018-09-23 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/3020#discussion_r219712821 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java --- @@ -177,19

[GitHub] nifi issue #3018: NIFI-5622 Updated test resource keystores and truststores ...

2018-09-21 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/3018 I believe @joewitt backed out the OkHttp changes from [NIFI-4806](https://issues.apache.org/jira/browse/NIFI-4806) (my previous note in the Jira) and is instead doing them in [NIFI-5623](https

[GitHub] nifi pull request #3018: NIFI-5622 Updated test resource keystores and trust...

2018-09-21 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/3018 NIFI-5622 Updated test resource keystores and truststores with Subjec… …tAlternativeNames to be compliant with RFC 6125. Refactored some test code to be clearer. Renamed some

[GitHub] nifi-registry issue #142: NIFIREG-200 Update dependencies

2018-09-20 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi-registry/pull/142 @kevdoran any reason you decided on 18.0 for guava? Looks like the most recent release is 26.0 [Guava](https://github.com/google/guava). ---

[GitHub] nifi pull request #2991: NIFI-3469: multipart request support added to Handl...

2018-09-19 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2991#discussion_r218868215 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java

[GitHub] nifi pull request #2983: NIFI-5566 Improve HashContent processor and standar...

2018-09-17 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2983#discussion_r218132155 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/groovy/org/apache/nifi/security/util/crypto/HashServiceTest.groovy

[GitHub] nifi-minifi-cpp issue #398: MINIFICPP-607: Remove host/peer bypass

2018-09-14 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/398 Thanks @phrocker . LGTM but my C++ is pretty rusty so I'm going to let @apiri or @achristianson give the +1 if they can. ---

[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation

2018-09-12 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2999 I looked at the code, and the documentation change is syntactically valid, but I am not familiar enough with MongoDB to assert that the content is correct. You will need a reviewer who is a MongoDB

[GitHub] nifi issue #2999: NIFI-5589 : Clarify PutMongo documentation

2018-09-12 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2999 Hi @josephxsxn I don't think we have to request that any more as GitHub shows the consolidated diff in one view, and rebasing & force-pushing to a branch that is used for a PR destroys his

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-12 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2983 Thanks. I may have published the wrong version of the template. I had a process group with processors configured to work with the current behavior, as well as one with the properties configured

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-11 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2983 @thenatog are you seeing behavior that conflicts with the description of expected behavior for configuration 1 if you reproduce the test case Otto described in his PR above? ---

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-10 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2983 Those attributes were added by @ottobackwards in the original PR for this issue. My understanding of the scenarios is as follows: **Flowfile A** *username*: `alopresto` *email

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-07 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2983 Based on @thenatog 's comment on [PR 2980](https://github.com/apache/nifi/pull/2980#issuecomment-419574743) which captured a Java Big Endian Byte Order Mark (BOM) being inserted in UTF-16 strings

[GitHub] nifi pull request #2980: NIFI-5147 Implement CalculateAttributeHash processo...

2018-09-07 Thread alopresto
Github user alopresto closed the pull request at: https://github.com/apache/nifi/pull/2980 ---

[GitHub] nifi issue #2980: NIFI-5147 Implement CalculateAttributeHash processor

2018-09-07 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2980 Thanks for discovering this @thenatog . This is an excellent catch. I've added behavior to catch this, better documentation, and unit tests. However, I added them on the branch

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-06 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2983 I added a `.keep` file in that directory. ---

[GitHub] nifi issue #2989: NIFI-5366 - Added ContentSecurityPolicyFilter which stops ...

2018-09-05 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2989 Thanks for making the requested changes. In general, please try to avoid rebasing in PRs as it loses the history of the interactions. The reviewer/committer should handle that when merging

[GitHub] nifi pull request #2989: NIFI-5366 - Added ContentSecurityPolicyFilter which...

2018-09-05 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2989#discussion_r215465715 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-05 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2983 @ottobackwards I've run this branch with the full build and all tests enabled multiple times and I have not encountered that error (just did it again from scratch with no `.m2` to be sure; 41:24

[GitHub] nifi issue #2989: NIFI-5366 - Added ContentSecurityPolicyFilter which stops ...

2018-09-04 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2989 Verified that the header is present on responses. Ran `contrib-check` and all tests pass. +1 if you re-order the dependencies. ---

[GitHub] nifi issue #2989: NIFI-5366 - Added ContentSecurityPolicyFilter which stops ...

2018-09-04 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2989 Reviewing... ---

[GitHub] nifi pull request #2989: NIFI-5366 - Added ContentSecurityPolicyFilter which...

2018-09-04 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2989#discussion_r215092182 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml --- @@ -154,5 +154,20 @@ jettison

[GitHub] nifi issue #2987: NIFI-3344 Added property to JoltTransformJSON allowing the...

2018-09-04 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2987 Thanks for reporting the context around that. If you're comfortable doing it, you can open a Jira to resolve that problem [here](https://issues.apache.org/jira/secure/CreateIssue!default.jspa

[GitHub] nifi pull request #2987: NIFI-3344 Added property to JoltTransformJSON allow...

2018-09-04 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2987#discussion_r215046005 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoltTransformJSON.java

[GitHub] nifi pull request #2987: NIFI-3344 Added property to JoltTransformJSON allow...

2018-09-04 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2987#discussion_r215021556 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoltTransformJSON.java

[GitHub] nifi issue #2987: NIFI-3344 Added property to JoltTransformJSON allowing the...

2018-09-04 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2987 What errors are you encountering when building with tests? ---

[GitHub] nifi pull request #2983: NIFI-5566 Improve HashContent processor and standar...

2018-09-04 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2983#discussion_r214979973 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HashAttribute.java --- @@ -51,6

[GitHub] nifi pull request #2980: NIFI-5147 Implement CalculateAttributeHash processo...

2018-09-04 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2980#discussion_r214979341 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/HashService.java --- @@ -0,0

[GitHub] nifi pull request #2980: NIFI-5147 Implement CalculateAttributeHash processo...

2018-09-04 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2980#discussion_r214979088 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/HashAlgorithm.java --- @@ -0,0

[GitHub] nifi pull request #2984: NIFI-5569 Added keywords to Route* and ScanAttribut...

2018-09-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2984#discussion_r214774007 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RouteText.java --- @@ -655,14

[GitHub] nifi pull request #2984: NIFI-5569 Added keywords to Route* and ScanAttribut...

2018-09-03 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/2984 NIFI-5569 Added keywords to Route* and ScanAttribute processors to im… …prove discoverability. Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #2983: NIFI-5566 Improve HashContent processor and standardize Ha...

2018-09-03 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2983 I created two templates that should help with testing the new behavior and ensuring that upgrading a flow that uses the old components doesn't break it. * [Hash Components (Legacy)](https

[GitHub] nifi pull request #2983: NIFI-5566 Improve HashContent processor and standar...

2018-09-03 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/2983 NIFI-5566 Improve HashContent processor and standardize HashAttribute processor ### This PR should not be merged before [PR 2980](https://github.com/apache/nifi/pull/2980) This PR

[GitHub] nifi issue #2977: NIFI-5562 - Upgraded guava versions from v18.0 to v26.0-jr...

2018-08-31 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2977 Reviewing... ---

[GitHub] nifi issue #2982: NIFI-4558 - Set JKS as the default keystore type and trust...

2018-08-31 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2982 Verified that this sets the defaults to "JKS" for both keystore and truststore on `StandardSSLContextService` and `StandardRestrictedSSLContextService`. Ran `contrib-check` and

[GitHub] nifi issue #2836: NIFI-5147 Calculate hash attribute redux

2018-08-31 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2836 I didn't capture every detail of the issue in the Jira because I planned on writing it myself. However, some of the behavior (empty input should still return a hash, etc.) was standard. Yes, please

[GitHub] nifi issue #2982: NIFI-4558 - Set JKS as the default keystore type and trust...

2018-08-31 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2982 Reviewing... ---

[GitHub] nifi issue #2836: NIFI-5147 Calculate hash attribute redux

2018-08-31 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2836 I started reviewing this PR but realized it did not implement many of the behaviors I had needed in the original ticket. I opened [PR 2980](https://github.com/apache/nifi/pull/2980) which includes

[GitHub] nifi pull request #2980: NIFI-5147 Implement CalculateAttributeHash processo...

2018-08-31 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2980#discussion_r214265868 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/HashAlgorithm.java --- @@ -0,0

[GitHub] nifi issue #2980: NIFI-5147 Implement CalculateAttributeHash processor

2018-08-31 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2980 This encapsulates the changes @ottobackwards made in [PR 2836](https://github.com/apache/nifi/pull/2836), but also: * Adds the *SHA-224, SHA-512/224, SHA-512/256, SHA-3 (SHA3-224, SHA3-256

[GitHub] nifi pull request #2980: NIFI-5147 Implement CalculateAttributeHash processo...

2018-08-31 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/2980 NIFI-5147 Implement CalculateAttributeHash processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi pull request #2836: NIFI-5147 Calculate hash attribute redux

2018-08-30 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2836#discussion_r214223024 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestCalculateAttributeHash.java

[GitHub] nifi pull request #2836: NIFI-5147 Calculate hash attribute redux

2018-08-30 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2836#discussion_r214222959 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestCalculateAttributeHash.java

[GitHub] nifi issue #2976: NIFI-4426 - Replaced Java7 jBCrypt implementation which wa...

2018-08-30 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2976 Ran `contrib-check` and all tests pass. +1, merging. ---

[GitHub] nifi issue #2973: NIFI-5561 - Add component name filtering to S2S Provenance...

2018-08-30 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2973 Thanks Pierre. Running a final check and will merge. ---

[GitHub] nifi pull request #2973: NIFI-5561 - Add component name filtering to S2S Pro...

2018-08-30 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2973#discussion_r214106940 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi issue #2976: NIFI-4426 - Replaced Java7 jBCrypt implementation which wa...

2018-08-30 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2976 Reviewing... ---

[GitHub] nifi pull request #2973: NIFI-5561 - Add component name filtering to S2S Pro...

2018-08-29 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2973#discussion_r213905518 --- Diff: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/java/org/apache/nifi/reporting

[GitHub] nifi pull request #2973: NIFI-5561 - Add component name filtering to S2S Pro...

2018-08-29 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2973#discussion_r213905074 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-reporting-utils/src/main/java/org/apache/nifi/reporting/util/provenance/ProvenanceEventConsumer.java

[GitHub] nifi issue #2973: NIFI-5561 - Add component name filtering to S2S Provenance...

2018-08-29 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2973 I created a flow which uses 3 `GenerateFlowFile` processors (named _Component A_, _Component A_, and _Component A (B)_) to evaluate the new filtering behavior. Each generates a flowfile

[GitHub] nifi issue #2975: NIFI-5526 Improve PutS3Object processor documentation

2018-08-29 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2975 Ran `contrib-check` and all tests pass. +1, merging. ---

[GitHub] nifi issue #2975: NIFI-5526 Improve PutS3Object processor documentation

2018-08-29 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2975 Reviewing... ---

[GitHub] nifi issue #2972: NIFI-5558 Fixed unit test to avoid contamination from Syst...

2018-08-29 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2972 Merging. ---

[GitHub] nifi issue #2972: NIFI-5558 Fixed unit test to avoid contamination from Syst...

2018-08-28 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2972 The issue that was encountered by some users was that the previous mechanism for creating a test `NiFiProperties` instance was `NiFiProperties.createBasicNiFiProperties(String filePath, Map

[GitHub] nifi pull request #2972: NIFI-5558 Fixed unit test to avoid contamination fr...

2018-08-28 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/2972 NIFI-5558 Fixed unit test to avoid contamination from System property… … "nifi.properties.file.path" when creating test NiFiProperties instance. Thank you for submitting a co

[GitHub] nifi issue #2960: NIFI-5482: Made WriteAheadProvenanceRepository the default...

2018-08-23 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2960 Ran a flow with multiple `GenerateFlowFile` processors creating flowfiles with a `0 sec` schedule and feeding to a `LogAttribute` processor. Was able to process ~350k flowfiles in about a minute

[GitHub] nifi issue #2960: NIFI-5482: Made WriteAheadProvenanceRepository the default...

2018-08-23 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2960 Reviewing... ---

[GitHub] nifi issue #2959: NIFI-5540 Provide default `nifi.sensitive.props.key` value...

2018-08-21 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2959 As discovered by @bbende , I introduced a bug in my commit [f60585a](https://github.com/apache/nifi/commit/f60585a9b6df6b3b28be1eb80a0a60deac6c0493#diff-882d0904bb315ac8a455aec69e6d44d8) as part

[GitHub] nifi pull request #2959: NIFI-5540 Provide default `nifi.sensitive.props.key...

2018-08-21 Thread alopresto
GitHub user alopresto opened a pull request: https://github.com/apache/nifi/pull/2959 NIFI-5540 Provide default `nifi.sensitive.props.key` value if none provided in cluster communications Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-08-14 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2615 @MikeThomsen I would maybe put a comment in the `src/test/java/.gitignore` file explaining why it's there so someone in the future doesn't see it as a superfluous tooling artifact and remove

[GitHub] nifi pull request #2615: NIFI-5051 Created ElasticSearch lookup service.

2018-08-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/2615#discussion_r210029087 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml --- @@ -127,8 +133,113 @@ 5.6.8

[GitHub] nifi issue #2936: NIFI-5489: Add expression language support to AMQP process...

2018-08-07 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2936 @danieljimenez correct, PRs merged now will be included in the next release. Because our *bug fix* releases (`x.x.1`) do not include feature work, this will be in the next *minor* release, which

[GitHub] nifi issue #2919: NIFI-5400 - Changed the hostname verifier from the custom ...

2018-08-06 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2919 I merged this but made two changes. First, the `nifi-web-utils` tests were not running, because they are Groovy tests and there is nothing in `src/test/java`. Without a file (even empty

[GitHub] nifi issue #2935: NIFI-5476 Allow TLS toolkit to use externally-signed CA in...

2018-08-03 Thread alopresto
Github user alopresto commented on the issue: https://github.com/apache/nifi/pull/2935 @pepov I've incorporated your PKCS #8 to PKCS #1 code and made some refactorings. Thank you. ---

  1   2   3   4   5   6   7   8   9   10   >