Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1917
Hey @champagst
Thanks for the contribution! I was digging into the ListHDFS implementation
and I think the reason it doesn't work on nested files might be that it is only
matching against
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1888#discussion_r124067647
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/sqs/DeleteSQS.java
---
@@ -45,7 +46,8
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1888
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1919
@champagst thanks for the contribution!
Would you mind adding tests that exercise this functionality?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user brosander closed the pull request at:
https://github.com/apache/nifi/pull/1390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123745136
--- Diff: libminifi/include/utils/Id.h ---
@@ -0,0 +1,77 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123744302
--- Diff: README.md ---
@@ -326,26 +326,44 @@ Additionally, users can utilize the MiNiFi Toolkit
Converter (version 0.0.1 - sc
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115#discussion_r123743755
--- Diff: libminifi/src/provenance/Provenance.cpp ---
@@ -34,9 +36,24 @@ namespace nifi {
namespace minifi {
namespace provenance
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/115
MINIFI-324 - More flexible uid generation
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1889
+ 1 on condition that we document limitations of downgrade with respect to
repos
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1889#discussion_r120720022
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -1317,6 +1318,82 @@ cluster if restarted and the flow for the cluster
has
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/103
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1878
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/103#discussion_r119398723
--- Diff: cmake/RunApacheRAT.cmake ---
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/103#discussion_r119398420
--- Diff: cmake/RunApacheRAT.cmake ---
@@ -0,0 +1,44 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
removed atomic_load, atomic_store as they are problematic w/ gcc 4.8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
rebased pr, fixed http get integration tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118706272
--- Diff: libminifi/test/TestBase.h ---
@@ -21,35 +21,104 @@
#include
#include
#include
+#include
#include
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118705983
--- Diff: libminifi/test/TestBase.h ---
@@ -21,35 +21,104 @@
#include
#include
#include
+#include
#include
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704850
--- Diff: libminifi/include/core/logging/LoggerConfiguration.h ---
@@ -0,0 +1,147 @@
+/**
+ * @file LoggerConfiguration.h
+ * Logger
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704917
--- Diff: libminifi/test/TestBase.h ---
@@ -21,35 +21,104 @@
#include
#include
#include
+#include
#include
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704895
--- Diff: libminifi/include/utils/StringUtils.h ---
@@ -89,6 +89,25 @@ class StringUtils {
s.end());
return s
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704804
--- Diff: libminifi/include/core/controller/ControllerService.h ---
@@ -64,7 +64,7 @@ class ControllerService : public ConfigurableComponent
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704784
--- Diff: libminifi/include/Site2SitePeer.h ---
@@ -72,8 +73,8 @@ class Site2SitePeer : public
org::apache::nifi::minifi::io::BaseStream
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
@phrocker I've added atomic load and store to the logger and loggerimpl
classes and a pattern option to minifi-log.properties along with some
alternative patterns and a link to the spdlog
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/104
@phrocker
For your first point about reinitializing logging while a flow is running,
is it worth it to switch the delegate reference on the Logger to an atomic?
Second
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104
MINIFI-296 - Configurable logging, spdlog 0.13.0
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/91
Thanks for feedback, changed those back and am rerunning build/tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1753
+1 Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1753
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/91
MINIFI-258 - Removing Configure, StreamFactory, TLSContext singletons
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/87
+1 Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1719
+1 Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
+1 works for me on bare metal Ubuntu 16.04, OSx 10.12.4, in docker
container on both platforms as well
---
If your project is set up for it, you can reply to this email and have your
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1726
Tested non-secure standalone instance, secure cluster. Works as expected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1719#discussion_r114228274
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1719#discussion_r114228190
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/FetchAzureBlobStorage.java
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
The following docker image repros it for me:
https://github.com/brosander/minifi-cpp-tooling/tree/9e5b1031d1772ccbee3ec8844a3decf232185284/Dockerfiles/ubuntu/xenial/build
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
Ubuntu 16.04 64 bit (latest LTS release of Ubuntu) I'll craft a dockerfile
for easier testing/validation.
---
If your project is set up for it, you can reply to this email and have your
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
```
TestSiteToSiteVerifySend
---
/home/bryan/Github/nifi-minifi-cpp/libminifi/test/unit
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
definitely better but I still seem to be getting a segfault on the s2s test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
@apiri I'll take a look, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1719#discussion_r114169894
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1719#discussion_r114169124
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureBlobStorage.java
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1719#discussion_r114168730
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/FetchAzureBlobStorage.java
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1719#discussion_r114136630
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureBlobStorage.java
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1719#discussion_r114135508
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/AbstractAzureBlobProcessor.java
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1719#discussion_r114135293
--- Diff: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/pom.xml
---
@@ -32,11 +32,35 @@ language governing permissions and limitations under
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
+1 merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/84
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/82
+1 merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi/pull/83
MINIFI-281 - Using RemoteProcessGroupSchemaV2
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/80#discussion_r113939300
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/CorePropertiesSchemaV2.java
---
@@ -0,0 +1,95
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/80#discussion_r113938266
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/CorePropertiesSchemaV2.java
---
@@ -0,0 +1,95
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/80#discussion_r113937684
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/CorePropertiesSchemaV2.java
---
@@ -0,0 +1,95
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/80#discussion_r113937508
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/CorePropertiesSchemaV2.java
---
@@ -0,0 +1,95
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/80#discussion_r113937276
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/v2/CorePropertiesSchemaV2.java
---
@@ -0,0 +1,95
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1711
NIFI-3755 - Restoring Hive exception handling behavior
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1697
+1 looks good to me, thoughts @mcgilman ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1698
NIFI-3744 - PutHiveStreaming cleanup null fixes
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1693
@andrewmlim those images work fine for me on OSx Sierra (10.12.4) and on
Ubuntu Linux. I asked @mattyb149 to try them and he said they worked for him
on Sierra and not El Capitan.
I think
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1693
NIFI-3737 - Ran optipng on all png files
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1669
+1 looks good to me, seems to be working, @alopresto did @YolandaMDavis
resolve your concerns?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi/pull/79
MINIFI-272 - Delegating C2 Provider, Caching ConfigService, Tests
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1669
Hey @YolandaMDavis this looks like a really good addition to the nifi
toolkit! Being able to send bulletins and manage nodes via the command line
will likely be a really nice-to-have feature
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1669
We may want to add some usage information to the documentation as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1669
Would it be difficult to create the other binary resources in test setup?
If not it might be preferable to having zips and tars in source control.
---
If your project is set up for it, you can
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1669
For the keystore, truststores in test resources, is it possible we could
use the tls-toolkit to generate those on demand?
https://github.com/apache/nifi-minifi/blob/master/minifi-c2/minifi
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1669#discussion_r111808071
--- Diff:
nifi-toolkit/nifi-toolkit-admin/src/main/groovy/org/apache/nifi/toolkit/admin/client/NiFiClientUtil.groovy
---
@@ -0,0 +1,156
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1669#discussion_r111807253
--- Diff: nifi-toolkit/nifi-toolkit-admin/pom.xml ---
@@ -0,0 +1,189 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1669#discussion_r111807027
--- Diff: nifi-toolkit/nifi-toolkit-admin/pom.xml ---
@@ -0,0 +1,189 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1669#discussion_r111806902
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/groovy/org/apache/nifi/web/StandardNiFiServiceFacadeSpec.groovy
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1669#discussion_r111806379
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/BulletinMerger.java
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1641
NIFI-3666 - TlsToolkit using .equals() comparison for parent and root
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/78#discussion_r108285965
--- Diff:
minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/src/main/resources/conf/bootstrap.conf
---
@@ -85,9 +85,13
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi/pull/76
MINIFI-242 - Initial integration tests focused around backwards compaâ¦
â¦tibility
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/74#discussion_r106938593
--- Diff: minifi-docker/dockerhub/Dockerfile ---
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi/pull/75
MINIFI-238 - MiNiFi Initial Command and Control Server Implementation
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi/pull/74
MINIFI-240 - Docker image for MiNiFi Java
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
Github user brosander commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/63
@phrocker
From a Java dev perspective, the namespaces look a little shallower than
the Java package names. I think that's probably justifiable though to prevent
a ton
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1578#discussion_r105418460
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveConfigurator.java
---
@@ -74,7 +74,8
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1578
contrib-check build working on linux, from root nifi folder, on OSX I've
been having issues with kafka tests so I just ran the changed modules and those
are checking out
---
If your project
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1578
NIFI-3574 - PutHiveStreaming UGI fixes
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1530
I agree that changing flags is likely to cause confusion although since we
haven't had a release yet, I would hope it would be minimal impact. Consistency
across modes of operation will help reduce
GitHub user brosander reopened a pull request:
https://github.com/apache/nifi/pull/1544
NIFI-3530 - Ensuring configuration and ugi information is passed downâ¦
⦠to Hive in PutHiveStreaming
Thank you for submitting a contribution to Apache NiFi.
In order
GitHub user brosander opened a pull request:
https://github.com/apache/nifi/pull/1544
NIFI-3530 - Ensuring configuration and ugi information is passed downâ¦
⦠to Hive in PutHiveStreaming
Thank you for submitting a contribution to Apache NiFi.
In order
Github user brosander closed the pull request at:
https://github.com/apache/nifi/pull/1544
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/72#discussion_r102292357
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
---
@@ -704,7 +691,7 @@ protected static void
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi/pull/72
MINIFI-216 - Allowing override of nifi.properties values
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1508
+1 merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1508
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1364#discussion_r101328875
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1364#discussion_r101160112
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1364
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1364#discussion_r101158900
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteStreamCommand.java
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1199
+1, merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/972
Seems like lack of demand for this change, probably should raise visibility
on impact via a discuss thread before messing with assemblies anyway
---
If your project is set up for it, you can reply
Github user brosander closed the pull request at:
https://github.com/apache/nifi/pull/972
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1199
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user brosander commented on the issue:
https://github.com/apache/nifi/pull/1446
@markap14 I was thinking this might be a time when verbosity makes it less
likely that someone would inadvertently change old behavior
I can pull the logic out into methods but anyone
1 - 100 of 281 matches
Mail list logo
