Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2607
Thanks @mcgilman, looks good. Could go either way on the Terminate v
Terminate threads menu, so unless anyone has a strong opinion for adding
"threads," I understand your logic for
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2607
@mcgilman , I was thinking about some suggestions to the formatting and
tooltip labeling used on these. I think we're using the '/' (forward slash)
inconsistently which could be a bit confusing
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/99#discussion_r167249634
--- Diff:
nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/AccessPolicyResource.java
---
@@ -174,7 +174,7 @@ public Response
Github user moranr commented on the issue:
https://github.com/apache/nifi-registry/pull/99
@scottyaslan , @kevdoran â redirect behavior looks good. Below are
recommendations for the dialog titles and messages.
UNSECURED
_-nifi-registry/explorer/grid-list/buckets/0_
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2269
To add to my previous comments, I also notice some styling changes, not
only in the advanced UI but other areas of the app as well. For example:
- Visible elements in the toolbar, status bar
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2269
@yuri1969 the behavior of the code editor addition looks good! Changes made
between the Script Engine/Body properties stay in place as changes are made and
as you move between the standard/advanced
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2102
I also commented in original JIRA looking for feedback from some others as
well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2102
This looks pretty good @yuri1969 . Another thing that would probably makes
sense is to change the icon's tooltip (title) to 'View configuration' since it
does not use the view details icon anymore
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2081
@scottyaslan â agreed, likely a larger and separate effort to know all
existing CSs. I'll create a new jira to capture the idea.
I think your suggestion as a first step is a good one. One
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2081
This will be a nice addition from a usability perspective.
It could be helpful to go ahead and generate a default name for the service
following some type of simple naming convention (e.g
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/1305
@scottyaslan this looks good. I put in a few long names in various cases
and it is behaving as you describe.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/1104
@scottyaslan let's go ahead and get this in since the issue is fixed and
the icons are now visible. I'll file a separate jira to completely update the
styling.
---
If your project is set up
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/1191
Thanks for the info @scottyaslan â I understand the issue regarding the
spacing/height so addressing in a follow on Jira is best.
I did just check out the latest and it looks good
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/1191
@mcgilman I think it makes sense to use the ellipsis for view state too.
@scottyaslan I'm still seeing the scrollable class applied on the Add
Processor description as well, so I can both
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/1151
Thanks @scottyaslan â agree on getting @mcgilman 's opinion too. Perhaps
it's just that initial color choice I'm not fond of. It's fine applied to the
processor icon, but at a larger scale it's
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/1151
@scottyaslan, @mcgilman â I think the processor preview looks good,
showing only what will change. For me, what is odd is the fact that the initial
preview is not an accurate view of the current
Github user moranr closed the pull request at:
https://github.com/apache/nifi-site/pull/4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user moranr opened a pull request:
https://github.com/apache/nifi-site/pull/3
NIFI-2706 Updating NiFi logos, home page screenshot, and some backgroâ¦
â¦und colors of website to align with UI redesign
You can merge this pull request into a Git repository by running
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/775
Looks good @scottyaslan thanks for getting this one in!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user moranr opened a pull request:
https://github.com/apache/nifi/pull/763
NIFI-2450 Update Getting Started guide, Data Provenance section graphics
- Updated data provenance section screen shots to reflect new styling
- Combined two Content tab screen shots into a single
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/749
Also for the context menus I recommend changing the Expand icon to
_fa-plus-square_ (from _fa-plus-square-o_) and Collapse to _fa-minus-square_
(from _fa-minus-square-o_); this reversed style
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/749
I can confirm the issues @joewitt has mentioned. Additionally, the context
menus still appear to be picking up some old styles. They should look just like
the component context menus.
---
If your
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi/pull/703#discussion_r71937949
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/common-ui.css
---
@@ -150,9 +150,8 @@ ul.links
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi/pull/703#discussion_r71937491
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css
---
@@ -178,31 +178,26 @@ div.flowfile
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi/pull/703#discussion_r71937315
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css
---
@@ -178,31 +178,26 @@ div.flowfile
Github user moranr commented on a diff in the pull request:
https://github.com/apache/nifi/pull/703#discussion_r71936940
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/provenance.css
---
@@ -270,11 +272,13 @@ div.modified
GitHub user moranr opened a pull request:
https://github.com/apache/nifi/pull/700
NIFI-2211 Updating NiFi architecture graphics for overview doc
Created new versions of _zero-master-cluster.png_ and _zero-master-node.png_
You can merge this pull request into a Git repository
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/627
@scottyaslan I don't see headerText for Processor Group Configuration âÂ
for example if you edit a process group name and click APPLY â dialog header
is empty.
---
If your project is set up
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/604
Everything is looking good!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
29 matches
Mail list logo
