[GitHub] nifi issue #2768: NIFI-5278: fixes JSON escaping of code parameter in Execut...

2018-06-21 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/nifi/pull/2768 @mattyb149 I've rebased this onto latest master. ---

[GitHub] nifi pull request #2768: NIFI-5278: fixes JSON escaping of code parameter in...

2018-06-08 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2768#discussion_r194157756 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/test/java/org/apache/nifi/processors/livy/TestExecuteSparkInteractive.java

[GitHub] nifi pull request #2768: NIFI-5278: fixes JSON escaping of code parameter in...

2018-06-08 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2768#discussion_r194157547 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/test/java/org/apache/nifi/processors/livy/ExecuteSparkInteractiveTestBase.java

[GitHub] nifi pull request #2768: NIFI-5278: fixes JSON escaping of code parameter in...

2018-06-08 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2768#discussion_r194157588 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/test/java/org/apache/nifi/processors/livy/TestExecuteSparkInteractiveSSL.java

[GitHub] nifi pull request #2768: NIFI-5278: fixes JSON escaping of code parameter in...

2018-06-08 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2768#discussion_r194157501 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-processors/src/test/java/org/apache/nifi/processors/livy/ExecuteSparkInteractiveTestBase.java

[GitHub] nifi issue #2768: NIFI-5278: fixes JSON escaping of code parameter in Execut...

2018-06-08 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/nifi/pull/2768 @joewitt , thanks for the feedback. I've added Apache Commons Text to NOTICE of the nifi-livy-nar and nifi-assembly as you suggested. I checked that it does not bring in any new transitive

[GitHub] nifi pull request #2768: NIFI-5278: fixes JSON escaping of code parameter in...

2018-06-07 Thread peter-toth
GitHub user peter-toth opened a pull request: https://github.com/apache/nifi/pull/2768 NIFI-5278: fixes JSON escaping of code parameter in Execute Spark Interactive processor Change-Id: I2cb0e6c658d4a0f2aad9c4aab9201a3334ee54df Thank you for submitting a contribution

[jira] [Updated] (NIFI-5278) ExecuteSparkInteractive processor fails on code containing a quote

2018-06-07 Thread Peter Toth (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Toth updated NIFI-5278: - Description: ExecuteSparkInteractive usesĀ  org.apache.commons.lang.StringEscapeUtils.escapeJavaScript

[jira] [Created] (NIFI-5278) ExecuteSparkInteractive processor fails on code containing a quote

2018-06-07 Thread Peter Toth (JIRA)
Peter Toth created NIFI-5278: Summary: ExecuteSparkInteractive processor fails on code containing a quote Key: NIFI-5278 URL: https://issues.apache.org/jira/browse/NIFI-5278 Project: Apache NiFi

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-05-22 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r189932016 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-controller-service/src/main/java/org/apache/nifi/controller/livy/LivySessionController.java

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-05-16 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r188609838 --- Diff: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-controller-service/src/main/java/org/apache/nifi/controller/livy/LivySessionController.java

[GitHub] nifi issue #2630: NIFI-5041 Adds SPNEGO authentication to LivySessionControl...

2018-05-14 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/nifi/pull/2630 Hi @mattyb149, Thanks for the feedback, I amended the error handling a bit: - Processor is yielded now if there is no session available - KerberosKeytabSPNegoScheme throws

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-05-08 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r186738068 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/KerberosConfiguration.java --- @@ -0,0 +1,52

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-04-26 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r184309195 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/KerberosConfiguration.java --- @@ -0,0 +1,52

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-04-16 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r181746461 --- Diff: pom.xml --- @@ -94,6 +94,7 @@ 1.7.25 0.7.1 9.4.3.v20170317 +4.5.5 --- End diff

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-04-13 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r181441723 --- Diff: pom.xml --- @@ -94,6 +94,7 @@ 1.7.25 0.7.1 9.4.3.v20170317 +4.5.5 --- End diff

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-04-12 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/nifi/pull/2630#discussion_r181127144 --- Diff: pom.xml --- @@ -94,6 +94,7 @@ 1.7.25 0.7.1 9.4.3.v20170317 +4.5.5 --- End diff

[GitHub] nifi issue #2630: NIFI-5041 Adds SPNEGO authentication to LivySessionControl...

2018-04-12 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/nifi/pull/2630 Some of the travis builds failed, but I don't see any issue in the logs except that the size of log exceeded 4MB. Could someone help me with this please? ---

[GitHub] nifi issue #2630: NIFI-5041 Adds SPNEGO authentication to LivySessionControl...

2018-04-12 Thread peter-toth
Github user peter-toth commented on the issue: https://github.com/apache/nifi/pull/2630 This improvement of LivySessionController uses the KerberosCredentialsService to fetch a principal and a keytab and provide SPNEGO authentication towards a Livy server

[GitHub] nifi pull request #2630: NIFI-5041 Adds SPNEGO authentication to LivySession...

2018-04-12 Thread peter-toth
GitHub user peter-toth opened a pull request: https://github.com/apache/nifi/pull/2630 NIFI-5041 Adds SPNEGO authentication to LivySessionController Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[jira] [Created] (NIFI-5041) Add convenient SPNEGO/Kerberos authentication support to LivySessionController

2018-04-04 Thread Peter Toth (JIRA)
Peter Toth created NIFI-5041: Summary: Add convenient SPNEGO/Kerberos authentication support to LivySessionController Key: NIFI-5041 URL: https://issues.apache.org/jira/browse/NIFI-5041 Project: Apache