[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-22 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1239041303 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java: ## @@ -214,6 +214,8 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-22 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1239039993 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/process-group-configuration.jsp: ## @@ -99,6 +99,17

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-14 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1229795456 ## nifi-registry/nifi-registry-core/nifi-registry-flow-diff/src/main/java/org/apache/nifi/registry/flow/diff/StandardFlowComparator.java: ## @@ -522,6 +522,8 @@ private

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-14 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1229697680 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/logging/PerProcessGroupLoggable.java: ## @@ -0,0 +1,23 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-14 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1229692228 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/logging/LoggingContext.java: ## @@ -0,0 +1,24 @@ +/* + *

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-14 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1229690788 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java: ## @@ -4422,6 +4426,26

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-14 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1229687291 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/process-group-configuration.jsp: ## @@ -99,6 +99,24

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-14 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1229686669 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/process-group-configuration.jsp: ## @@ -99,6 +99,24

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-14 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1229681996 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-process-group-configuration.js: ## @@ -316,6 +337,23 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-14 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1229680948 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-process-group-configuration.js: ## @@ -272,6 +274,25 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-14 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1229679296 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-process-group-configuration.js: ## @@ -272,6 +274,25 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-14 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1229678647 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-process-group-configuration.js: ## @@ -272,6 +274,25 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-01 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1213212094 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/logging/StandardLoggingContext.java: ## @@ -0,0 +1,62 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-01 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1213211136 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/logging/StandardLoggingContext.java: ## @@ -0,0 +1,62 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-01 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1213208436 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java: ## @@ -243,6 +246,7 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-01 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1213207373 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java: ## @@ -214,6 +214,9 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-01 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1213207734 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java: ## @@ -214,6 +214,9 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-01 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1213205285 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/entity/ProcessGroupEntity.java: ## @@ -56,6 +56,9 @@

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-01 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1213204117 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ProcessGroupDTO.java: ## @@ -39,6 +39,8 @@ public

[GitHub] [nifi] markap14 commented on a diff in pull request #7315: NIFI-3065 Per Process Group logging

2023-06-01 Thread via GitHub
markap14 commented on code in PR #7315: URL: https://github.com/apache/nifi/pull/7315#discussion_r1213199524 ## nifi-api/src/main/java/org/apache/nifi/flow/VersionedProcessGroup.java: ## @@ -47,6 +47,9 @@ public class VersionedProcessGroup extends VersionedComponent {