[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1443: MINIFICPP-1972 - Refactor State Manager code

2022-12-06 Thread GitBox
adam-markovics commented on code in PR #1443: URL: https://github.com/apache/nifi-minifi-cpp/pull/1443#discussion_r1041157615 ## libminifi/src/controllers/keyvalue/KeyValueStateManager.cpp: ## @@ -0,0 +1,145 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1443: MINIFICPP-1972 - Refactor State Manager code

2022-11-02 Thread GitBox
adam-markovics commented on code in PR #1443: URL: https://github.com/apache/nifi-minifi-cpp/pull/1443#discussion_r1011988685 ## libminifi/src/controllers/keyvalue/KeyValueStateStorage.cpp: ## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1443: MINIFICPP-1972 - Refactor State Manager code

2022-11-02 Thread GitBox
adam-markovics commented on code in PR #1443: URL: https://github.com/apache/nifi-minifi-cpp/pull/1443#discussion_r1011988154 ## libminifi/include/core/ProcessContext.h: ## @@ -246,14 +238,14 @@ class ProcessContext : public controller::ControllerServiceLookup, public core::

[GitHub] [nifi-minifi-cpp] adam-markovics commented on a diff in pull request #1443: MINIFICPP-1972 - Refactor State Manager code

2022-11-02 Thread GitBox
adam-markovics commented on code in PR #1443: URL: https://github.com/apache/nifi-minifi-cpp/pull/1443#discussion_r1011941159 ## libminifi/include/core/StateManager.h: ## @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *