[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-17 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367275409 ## File path: libminifi/src/utils/file/PathUtils.cpp ## @@ -48,6 +56,35 @@ bool

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-17 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367268406 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-17 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367268047 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-17 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367267981 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-17 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367268177 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-16 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367273019 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-15 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367275409 ## File path: libminifi/src/utils/file/PathUtils.cpp ## @@ -48,6 +56,35 @@ bool

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-15 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367274461 ## File path: libminifi/src/utils/file/PathUtils.cpp ## @@ -48,6 +56,35 @@ bool

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-15 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367274461 ## File path: libminifi/src/utils/file/PathUtils.cpp ## @@ -48,6 +56,35 @@ bool

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-15 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367273019 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-15 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367268406 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-15 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367268047 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-15 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367268177 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-15 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367267981 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *

[GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic

2020-01-15 Thread GitBox
am-c-p-p commented on a change in pull request #709: MINIFICPP-1088 - clean up minifiexe and MINIFI_HOME logic URL: https://github.com/apache/nifi-minifi-cpp/pull/709#discussion_r367267576 ## File path: libminifi/src/utils/Environment.cpp ## @@ -0,0 +1,192 @@ +/** + *