[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs

2020-03-17 Thread GitBox
bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r393716853 ## File path: libminifi/src/io/ClientSocket.cpp ## @@ -0,0 +1,625 @@ +/** + *

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs

2020-03-16 Thread GitBox
bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r392914757 ## File path: libminifi/src/io/ClientSocket.cpp ## @@ -0,0 +1,625 @@ +/** + *

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs

2020-03-16 Thread GitBox
bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r392903802 ## File path: libminifi/src/io/tls/TLSSocket.cpp ## @@ -170,23 +175,38 @@ void

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs

2020-03-16 Thread GitBox
bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r392895813 ## File path: libminifi/include/io/BaseStream.h ## @@ -175,13 +174,12 @@ class

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs

2020-02-11 Thread GitBox
bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377558660 ## File path: libminifi/include/io/tls/TLSSocket.h ## @@ -68,9 +68,8 @@ class

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs

2020-02-11 Thread GitBox
bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377559033 ## File path: libminifi/include/core/ProcessSession.h ## @@ -48,11 +49,11 @@

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs

2020-02-11 Thread GitBox
bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377558824 ## File path: libminifi/src/io/StreamFactory.cpp ## @@ -38,35 +39,21 @@

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs

2020-02-11 Thread GitBox
bakaid commented on a change in pull request #713: MINIFICPP-1119 MINIFICPP-1154 unify win/posix sockets + fix bugs URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377558485 ## File path: libminifi/include/io/StreamFactory.h ## @@ -90,8 +88,7 @@ class