[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #809: MINIFICPP-1254 - Introduce optional-lite

hunyadi-dev commented on a change in pull request #809: URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r440793037 ## File path: libminifi/include/utils/OptionalUtils.h ## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #809: MINIFICPP-1254 - Introduce optional-lite

hunyadi-dev commented on a change in pull request #809: URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r440792716 ## File path: libminifi/include/utils/GeneralUtils.h ## @@ -64,6 +64,7 @@ using std::exchange; #if __cplusplus < 201703L template using void_

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #809: MINIFICPP-1254 - Introduce optional-lite

hunyadi-dev commented on a change in pull request #809: URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r440197225 ## File path: libminifi/include/utils/OptionalUtils.h ## @@ -21,17 +21,20 @@ #include #include -#include "utils/GeneralUtils.h" +#include

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #809: MINIFICPP-1254 - Introduce optional-lite

hunyadi-dev commented on a change in pull request #809: URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r440196041 ## File path: libminifi/include/utils/OptionalUtils.h ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #809: MINIFICPP-1254 - Introduce optional-lite

hunyadi-dev commented on a change in pull request #809: URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r440188628 ## File path: libminifi/include/utils/OptionalUtils.h ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #809: MINIFICPP-1254 - Introduce optional-lite

hunyadi-dev commented on a change in pull request #809: URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r440152423 ## File path: libminifi/include/utils/OptionalUtils.h ## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #809: MINIFICPP-1254 - Introduce optional-lite

hunyadi-dev commented on a change in pull request #809: URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r440112121 ## File path: libminifi/include/utils/GeneralUtils.h ## @@ -61,6 +61,17 @@ T exchange(T& obj, U&& new_value) { template using void_t = void;

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #809: MINIFICPP-1254 - Introduce optional-lite

hunyadi-dev commented on a change in pull request #809: URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r440102107 ## File path: libminifi/src/utils/BackTrace.cpp ## @@ -89,19 +90,9 @@ void pull_trace(uint8_t frames_to_skip /* = 1 */) { } } -

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #809: MINIFICPP-1254 - Introduce optional-lite

hunyadi-dev commented on a change in pull request #809: URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r439966301 ## File path: CMakeLists.txt ## @@ -307,6 +307,9 @@ if (STRICT_GSL_CHECKS STREQUAL "DEBUG_ONLY") endif() target_compile_definitions(gsl-lite I

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #809: MINIFICPP-1254 - Introduce optional-lite

hunyadi-dev commented on a change in pull request #809: URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r439324945 ## File path: libminifi/src/utils/BackTrace.cpp ## @@ -30,22 +30,24 @@ #include #endif +#include + #ifdef HAS_EXECINFO namespace { /*