[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-25 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1273249255 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -186,6 +250,48 @@ void PutS3Object::setAttributes( } } +void

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-25 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1273117515 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -29,9 +29,51 @@ #include "core/ProcessContext.h" #include "core/ProcessSession.h" #include

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-11 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1259296645 ## extensions/aws/processors/PutS3Object.h: ## @@ -97,54 +111,46 @@ class PutS3Object : public S3Processor { class ReadCallback { public: -

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-11 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1259296115 ## extensions/aws/s3/S3Wrapper.cpp: ## @@ -75,42 +71,158 @@ std::string S3Wrapper::getEncryptionString(Aws::S3::Model::ServerSideEncryption return ""; }

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-11 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1259278368 ## extensions/aws/s3/MultipartUploadStateStorage.cpp: ## @@ -0,0 +1,128 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-10 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1258204617 ## libminifi/include/utils/TimeUtil.h: ## @@ -189,6 +189,20 @@ inline bool unit_matches(const std::string& unit) { return unit == "d" || unit == "day" ||

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-10 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1258202433 ## extensions/aws/s3/S3Wrapper.cpp: ## @@ -75,42 +70,160 @@ std::string S3Wrapper::getEncryptionString(Aws::S3::Model::ServerSideEncryption return ""; }

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-10 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1258201957 ## extensions/aws/processors/PutS3Object.h: ## @@ -97,54 +111,61 @@ class PutS3Object : public S3Processor { class ReadCallback { public: -

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-10 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1258158757 ## extensions/aws/s3/MultipartUploadStateStorage.cpp: ## @@ -0,0 +1,128 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-10 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1258152157 ## extensions/aws/s3/MultipartUploadStateStorage.cpp: ## @@ -0,0 +1,128 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-10 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1258122129 ## extensions/aws/s3/MultipartUploadStateStorage.cpp: ## @@ -0,0 +1,128 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-10 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1258122129 ## extensions/aws/s3/MultipartUploadStateStorage.cpp: ## @@ -0,0 +1,128 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-10 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1258086012 ## extensions/aws/s3/S3Wrapper.cpp: ## @@ -75,42 +69,160 @@ std::string S3Wrapper::getEncryptionString(Aws::S3::Model::ServerSideEncryption return ""; }

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-07-07 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1255506187 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -187,6 +208,48 @@ void PutS3Object::setAttributes( } } +void

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-20 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1234870455 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -77,7 +78,31 @@ void PutS3Object::onSchedule(const std::shared_ptr use_virtual_addressing_ =

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-20 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1234249400 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -77,7 +78,31 @@ void PutS3Object::onSchedule(const std::shared_ptr use_virtual_addressing_ =

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-19 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1234249400 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -77,7 +78,31 @@ void PutS3Object::onSchedule(const std::shared_ptr use_virtual_addressing_ =

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-19 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1234106980 ## extensions/aws/s3/S3Wrapper.cpp: ## @@ -297,4 +404,57 @@ FetchObjectResult S3Wrapper::fillFetchObjectResult(const GetObjectRequestParamet return

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-19 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1234106443 ## docker/test/integration/cluster/checkers/AwsChecker.py: ## @@ -29,6 +29,18 @@ def check_s3_server_object_data(self, container_name, test_data):

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-19 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1234094500 ## extensions/aws/s3/S3Wrapper.cpp: ## @@ -297,4 +404,57 @@ FetchObjectResult S3Wrapper::fillFetchObjectResult(const GetObjectRequestParamet return

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-19 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1234036346 ## extensions/aws/s3/S3Wrapper.cpp: ## @@ -75,42 +69,155 @@ std::string S3Wrapper::getEncryptionString(Aws::S3::Model::ServerSideEncryption return ""; }

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-19 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1234035975 ## docker/test/integration/cluster/checkers/AwsChecker.py: ## @@ -29,6 +29,16 @@ def check_s3_server_object_data(self, container_name, test_data):

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-19 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1233691783 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -77,7 +78,31 @@ void PutS3Object::onSchedule(const std::shared_ptr use_virtual_addressing_ =

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-16 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1232009977 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -77,7 +78,31 @@ void PutS3Object::onSchedule(const std::shared_ptr use_virtual_addressing_ =

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-16 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1231973493 ## extensions/aws/tests/MultipartUploadStateStorageTest.cpp: ## @@ -0,0 +1,141 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-15 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1231548116 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -77,7 +78,31 @@ void PutS3Object::onSchedule(const std::shared_ptr use_virtual_addressing_ =

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-08 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1223096466 ## libminifi/include/utils/TimeUtil.h: ## @@ -189,6 +189,20 @@ inline bool unit_matches(const std::string& unit) { return unit == "d" || unit == "day" ||

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

2023-06-08 Thread via GitHub
lordgamez commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1223080276 ## libminifi/include/utils/TimeUtil.h: ## @@ -189,6 +189,20 @@ inline bool unit_matches(const std::string& unit) { return unit == "d" || unit == "day" ||