[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1436: MINIFICPP-1963 improve exception logging

2022-11-02 Thread GitBox
szaszm commented on code in PR #1436: URL: https://github.com/apache/nifi-minifi-cpp/pull/1436#discussion_r1011979667 ## libminifi/src/SchedulingAgent.cpp: ## @@ -115,11 +115,11 @@ bool SchedulingAgent::onTrigger(core::Processor* processor, const std::shared_pt

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1436: MINIFICPP-1963 improve exception logging

2022-11-02 Thread GitBox
szaszm commented on code in PR #1436: URL: https://github.com/apache/nifi-minifi-cpp/pull/1436#discussion_r1011979349 ## libminifi/src/core/ProcessGroup.cpp: ## @@ -153,8 +153,10 @@ void ProcessGroup::startProcessingProcessors(const std::shared_ptronUnSchedule(); +} catch

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1436: MINIFICPP-1963 improve exception logging

2022-11-02 Thread GitBox
szaszm commented on code in PR #1436: URL: https://github.com/apache/nifi-minifi-cpp/pull/1436#discussion_r1011901598 ## libminifi/src/sitetosite/RawSocketProtocol.cpp: ## @@ -601,14 +601,14 @@ bool RawSiteToSiteClient::transmitPayload(const std::shared_ptryield();

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1436: MINIFICPP-1963 improve exception logging

2022-11-02 Thread GitBox
szaszm commented on code in PR #1436: URL: https://github.com/apache/nifi-minifi-cpp/pull/1436#discussion_r1011901598 ## libminifi/src/sitetosite/RawSocketProtocol.cpp: ## @@ -601,14 +601,14 @@ bool RawSiteToSiteClient::transmitPayload(const std::shared_ptryield();

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1436: MINIFICPP-1963 improve exception logging

2022-10-25 Thread GitBox
szaszm commented on code in PR #1436: URL: https://github.com/apache/nifi-minifi-cpp/pull/1436#discussion_r1004682844 ## libminifi/src/Exception.cpp: ## @@ -0,0 +1,41 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license