[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-13 Thread via GitHub
szaszm commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1165139414 ## extensions/aws/CMakeLists.txt: ## Review Comment: Can we restrict the "wholearchive" linkage to ARM64? -- This is an automated message from the

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-12 Thread via GitHub
szaszm commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1163989146 ## extensions/aws/CMakeLists.txt: ## Review Comment: In this case, we should only do the wholearchive linking on the platforms where it's necessary. It

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1554: MINIFICPP-2058 Fix AWS extension link error on ARM64

2023-04-12 Thread via GitHub
szaszm commented on code in PR #1554: URL: https://github.com/apache/nifi-minifi-cpp/pull/1554#discussion_r1163967935 ## extensions/aws/CMakeLists.txt: ## Review Comment: Is there a way to keep that symbol without keeping all of the unused symbols? Or is this the