[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1581: MINIFICPP-2125 fix for waking up prematurely after processor yields

szaszm commented on code in PR #1581: URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1215630971 ## libminifi/src/TimerDrivenSchedulingAgent.cpp: ## @@ -28,11 +28,13 @@ namespace org::apache::nifi::minifi { utils::TaskRescheduleInfo

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1581: MINIFICPP-2125 fix for waking up prematurely after processor yields

szaszm commented on code in PR #1581: URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1214442945 ## libminifi/src/TimerDrivenSchedulingAgent.cpp: ## @@ -28,11 +28,13 @@ namespace org::apache::nifi::minifi { utils::TaskRescheduleInfo

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1581: MINIFICPP-2125 fix for waking up prematurely after processor yields

szaszm commented on code in PR #1581: URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1211836375 ## libminifi/test/unit/ThreadPoolTests.cpp: ## @@ -84,7 +81,33 @@ TEST_CASE("ThreadPoolTest2", "[TPT2]") { utils::Worker functor(f_ex, "id",

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1581: MINIFICPP-2125 fix for waking up prematurely after processor yields

szaszm commented on code in PR #1581: URL: https://github.com/apache/nifi-minifi-cpp/pull/1581#discussion_r1211136629 ## libminifi/test/unit/ThreadPoolTests.cpp: ## Review Comment: What is the function called `function` used for at line 28? Can we remove it if it's