[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1279305420 ## extensions/aws/processors/PutS3Object.h: ## @@ -26,6 +26,8 @@ #include #include #include +#include +#include Review Comment: I think `` is no

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1279299975 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -186,6 +250,48 @@ void PutS3Object::setAttributes( } } +void PutS3Object::ageOffMultipartUploads(const

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1268163955 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -29,9 +29,51 @@ #include "core/ProcessContext.h" #include "core/ProcessSession.h" #include

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1258328212 ## extensions/aws/processors/PutS3Object.h: ## @@ -97,54 +111,46 @@ class PutS3Object : public S3Processor { class ReadCallback { public: -static

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1258127052 ## extensions/aws/processors/PutS3Object.h: ## @@ -97,54 +111,61 @@ class PutS3Object : public S3Processor { class ReadCallback { public: -static

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1232586633 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -77,7 +78,31 @@ void PutS3Object::onSchedule(const std::shared_ptr use_virtual_addressing_ =

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1232540073 ## extensions/aws/s3/S3Wrapper.cpp: ## @@ -75,42 +69,155 @@ std::string S3Wrapper::getEncryptionString(Aws::S3::Model::ServerSideEncryption return ""; }

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1231981938 ## extensions/aws/processors/PutS3Object.cpp: ## @@ -77,7 +78,31 @@ void PutS3Object::onSchedule(const std::shared_ptr use_virtual_addressing_ =

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1231135508 ## extensions/aws/tests/MultipartUploadStateStorageTest.cpp: ## @@ -0,0 +1,141 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1223088139 ## libminifi/include/utils/TimeUtil.h: ## @@ -189,6 +189,20 @@ inline bool unit_matches(const std::string& unit) { return unit == "d" || unit == "day" ||

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1586: MINIFICPP-2127 Add multipart upload support for PutS3Object processor

szaszm commented on code in PR #1586: URL: https://github.com/apache/nifi-minifi-cpp/pull/1586#discussion_r1222009549 ## libminifi/include/utils/TimeUtil.h: ## @@ -189,6 +189,20 @@ inline bool unit_matches(const std::string& unit) { return unit == "d" || unit == "day" ||