ekovacs commented on issue #245: NIFIREG-252: adding mavendocker build profile
URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-546347391
> +1 for relocating it and making it a maven project, as well as for doing
that as a separate jira/pr. I will re-review this PR as-is.
ekovacs commented on issue #245: NIFIREG-252: adding mavendocker build profile
URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-545966491
> Yeah, good points. I would support moving
nifi-registry-core/nifi-registry-docker to a top level module that is
responsible for
ekovacs commented on issue #245: NIFIREG-252: adding mavendocker build profile
URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-545815844
> Thanks for the contribution @ekovacs!
>
> Overall this looks good to me.
>
> I had one inline suggestion about
ekovacs commented on issue #245: NIFIREG-252: adding mavendocker build profile
URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-543921492
`mvn clean package verify -P include-ranger -P include-aws -P docker`
creates the docker image locally
ekovacs commented on issue #245: NIFIREG-252: adding mavendocker build profile
URL: https://github.com/apache/nifi-registry/pull/245#issuecomment-543920721
@kevdoran could you please take a look? / Give it a run?
This is an