Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@achristianson had some other things that interrupted, but looks good.
will get these squashed and merged. appreciate you working through all the
iterations with us!
---
If your project is
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
Great, thanks for all the resources. If you are not aware, the community
also has the TLS Toolkit that is super helpful as well:
http://nifi.apache.org/docs/nifi-docs/html/administration-guid
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@apiri Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@apiri Sure thing. These cmds might help for part of your testing:
```sh
dd if=/dev/urandom of=./testdat bs=1M count=1
```
```sh
curl -vvv -X POST --data-binary @
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@achristianson great, thanks. still working through testing functionality
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@apiri Will do. Expecting to get an updated PR out here in a couple minutes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@achristianson feel free to update the LICENSE when you have the
opportunity if you are going to adjust the libxml items
---
If your project is set up for it, you can reply to this email and h
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@apiri Correct. Not using any of the optional features listed there. Want
me to update the LICENSE file, or were you planning to do it? I don't mind,
just want to avoid a merge conflict
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
We will need to update the LICENSE for the civetweb source inclusion. That
does not appear to be present currently. My understanding is that we are not
using any of the optional items in the
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@achristianson sounds fair concerning the ExternalProjects, will scope this
out
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@apiri @phrocker Addressed the comments, updated the code, and rebased. The
biggest thing is cleanly setting up an ExternalProject system, but I think
that's best addressed under the ti
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@phrocker Sounds good. I'll take a look at the rest and also fix this new
merge conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
Created MINIFI-213 to have the CMake 3rd party discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@achristianson I thought I created a ticket to break these out...or maybe
it was an E-mail, but I think that's something we could discuss. When I sent a
message to @apiri earlier I said tha
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@phrocker @apiri Thanks for the feedback. All makes sense, but had one
question re: civet as an ExternalProject. I did it as a thirdparty/ dir mainly
to be consistent with how the curre
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
If you happen to update try -Os ( don't feel like you need to in this PR )
https://issues.apache.org/jira/browse/MINIFI-197 is a corresponding ticket for
it. I was going to do this and prun
Github user apiri commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
great, thanks. will scope out shortly
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@apiri Just resolved some conflicts with the master branch that emerged
with other changes. Tested and should be good to go now.
---
If your project is set up for it, you can reply to
18 matches
Mail list logo
