Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/43
@phrocker @apiri Thanks for the feedback. All makes sense, but had one
question re: civet as an ExternalProject. I did it as a thirdparty/ dir mainly
to be consistent with how the current thirdparty dependencies are handled, e.g.
yaml and leveldb. If we're OK with breaking that consistency, and perhaps
adding future tickets to extract out the current thirdparty projects, then I'll
move forward with that.
The only other concern regarding the ExternalProject is that it does make
it harder to build offline or if the remote host goes down. We would probably
want to add some build instructions for how and where to place the external
code manually to cover these build-time use cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
