Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2034
Looks good. Thanks again for fixing this, @Wesley-Lawrence.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user Wesley-Lawrence commented on the issue:
https://github.com/apache/nifi/pull/2034
Alright, changes made, and contrib-check still passing for me.
Thanks for the review @jvwing!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2034
@Wesley-Lawrence I think this is a good fix, your approach to the solution
seems solid. Thanks for adding the unit tests for the recursive and
mutually-referential cases. Would you please:
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2034
Thanks @pvillard31!
@Wesley-Lawrence Don't worry about squashing yet, we can do that as a final
step.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Wesley-Lawrence commented on the issue:
https://github.com/apache/nifi/pull/2034
@pvillard31 Yup, you're right, that solves the issue for me ð.
I got so caught up in the second `RightCurly` definitons saying `}` should
be alone, and other `if`s being that way,
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2034
@Wesley-Lawrence I believe this should be:
java
if() {
} else {
}
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Wesley-Lawrence commented on the issue:
https://github.com/apache/nifi/pull/2034
Thanks for taking a look @jvwing!
I didn't want to change it, but I keep getting the following error with it;
```
[ERROR] Failed to execute goal
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2034
@Wesley-Lawrence Thanks for putting this PR together. I am still reviewing
- the only immediate feedback I can give is that I would prefer not to update
the checkstyle definition in pom.xml as part
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2034
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
