Github user baank commented on the issue:
https://github.com/apache/nifi/pull/2291
We will be forking the project so please don't merge the commits.
---
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2291
@baank, did you mean to close this PR? The latest changes appear to be
well worth reviewing, if that is OK with you?
---
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2291
@baank - closed?
---
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2291
@baank - thanks for the update, I think we're almost done. Two things:
1.) I still see a checkstyle warning for nifi-aws-processors:
> [INFO] --- maven-checkstyle-plugin:2.15:check
Github user baank commented on the issue:
https://github.com/apache/nifi/pull/2291
@jvwing .. All changes made.
---
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2291
@baank, thanks for the latest update. Good news, we're getting down to the
nit-picks:
1. I had a checkstyle error running the full build with contrib check on
nifi-aws-service-api
