Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2351
@ijokarumawak Looks great, thanks! Guess I was a little careless with
implementation and testing on that go-round, thanks for getting it across the
finish line. I ran the tests and with a number
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2351
@mattyb149 Good catch. Yeah, simple ProcessGroupID tree structure would
help optimizing lookup at filtering. Please add that and squash commits, then
I'll do a final review and merge it. Thanks!
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2351
Thanks for the commit, great stuff! Do you think the processing of the
stack for each record will be ok in terms of performance impact? I wonder if
we'd be better off building a tree (basically a
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2351
@mattyb149 I forgot to mention that I'm +1 with the rest of the code, so if
my commit seems reasonable, please squash yours and merge it. Thanks!
---
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2351
Hi @mattyb149 Thanks for updating this PR. It mostly looks good, however,
while I was testing, I found few points those can be improved. I went ahead and
added following improvements on top ob
