[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-24 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r102947724 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/TextLineDemarcator.java --- @@ -90,58 +70,73 @@ public OffsetInfo

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-23 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r102830048 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/AbstractDemarcator.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to the

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-23 Thread mosermw
Github user mosermw commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r102828860 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/AbstractDemarcator.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to the

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-23 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r102775809 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/AbstractDemarcator.java --- @@ -98,22 +136,26 @@ void fill() throws IOException

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r102774788 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/AbstractDemarcator.java --- @@ -98,22 +136,26 @@ void fill() throws

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r102725986 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/TextLineDemarcator.java --- @@ -95,52 +71,61 @@ public OffsetInfo

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r102712235 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/AbstractDemarcator.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r102718767 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/TextLineDemarcator.java --- @@ -95,52 +71,61 @@ public OffsetInfo

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r102713215 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/AbstractDemarcator.java --- @@ -0,0 +1,138 @@ +/* + * Licensed to

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-23 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r102725352 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/TextLineDemarcator.java --- @@ -270,5 +180,10 @@ public boolean

[GitHub] nifi pull request #1214: NIFI-2876 refactored demarcators into a common abst...

2017-02-14 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/1214#discussion_r10449 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/util/TextLineDemarcator.java --- @@ -150,7 +126,15 @@ public OffsetInfo