Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

2024-01-02 Thread via GitHub
arpadboda closed pull request #1709: MINIFICPP-2274 Ship Markdown docs in binary packages URL: https://github.com/apache/nifi-minifi-cpp/pull/1709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

2023-12-14 Thread via GitHub
szaszm commented on code in PR #1709: URL: https://github.com/apache/nifi-minifi-cpp/pull/1709#discussion_r1426440875 ## CMakeLists.txt: ## @@ -422,8 +422,12 @@ if(WIN32) file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/conf/" DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/conf/")

Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

2023-12-13 Thread via GitHub
szaszm commented on code in PR #1709: URL: https://github.com/apache/nifi-minifi-cpp/pull/1709#discussion_r1426258158 ## CMakeLists.txt: ## @@ -422,8 +422,12 @@ if(WIN32) file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/conf/" DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/conf/")

Re: [PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

2023-12-13 Thread via GitHub
martinzink commented on code in PR #1709: URL: https://github.com/apache/nifi-minifi-cpp/pull/1709#discussion_r1425873524 ## CMakeLists.txt: ## @@ -422,8 +422,12 @@ if(WIN32) file(COPY "${CMAKE_CURRENT_SOURCE_DIR}/conf/" DESTINATION "${CMAKE_CURRENT_BINARY_DIR}/conf/")

[PR] MINIFICPP-2274 Ship Markdown docs in binary packages [nifi-minifi-cpp]

2023-12-13 Thread via GitHub
szaszm opened a new pull request, #1709: URL: https://github.com/apache/nifi-minifi-cpp/pull/1709 https://apachenifi.slack.com/archives/CDF1VC1UZ/p1702055532245309?thread_ts=1702050961.615049=CDF1VC1UZ --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.