Re: [PR] NIFI-12885 Add convenience method to `Record` to parse DateTime objects [nifi]

2024-04-24 Thread via GitHub
exceptionfactory merged PR #8502: URL: https://github.com/apache/nifi/pull/8502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] NIFI-12885 Add convenience method to `Record` to parse DateTime objects [nifi]

2024-04-02 Thread via GitHub
knguyen1 commented on PR #8502: URL: https://github.com/apache/nifi/pull/8502#issuecomment-2032530415 @exceptionfactory Hopefully we are close. I added 1. `testGettingLocalDate` 2. `testGettingLocalDateTime` 3. `testGettingOffsetDateTime` in their own tests. In

Re: [PR] NIFI-12885 Add convenience method to `Record` to parse DateTime objects [nifi]

2024-04-02 Thread via GitHub
knguyen1 commented on code in PR #8502: URL: https://github.com/apache/nifi/pull/8502#discussion_r1547851647 ## nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/MapRecord.java: ## @@ -279,10 +282,27 @@ public Boolean getAsBoolean(final String

Re: [PR] NIFI-12885 Add convenience method to `Record` to parse DateTime objects [nifi]

2024-04-01 Thread via GitHub
exceptionfactory commented on code in PR #8502: URL: https://github.com/apache/nifi/pull/8502#discussion_r1546320728 ## nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/MapRecord.java: ## @@ -279,10 +282,27 @@ public Boolean getAsBoolean(final String

Re: [PR] NIFI-12885 Add convenience method to `Record` to parse DateTime objects [nifi]

2024-03-15 Thread via GitHub
exceptionfactory commented on PR #8502: URL: https://github.com/apache/nifi/pull/8502#issuecomment-290444 > > It may be helpful to scope down the number of timestamps in the provideTimestamps method to focus on differences. > > @exceptionfactory Okay. I scoped it down to 2

Re: [PR] NIFI-12885 Add convenience method to `Record` to parse DateTime objects [nifi]

2024-03-15 Thread via GitHub
knguyen1 commented on PR #8502: URL: https://github.com/apache/nifi/pull/8502#issuecomment-255062 > It may be helpful to scope down the number of timestamps in the provideTimestamps method to focus on differences. @exceptionfactory Okay. I scoped it down to 2 formats:

[PR] NIFI-12885 Add convenience method to `Record` to parse DateTime objects [nifi]

2024-03-14 Thread via GitHub
knguyen1 opened a new pull request, #8502: URL: https://github.com/apache/nifi/pull/8502 # Summary [NIFI-12885](https://issues.apache.org/jira/browse/NIFI-12885) # Tracking Please complete the following tracking steps