Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-04-19 Thread via GitHub
mattyb149 closed pull request #8544: NIFI-12923 Added append avro mode to PutHDFS URL: https://github.com/apache/nifi/pull/8544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-04-19 Thread via GitHub
mattyb149 commented on PR #8544: URL: https://github.com/apache/nifi/pull/8544#issuecomment-2067074203 +1 LGTM, verified the Avro append capability works as expected. Thanks for the improvement! Merging to main and support/nifi-1.x -- This is an automated message from the Apache Git

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-04-18 Thread via GitHub
mattyb149 commented on PR #8544: URL: https://github.com/apache/nifi/pull/8544#issuecomment-2065354244 Now I'm running into [this](https://github.com/apache/hadoop/blob/rel/release-3.4.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ChecksumFileSystem.java#L590) in

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-04-10 Thread via GitHub
balazsgerner commented on PR #8544: URL: https://github.com/apache/nifi/pull/8544#issuecomment-2047264513 I had to rebase to `main` in order resolve merge conflicts. Sorry for the force push. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-04-05 Thread via GitHub
balazsgerner commented on PR #8544: URL: https://github.com/apache/nifi/pull/8544#issuecomment-2039019933 > In order for the append to work I had to set `Writing Strategy` to `Simple write`, if I leave the default `Write and rename`, it actually deletes the file. Is this intended? If not

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-04-04 Thread via GitHub
mattyb149 commented on PR #8544: URL: https://github.com/apache/nifi/pull/8544#issuecomment-2037620687 In order for the append to work I had to set `Writing Strategy` to `Simple write`, if I leave the default `Write and rename`, it actually deletes the file. Is this intended? If not we

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-03-28 Thread via GitHub
balazsgerner commented on code in PR #8544: URL: https://github.com/apache/nifi/pull/8544#discussion_r1542485279 ## nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java: ## @@ -160,6 +170,14 @@ public class

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-03-27 Thread via GitHub
turcsanyip commented on code in PR #8544: URL: https://github.com/apache/nifi/pull/8544#discussion_r1541225410 ## nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java: ## @@ -160,6 +170,14 @@ public class PutHDFS

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-03-27 Thread via GitHub
balazsgerner commented on code in PR #8544: URL: https://github.com/apache/nifi/pull/8544#discussion_r1540709931 ## nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java: ## @@ -160,6 +170,14 @@ public class

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-03-26 Thread via GitHub
Lehel44 commented on code in PR #8544: URL: https://github.com/apache/nifi/pull/8544#discussion_r1540085973 ## nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java: ## @@ -160,6 +170,14 @@ public class PutHDFS

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-03-26 Thread via GitHub
balazsgerner commented on code in PR #8544: URL: https://github.com/apache/nifi/pull/8544#discussion_r1538866777 ## nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java: ## @@ -397,10 +432,28 @@ public void

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-03-25 Thread via GitHub
exceptionfactory commented on code in PR #8544: URL: https://github.com/apache/nifi/pull/8544#discussion_r1538408812 ## nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java: ## @@ -397,10 +432,28 @@ public void

Re: [PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-03-25 Thread via GitHub
mattyb149 commented on code in PR #8544: URL: https://github.com/apache/nifi/pull/8544#discussion_r1538170755 ## nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java: ## @@ -397,10 +432,28 @@ public void

[PR] NIFI-12923 Added append avro mode to PutHDFS [nifi]

2024-03-22 Thread via GitHub
balazsgerner opened a new pull request, #8544: URL: https://github.com/apache/nifi/pull/8544 # Summary [NIFI-12923](https://issues.apache.org/jira/browse/NIFI-12923) # Tracking Please complete the following tracking