greyp9 commented on PR #8463:
URL: https://github.com/apache/nifi/pull/8463#issuecomment-2123083750
> @greyp9 It looks like the latest changes are failing on integration tests
due to property name changes.
Thanks; pushed an update.
--
This is an automated message from the Apache
exceptionfactory commented on PR #8463:
URL: https://github.com/apache/nifi/pull/8463#issuecomment-2122889110
@greyp9 It looks like the latest changes are failing on integration tests
due to property name changes.
--
This is an automated message from the Apache Git Service.
To respond to
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1605446151
##
nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/producer/config/DeliveryGuarantee.java:
##
@@ -0,0 +1,47
greyp9 commented on PR #8463:
URL: https://github.com/apache/nifi/pull/8463#issuecomment-2091285872
> I see what you mean. I'm suggesting even needing to swap out the
controller service seems problematic.
The jump from 2.6 to 3.0 involved * slight * changes in the NiFi component
joewitt commented on PR #8463:
URL: https://github.com/apache/nifi/pull/8463#issuecomment-2091227065
I see what you mean. I'm suggesting even needing to swap out the controller
service seems problematic.
I like the controller service model and I recall why this direction was
taken.
joewitt commented on PR #8463:
URL: https://github.com/apache/nifi/pull/8463#issuecomment-2090978880
@greyp9 Yeah that is fair. Dropping the 2.x stuff is certainly fair in a
diff PR.
More relevant for this PR though would be the naming for the Kafka3
components and breaking the
greyp9 commented on PR #8463:
URL: https://github.com/apache/nifi/pull/8463#issuecomment-2090939791
> Can we just drop the old Kafka processors and go all in on the latest
release? At this point the client libraries have stabilized greatly and us
supporting the older stuff feels far less
joewitt commented on PR #8463:
URL: https://github.com/apache/nifi/pull/8463#issuecomment-2089326292
Can we just drop the old Kafka processors and go all in on the latest
release? At this point the client libraries have stabilized greatly and us
supporting the older stuff feels far less
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1556223354
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/ConsumeKafka.java:
##
@@ -0,0 +1,464 @@
+/*
+ * Licensed to the
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538322756
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/ConsumeKafka.java:
##
@@ -0,0 +1,464 @@
+/*
+ * Licensed to the
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538320629
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/producer/txn/KafkaTransactionalProducerWrapper.java:
##
@@ -0,0
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538319116
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/producer/txn/KafkaProducerWrapper.java:
##
@@ -0,0 +1,82 @@
+/*
+ *
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538315024
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/producer/ProducerCallback.java:
##
@@ -0,0 +1,99 @@
+/*
+ * Licensed
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538306358
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/producer/Kafka3ProducerService.java:
##
@@ -0,0 +1,127 @@
+/*
+ *
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538303445
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-integration/src/test/java/org/apache/nifi/kafka/processors/publish/additional/readme.txt:
##
@@ -0,0 +1,2 @@
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538303639
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/README.md:
##
@@ -0,0 +1,14 @@
+
+
+### Kafka3ProducerService
+- As the `send()` API maps cleanly to the context
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1538301385
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/Kafka3ConnectionService.java:
##
@@ -0,0 +1,402 @@
+/*
+ * Licensed
exceptionfactory commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1526461916
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/README.md:
##
@@ -0,0 +1,14 @@
+
+
+### Kafka3ProducerService
+- As the `send()` API maps cleanly to
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1522080555
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/ConsumeKafka.java:
##
@@ -0,0 +1,464 @@
+/*
+ * Licensed to the
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1522076394
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-3-service/src/main/java/org/apache/nifi/kafka/service/Kafka3ConnectionService.java:
##
@@ -0,0 +1,402 @@
+/*
+ * Licensed
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1522075657
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/PublishKafka.java:
##
@@ -0,0 +1,527 @@
+/*
+ * Licensed to the
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1522074061
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/ConsumeKafka.java:
##
@@ -0,0 +1,464 @@
+/*
+ * Licensed to the
taz1988 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1517541500
##
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/PublishKafka.java:
##
@@ -0,0 +1,527 @@
+/*
+ * Licensed to the
23 matches
Mail list logo
