exceptionfactory closed pull request #8094: NIFI-12270: Add new provenance
event: UPLOAD
URL: https://github.com/apache/nifi/pull/8094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Lehel44 commented on PR #8094:
URL: https://github.com/apache/nifi/pull/8094#issuecomment-1908258979
Thanks for the review @markap14 @exceptionfactory. Is this one good to go in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
exceptionfactory commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1458173813
##
nifi-mock/src/main/java/org/apache/nifi/util/MockProvenanceReporter.java:
##
@@ -225,6 +228,49 @@ public void send(final FlowFile flowFile, final String
Lehel44 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1458055270
##
nifi-api/src/main/java/org/apache/nifi/provenance/upload/FileResource.java:
##
@@ -20,15 +20,26 @@
* Holds information of a file resource for UPLOAD
* provenance
exceptionfactory commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1437971330
##
nifi-api/src/main/java/org/apache/nifi/provenance/upload/FileResource.java:
##
@@ -20,15 +20,26 @@
* Holds information of a file resource for UPLOAD
*
Lehel44 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1437917401
##
nifi-api/src/main/java/org/apache/nifi/provenance/upload/FileResource.java:
##
@@ -20,15 +20,26 @@
* Holds information of a file resource for UPLOAD
* provenance
Lehel44 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1437914962
##
nifi-api/src/main/java/org/apache/nifi/provenance/upload/FileResource.java:
##
@@ -20,15 +20,26 @@
* Holds information of a file resource for UPLOAD
* provenance
exceptionfactory commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1437901472
##
nifi-api/src/main/java/org/apache/nifi/provenance/upload/FileResource.java:
##
@@ -20,15 +20,26 @@
* Holds information of a file resource for UPLOAD
*
Lehel44 commented on PR #8094:
URL: https://github.com/apache/nifi/pull/8094#issuecomment-1867062046
@joewitt I added the discussion link to the Jira, thanks for pointing out.
The main issue here was that the SEND event used the size of the incoming
FlowFile but instead of a copy of this
markap14 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1434525927
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml:
##
@@ -468,6 +468,11 @@
org.glassfish.jaxb
jaxb-runtime
+
markap14 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1434523863
##
nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/upload/StandardFileResource.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache
markap14 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1434523320
##
nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/upload/StandardUploadContext.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache
markap14 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1434522640
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/repository/StandardProvenanceReporter.java:
markap14 commented on code in PR #8094:
URL: https://github.com/apache/nifi/pull/8094#discussion_r1434522521
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml:
##
@@ -468,6 +468,11 @@
org.glassfish.jaxb
jaxb-runtime
+
joewitt commented on PR #8094:
URL: https://github.com/apache/nifi/pull/8094#issuecomment-1866733000
Ahh that discussion context is helpful - would make sense to have that
already linked in either the JIRA itself or this PR. If it was there and I
missed it sorry about that. Otherwise, we
pvillard31 commented on PR #8094:
URL: https://github.com/apache/nifi/pull/8094#issuecomment-1866718524
This PR is following @markap14 's recommendation in this email thread:
https://lists.apache.org/thread/hwt87hz4679vbmtv9yg78dw38jrwc861
--
This is an automated message from the
joewitt commented on PR #8094:
URL: https://github.com/apache/nifi/pull/8094#issuecomment-1866711876
Similar to Matt's comment why does a SEND event not cover this case
sufficiently?
In this case it is that NiFi is effectively being used to take a given
external reference and send
mattyb149 commented on PR #8094:
URL: https://github.com/apache/nifi/pull/8094#issuecomment-1835309013
For uploading local files isn't that what the SEND is for? Or is this to
upload from an external location into an external system without ever storing
locally? If that's the use case
18 matches
Mail list logo
