[jira] [Commented] (NIFI-2896) Perform Release Management Functions for 0.7.1

2016-10-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15590772#comment-15590772
 ] 

ASF subversion and git services commented on NIFI-2896:
---

Commit 421d5e61553e5fa160af9e0cc9fdc237af46906d in nifi's branch refs/heads/0.x 
from [~jskora]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=421d5e6 ]

NIFI-2896-RC1 prepare release nifi-0.7.1-RC1


> Perform Release Management Functions for 0.7.1
> --
>
> Key: NIFI-2896
> URL: https://issues.apache.org/jira/browse/NIFI-2896
> Project: Apache NiFi
>  Issue Type: Task
>Reporter: Joe Skora
>Assignee: Joe Skora
>  Labels: release
> Fix For: 0.7.1
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2896) Perform Release Management Functions for 0.7.1

2016-10-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15590773#comment-15590773
 ] 

ASF subversion and git services commented on NIFI-2896:
---

Commit e97d1a86094c45dd53af66e8c628b5cb5750c2a6 in nifi's branch refs/heads/0.x 
from [~jskora]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=e97d1a8 ]

NIFI-2896-RC1 prepare for next development iteration


> Perform Release Management Functions for 0.7.1
> --
>
> Key: NIFI-2896
> URL: https://issues.apache.org/jira/browse/NIFI-2896
> Project: Apache NiFi
>  Issue Type: Task
>Reporter: Joe Skora
>Assignee: Joe Skora
>  Labels: release
> Fix For: 0.7.1
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-1784) Create a FetchHBase Processor

2016-10-19 Thread Bryan Bende (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15590353#comment-15590353
 ] 

Bryan Bende commented on NIFI-1784:
---

[~sean.monner] Unfortunately I don't know of any good work arounds at the 
moment. It looks like HBase has a REST API, so it might be possible to use 
InvokeHttp/GetHttp to interact with it, but I have never tried 
(http://hbase.apache.org/book.html#_rest).

> Create a FetchHBase Processor
> -
>
> Key: NIFI-1784
> URL: https://issues.apache.org/jira/browse/NIFI-1784
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Priority: Minor
>
> We should provide a processor to fetch a row from HBase. The processor should 
> support receiving an incoming FlowFile and taking the row id to fetch from an 
> attribute on the incoming, and should also be able to fetch a static row id.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-1784) Create a FetchHBase Processor

2016-10-19 Thread Sean Monner (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15590093#comment-15590093
 ] 

Sean Monner commented on NIFI-1784:
---

Is there a good alternative to the existence of this processor?  GetHBase does 
not seem to cover all situations.

> Create a FetchHBase Processor
> -
>
> Key: NIFI-1784
> URL: https://issues.apache.org/jira/browse/NIFI-1784
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Bryan Bende
>Priority: Minor
>
> We should provide a processor to fetch a row from HBase. The processor should 
> support receiving an incoming FlowFile and taking the row id to fetch from an 
> attribute on the incoming, and should also be able to fetch a static row id.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2923) Add expression language support to Kerberos parameters used by processors

2016-10-19 Thread Maurizio Colleluori (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maurizio Colleluori updated NIFI-2923:
--
Description: At the moment it is not possible to parameterise the kerberos 
properties (e.g. principal, keytab) defined in some of the processors like the 
HDFS ones. Support for expression language could be added to these attributes.  
(was: At the moment it is not possible to parameterise the kerberos properties 
(e.g. principal, keytab) defined in some of the processors like the HDFS ones. 
Support for expression language should be added to these attributes.)

> Add expression language support to Kerberos parameters used by processors
> -
>
> Key: NIFI-2923
> URL: https://issues.apache.org/jira/browse/NIFI-2923
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Maurizio Colleluori
>Priority: Minor
>
> At the moment it is not possible to parameterise the kerberos properties 
> (e.g. principal, keytab) defined in some of the processors like the HDFS 
> ones. Support for expression language could be added to these attributes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2923) Add expression language support to Kerberos parameters used by processors

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589994#comment-15589994
 ] 

ASF GitHub Bot commented on NIFI-2923:
--

GitHub user mauriziocolleluori opened a pull request:

https://github.com/apache/nifi/pull/1148

NIFI-2923 Add expression language support to Kerberos parameters used…

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

… by processors

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mauriziocolleluori/nifi NIFI-2923

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1148.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1148


commit 1e7035c5f6bc730c48fc83264586f49ec90bdaf9
Author: Maurizio Colleluori 
Date:   2016-10-19T21:54:22Z

NIFI-2923 Add expression language support to Kerberos parameters used by 
processors




> Add expression language support to Kerberos parameters used by processors
> -
>
> Key: NIFI-2923
> URL: https://issues.apache.org/jira/browse/NIFI-2923
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Maurizio Colleluori
>Priority: Minor
>
> At the moment it is not possible to parameterise the kerberos properties 
> (e.g. principal, keytab) defined in some of the processors like the HDFS 
> ones. Support for expression language should be added to these attributes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1148: NIFI-2923 Add expression language support to Kerber...

2016-10-19 Thread mauriziocolleluori
GitHub user mauriziocolleluori opened a pull request:

https://github.com/apache/nifi/pull/1148

NIFI-2923 Add expression language support to Kerberos parameters used…

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [X] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.

… by processors

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mauriziocolleluori/nifi NIFI-2923

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1148.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1148


commit 1e7035c5f6bc730c48fc83264586f49ec90bdaf9
Author: Maurizio Colleluori 
Date:   2016-10-19T21:54:22Z

NIFI-2923 Add expression language support to Kerberos parameters used by 
processors




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (NIFI-2923) Add expression language support to Kerberos parameters used by processors

2016-10-19 Thread Maurizio Colleluori (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maurizio Colleluori updated NIFI-2923:
--
Priority: Minor  (was: Major)

> Add expression language support to Kerberos parameters used by processors
> -
>
> Key: NIFI-2923
> URL: https://issues.apache.org/jira/browse/NIFI-2923
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Maurizio Colleluori
>Priority: Minor
>
> At the moment it is not possible to parameterise the kerberos properties 
> (e.g. principal, keytab) defined in some of the processors like the HDFS 
> ones. Support for expression language should be added to these attributes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (NIFI-2923) Add expression language support to Kerberos parameters used by processors

2016-10-19 Thread Maurizio Colleluori (JIRA)
Maurizio Colleluori created NIFI-2923:
-

 Summary: Add expression language support to Kerberos parameters 
used by processors
 Key: NIFI-2923
 URL: https://issues.apache.org/jira/browse/NIFI-2923
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Maurizio Colleluori


At the moment it is not possible to parameterise the kerberos properties (e.g. 
principal, keytab) defined in some of the processors like the HDFS ones. 
Support for expression language should be added to these attributes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread Andy LoPresto (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy LoPresto updated NIFI-2919:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589854#comment-15589854
 ] 

ASF subversion and git services commented on NIFI-2919:
---

Commit 611cadd231309126a0a7737391f6e07730bb3864 in nifi's branch 
refs/heads/master from [~ozhurakousky]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=611cadd ]

NIFI-2919 Improved GetFile processor to fail (and provide bulletins) if target 
directory is inaccessible.

This closes #1147.

Signed-off-by: Andy LoPresto 

Fixed typos in error messages, renamed variables in test, and cleaned up 
unnecessary imports. (+1 squashed commit)
Squashed commits:
[e755cbd] NIFI-2919 improved GetFile to fail if target directory is inaccessible


> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589853#comment-15589853
 ] 

ASF subversion and git services commented on NIFI-2919:
---

Commit 611cadd231309126a0a7737391f6e07730bb3864 in nifi's branch 
refs/heads/master from [~ozhurakousky]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=611cadd ]

NIFI-2919 Improved GetFile processor to fail (and provide bulletins) if target 
directory is inaccessible.

This closes #1147.

Signed-off-by: Andy LoPresto 

Fixed typos in error messages, renamed variables in test, and cleaned up 
unnecessary imports. (+1 squashed commit)
Squashed commits:
[e755cbd] NIFI-2919 improved GetFile to fail if target directory is inaccessible


> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589855#comment-15589855
 ] 

ASF GitHub Bot commented on NIFI-2919:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1147


> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1147: NIFI-2919 improved GetFile to fail if target direct...

2016-10-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1147


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589852#comment-15589852
 ] 

ASF GitHub Bot commented on NIFI-2919:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1147
  
I made a couple small changes, but otherwise +1. Verified by creating a 
directory structure as below and verified the positive case succeeded with no 
error output; the two negative cases caused the expected bulletins and log 
messages to be generated. 

```
hw12203:/Users/alopresto/Workspace/scratch/pr1147 (master) alopresto
 73s @ 16:03:49 $ ll
total 0
drwxr-xr-x   5 alopresto  staff   170B Oct 19 16:03 ./
drwxr-xr-x  56 alopresto  staff   1.9K Oct 19 16:01 ../
drwxr-xr-x   2 alopresto  staff68B Oct 19 16:03 regular/
d-wx-wx-wx   2 alopresto  staff68B Oct 19 16:01 unreadable/
dr-xr-xr-x   2 alopresto  staff68B Oct 19 16:01 unwritable/
hw12203:/Users/alopresto/Workspace/scratch/pr1147 (master) alopresto
 2s @ 16:03:52 $
```

* Fixed typos in error message ("redable" -> "readable")
* Changed multiline comment to block comment
* Removed unusued imports in test
* Fixed variable names & directory in test as per @olegz 's request above


> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1147: NIFI-2919 improved GetFile to fail if target directory is ...

2016-10-19 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1147
  
I made a couple small changes, but otherwise +1. Verified by creating a 
directory structure as below and verified the positive case succeeded with no 
error output; the two negative cases caused the expected bulletins and log 
messages to be generated. 

```
hw12203:/Users/alopresto/Workspace/scratch/pr1147 (master) alopresto
🔓 73s @ 16:03:49 $ ll
total 0
drwxr-xr-x   5 alopresto  staff   170B Oct 19 16:03 ./
drwxr-xr-x  56 alopresto  staff   1.9K Oct 19 16:01 ../
drwxr-xr-x   2 alopresto  staff68B Oct 19 16:03 regular/
d-wx-wx-wx   2 alopresto  staff68B Oct 19 16:01 unreadable/
dr-xr-xr-x   2 alopresto  staff68B Oct 19 16:01 unwritable/
hw12203:/Users/alopresto/Workspace/scratch/pr1147 (master) alopresto
🔓 2s @ 16:03:52 $
```

* Fixed typos in error message ("redable" -> "readable")
* Changed multiline comment to block comment
* Removed unusued imports in test
* Fixed variable names & directory in test as per @olegz 's request above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Comment Edited] (NIFI-2898) Add Processor dialog cuts off processor descriptions

2016-10-19 Thread Scott Aslan (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589624#comment-15589624
 ] 

Scott Aslan edited comment on NIFI-2898 at 10/19/16 9:02 PM:
-

[~rmoran] I can look at adding the scrollable type to the 
#processor-types-table​ but I think that if we were to add that we would also 
need to add this conditional style to all slickgrid tables and I would think we 
would need another ticket for this.

I was also able to track down the original problem as to why the ellipsis() 
were not working in the first place. It is due to a fixed height being applied 
through CSS to the #processor-type-description div. The reason I bring this up 
is because I think for consistency across the application if we add these 
scrollable styles to the #processor-type-description then there are other areas 
of the application this will impact as well (View State, Component State, CS, 
and RT descriptions to name a few). In fact, it could be argued that if we are 
choosing to go a different route with scrollable content opposed to ellipsis 
then we probably need to remove the ellipsis jQuery plugin and update the areas 
it has been applied to use the new scrollable approach. This obviously is a 
much bigger effort and I would propose a simple solution for bringing back the 
ellipsis() to close this ticket and open a new ticket to encapsulate the 
removal of the ellipsis plugin and apply scrollable content areas in its stead.

Thoughts? [~mcgilman] do you have any input?


was (Author: scottyaslan):
[~rmoran] I can look at adding the scrollable type to the 
#processor-types-table​ but I think that if we were to add that we would also 
need to add this conditional style to all slickgrid tables and I would think we 
would need another ticket for this.

> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (NIFI-2922) Ability to clear bulletins on a per-processor basis

2016-10-19 Thread Andy LoPresto (JIRA)
Andy LoPresto created NIFI-2922:
---

 Summary: Ability to clear bulletins on a per-processor basis
 Key: NIFI-2922
 URL: https://issues.apache.org/jira/browse/NIFI-2922
 Project: Apache NiFi
  Issue Type: New Feature
  Components: Core Framework, Core UI
Affects Versions: 0.7.0, 1.0.0
Reporter: Andy LoPresto
Priority: Trivial


Often when testing or verifying a change in processor properties, etc., I will 
run a "negative" flow (a flow I expect to result in some type of error case, 
generate bulletins, etc.) and then change the setting under examination and 
re-run. In this case, I would like to be able to quickly clear the existing 
bulletins from the processor under examination in order to be able to determine 
if the issue is resolved without having to manually examine timestamps in the 
bulletins/wait for the 5 minute bulletin expiration to age off the existing 
bulletins. 

I imagine this being implemented as a REST API (likely {{PUT}}/{{DELETE}} on 
{{/processors/{id}/bulletins}}) which could be invoked via a context menu item 
or a dedicated button in the Operate palette. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589680#comment-15589680
 ] 

ASF GitHub Bot commented on NIFI-2919:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1147
  
@olegz No problem. 


> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1147: NIFI-2919 improved GetFile to fail if target directory is ...

2016-10-19 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1147
  
@olegz No problem. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-1459) Scroll bar in the properties tab of processor Config appears behind allowable values dropdown

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589664#comment-15589664
 ] 

ASF GitHub Bot commented on NIFI-1459:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1070
  
Thanks @scottyaslan. This has been merged to master.


> Scroll bar in the properties tab of processor Config appears behind allowable 
> values dropdown
> -
>
> Key: NIFI-1459
> URL: https://issues.apache.org/jira/browse/NIFI-1459
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 0.4.1
> Environment: OSX 10.10.15 with "Show scroll bars" option set to "When 
> scrolling" and using Google Chrome version 48.0.2564.97 (64-bit)
>Reporter: Joseph Percivall
>Assignee: Scott Aslan
>Priority: Trivial
> Fix For: 1.1.0
>
> Attachments: Screen Shot 2016-02-02 at 11.23.46 AM.png
>
>
> In processors with many properties, one of them being a dropdown of allowable 
> values,  when the value for the property is select (bringing up the pop-up) 
> the scroll bar will overlap the box.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-1459) Scroll bar in the properties tab of processor Config appears behind allowable values dropdown

2016-10-19 Thread Matt Gilman (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-1459:
--
   Resolution: Fixed
Fix Version/s: 1.1.0
   Status: Resolved  (was: Patch Available)

> Scroll bar in the properties tab of processor Config appears behind allowable 
> values dropdown
> -
>
> Key: NIFI-1459
> URL: https://issues.apache.org/jira/browse/NIFI-1459
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 0.4.1
> Environment: OSX 10.10.15 with "Show scroll bars" option set to "When 
> scrolling" and using Google Chrome version 48.0.2564.97 (64-bit)
>Reporter: Joseph Percivall
>Assignee: Scott Aslan
>Priority: Trivial
> Fix For: 1.1.0
>
> Attachments: Screen Shot 2016-02-02 at 11.23.46 AM.png
>
>
> In processors with many properties, one of them being a dropdown of allowable 
> values,  when the value for the property is select (bringing up the pop-up) 
> the scroll bar will overlap the box.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1070: [NIFI-1459] add css translate3d to properties table editor...

2016-10-19 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1070
  
Thanks @scottyaslan. This has been merged to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-1459) Scroll bar in the properties tab of processor Config appears behind allowable values dropdown

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589662#comment-15589662
 ] 

ASF GitHub Bot commented on NIFI-1459:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1070


> Scroll bar in the properties tab of processor Config appears behind allowable 
> values dropdown
> -
>
> Key: NIFI-1459
> URL: https://issues.apache.org/jira/browse/NIFI-1459
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 0.4.1
> Environment: OSX 10.10.15 with "Show scroll bars" option set to "When 
> scrolling" and using Google Chrome version 48.0.2564.97 (64-bit)
>Reporter: Joseph Percivall
>Assignee: Scott Aslan
>Priority: Trivial
> Attachments: Screen Shot 2016-02-02 at 11.23.46 AM.png
>
>
> In processors with many properties, one of them being a dropdown of allowable 
> values,  when the value for the property is select (bringing up the pop-up) 
> the scroll bar will overlap the box.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1070: [NIFI-1459] add css translate3d to properties table...

2016-10-19 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1070


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

2016-10-19 Thread Scott Aslan (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589624#comment-15589624
 ] 

Scott Aslan commented on NIFI-2898:
---

[~rmoran] I can look at adding the scrollable type to the 
#processor-types-table​ but I think that if we were to add that we would also 
need to add this conditional style to all slickgrid tables and I would think we 
would need another ticket for this.

> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-1662) Improve Expression Language to Enable Working with Decimals

2016-10-19 Thread Joseph Percivall (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Percivall updated NIFI-1662:
---
Fix Version/s: 1.1.0

> Improve Expression Language to Enable Working with Decimals
> ---
>
> Key: NIFI-1662
> URL: https://issues.apache.org/jira/browse/NIFI-1662
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joseph Percivall
>Assignee: Joseph Percivall
> Fix For: 1.1.0
>
>
> Currently the math operations in Expression Language use Longs to evaluate 
> numbers. This leads to any decimal places getting truncated when performing 
> operations like divide. 
> NiFi should support working with decimals



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589610#comment-15589610
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84139791
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
 ---
@@ -185,6 +191,19 @@ nf.ProcessorDetails = (function () {
 $('#read-only-run-schedule').hide();
 }
 
+// only show the execution-node when applicable
+if (executionNode === 'ALL') {
+executionNode = "All nodes";
+} else if (executionNode === 'PRIMARY') {
+executionNode = "Primary node only";
+}
+nf.Common.populateField('read-only-execution-node', 
executionNode);
+if (nf.Canvas.isClustered()) {
--- End diff --

Same comment as above regarding determining whether or not we should be 
showing the execution node. Since a node can be easily connected/disconnected 
we should probably show the execution node if clustered or if the value is 
'primary node only'. Should only be hiding this field if the instance is not 
clustered and the execution node is 'all'.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589613#comment-15589613
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84142131
  
--- Diff: 
nifi-api/src/main/java/org/apache/nifi/scheduling/SchedulingStrategy.java ---
@@ -56,6 +56,10 @@
  */
 TIMER_DRIVEN(1, "0 sec"),
 /**
+ * NOTE: This option has been deprecated with the addition of the
+ * execution-node combo box.  It still exists for backward 
compatibility
+ * with existing flows that still have this value for 
schedulingStrategy.
+ **
--- End diff --

Probably should actually mark this option as deprecated using an annotation.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589612#comment-15589612
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84145273
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/processor-configuration.jsp
 ---
@@ -108,6 +108,18 @@
 
 
 
+
--- End diff --

The Scheduling Strategy and the Run Schedule should probably remain closer 
together. Can you shift the Execution Node setting below the Concurrent Tasks 
and Run Schedule.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589608#comment-15589608
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84136870
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
 ---
@@ -52,22 +52,6 @@ nf.ProcessorConfiguration = (function () {
 });
 }
 
-// conditionally support event driven
-if (nf.Canvas.isClustered()) {
-strategies.push({
-text: 'On primary node',
-value: 'PRIMARY_NODE_ONLY',
-description: 'Processor will be scheduled on the primary 
node on an interval defined by the run schedule.'
-});
-} else if (processor.config['schedulingStrategy'] === 
'PRIMARY_NODE_ONLY') {
--- End diff --

I realize that we are deprecating 'Primary Node Only' but I believe we 
still need to retain this case to handle existing components with this 
configuration. The disabled flag will prevent this option from being selected 
again.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589618#comment-15589618
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84146168
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/processor-details.jsp
 ---
@@ -103,6 +103,18 @@
 
 
 
+
--- End diff --

Same comment as above, we should keep the Scheduling Strategy and Run 
Schedule close together by shifting the Execution Node below the Concurrent 
Tasks and Run Schedule.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589609#comment-15589609
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84138137
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
 ---
@@ -662,6 +674,16 @@ nf.ProcessorConfiguration = (function () {
 }
 });
 
+// select the execution node
+$('#execution-node-combo').combo('setSelectedOption', {
+value: executionNode
+});
+if (nf.Canvas.isClustered()) {
--- End diff --

If we are going to hide/show the execution node container, we should 
probably also be considering the currently configured value. If a node is 
configured for 'Primary Node Only' we need to retain that fact even when not 
clustered. If a user has disconnected a node and then went to that node 
directly we still want the configuration actually reflected. Should probably 
show the field if clustered or if the execution node is 'primary node only'.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589615#comment-15589615
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84133750
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/processor-configuration.css
 ---
@@ -110,6 +110,12 @@ div.processor-enabled-container {
 line-height: 18px;
 }
 
+#execution-node-combo {
--- End diff --

With the updated UI in 1.0.0 I don't think this style is necessary anymore. 
Specifically the width and height are not consistent with the other combos in 
the scheduling tab.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589614#comment-15589614
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84139832
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
 ---
@@ -166,15 +167,20 @@ nf.ProcessorDetails = (function () {
 
 // make the scheduling strategy human readable
 var schedulingStrategy = 
details.config['schedulingStrategy'];
+var executionNode = details.config['executionNode'];
 if (schedulingStrategy === 'EVENT_DRIVEN') {
 showRunSchedule = false;
 schedulingStrategy = 'Event driven';
 } else if (schedulingStrategy === 'CRON_DRIVEN') {
 schedulingStrategy = 'CRON driven';
 } else if (schedulingStrategy === 'TIMER_DRIVEN') {
 schedulingStrategy = "Timer driven";
-} else {
-schedulingStrategy = "On primary node";
+} else if (schedulingStrategy === 'PRIMARY_NODE_ONLY') 
{
--- End diff --

Again, I don't think we want to infer the configuration here. We should 
continuing showing 'On primary node' if the component is configured with it.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589617#comment-15589617
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84141846
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/processor-configuration.jsp
 ---
@@ -108,6 +108,18 @@
 
 
 
+
+
+
+Execution node
+
--- End diff --

Can you update the 'Info Icon' to use the same styles as the others in the 
scheduling tab?


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589616#comment-15589616
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84136907
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
 ---
@@ -632,11 +633,22 @@ nf.ProcessorConfiguration = (function () {
 value: processor.config['bulletinLevel']
 });
 
+// If the scheduling strategy is PRIMARY_NODE_ONLY 
(deprecated),
+// then set the execution node to PRIMARY and the 
scheduling
+// strategy to TIMER.  These new values will be saved 
when/if
+// the dialog is applied.
+var schedulingStrategy = 
processor.config['schedulingStrategy'];
+var executionNode = processor.config['executionNode'];
+if (schedulingStrategy === 'PRIMARY_NODE_ONLY') {
--- End diff --

This appears to be rendering the inferred configuration based on the 
currently (now deprecated) option. I think we should be rendering what is 
actually configured. If the option is now deprecated we should mark the item as 
disabled to prevent it from being selected again. But I do not believe we 
should be rendering something that is not actually configured.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589619#comment-15589619
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84147018
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
 ---
@@ -264,6 +251,7 @@ nf.ProcessorConfiguration = (function () {
 processorConfigDto['schedulingPeriod'] = 
schedulingPeriod.val();
 }
 
+processorConfigDto['executionNode'] = 
$('#execution-node-combo').combo('getSelectedOption').value;
--- End diff --

Should probably consider whether the execution node is available before 
including its value in the processor's configuration.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84142131
  
--- Diff: 
nifi-api/src/main/java/org/apache/nifi/scheduling/SchedulingStrategy.java ---
@@ -56,6 +56,10 @@
  */
 TIMER_DRIVEN(1, "0 sec"),
 /**
+ * NOTE: This option has been deprecated with the addition of the
+ * execution-node combo box.  It still exists for backward 
compatibility
+ * with existing flows that still have this value for 
schedulingStrategy.
+ **
--- End diff --

Probably should actually mark this option as deprecated using an annotation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589605#comment-15589605
 ] 

ASF GitHub Bot commented on NIFI-2919:
--

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1147
  
@alopresto unless you find any major issues that would require me to follow 
up with more work, would you be able (before merging) to change in 
_testWithUnwritableDir_ the actual directory to be ```File unreadableDir = new 
File("target/unwritable");```? Copy/Paste error, otherwise i'll do it.


> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84146168
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/processor-details.jsp
 ---
@@ -103,6 +103,18 @@
 
 
 
+
--- End diff --

Same comment as above, we should keep the Scheduling Strategy and Run 
Schedule close together by shifting the Execution Node below the Concurrent 
Tasks and Run Schedule.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84141846
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/processor-configuration.jsp
 ---
@@ -108,6 +108,18 @@
 
 
 
+
+
+
+Execution node
+
--- End diff --

Can you update the 'Info Icon' to use the same styles as the others in the 
scheduling tab?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84136870
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
 ---
@@ -52,22 +52,6 @@ nf.ProcessorConfiguration = (function () {
 });
 }
 
-// conditionally support event driven
-if (nf.Canvas.isClustered()) {
-strategies.push({
-text: 'On primary node',
-value: 'PRIMARY_NODE_ONLY',
-description: 'Processor will be scheduled on the primary 
node on an interval defined by the run schedule.'
-});
-} else if (processor.config['schedulingStrategy'] === 
'PRIMARY_NODE_ONLY') {
--- End diff --

I realize that we are deprecating 'Primary Node Only' but I believe we 
still need to retain this case to handle existing components with this 
configuration. The disabled flag will prevent this option from being selected 
again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84147018
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
 ---
@@ -264,6 +251,7 @@ nf.ProcessorConfiguration = (function () {
 processorConfigDto['schedulingPeriod'] = 
schedulingPeriod.val();
 }
 
+processorConfigDto['executionNode'] = 
$('#execution-node-combo').combo('getSelectedOption').value;
--- End diff --

Should probably consider whether the execution node is available before 
including its value in the processor's configuration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84139832
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
 ---
@@ -166,15 +167,20 @@ nf.ProcessorDetails = (function () {
 
 // make the scheduling strategy human readable
 var schedulingStrategy = 
details.config['schedulingStrategy'];
+var executionNode = details.config['executionNode'];
 if (schedulingStrategy === 'EVENT_DRIVEN') {
 showRunSchedule = false;
 schedulingStrategy = 'Event driven';
 } else if (schedulingStrategy === 'CRON_DRIVEN') {
 schedulingStrategy = 'CRON driven';
 } else if (schedulingStrategy === 'TIMER_DRIVEN') {
 schedulingStrategy = "Timer driven";
-} else {
-schedulingStrategy = "On primary node";
+} else if (schedulingStrategy === 'PRIMARY_NODE_ONLY') 
{
--- End diff --

Again, I don't think we want to infer the configuration here. We should 
continuing showing 'On primary node' if the component is configured with it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (NIFI-1662) Improve Expression Language to Enable Working with Decimals

2016-10-19 Thread Joseph Percivall (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Percivall updated NIFI-1662:
---
Status: Patch Available  (was: Open)

> Improve Expression Language to Enable Working with Decimals
> ---
>
> Key: NIFI-1662
> URL: https://issues.apache.org/jira/browse/NIFI-1662
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joseph Percivall
>Assignee: Joseph Percivall
>
> Currently the math operations in Expression Language use Longs to evaluate 
> numbers. This leads to any decimal places getting truncated when performing 
> operations like divide. 
> NiFi should support working with decimals



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84133750
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/processor-configuration.css
 ---
@@ -110,6 +110,12 @@ div.processor-enabled-container {
 line-height: 18px;
 }
 
+#execution-node-combo {
--- End diff --

With the updated UI in 1.0.0 I don't think this style is necessary anymore. 
Specifically the width and height are not consistent with the other combos in 
the scheduling tab.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84138137
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
 ---
@@ -662,6 +674,16 @@ nf.ProcessorConfiguration = (function () {
 }
 });
 
+// select the execution node
+$('#execution-node-combo').combo('setSelectedOption', {
+value: executionNode
+});
+if (nf.Canvas.isClustered()) {
--- End diff --

If we are going to hide/show the execution node container, we should 
probably also be considering the currently configured value. If a node is 
configured for 'Primary Node Only' we need to retain that fact even when not 
clustered. If a user has disconnected a node and then went to that node 
directly we still want the configuration actually reflected. Should probably 
show the field if clustered or if the execution node is 'primary node only'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84145273
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/processor-configuration.jsp
 ---
@@ -108,6 +108,18 @@
 
 
 
+
--- End diff --

The Scheduling Strategy and the Run Schedule should probably remain closer 
together. Can you shift the Execution Node setting below the Concurrent Tasks 
and Run Schedule.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84136883
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
 ---
@@ -201,6 +185,9 @@ nf.ProcessorConfiguration = (function () {
 return true;
 }
 
+if ($('#execution-node-combo').combo('getSelectedOption').value 
!== (details.config['executionNode'] + '')) {
--- End diff --

Should we be considering whether the execution node combo is available 
before using it to determine if a save is required?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84136907
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-processor-configuration.js
 ---
@@ -632,11 +633,22 @@ nf.ProcessorConfiguration = (function () {
 value: processor.config['bulletinLevel']
 });
 
+// If the scheduling strategy is PRIMARY_NODE_ONLY 
(deprecated),
+// then set the execution node to PRIMARY and the 
scheduling
+// strategy to TIMER.  These new values will be saved 
when/if
+// the dialog is applied.
+var schedulingStrategy = 
processor.config['schedulingStrategy'];
+var executionNode = processor.config['executionNode'];
+if (schedulingStrategy === 'PRIMARY_NODE_ONLY') {
--- End diff --

This appears to be rendering the inferred configuration based on the 
currently (now deprecated) option. I think we should be rendering what is 
actually configured. If the option is now deprecated we should mark the item as 
disabled to prevent it from being selected again. But I do not believe we 
should be rendering something that is not actually configured.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi pull request #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1117#discussion_r84139791
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-processor-details.js
 ---
@@ -185,6 +191,19 @@ nf.ProcessorDetails = (function () {
 $('#read-only-run-schedule').hide();
 }
 
+// only show the execution-node when applicable
+if (executionNode === 'ALL') {
+executionNode = "All nodes";
+} else if (executionNode === 'PRIMARY') {
+executionNode = "Primary node only";
+}
+nf.Common.populateField('read-only-execution-node', 
executionNode);
+if (nf.Canvas.isClustered()) {
--- End diff --

Same comment as above regarding determining whether or not we should be 
showing the execution node. Since a node can be easily connected/disconnected 
we should probably show the execution node if clustered or if the value is 
'primary node only'. Should only be hiding this field if the instance is not 
clustered and the execution node is 'all'.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1147: NIFI-2919 improved GetFile to fail if target directory is ...

2016-10-19 Thread olegz
Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/1147
  
@alopresto unless you find any major issues that would require me to follow 
up with more work, would you be able (before merging) to change in 
_testWithUnwritableDir_ the actual directory to be ```File unreadableDir = new 
File("target/unwritable");```? Copy/Paste error, otherwise i'll do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi issue #1147: NIFI-2919 improved GetFile to fail if target directory is ...

2016-10-19 Thread alopresto
Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1147
  
Reviewing...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589576#comment-15589576
 ] 

ASF GitHub Bot commented on NIFI-2919:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1147
  
Reviewing...


> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

2016-10-19 Thread Rob Moran (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589545#comment-15589545
 ] 

Rob Moran commented on NIFI-2898:
-

I also notice that a similar pattern is used in the Component State dialog 
(e.g., select 'View state' action from the context menu of the TailFile 
processor). It would be nice to again use the available height for the 
description before the table starts and use the same styling for the label, 
component name, and its description. I have created NIFI-2921 to capture 
details and linked it to this issue.

> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2921) Use consistent scrolling behavior and styling in Component State dialog

2016-10-19 Thread Rob Moran (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Moran updated NIFI-2921:

Attachment: view-state-descripiton-scrolling.png

> Use consistent scrolling behavior and styling in Component State dialog
> ---
>
> Key: NIFI-2921
> URL: https://issues.apache.org/jira/browse/NIFI-2921
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Rob Moran
>Priority: Minor
> Attachments: view-state-descripiton-scrolling.png
>
>
> In the Component State dialog, use a consistent scrolling behavior for the 
> description content and use similar styling for the label, component name, 
> and description as described in NIFI-2898.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1018: NIFI-1662 adding Expression Language decimal support

2016-10-19 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1018
  
@mattyb149 just pushed out a new commit along with yours. I added proper 
support for literal decimals in the UI as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-1662) Improve Expression Language to Enable Working with Decimals

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589513#comment-15589513
 ] 

ASF GitHub Bot commented on NIFI-1662:
--

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1018
  
@mattyb149 just pushed out a new commit along with yours. I added proper 
support for literal decimals in the UI as well.


> Improve Expression Language to Enable Working with Decimals
> ---
>
> Key: NIFI-1662
> URL: https://issues.apache.org/jira/browse/NIFI-1662
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joseph Percivall
>Assignee: Joseph Percivall
>
> Currently the math operations in Expression Language use Longs to evaluate 
> numbers. This leads to any decimal places getting truncated when performing 
> operations like divide. 
> NiFi should support working with decimals



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2898) Add Processor dialog cuts off processor descriptions

2016-10-19 Thread Rob Moran (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Moran updated NIFI-2898:

Attachment: processor-description-scrolling.png

> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2898) Add Processor dialog cuts off processor descriptions

2016-10-19 Thread Rob Moran (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589495#comment-15589495
 ] 

Rob Moran commented on NIFI-2898:
-


I think the move to a scrolling pattern was a good choice. I do think some more 
improvements could be made to the way space is utilized, along with a few style 
changes.

I attached a screenshot  – *processor-description-scrolling.png* – that I did 
using browser dev tool, then added some annotation on top since I could not get 
it exactly as intended.

As I describe in the attached file, it would be nice to use the remaining 
height to display as much of the description as possible. To add, it would be 
nice if that available height was fluid as the height of the dialog changes. 
This way the description would always end 20px above the dialog buttons.

As mentioned there were a few style changes made:

For _#processor-type-name-title_ changed/added​{code}​padding: 20px 0 4px 0; 
font-size: 12px;​{code}​
For ​_​#processor-type-name​_​ changed/added​{code}​color: #775351; font-size: 
13px; font-weight: 500;​{code}​
For ​_​#processor-type-description​_​ changed/added{code}​font-size: 13px; 
line-height: 17px;​{code}​

​We could also add the 'scrollable' class to the _#processor-types-table​_ to 
be consistent with how scrollable content is displayed.

> Add Processor dialog cuts off processor descriptions
> 
>
> Key: NIFI-2898
> URL: https://issues.apache.org/jira/browse/NIFI-2898
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 1.0.0
>Reporter: Jeff Storck
>Assignee: Scott Aslan
>Priority: Minor
> Fix For: 1.1.0
>
> Attachments: processor-description-scrolling.png
>
>
> In the Add Processor dialog, descriptions for processors like 
> ConvertJSONToSQL get cut off instead of showing a ellipses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2920) Swapped FlowFiles are not removed from content repo when a queue is emptied.

2016-10-19 Thread Mark Payne (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589332#comment-15589332
 ] 

Mark Payne commented on NIFI-2920:
--

I have been able to reproduce this locally. To do so, I created a simple Flow: 
GenerateFlowFile (1 KB file size) with success going to 2 different 
UpdateAttribute Processors (so that the same Content Claim is held by 2 
different FlowFiles). I let about 150,000 FlowFiles queue up (with backpressure 
turned off). I then start one of the UpdateAttribute processors. This drained 
its queue. I could then look at my content repo for any files not archived:

{code}
content_repository $ find . -type f | grep -v archive | wc -l
 192
{code}

After a few minutes, the FlowFile repo is checkpointed, which will result in 
things getting cleaned up if they can. The above command shows the same result 
(expected, since the FlowFiles are still held. I then empty the queue. After 
the FlowFile checkpoints again, I should see nothing in the content repo 
outside of archive, but I see:

{code}
content_repository $ find . -type f | grep -v archive | wc -l
 167
{code}

I see the same thing happening if I turn on expiration to remove the FlowFiles 
instead of clicking Empty Queue.


> Swapped FlowFiles are not removed from content repo when a queue is emptied.
> 
>
> Key: NIFI-2920
> URL: https://issues.apache.org/jira/browse/NIFI-2920
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
> Environment: Linux
>Reporter: Matthew Clarke
>Priority: Critical
>
> If a queue contains enough FlowFiles to trigger swapping to occur and a user 
> selects "empty queue" or sets file expiration, only the content claims 
> associated to FlowFiles that were not swapped get removed from the content 
> repository.  All other content claims are left in the content repository and 
> are not moved to archive and/or purged.
> A restart of NiFi will produce app log messages about these unknown files 
> left in the content repo and will at that time move them to archive or purge 
> them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2888) Display processor fill color when sufficiently zoomed out.

2016-10-19 Thread Rob Moran (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Moran updated NIFI-2888:

Attachment: processor-change-color.png

> Display processor fill color when sufficiently zoomed out.
> --
>
> Key: NIFI-2888
> URL: https://issues.apache.org/jira/browse/NIFI-2888
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Scott Aslan
>Assignee: Scott Aslan
> Fix For: 1.2.0
>
> Attachments: processor-change-color.png
>
>
> As a user when viewing the zoomed out overview of my flow I want to be able 
> to quickly identify processors based on their fill color.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2920) Swapped FlowFiles are not removed from content repo when a queue is emptied.

2016-10-19 Thread Mark Payne (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Payne updated NIFI-2920:
-
Affects Version/s: 1.0.0

> Swapped FlowFiles are not removed from content repo when a queue is emptied.
> 
>
> Key: NIFI-2920
> URL: https://issues.apache.org/jira/browse/NIFI-2920
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
> Environment: Linux
>Reporter: Matthew Clarke
>Priority: Critical
>
> If a queue contains enough FlowFiles to trigger swapping to occur and a user 
> selects "empty queue" or sets file expiration, only the content claims 
> associated to FlowFiles that were not swapped get removed from the content 
> repository.  All other content claims are left in the content repository and 
> are not moved to archive and/or purged.
> A restart of NiFi will produce app log messages about these unknown files 
> left in the content repo and will at that time move them to archive or purge 
> them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2920) Swapped FlowFiles are not removed from content repo when a queue is emptied.

2016-10-19 Thread Mark Payne (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Payne updated NIFI-2920:
-
Priority: Critical  (was: Major)

> Swapped FlowFiles are not removed from content repo when a queue is emptied.
> 
>
> Key: NIFI-2920
> URL: https://issues.apache.org/jira/browse/NIFI-2920
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.6.1
> Environment: Linux
>Reporter: Matthew Clarke
>Priority: Critical
>
> If a queue contains enough FlowFiles to trigger swapping to occur and a user 
> selects "empty queue" or sets file expiration, only the content claims 
> associated to FlowFiles that were not swapped get removed from the content 
> repository.  All other content claims are left in the content repository and 
> are not moved to archive and/or purged.
> A restart of NiFi will produce app log messages about these unknown files 
> left in the content repo and will at that time move them to archive or purge 
> them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (NIFI-2920) Swapped FlowFiles are not removed from content repo when a queue is emptied.

2016-10-19 Thread Matthew Clarke (JIRA)
Matthew Clarke created NIFI-2920:


 Summary: Swapped FlowFiles are not removed from content repo when 
a queue is emptied.
 Key: NIFI-2920
 URL: https://issues.apache.org/jira/browse/NIFI-2920
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core Framework
Affects Versions: 0.6.1
 Environment: Linux
Reporter: Matthew Clarke


If a queue contains enough FlowFiles to trigger swapping to occur and a user 
selects "empty queue" or sets file expiration, only the content claims 
associated to FlowFiles that were not swapped get removed from the content 
repository.  All other content claims are left in the content repository and 
are not moved to archive and/or purged.

A restart of NiFi will produce app log messages about these unknown files left 
in the content repo and will at that time move them to archive or purge them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2888) Display processor fill color when sufficiently zoomed out.

2016-10-19 Thread Rob Moran (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589323#comment-15589323
 ] 

Rob Moran commented on NIFI-2888:
-

I think if we can add a square containing element around the processor icon the 
color change will be apparent when zoomed out. This will actually help at any 
zoom level as the color change will be a lot more obvious. See the mockup I've 
attached to help illustrate – *processor-change-color.png.* The grouping of the 
run status icon, processor name, and processor type will need to shift 
slightly, but the change is very minor. I've annotated the spacing around these 
elements in the mockup.

Another thing I think will help a bit is to change the border of a processor 
when it's color is changed. So, the current default​ processor border​ is set 
to:​
{code}stroke: rgba(0,0,0,0.25);{code}

When processor color is changed​, set the border to​:
{code}stroke: rgba(X,X,X,0.65);{code}

X,X,X represents the RGB value​ of the​ color​ selected by the user.​

> Display processor fill color when sufficiently zoomed out.
> --
>
> Key: NIFI-2888
> URL: https://issues.apache.org/jira/browse/NIFI-2888
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Scott Aslan
>Assignee: Scott Aslan
> Fix For: 1.2.0
>
>
> As a user when viewing the zoomed out overview of my flow I want to be able 
> to quickly identify processors based on their fill color.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-401) New Scheduling strategy (On primary node - CRON )

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589282#comment-15589282
 ] 

ASF GitHub Bot commented on NIFI-401:
-

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1117
  
@beugley Thanks for the PR! Going to start reviewing... Sorry this lingered 
a bit. I see there are a couple conflicting files but I'm going to see if I can 
rebase them locally. If I have any issues, I'll reach back out.


> New Scheduling strategy (On primary node - CRON )
> -
>
> Key: NIFI-401
> URL: https://issues.apache.org/jira/browse/NIFI-401
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Matthew Clarke
>Priority: Minor
> Attachments: initial prototype .png
>
>
> Currently the only scheduling strategy supported when a processor is set to 
> use "On primary Node" is Timer Driven.   There should be a second option to 
> allow cron driven On primary Node scheduling strategy.  This would allow 
> users to more control over when a given primary node only processor runs. 
> This would prevent these processors from running when configuration changes 
> or instance restarts occur.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1117: NIFI-401

2016-10-19 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1117
  
@beugley Thanks for the PR! Going to start reviewing... Sorry this lingered 
a bit. I see there are a couple conflicting files but I'm going to see if I can 
rebase them locally. If I have any issues, I'll reach back out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-1459) Scroll bar in the properties tab of processor Config appears behind allowable values dropdown

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589125#comment-15589125
 ] 

ASF GitHub Bot commented on NIFI-1459:
--

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/1070
  
@mcgilman I have updated the tables in the UA Custom UI to account for 
overlaid scrollbars. This PR should be ready to merge.


> Scroll bar in the properties tab of processor Config appears behind allowable 
> values dropdown
> -
>
> Key: NIFI-1459
> URL: https://issues.apache.org/jira/browse/NIFI-1459
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core UI
>Affects Versions: 0.4.1
> Environment: OSX 10.10.15 with "Show scroll bars" option set to "When 
> scrolling" and using Google Chrome version 48.0.2564.97 (64-bit)
>Reporter: Joseph Percivall
>Assignee: Scott Aslan
>Priority: Trivial
> Attachments: Screen Shot 2016-02-02 at 11.23.46 AM.png
>
>
> In processors with many properties, one of them being a dropdown of allowable 
> values,  when the value for the property is select (bringing up the pop-up) 
> the scroll bar will overlap the box.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1070: [NIFI-1459] add css translate3d to properties table editor...

2016-10-19 Thread scottyaslan
Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/1070
  
@mcgilman I have updated the tables in the UA Custom UI to account for 
overlaid scrollbars. This PR should be ready to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2888) Display processor fill color when sufficiently zoomed out.

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589086#comment-15589086
 ] 

ASF GitHub Bot commented on NIFI-2888:
--

Github user scottyaslan commented on the issue:

https://github.com/apache/nifi/pull/1133
  
Thanks for the input @mcgilman! I will close this PR so that the work can 
remain on this branch in case we want to revisit this later. For now I will 
open a new PR for NIFI-2888.


> Display processor fill color when sufficiently zoomed out.
> --
>
> Key: NIFI-2888
> URL: https://issues.apache.org/jira/browse/NIFI-2888
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Scott Aslan
>Assignee: Scott Aslan
> Fix For: 1.2.0
>
>
> As a user when viewing the zoomed out overview of my flow I want to be able 
> to quickly identify processors based on their fill color.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1133: [NIFI-2888] Display processor fill color when suffi...

2016-10-19 Thread scottyaslan
Github user scottyaslan closed the pull request at:

https://github.com/apache/nifi/pull/1133


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2888) Display processor fill color when sufficiently zoomed out.

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1553#comment-1553
 ] 

ASF GitHub Bot commented on NIFI-2888:
--

Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1133
  
@scottyaslan After checking out the most recent PR I think we may want to 
to make a few more adjustments.

Coloring the components to align with the birdseye view takes away from the 
components that have explicitly been colored. I think we may want to revert 
back to the previous implementation for the zoomed out mode. 

Coloring the background of the Processor icon may be sufficient while 
retaining the current zoomed out effect. This may also make the zoomed in 
coloration more prominent.

Thoughts? 




> Display processor fill color when sufficiently zoomed out.
> --
>
> Key: NIFI-2888
> URL: https://issues.apache.org/jira/browse/NIFI-2888
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core UI
>Reporter: Scott Aslan
>Assignee: Scott Aslan
> Fix For: 1.2.0
>
>
> As a user when viewing the zoomed out overview of my flow I want to be able 
> to quickly identify processors based on their fill color.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1133: [NIFI-2888] Display processor fill color when sufficiently...

2016-10-19 Thread mcgilman
Github user mcgilman commented on the issue:

https://github.com/apache/nifi/pull/1133
  
@scottyaslan After checking out the most recent PR I think we may want to 
to make a few more adjustments.

Coloring the components to align with the birdseye view takes away from the 
components that have explicitly been colored. I think we may want to revert 
back to the previous implementation for the zoomed out mode. 

Coloring the background of the Processor icon may be sufficient while 
retaining the current zoomed out effect. This may also make the zoomed in 
coloration more prominent.

Thoughts? 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-1662) Improve Expression Language to Enable Working with Decimals

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588871#comment-15588871
 ] 

ASF GitHub Bot commented on NIFI-1662:
--

Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1018
  
@mattyb149 this is awesome! I was having bit of trouble trying with the 
grammar due to not knowing much about ANTLR. I'm gonna add your commit to my 
branch, test it a bit and then add it to the PR.


> Improve Expression Language to Enable Working with Decimals
> ---
>
> Key: NIFI-1662
> URL: https://issues.apache.org/jira/browse/NIFI-1662
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joseph Percivall
>Assignee: Joseph Percivall
>
> Currently the math operations in Expression Language use Longs to evaluate 
> numbers. This leads to any decimal places getting truncated when performing 
> operations like divide. 
> NiFi should support working with decimals



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #1018: NIFI-1662 adding Expression Language decimal support

2016-10-19 Thread JPercivall
Github user JPercivall commented on the issue:

https://github.com/apache/nifi/pull/1018
  
@mattyb149 this is awesome! I was having bit of trouble trying with the 
grammar due to not knowing much about ANTLR. I'm gonna add your commit to my 
branch, test it a bit and then add it to the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588777#comment-15588777
 ] 

ASF GitHub Bot commented on NIFI-2919:
--

GitHub user olegz opened a pull request:

https://github.com/apache/nifi/pull/1147

NIFI-2919 improved GetFile to fail if target directory is inaccessible

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/olegz/nifi NIFI-2919

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1147


commit e755cbddad5bd5acd4be1a5cbf1ea109f4125897
Author: Oleg Zhurakousky 
Date:   2016-10-19T13:30:12Z

NIFI-2919 improved GetFile to fail if target directory is inaccessible




> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread Oleg Zhurakousky (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Zhurakousky updated NIFI-2919:
---
Status: Patch Available  (was: Open)

> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi pull request #1147: NIFI-2919 improved GetFile to fail if target direct...

2016-10-19 Thread olegz
GitHub user olegz opened a pull request:

https://github.com/apache/nifi/pull/1147

NIFI-2919 improved GetFile to fail if target directory is inaccessible

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/olegz/nifi NIFI-2919

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1147.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1147


commit e755cbddad5bd5acd4be1a5cbf1ea109f4125897
Author: Oleg Zhurakousky 
Date:   2016-10-19T13:30:12Z

NIFI-2919 improved GetFile to fail if target directory is inaccessible




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] nifi-minifi-cpp pull request #20: Adding an initial GitHub PR template.

2016-10-19 Thread apiri
GitHub user apiri opened a pull request:

https://github.com/apache/nifi-minifi-cpp/pull/20

Adding an initial GitHub PR template.

Providing an initial PR template to provide guidance for those submitting 
contributions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apiri/nifi-minifi-cpp add-pr-template

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi-minifi-cpp/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #20


commit aed8db4ab62a1707b12fc19f3cedcec53cc816ca
Author: Aldrin Piri 
Date:   2016-10-19T13:27:48Z

Adding an initial GitHub PR template.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (NIFI-2380) ExtractEmailAttachments processor should support TNEF files (aka winmail.dat)

2016-10-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588592#comment-15588592
 ] 

ASF GitHub Bot commented on NIFI-2380:
--

Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/817
  
@trixpan sorry for the hold up. Actually I would like for @joewitt to look 
at License/Notice (as you have suggested earlier) as I don't feel competent 
enough as there are some things I've not seen before. @joewitt could you please 
just give it a quick look to make sure everything is kosher with License/Notice?


> ExtractEmailAttachments processor should support TNEF files (aka winmail.dat)
> -
>
> Key: NIFI-2380
> URL: https://issues.apache.org/jira/browse/NIFI-2380
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Andre
>Assignee: Andre
> Fix For: 1.1.0
>
>
> during the review of NIFI-1899 Dan Marshall highlighted some use cases for 
> email processing that have not been addressed as part of the initial 
> development cycle.
> One of these use cases was the decoding of Microsoft Transport Neutral 
> Encoding Files (TNEF). 
> This type of attachments is popularly know as winmail.dat and uses a non RFC 
> compliant structure to transfer attachments across different Microsoft 
> Outlook clients.
> Given the prevalence of outlook and the issues with winmail.dat files, it 
> would be nice to be able to decode TNEF as we currently do with MIME 
> attachments.
> Permalink to Dan's comments 
> http://mail-archives.apache.org/mod_mbox/nifi-dev/201607.mbox/%3C1468716836729-12827.post%40n7.nabble.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-10-19 Thread olegz
Github user olegz commented on the issue:

https://github.com/apache/nifi/pull/817
  
@trixpan sorry for the hold up. Actually I would like for @joewitt to look 
at License/Notice (as you have suggested earlier) as I don't feel competent 
enough as there are some things I've not seen before. @joewitt could you please 
just give it a quick look to make sure everything is kosher with License/Notice?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread Oleg Zhurakousky (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Zhurakousky updated NIFI-2919:
---
Description: 
GetFile processor requires write permission to its input directory.
For example, if nifi is started by a user named 'nifi' (which is the case in 
Ambari environment), and if the input directory does not give write permission 
to user 'nifi', the processor simply stop working without giving warning or 
error messages. From the end user's perspective, it is confusing.
I'd like to improve the user's experience by providing some check and warning. 
It is similar to the check of the existence of the input directory. If the 
input directory is not present, GetFile already gives error messages to the 
user. The same check can be done for directory permission.

  was:
GetFile processor requires write permission to its input directory.
For example, if nifi is started by a user named 'nifi' (which is the case in 
Ambari environment), and if the input directory does not give write permission 
to user 'nifi', the processor simply stop working without giving warning or 
error messages. From the end user's perspective, it is confusing.
I'd like to improve the user's experience by providing some check and warning. 
It is similar to the check of the existencce of the input directory. If the 
input directory is not present, GetFile already gives error messages to the 
user. The same check can be done for directory permission.


> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread Oleg Zhurakousky (JIRA)

 [ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleg Zhurakousky updated NIFI-2919:
---
Description: 
GetFile processor requires write permission to its input directory.
For example, if nifi is started by a user named 'nifi' (which is the case in 
Ambari environment), and if the input directory does not give write permission 
to user 'nifi', the processor simply stop working without giving warning or 
error messages. From the end user's perspective, it is confusing.
I'd like to improve the user's experience by providing some check and warning. 
It is similar to the check of the existencce of the input directory. If the 
input directory is not present, GetFile already gives error messages to the 
user. The same check can be done for directory permission.

> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> ---
>
> Key: NIFI-2919
> URL: https://issues.apache.org/jira/browse/NIFI-2919
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Oleg Zhurakousky
>Assignee: Oleg Zhurakousky
> Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existencce of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (NIFI-2919) NiFi GetFile processor silently refuses to work if write permission is not given to the input directory

2016-10-19 Thread Oleg Zhurakousky (JIRA)
Oleg Zhurakousky created NIFI-2919:
--

 Summary: NiFi GetFile processor silently refuses to work if write 
permission is not given to the input directory
 Key: NIFI-2919
 URL: https://issues.apache.org/jira/browse/NIFI-2919
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Oleg Zhurakousky
Assignee: Oleg Zhurakousky
 Fix For: 1.1.0






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (NIFI-2918) JDBC getColumnName may return empty string

2016-10-19 Thread Toivo Adams (JIRA)

[ 
https://issues.apache.org/jira/browse/NIFI-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588458#comment-15588458
 ] 

Toivo Adams commented on NIFI-2918:
---

Hi,

I don't want to argue with SAP.
But maybe we should preserve current behavior?
I mean we still use getColumnName()
and when return value is null or empty String we try getColumnLabel()

I am not sure how other vendors use getColumnLabel()

Thanks
Toivo


> JDBC getColumnName may return empty string
> --
>
> Key: NIFI-2918
> URL: https://issues.apache.org/jira/browse/NIFI-2918
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.1.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>
> The SAP Hana JDBC Driver returns an empty string for getColumnName if the 
> column name in the SELECT statement was aliased.
> Instead you have to call getColumnLabel on the ResultSetMetaData.
> SAP as a company feels this is per the JDBC spec, so they are not going to 
> change it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] nifi-minifi-cpp issue #19: MINIFI-119 add source.hostname to all flowfiles

2016-10-19 Thread trixpan
Github user trixpan commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/19
  
Can you rebase this commit by any chance? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---