[GitHub] nifi-minifi-cpp pull request #268: MINIFICPP-397 Added implementation of Rou...

2018-02-28 Thread achristianson
Github user achristianson commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/268#discussion_r171338847 --- Diff: libminifi/src/processors/RouteOnAttribute.cpp --- @@ -0,0 +1,107 @@ +/** + * @file RouteOnAttribute.cpp + *

[jira] [Commented] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381031#comment-16381031 ] ASF GitHub Bot commented on NIFI-4809: -- Github user pvillard31 commented on the issue:

[jira] [Assigned] (NIFI-4911) NiFi CompressContent Snappy incompatible behavior with Spark

2018-02-28 Thread Mark Owens (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Owens reassigned NIFI-4911: Assignee: (was: Mark Owens) > NiFi CompressContent Snappy incompatible behavior with Spark >

[GitHub] nifi issue #2486: NIFI-4901 Json to Avro using Record framework does not sup...

2018-02-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2486 +1 LGTM. Built it and ran. Looks like a good solution. However, the unit test probably should be merged with an existing test class if there is one where it is a reasonable fit. ---

[GitHub] nifi pull request #2458: NIFI-2630 Allow PublishJMS to send TextMessages

2018-02-28 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2458#discussion_r171352969 --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java --- @@ -136,9 +155,16 @@

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2493 @david-streamlio i'm supportive of doing non record ones for the cases you mention. Does Pulsar by any chance offer a true streaming API instead of byte[] then so handling the types of objects you

[jira] [Commented] (NIFI-2630) Allow PublishJMS processor to create TextMessages

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380863#comment-16380863 ] ASF GitHub Bot commented on NIFI-2630: -- Github user markap14 commented on a diff in the pull request:

[jira] [Commented] (NIFI-4901) Json to Avro using Record framework does not support union types with boolean

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380862#comment-16380862 ] ASF GitHub Bot commented on NIFI-4901: -- Github user MikeThomsen commented on the issue:

[jira] [Resolved] (NIFI-4880) Add the ability to utilize aliases in Avro to Avro record conversion

2018-02-28 Thread Mark Payne (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-4880. -- Resolution: Fixed Fix Version/s: 1.6.0 > Add the ability to utilize aliases in Avro to Avro

[jira] [Commented] (NIFI-4901) Json to Avro using Record framework does not support union types with boolean

2018-02-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380890#comment-16380890 ] ASF subversion and git services commented on NIFI-4901: --- Commit

[GitHub] nifi issue #2500: NIFI-4916 - ConvertExcelToCSVProcessor inherit parent attr...

2018-02-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2500 +1 LGTM. Build it and unit tests ran. Japanese build succeeded on Travis CI. I think it's ready to merge. ---

[jira] [Commented] (NIFI-4901) Json to Avro using Record framework does not support union types with boolean

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380931#comment-16380931 ] ASF GitHub Bot commented on NIFI-4901: -- Github user MikeThomsen commented on the issue:

[GitHub] nifi issue #2430: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-02-28 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2430 Thanks for your comments @mattyb149 - I just pushed a commit that should address everything. Regarding the record approach you suggested. Even though I really like the idea, I'm not sure

[jira] [Commented] (NIFI-4901) Json to Avro using Record framework does not support union types with boolean

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380870#comment-16380870 ] ASF GitHub Bot commented on NIFI-4901: -- Github user gardellajuanpablo commented on the issue:

[GitHub] nifi pull request #2458: NIFI-2630 Allow PublishJMS to send TextMessages

2018-02-28 Thread mosermw
Github user mosermw commented on a diff in the pull request: https://github.com/apache/nifi/pull/2458#discussion_r171354166 --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java --- @@ -136,9 +155,16 @@

[GitHub] nifi pull request #2474: NIFI-4880: Add the ability to map record based on t...

2018-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2474 ---

[GitHub] nifi issue #2474: NIFI-4880: Add the ability to map record based on the alia...

2018-02-28 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2474 @derekstraka thanks that was a good catch! Code all looks good, unit tests pass, contrib-check is good. +1 I've merged this to master. Thanks again! ---

[jira] [Commented] (NIFI-4880) Add the ability to utilize aliases in Avro to Avro record conversion

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380884#comment-16380884 ] ASF GitHub Bot commented on NIFI-4880: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-4901) Json to Avro using Record framework does not support union types with boolean

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380891#comment-16380891 ] ASF GitHub Bot commented on NIFI-4901: -- Github user asfgit closed the pull request at:

[GitHub] nifi issue #2486: NIFI-4901 Json to Avro using Record framework does not sup...

2018-02-28 Thread gardellajuanpablo
Github user gardellajuanpablo commented on the issue: https://github.com/apache/nifi/pull/2486 @MikeThomsen the ticket is invalid. Please do not merge to master. ---

[jira] [Updated] (NIFI-4912) Update jackson version to latest stable

2018-02-28 Thread Derek Straka (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Derek Straka updated NIFI-4912: --- Status: Patch Available (was: Open) > Update jackson version to latest stable >

[jira] [Commented] (NIFI-4880) Add the ability to utilize aliases in Avro to Avro record conversion

2018-02-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380883#comment-16380883 ] ASF subversion and git services commented on NIFI-4880: --- Commit

[jira] [Commented] (NIFI-4880) Add the ability to utilize aliases in Avro to Avro record conversion

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380885#comment-16380885 ] ASF GitHub Bot commented on NIFI-4880: -- Github user markap14 commented on the issue:

[GitHub] nifi issue #2486: NIFI-4901 Json to Avro using Record framework does not sup...

2018-02-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2486 Fortunately for all of us here, I don't have commit rights :) ---

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2493 @david-streamlio HBase is an example of what @markap14 suggested. https://github.com/apache/nifi/tree/master/nifi-nar-bundles/nifi-standard-services and there is a new PR (#2498) currently

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2493 @david-streamlio the idea behind the record-oriented processors is that they make building your flow in NiFi much easier. Without that, you end up having to split your data up into tons of FlowFiles

[jira] [Commented] (MINIFICPP-397) Implement RouteOnAttribute

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380793#comment-16380793 ] ASF GitHub Bot commented on MINIFICPP-397: -- Github user achristianson commented on a diff in

[jira] [Commented] (NIFI-4916) Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380818#comment-16380818 ] ASF GitHub Bot commented on NIFI-4916: -- Github user MikeThomsen commented on the issue:

[jira] [Commented] (NIFI-2630) Allow PublishJMS processor to create TextMessages

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380873#comment-16380873 ] ASF GitHub Bot commented on NIFI-2630: -- Github user mosermw commented on a diff in the pull request:

[GitHub] nifi pull request #2486: NIFI-4901 Json to Avro using Record framework does ...

2018-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2486 ---

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread david-streamlio
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2493 @markap14. I completely agree that is the best approach for handling text-based payloads into and out of Pulsar, and am starting to work on the record based processors now. However, I do see

[GitHub] nifi issue #2430: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-02-28 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2430 I like all those ideas! ---

[jira] [Commented] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381071#comment-16381071 ] ASF GitHub Bot commented on NIFI-4809: -- Github user mattyb149 commented on the issue:

[GitHub] nifi issue #2430: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-02-28 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/2430 Ugh that's true, I'm not a fan of dynamic keys. Since the schema would be generated by the reporting task, then we could create a schema for the example above, but then each flow file would have

[jira] [Commented] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381050#comment-16381050 ] ASF GitHub Bot commented on NIFI-4809: -- Github user mattyb149 commented on the issue:

[jira] [Commented] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381061#comment-16381061 ] ASF GitHub Bot commented on NIFI-4809: -- Github user pvillard31 commented on the issue:

[GitHub] nifi issue #2458: NIFI-2630 Allow PublishJMS to send TextMessages

2018-02-28 Thread mosermw
Github user mosermw commented on the issue: https://github.com/apache/nifi/pull/2458 @markap14 I added a commit to do character set validation in a property validator instead of OnScheduled. ---

[GitHub] nifi-minifi-cpp pull request #268: MINIFICPP-397 Added implementation of Rou...

2018-02-28 Thread minifirocks
Github user minifirocks commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/268#discussion_r171389409 --- Diff: libminifi/src/processors/RouteOnAttribute.cpp --- @@ -0,0 +1,107 @@ +/** + * @file RouteOnAttribute.cpp + *

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2493 on the consume side you would generate a flowfile. But you'd then write to it via the streaming API. #neverbytearray is a movement we should start. ---

[jira] [Commented] (MINIFICPP-397) Implement RouteOnAttribute

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381058#comment-16381058 ] ASF GitHub Bot commented on MINIFICPP-397: -- Github user minifirocks commented on a diff in the

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/2493 yes correct it would be awesome if the client/broker interface could support a genuinely streaming interface rather than a byte[] as this helps frameworks that can operate on the streams rather than

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread david-streamlio
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2493 I completely agree on your observation about having to land the entire, unbroken file into NiFi's repo rather than streaming through memory is inefficient. I will talk to the Pulsar team

[GitHub] nifi issue #2430: NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

2018-02-28 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2430 What about adding a property to let the user decide the output format: - "Output format" with two options: "Ambari Metrics Collector format" or "Record based format" - "Record writer": this

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread david-streamlio
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2493 The Pulsar client API, https://pulsar.apache.org/api/client/, currently only supports byte[] payloads. By true streaming, I am assuming you mean an API that return an IO stream object of some

[jira] [Commented] (NIFI-2630) Allow PublishJMS processor to create TextMessages

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381097#comment-16381097 ] ASF GitHub Bot commented on NIFI-2630: -- Github user mosermw commented on the issue:

[jira] [Commented] (MINIFICPP-411) MiNIFi Controller's output needs some fixing

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380329#comment-16380329 ] ASF GitHub Bot commented on MINIFICPP-411: -- Github user phrocker commented on the issue:

[GitHub] nifi-minifi-cpp issue #269: MINIFICPP-411: Resolve issues with command repor...

2018-02-28 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/269 Here is an example response @apiri when it is not running. Is this not what you see? [HOST:bin phrocker$ ./minificontroller --stop GetFile Could not connect to remote host

[GitHub] nifi-minifi-cpp issue #269: MINIFICPP-411: Resolve issues with command repor...

2018-02-28 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/269 @phrocker looks good. will merge ---

[jira] [Commented] (MINIFICPP-411) MiNIFi Controller's output needs some fixing

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380375#comment-16380375 ] ASF GitHub Bot commented on MINIFICPP-411: -- Github user apiri commented on the issue:

[GitHub] nifi-minifi-cpp pull request #269: MINIFICPP-411: Resolve issues with comman...

2018-02-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/269 ---

[jira] [Commented] (NIFI-4916) Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes

2018-02-28 Thread Fabio Coutinho (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380388#comment-16380388 ] Fabio Coutinho commented on NIFI-4916: -- Hey [~pvillard]! Thanks for the swift reply. This is actually

[GitHub] nifi-minifi-cpp issue #269: MINIFICPP-411: Resolve issues with command repor...

2018-02-28 Thread apiri
Github user apiri commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/269 Hey @phrocker it was not, but it looks like the changes you added in 645e355 would resolve the hardcoded true. Not sure of exact sequence of your reply to my initial review and this last

[jira] [Created] (NIFI-4916) Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes

2018-02-28 Thread Fabio Coutinho (JIRA)
Fabio Coutinho created NIFI-4916: Summary: Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes Key: NIFI-4916 URL: https://issues.apache.org/jira/browse/NIFI-4916 Project:

[jira] [Commented] (NIFI-4917) Create a new Controller Service for specifying Keytabs

2018-02-28 Thread Mark Payne (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380403#comment-16380403 ] Mark Payne commented on NIFI-4917: -- Is blocked by NIFI-4885 because it needs the more granular @Restricted

[jira] [Commented] (MINIFICPP-411) MiNIFi Controller's output needs some fixing

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380369#comment-16380369 ] ASF GitHub Bot commented on MINIFICPP-411: -- Github user apiri commented on the issue:

[jira] [Updated] (MINIFICPP-411) MiNIFi Controller's output needs some fixing

2018-02-28 Thread Aldrin Piri (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri updated MINIFICPP-411: -- Fix Version/s: 0.5.0 > MiNIFi Controller's output needs some fixing >

[jira] [Resolved] (MINIFICPP-411) MiNIFi Controller's output needs some fixing

2018-02-28 Thread Aldrin Piri (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri resolved MINIFICPP-411. --- Resolution: Fixed > MiNIFi Controller's output needs some fixing >

[jira] [Commented] (MINIFICPP-411) MiNIFi Controller's output needs some fixing

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380379#comment-16380379 ] ASF GitHub Bot commented on MINIFICPP-411: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-4916) Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes

2018-02-28 Thread Pierre Villard (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380384#comment-16380384 ] Pierre Villard commented on NIFI-4916: -- Thanks for reporting this [~fabio.coutinho]. I believe we

[jira] [Updated] (NIFI-4916) Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes

2018-02-28 Thread Pierre Villard (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-4916: - Component/s: (was: Core Framework) Extensions > Flowfiles created by

[jira] [Created] (NIFI-4917) Create a new Controller Service for specifying Keytabs

2018-02-28 Thread Mark Payne (JIRA)
Mark Payne created NIFI-4917: Summary: Create a new Controller Service for specifying Keytabs Key: NIFI-4917 URL: https://issues.apache.org/jira/browse/NIFI-4917 Project: Apache NiFi Issue Type:

[jira] [Updated] (NIFI-4916) Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes

2018-02-28 Thread Fabio Coutinho (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabio Coutinho updated NIFI-4916: - Description: When converting a flowfile containing an XLS file to CSV, the newly generated

[GitHub] nifi issue #2448: NIFI-4838 Added configurable progressive commits to GetMon...

2018-02-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2448 @mattyb149 Rebased, and passes all tests (updated some unit tests too). ---

[GitHub] nifi pull request #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2493#discussion_r171294580 --- Diff: nifi-nar-bundles/nifi-pulsar-client-services/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/PulsarClientPool.java --- @@

[jira] [Commented] (NIFI-4876) Add Minimum Age Filter to ListS3

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380410#comment-16380410 ] ASF GitHub Bot commented on NIFI-4876: -- Github user jvwing commented on the issue:

[GitHub] nifi issue #2491: NIFI-4876 Adding Min Object Age to ListS3

2018-02-28 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/2491 Thanks, @pvillard31 ---

[jira] [Commented] (NIFI-4838) Make GetMongo support multiple commits and give some progress indication

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380422#comment-16380422 ] ASF GitHub Bot commented on NIFI-4838: -- Github user MikeThomsen commented on the issue:

[jira] [Commented] (NIFI-4838) Make GetMongo support multiple commits and give some progress indication

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380467#comment-16380467 ] ASF GitHub Bot commented on NIFI-4838: -- Github user mattyb149 commented on a diff in the pull request:

[GitHub] nifi pull request #2448: NIFI-4838 Added configurable progressive commits to...

2018-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2448#discussion_r171280456 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java --- @@ -129,26

[GitHub] nifi pull request #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread david-streamlio
Github user david-streamlio commented on a diff in the pull request: https://github.com/apache/nifi/pull/2493#discussion_r171295857 --- Diff: nifi-nar-bundles/nifi-pulsar-client-services/nifi-pulsar-client-service-api/src/main/java/org/apache/nifi/pulsar/PulsarClientPool.java ---

[jira] [Updated] (NIFI-4838) Make GetMongo support multiple commits and give some progress indication

2018-02-28 Thread Matt Burgess (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-4838: --- Status: Patch Available (was: Open) > Make GetMongo support multiple commits and give some progress

[GitHub] nifi pull request #2458: NIFI-2630 Allow PublishJMS to send TextMessages

2018-02-28 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2458#discussion_r171283791 --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/ConsumeJMS.java --- @@ -136,9 +155,16 @@

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread david-streamlio
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2493 When I started writing these processors, I used the Kafka ones as a model. However, I felt that it would be easier to configure the Pulsar client once, such as SSLContextService integration,

[jira] [Created] (NIFI-4918) JMS Connection Factory setting the dynamic Properties wrong

2018-02-28 Thread Julian Gimbel (JIRA)
Julian Gimbel created NIFI-4918: --- Summary: JMS Connection Factory setting the dynamic Properties wrong Key: NIFI-4918 URL: https://issues.apache.org/jira/browse/NIFI-4918 Project: Apache NiFi

[GitHub] nifi-minifi-cpp pull request #268: MINIFICPP-397 Added implementation of Rou...

2018-02-28 Thread minifirocks
Github user minifirocks commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/268#discussion_r171293683 --- Diff: libminifi/src/processors/RouteOnAttribute.cpp --- @@ -0,0 +1,107 @@ +/** + * @file RouteOnAttribute.cpp + *

[jira] [Commented] (NIFI-4916) Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes

2018-02-28 Thread Pierre Villard (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380460#comment-16380460 ] Pierre Villard commented on NIFI-4916: -- Sure, no problem at all. > Flowfiles created by

[jira] [Commented] (NIFI-2630) Allow PublishJMS processor to create TextMessages

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380479#comment-16380479 ] ASF GitHub Bot commented on NIFI-2630: -- Github user markap14 commented on a diff in the pull request:

[jira] [Commented] (MINIFICPP-397) Implement RouteOnAttribute

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380528#comment-16380528 ] ASF GitHub Bot commented on MINIFICPP-397: -- Github user minifirocks commented on a diff in the

[GitHub] nifi-minifi-cpp pull request #269: MINIFICPP-411: Resolve issues with comman...

2018-02-28 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/269#discussion_r171185379 --- Diff: controller/MiNiFiController.cpp --- @@ -178,7 +177,7 @@ int main(int argc, char **argv) { auto& components =

[jira] [Commented] (MINIFICPP-411) MiNIFi Controller's output needs some fixing

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380042#comment-16380042 ] ASF GitHub Bot commented on MINIFICPP-411: -- Github user phrocker commented on a diff in the

[GitHub] nifi pull request #2500: NIFI-4916 - ConvertExcelToCSVProcessor inherit pare...

2018-02-28 Thread pvillard31
GitHub user pvillard31 opened a pull request: https://github.com/apache/nifi/pull/2500 NIFI-4916 - ConvertExcelToCSVProcessor inherit parent attributes Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[jira] [Commented] (NIFI-4916) Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380699#comment-16380699 ] ASF GitHub Bot commented on NIFI-4916: -- GitHub user pvillard31 opened a pull request:

[jira] [Updated] (NIFI-4916) Flowfiles created by ConvertExcelToCSVProcessor do not inherit attributes

2018-02-28 Thread Pierre Villard (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-4916: - Assignee: Pierre Villard Status: Patch Available (was: Open) > Flowfiles created by

[GitHub] nifi issue #2477: NIFI-4839 Adding CLI to nifi-toolkit

2018-02-28 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2477 +1. Just a remark: the version of commons-io does not need to be specified in the toolkit-cli pom file as it's already defined in the root pom. Will take care of it while merging. Thanks for the

[GitHub] nifi pull request #2499: Nifi-4918 JMS Connection Factory setting the dynami...

2018-02-28 Thread jugi92
GitHub user jugi92 opened a pull request: https://github.com/apache/nifi/pull/2499 Nifi-4918 JMS Connection Factory setting the dynamic Properties wrong Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows

2018-02-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380594#comment-16380594 ] ASF subversion and git services commented on NIFI-4839: --- Commit

[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows

2018-02-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380593#comment-16380593 ] ASF subversion and git services commented on NIFI-4839: --- Commit

[jira] [Commented] (NIFI-4901) Json to Avro using Record framework does not support union types with boolean

2018-02-28 Thread Gardella Juan Pablo (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380617#comment-16380617 ] Gardella Juan Pablo commented on NIFI-4901: --- Yes, please close it. Thanks! > Json to Avro using

[GitHub] nifi issue #2498: [WIP] NIFI-4915 - Creating new nifi-hbase_2-client-service...

2018-02-28 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2498 @bbende I have a huge commit in the works for the existing 1.X functionality that adds visibility label support. You might want to at least eyeball that commit. It's in branch 4637 on my repo.

[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows

2018-02-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380595#comment-16380595 ] ASF subversion and git services commented on NIFI-4839: --- Commit

[jira] [Closed] (NIFI-4901) Json to Avro using Record framework does not support union types with boolean

2018-02-28 Thread Gardella Juan Pablo (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gardella Juan Pablo closed NIFI-4901. - > Json to Avro using Record framework does not support union types with boolean >

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread david-streamlio
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2493 I created a separate JIRA for record-based processors.https://issues.apache.org/jira/browse/NIFI-4914, but would like to get these processors into the release as well. Primarily because

[jira] [Commented] (NIFI-4914) Implement record model processor for Pulsar, i.e. ConsumePulsarRecord, PublishPulsarRecord

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380659#comment-16380659 ] ASF GitHub Bot commented on NIFI-4914: -- Github user david-streamlio commented on the issue:

[jira] [Commented] (MINIFICPP-415) Implement matches() Expression Language function

2018-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380582#comment-16380582 ] ASF GitHub Bot commented on MINIFICPP-415: -- Github user asfgit closed the pull request at:

[GitHub] nifi issue #2493: Added Pulsar processors and Controller Service

2018-02-28 Thread david-streamlio
Github user david-streamlio commented on the issue: https://github.com/apache/nifi/pull/2493 Thanks @markap14. This has been a great learning experience for me, and I am happy to contribute back to such a great project. I am still new to developing processors, so I really appreciate

[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows

2018-02-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380598#comment-16380598 ] ASF subversion and git services commented on NIFI-4839: --- Commit

[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows

2018-02-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380603#comment-16380603 ] ASF subversion and git services commented on NIFI-4839: --- Commit

[jira] [Updated] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows

2018-02-28 Thread Pierre Villard (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-4839: - Component/s: Tools and Build > Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy

[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows

2018-02-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380605#comment-16380605 ] ASF subversion and git services commented on NIFI-4839: --- Commit

[jira] [Commented] (NIFI-4839) Create a CLI in NiFi Toolkit to interact with NIFi Registry/deploy flows

2018-02-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380604#comment-16380604 ] ASF subversion and git services commented on NIFI-4839: --- Commit

  1   2   >