lordgamez commented on code in PR #1362:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1362#discussion_r911883288
##
extensions/librdkafka/PublishKafka.cpp:
##
@@ -184,12 +184,12 @@ class ReadCallback {
});
}
- static rd_kafka_headers_unique_ptr
ferencerdei commented on code in PR #6160:
URL: https://github.com/apache/nifi/pull/6160#discussion_r911657359
##
minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/service/BootstrapCodecTest.java:
##
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software
Mike R created NIFI-10190:
-
Summary: Update azure-cosmos from 4.26.0 to 4.31.0
Key: NIFI-10190
URL: https://issues.apache.org/jira/browse/NIFI-10190
Project: Apache NiFi
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/NIFI-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike R updated NIFI-10190:
--
Description: Update azure-cosmos component from 4.26.0 to 4.31.0 to
remediate CVE-2020-36518 (was: Update
ferencerdei commented on code in PR #6160:
URL: https://github.com/apache/nifi/pull/6160#discussion_r911639888
##
minifi/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java:
##
@@ -750,6 +756,72 @@ protected static void
ferencerdei commented on code in PR #6160:
URL: https://github.com/apache/nifi/pull/6160#discussion_r911779208
##
minifi/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/configuration/ingestors/PullHttpChangeIngestor.java:
##
@@ -234,8 +218,9 @@ public void run()
ferencerdei commented on code in PR #6160:
URL: https://github.com/apache/nifi/pull/6160#discussion_r911653320
##
minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/command/DumpRunnerTest.java:
##
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software
mr1716 opened a new pull request, #6175:
URL: https://github.com/apache/nifi/pull/6175
# Summary
[NiFi 10190](https://issues.apache.org/jira/browse/NIFI-10190)
# Tracking
Please complete the following tracking steps prior
szaszm commented on code in PR #1362:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1362#discussion_r911902756
##
libminifi/include/utils/HTTPUtils.h:
##
@@ -31,14 +31,14 @@ so we convert localhost to our local hostname.
inline bool parse_http_components(const
[
https://issues.apache.org/jira/browse/NIFI-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike R resolved NIFI-10190.
---
Resolution: Won't Fix
> Update azure-cosmos from 4.26.0 to 4.31.0
>
[
https://issues.apache.org/jira/browse/NIFI-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561441#comment-17561441
]
Mike R commented on NIFI-10190:
---
Will wait until the CVE is updated before updating this.
> Update
[
https://issues.apache.org/jira/browse/NIFI-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Doran updated NIFI-9809:
--
Summary: Disable Kudu Tests on arm64 platforms (was: Support Kudu NAR on
arm64 platforms)
> Disable
mr1716 commented on code in PR #6175:
URL: https://github.com/apache/nifi/pull/6175#discussion_r911933610
##
nifi-nar-bundles/nifi-azure-bundle/pom.xml:
##
@@ -31,7 +31,7 @@
1.4.5
1.11.0
-4.26.0
+4.31.0
Review Comment:
Lehel44 closed pull request #5654: NIFI-9558: ConnectWebSocket leaks
connections and duplicates FlowFile
URL: https://github.com/apache/nifi/pull/5654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lordgamez commented on code in PR #1362:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1362#discussion_r911906233
##
libminifi/include/utils/HTTPUtils.h:
##
@@ -31,14 +31,14 @@ so we convert localhost to our local hostname.
inline bool parse_http_components(const
mr1716 commented on code in PR #6175:
URL: https://github.com/apache/nifi/pull/6175#discussion_r911921267
##
nifi-nar-bundles/nifi-azure-bundle/pom.xml:
##
@@ -31,7 +31,7 @@
1.4.5
1.11.0
-4.26.0
+4.31.0
Review Comment:
mr1716 closed pull request #6175: NIFI-10190 Update azure-cosmos from 4.26.0 to
4.31.0
URL: https://github.com/apache/nifi/pull/6175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/NIFI-10190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561440#comment-17561440
]
Mike R commented on NIFI-10190:
---
Even with the update, it is still vulnerable to
exceptionfactory commented on code in PR #6175:
URL: https://github.com/apache/nifi/pull/6175#discussion_r911926375
##
nifi-nar-bundles/nifi-azure-bundle/pom.xml:
##
@@ -31,7 +31,7 @@
1.4.5
1.11.0
-4.26.0
+4.31.0
Review Comment:
[
https://issues.apache.org/jira/browse/NIFI-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Doran updated NIFI-9809:
--
Description:
The kudu-binary artifact is not available for aarch64 (arm64) platforms:
{noformat}
We
Dennis Jaheruddin created NIFI-10191:
Summary: Method to stop NiFi on windows
Key: NIFI-10191
URL: https://issues.apache.org/jira/browse/NIFI-10191
Project: Apache NiFi
Issue Type:
NissimShiman commented on PR #6077:
URL: https://github.com/apache/nifi/pull/6077#issuecomment-1172402045
Good eye to catch this subtle issue.
Very minor point, but maybe add step to jira example to set CSVReader's
SchemaAccessStrategy to HWS Schema Reference Attributes (or some
mr1716 commented on code in PR #6175:
URL: https://github.com/apache/nifi/pull/6175#discussion_r911921943
##
nifi-nar-bundles/nifi-azure-bundle/pom.xml:
##
@@ -31,7 +31,7 @@
1.4.5
1.11.0
-4.26.0
+4.31.0
Review Comment:
If so, we
[
https://issues.apache.org/jira/browse/NIFI-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard updated NIFI-10187:
--
Fix Version/s: 1.17.0
Resolution: Fixed
Status: Resolved (was: Patch
[
https://issues.apache.org/jira/browse/NIFI-10187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561436#comment-17561436
]
ASF subversion and git services commented on NIFI-10187:
Commit
asfgit closed pull request #6171: NIFI-10187 Upgrade FtpServer from 1.1.1 to
1.2.0
URL: https://github.com/apache/nifi/pull/6171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
exceptionfactory commented on code in PR #6175:
URL: https://github.com/apache/nifi/pull/6175#discussion_r911916049
##
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/pom.xml:
##
@@ -97,7 +97,7 @@
com.azure
azure-cosmos
-
pvillard31 commented on PR #6174:
URL: https://github.com/apache/nifi/pull/6174#issuecomment-1172295029
ReplaceText with "Always Replace" as the strategy won't evaluate the
flowfile's content. We're also checking the specified regex to see if Always
Replace should be applied by default. In
[
https://issues.apache.org/jira/browse/NIFI-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Doran updated NIFI-9809:
--
Description:
The kudu-binary artifact is not available for aarch64 (arm64) platforms:
{noformat}
Could
[
https://issues.apache.org/jira/browse/NIFI-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Doran reassigned NIFI-9809:
-
Assignee: Kevin Doran
> Disable Kudu Tests on arm64 platforms
>
exceptionfactory commented on code in PR #6172:
URL: https://github.com/apache/nifi/pull/6172#discussion_r911999082
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFTPCharset.java:
##
@@ -0,0 +1,295 @@
+/*
markobean commented on PR #6151:
URL: https://github.com/apache/nifi/pull/6151#issuecomment-1172541808
I found some interesting things while testing this PR. When using
ReplaceText in a flow, I found a buffer size < 8k never caused the
BufferOverflowException. I believe this is due to a
exceptionfactory closed pull request #6160: NIFI-10166 improve MiNiFi bootstrap
test coverage
URL: https://github.com/apache/nifi/pull/6160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
exceptionfactory commented on code in PR #6160:
URL: https://github.com/apache/nifi/pull/6160#discussion_r912128263
##
minifi/minifi-bootstrap/src/test/java/org/apache/nifi/minifi/bootstrap/command/CommandRunnerFactoryTest.java:
##
@@ -0,0 +1,155 @@
+/*
+ * Licensed to the
NissimShiman commented on code in PR #6134:
URL: https://github.com/apache/nifi/pull/6134#discussion_r912152508
##
nifi-toolkit/nifi-toolkit-api/pom.xml:
##
@@ -83,7 +84,7 @@ language governing permissions and limitations under the
License. -->
exceptionfactory commented on PR #6174:
URL: https://github.com/apache/nifi/pull/6174#issuecomment-1172536272
As @pvillard31 noted, the `Always Replace` strategy seems to meet the use
case described, and would seem to obviate the need for a new processor.
--
This is an automated message
exceptionfactory commented on code in PR #6134:
URL: https://github.com/apache/nifi/pull/6134#discussion_r912190782
##
nifi-toolkit/nifi-toolkit-api/pom.xml:
##
@@ -83,7 +84,7 @@ language governing permissions and limitations under the
License. -->
exceptionfactory commented on PR #6134:
URL: https://github.com/apache/nifi/pull/6134#issuecomment-1172625430
Thanks for the review and feedback @NissimShiman!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
markobean commented on PR #6151:
URL: https://github.com/apache/nifi/pull/6151#issuecomment-1172538089
There is a typo in a similar error message for exceeding buffer on line 319.
It's not explicitly part of this PR, but please update.
--
This is an automated message from the Apache Git
joewitt commented on PR #6174:
URL: https://github.com/apache/nifi/pull/6174#issuecomment-1172540099
So I agree with the spirit of what Mike is trying to solve. Make it easier
for users to find the right function with minimal additional complexity to do
the thing. Especially for simple
markobean commented on PR #6151:
URL: https://github.com/apache/nifi/pull/6151#issuecomment-1172548765
Less critical, but in passing I noted an inconsistency in the documentation
for AbstractTextDemarcator.fill(). It mentions throwing TokenTooLargeException
in the description, and
NissimShiman commented on code in PR #6134:
URL: https://github.com/apache/nifi/pull/6134#discussion_r912152508
##
nifi-toolkit/nifi-toolkit-api/pom.xml:
##
@@ -83,7 +84,7 @@ language governing permissions and limitations under the
License. -->
NissimShiman commented on PR #6134:
URL: https://github.com/apache/nifi/pull/6134#issuecomment-1172605337
@exceptionfactory This looks good to me.
LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
exceptionfactory commented on code in PR #6172:
URL: https://github.com/apache/nifi/pull/6172#discussion_r912188451
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ftp/StandardFTPClientProvider.java:
##
@@
[
https://issues.apache.org/jira/browse/NIFI-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561603#comment-17561603
]
ASF subversion and git services commented on NIFI-10166:
Commit
[
https://issues.apache.org/jira/browse/NIFI-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-10166.
-
Fix Version/s: 1.17.0
Resolution: Fixed
> MiNiFi Bootstrap test coverage
>
greyp9 commented on code in PR #6172:
URL: https://github.com/apache/nifi/pull/6172#discussion_r912276213
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFTPCharset.java:
##
@@ -0,0 +1,295 @@
+/*
+ *
greyp9 commented on code in PR #6172:
URL: https://github.com/apache/nifi/pull/6172#discussion_r912281332
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFTPCharset.java:
##
@@ -0,0 +1,295 @@
+/*
+ *
github-actions[bot] commented on PR #5684:
URL: https://github.com/apache/nifi/pull/5684#issuecomment-1172794130
We're marking this PR as stale due to lack of updates in the past few
months. If after another couple of weeks the stale label has not been removed
this PR will be closed. This
greyp9 commented on code in PR #6172:
URL: https://github.com/apache/nifi/pull/6172#discussion_r912263177
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ftp/StandardFTPClientProvider.java:
##
@@ -152,10
greyp9 commented on code in PR #6172:
URL: https://github.com/apache/nifi/pull/6172#discussion_r912275991
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestFTPCharset.java:
##
@@ -0,0 +1,295 @@
+/*
+ *
greyp9 commented on PR #6172:
URL: https://github.com/apache/nifi/pull/6172#issuecomment-1172776789
> Thanks for digging into this issue and developing a new test @greyp9! The
ClientProvider changes make sense.
>
> The new test is helpful, and covers a lot of ground. It does a lot of
52 matches
Mail list logo
