Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3156#discussion_r231759360
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
---
@@
Github user yjhyjhyjh0 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3156#discussion_r231754034
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteSQLRecord.java
---
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/3158
NIFI-5802: Add QueryRecord nullable field support
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user yjhyjhyjh0 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3156#discussion_r231753838
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
---
@@
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
> an Idle connection was one that had been returned to the pool?
That's what I would think, but I couldn't seem to actually trigger it.
Reading through the API docs some more, I
Github user viswaug commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3113#discussion_r231747175
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java
---
@@ -134,6 +134,14
Github user ijokarumawak commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3113#discussion_r231743426
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java
---
@@ -134,6
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678937#comment-16678937
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user colindean commented on the issue:
Mark Payne created NIFI-5801:
Summary: Evaluating Expression Language can in many cases be made
much more efficient
Key: NIFI-5801
URL: https://issues.apache.org/jira/browse/NIFI-5801
Project: Apache
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
Ah, I did that through checking the minIdle and maxIdle properties.
---
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678932#comment-16678932
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user patricker commented on the issue:
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/3133
My thought was you could look for the idle count and see if it was 0, 8,
etc... based on the config, and not worry about testing the timeouts for now.
---
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678885#comment-16678885
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user patricker commented on the issue:
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678921#comment-16678921
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user colindean commented on the issue:
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
> What if you exposed the number of active and idle connections in the
connection pool as properties on the DBCPConnectionPool? These are available by
calling getNumActive() and getNumIdle(). Or
[
https://issues.apache.org/jira/browse/NIFI-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678904#comment-16678904
]
Kislay Kumar commented on NIFI-4621:
[~markap14], [~patricker] : Thanks for quick help.
I am am
[
https://issues.apache.org/jira/browse/NIFI-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne resolved NIFI-1161.
--
Resolution: Won't Do
This should now be handled by PartitionRecord, QueryRecord, etc.
> Create
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/3133
@colindean I know Matt responded right after I did before, what are your
thoughts on working on enabling unit tests by exposing the idle/active
connection counts?
---
[
https://issues.apache.org/jira/browse/NIFI-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678845#comment-16678845
]
ASF GitHub Bot commented on NIFI-5800:
--
GitHub user markap14 opened a pull request:
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678821#comment-16678821
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user colindean commented on the issue:
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/3157
NIFI-5800: Do not recursively call hashCode on child schema for Recorâ¦
â¦d Field Types
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
[
https://issues.apache.org/jira/browse/NIFI-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne resolved NIFI-4065.
--
Resolution: Fixed
Was fixed in NIFI-5516
> toString() method of StandardConnection provides wrong
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
Test failure now seems to be a timeout in another module:
```
[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
30.287 s <<< FAILURE! - in
[
https://issues.apache.org/jira/browse/NIFI-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne resolved NIFI-4427.
--
Resolution: Fixed
Resolved by NIFI-5533
> Default for FlowFile's filename should be the FlowFile's
[
https://issues.apache.org/jira/browse/NIFI-4427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-4427:
-
Fix Version/s: 1.9.0
> Default for FlowFile's filename should be the FlowFile's UUID
>
[
https://issues.apache.org/jira/browse/NIFI-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne resolved NIFI-5687.
--
Resolution: Fixed
This was resolved as part of another commit before the feature was ever
released.
>
Mark Payne created NIFI-5800:
Summary: If RecordSchema has an inner field that references a
schema recursively by name, hashCode() throws StackOverflowError
Key: NIFI-5800
URL:
Github user colindean commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r231660071
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
---
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678725#comment-16678725
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user colindean commented on a diff in the pull
[
https://issues.apache.org/jira/browse/NIFI-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678720#comment-16678720
]
Mark Payne commented on NIFI-4621:
--
[~kislayom] I have assigned the Jira to you. You should now be able
[
https://issues.apache.org/jira/browse/NIFI-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne reassigned NIFI-4621:
Assignee: Kislay Kumar (was: Puspendu Banerjee)
> Allow inputs to ListSFTP
>
Github user colindean commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r231654261
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
---
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678702#comment-16678702
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user colindean commented on a diff in the pull
Github user viswaug commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3113#discussion_r231638762
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java
---
@@ -134,6 +134,14
[
https://issues.apache.org/jira/browse/NIFI-5724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678656#comment-16678656
]
ASF GitHub Bot commented on NIFI-5724:
--
Github user viswaug commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/NIFI-4621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678545#comment-16678545
]
Peter Wicks commented on NIFI-4621:
---
[~kislayom], I can't do this with your current permissions.
[
https://issues.apache.org/jira/browse/NIFI-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678537#comment-16678537
]
ASF GitHub Bot commented on NIFI-5780:
--
Github user patricker commented on a diff in the pull
[
https://issues.apache.org/jira/browse/NIFI-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678538#comment-16678538
]
ASF GitHub Bot commented on NIFI-5780:
--
Github user patricker commented on a diff in the pull
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3156#discussion_r231596320
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
---
@@
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3156#discussion_r231603266
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteSQLRecord.java
---
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678489#comment-16678489
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user mattyb149 commented on a diff in the pull
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r231582876
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
---
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r231582349
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
---
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678486#comment-16678486
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user mattyb149 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678482#comment-16678482
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user mattyb149 commented on a diff in the pull
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r231580669
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
---
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678480#comment-16678480
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user mattyb149 commented on a diff in the pull
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r231580368
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
---
[
https://issues.apache.org/jira/browse/NIFI-5780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678474#comment-16678474
]
ASF GitHub Bot commented on NIFI-5780:
--
GitHub user yjhyjhyjh0 opened a pull request:
GitHub user yjhyjhyjh0 opened a pull request:
https://github.com/apache/nifi/pull/3156
NIFI-5780 Add pre and post statements to ExecuteSQL and ExecuteSQLRecord
Add pre, post query property to AbstractExecuteSQL.
Most of implementation comes from SelectHiveQL.
Add unit test
Noel Winstanley created NIFI-5799:
-
Summary: Unable to extend docker image with custom configuration
Key: NIFI-5799
URL: https://issues.apache.org/jira/browse/NIFI-5799
Project: Apache NiFi
[
https://issues.apache.org/jira/browse/NIFI-5784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678459#comment-16678459
]
ASF GitHub Bot commented on NIFI-5784:
--
GitHub user andrewmlim opened a pull request:
GitHub user andrewmlim opened a pull request:
https://github.com/apache/nifi/pull/3155
NIFI-5784 Edit Admin Guide to remove duplicate content that is in newâ¦
⦠Toolkit Guide
Edited Toolkit Guide as needed for links.
You can merge this pull request into a Git repository
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678395#comment-16678395
]
ASF GitHub Bot commented on NIFI-5790:
--
Github user patricker commented on the issue:
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/3133
@colindean I don't have a good answer yet, hoping I can get some input from
other developers.
But I was thinking about unit tests, and what you could do to help make
this code change unit
Github user patricker commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3100#discussion_r231534519
--- Diff:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/RepeatingInputStream.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/NIFI-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678325#comment-16678325
]
ASF GitHub Bot commented on NIFI-5718:
--
Github user patricker commented on a diff in the pull
[
https://issues.apache.org/jira/browse/NIFI-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678264#comment-16678264
]
ASF GitHub Bot commented on NIFI-5798:
--
GitHub user markap14 opened a pull request:
[
https://issues.apache.org/jira/browse/NIFI-5798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-5798:
-
Fix Version/s: 1.9.0
Status: Patch Available (was: Open)
> FlattenJson improperly escapes
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/3138
NIFI-5798:Fixed bug in FlattenJson that was escaping text as Java insâ¦
â¦tead of escaping as JSON
Thank you for submitting a contribution to Apache NiFi.
In order to streamline
Mark Payne created NIFI-5798:
Summary: FlattenJson improperly escapes special characters
Key: NIFI-5798
URL: https://issues.apache.org/jira/browse/NIFI-5798
Project: Apache NiFi
Issue Type: Bug
[
https://issues.apache.org/jira/browse/NIFI-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678164#comment-16678164
]
ASF GitHub Bot commented on NIFI-5791:
--
Github user stevedlawrence commented on the issue:
Github user stevedlawrence commented on the issue:
https://github.com/apache/nifi/pull/3130
Ah yes, you are correct.
---
[
https://issues.apache.org/jira/browse/NIFI-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678162#comment-16678162
]
ASF GitHub Bot commented on NIFI-5791:
--
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/3130
What I mean is that from a high level, it is a transformational capability,
and may be used as an alternative.
---
[
https://issues.apache.org/jira/browse/NIFI-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678146#comment-16678146
]
ASF GitHub Bot commented on NIFI-5791:
--
Github user stevedlawrence commented on the issue:
Github user stevedlawrence commented on the issue:
https://github.com/apache/nifi/pull/3130
From my understanding of Jolt, this capability is pretty different.
Jolt reads JSON data, performs various transformations as described by a
JOLT specification, and then writes out
[
https://issues.apache.org/jira/browse/NIFI-5775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678002#comment-16678002
]
Sivaprasanna Sethuraman commented on NIFI-5775:
---
When do you see this error? Any example
[
https://issues.apache.org/jira/browse/NIFI-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677884#comment-16677884
]
ASF GitHub Bot commented on NIFI-5752:
--
Github user kotarot commented on the issue:
Github user kotarot commented on the issue:
https://github.com/apache/nifi/pull/3110
@ijokarumawak Thanks for reviewing and merging my PR!
---
[
https://issues.apache.org/jira/browse/NIFI-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura updated NIFI-5752:
Resolution: Fixed
Fix Version/s: 1.9.0
Status: Resolved (was: Patch Available)
>
[
https://issues.apache.org/jira/browse/NIFI-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677817#comment-16677817
]
ASF GitHub Bot commented on NIFI-5752:
--
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/3110
---
[
https://issues.apache.org/jira/browse/NIFI-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677815#comment-16677815
]
ASF subversion and git services commented on NIFI-5752:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677814#comment-16677814
]
ASF subversion and git services commented on NIFI-5752:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677813#comment-16677813
]
ASF subversion and git services commented on NIFI-5752:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677810#comment-16677810
]
ASF GitHub Bot commented on NIFI-5752:
--
Github user ijokarumawak commented on the issue:
[
https://issues.apache.org/jira/browse/MINIFICPP-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677809#comment-16677809
]
ASF GitHub Bot commented on MINIFICPP-648:
--
Github user arpadboda commented on the issue:
Github user arpadboda commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/432
>
>
> @arpadboda is this good? I'm good with this otherwise.
Now it is.
---
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/3110
It looks good. +1. Merging. Thanks, @kotarot!
---
80 matches
Mail list logo