[jira] [Created] (NIFI-12544) Support receiving HTTP SSE (Server Sent Events)
Justin created NIFI-12544: - Summary: Support receiving HTTP SSE (Server Sent Events) Key: NIFI-12544 URL: https://issues.apache.org/jira/browse/NIFI-12544 Project: Apache NiFi Issue Type: Improvement Reporter: Justin Currently NiFi has no processor which supports long poll type HTTP connections, InvokeHTTP expects that every http request will terminate shortly and does not forward intermediate results for long-lived connections instead hanging until the read timeout is reached and then erroring the request. This makes it difficult to connect to any system which utilizes the SSE standard to stream events to clients as they happen from NiFi, requiring a script processor or external tool to convert the SSE stream into something NiFi can handle. Since streaming data processing (streaming events) is NiFi's MO, it seems appropriate that there would be a native processor which can connect and stream these types of events. I also have need of such a processor and would like to upstream the changes, hence the ticket before I get too far into an implementation. A couple possibilities for implementing these changes: * Extend InvokeHTTP to support streaming content when enabled in processor options, thus it would forward content as it arrives, possibly broken apart via a delimiter/parse config. This would only timing out connections that don't make progress in so long (read timeout limits). * Add a new processor which is SSE specific which does all of the Proxy, Auth, ... work of InvokeHTTP, but outputs SSE events roughly as they arrived instead of a single HTTP response per input request. Should this accept configuration via FlowFile or be an INPUT_FORBIDDEN processor where everything is through Configuration? How do you close a stream programmatically if configured via FlowFile? * Create a new HTTP processor which has some level of support/awareness of content types (application/stream+json, application/x-ngjson, text/event-stream, ...) and doesn't time out long connections unless they aren't making progress, would output blocks in some predefined size or by a delimiter and rely on downstream to decide what to do with the content. Ref: https://developer.mozilla.org/en-US/docs/Web/API/Server-sent_events -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12534) Prepare New Website Design for Production
[ https://issues.apache.org/jira/browse/NIFI-12534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799961#comment-17799961 ] David Handermann commented on NIFI-12534: - With updates in NIFI-12540 and NIFI-12541, the remaining tasks for the redesign effort include the following: 1. Incorporate updated documentation links for MiNiFi Java and C++ from MINIFICPP-2273 2. Review Apache project guidelines for compliance: https://whimsy.apache.org/site/project/nifi > Prepare New Website Design for Production > - > > Key: NIFI-12534 > URL: https://issues.apache.org/jira/browse/NIFI-12534 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: James Elliott >Priority: Major > > Following completion of initial project website redesign and deployment to > staging, the following items should be reviewed and addressed to prepare the > new design for deployment to production: > # Adjust navigation bar behavior for small screens > # Correct Developer Guide page visibility on small screens > # Add deep-linking for each section of the Download page and remove separate > downloads > # Incorporate updated documentation for MiNiFi Java and C++ components > # Review Apache project guidelines for compliance with required links > # Add rewrite rules for popular pages, including the Security Reporting > page, to maintain published links > This issue can cover a number of these items, and separate related issues can > be created and tracked as needed for individual tasks. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12540) Restructure Pages and Add Rewrite Rules for Website Redesign
[ https://issues.apache.org/jira/browse/NIFI-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12540: Priority: Minor (was: Major) > Restructure Pages and Add Rewrite Rules for Website Redesign > > > Key: NIFI-12540 > URL: https://issues.apache.org/jira/browse/NIFI-12540 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > The Rewrite Rule configuration should be updated to provide automatic > redirect for popular pages such and documentation and security reporting. The > new design removes the HTML file extension from URLs and also provides the > opportunity to restructure some pages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-12540) Restructure Pages and Add Rewrite Rules for Website Redesign
[ https://issues.apache.org/jira/browse/NIFI-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12540: Resolution: Fixed Status: Resolved (was: Patch Available) > Restructure Pages and Add Rewrite Rules for Website Redesign > > > Key: NIFI-12540 > URL: https://issues.apache.org/jira/browse/NIFI-12540 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > The Rewrite Rule configuration should be updated to provide automatic > redirect for popular pages such and documentation and security reporting. The > new design removes the HTML file extension from URLs and also provides the > opportunity to restructure some pages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12540 Restructure Documentation and Guides [nifi-site]
exceptionfactory closed pull request #81: NIFI-12540 Restructure Documentation and Guides URL: https://github.com/apache/nifi-site/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12540 Restructure Documentation and Guides [nifi-site]
exceptionfactory commented on PR #81: URL: https://github.com/apache/nifi-site/pull/81#issuecomment-1868098176 Merged to main-staging in commit: https://github.com/apache/nifi-site/commit/92f976c2b4a45c4f18feead10a3323f6d5f954d1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12540 Restructure Documentation and Guides [nifi-site]
exceptionfactory commented on PR #81: URL: https://github.com/apache/nifi-site/pull/81#issuecomment-1868097403 Thanks for the feedback @james-elliott. I pushed a commit adding the external link icon to relevant links. With that feedback, I will proceed with merging to the `main-staging` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination * Counters (NIFI-12415) * Bulletin Board * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Flow Analysis Rules * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users (NIFI-12543) * Policies (NIFI-12543) * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * Prevent navigate to Service when configuration form is dirty * Introduce header in new pages to unify with canvas and offer better navigation. * Prompt user to save Parameter Context when Edit form is dirty [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination * Counters (NIFI-12415) * Bulletin Board * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Flow Analysis Rules * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * Prevent navigate to Service when configuration form is dirty * Introduce header in new pages to unify with canvas and offer better navigation. * Prompt user to save Parameter Context when Edit form is dirty [1] [https://github.com/apache/nifi/pull/8053] > Remaining items to
[jira] [Created] (NIFI-12543) Introduce pages for managing Users/Groups and Access Policies
Matt Gilman created NIFI-12543: -- Summary: Introduce pages for managing Users/Groups and Access Policies Key: NIFI-12543 URL: https://issues.apache.org/jira/browse/NIFI-12543 Project: Apache NiFi Issue Type: Sub-task Components: Core UI Reporter: Matt Gilman Assignee: Matt Gilman Introduce pages for managing Users/Groups and Access Policies. We should also support actions from the context menu and operate palette to open the policy page. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12540 Restructure Documentation and Guides [nifi-site]
james-elliott commented on code in PR #81:
URL: https://github.com/apache/nifi-site/pull/81#discussion_r1435321545
##
content/documentation/_index.md:
##
@@ -7,4 +7,27 @@ menu:
weight: 1
---
-https://nifi.apache.org/documentation/nifi-{{< param currentProjectVersion
>}}/">
+# Apache {{< project-label >}} Documentation
+
+## Configuration and Component Properties
+
+- [NiFi Documentation {{< param currentProjectVersion >}}]({{< ref
"/documentation/v2" >}})
+- [NiFi Documentation {{< param previousProjectVersion >}}]({{< ref
"/documentation/v1" >}})
+
+## Development Process
+
+-
[Contributing](https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide)
+- [Commit and Release Signing]({{< ref "documentation/guides/signing" >}})
+- [Licensing]({{< ref "documentation/guides/licensing" >}})
+
+## Release Process
+
+- [Flow Design System Releases]({{< ref "documentation/guides/fds-releases"
>}})
+- [Maven Plugin Releases]({{< ref "documentation/guides/maven-plugin-releases"
>}})
+- [Releases]({{< ref "documentation/guides/releases" >}})
+
+## Reference Information
+
+- [Security Reporting]({{< ref "/documentation/security" >}})
+- [Videos](https://cwiki.apache.org/confluence/display/NIFI/Project+Videos)
+- [Wiki](https://cwiki.apache.org/confluence/display/NIFI/)
Review Comment:
Same thought here about it being better to mark external links
##
content/development/_index.md:
##
@@ -6,4 +6,16 @@ menu:
weight: 2
---
-http://nifi.apache.org/docs/nifi-docs/html/developer-guide.html;>
+# Apache {{< project-label >}} Development
+
+## Development Process
+
+-
[Contributing](https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide)
+- [Commit and Release Signing]({{< ref "documentation/guides/signing" >}})
+- [Developing](https://nifi.apache.org/documentation/nifi-{{< param
currentProjectVersion >}}/html/developer-guide.html)
+- [Licensing]({{< ref "documentation/guides/licensing" >}})
Review Comment:
We should mark the external links here with an icon
##
content/documentation/guides/_index.md:
##
@@ -0,0 +1,23 @@
+---
+title: Guides
+menu:
+ main:
+name: Guides
+parent: "Documentation"
+weight: 3
+---
+
+# Apache {{< project-label >}} Guides
+
+## Development Process
+
+-
[Contributing](https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide)
+- [Commit and Release Signing]({{< ref "documentation/guides/signing" >}})
+- [Developing](https://nifi.apache.org/documentation/nifi-{{< param
currentProjectVersion >}}/html/developer-guide.html)
Review Comment:
External links aren't marked. We should either mark all of them, or remove
the indicator the menu. I think adding external icons to all of them is best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-12529) Enable/Disable Controller Service
[ https://issues.apache.org/jira/browse/NIFI-12529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12529: --- Status: Patch Available (was: In Progress) > Enable/Disable Controller Service > - > > Key: NIFI-12529 > URL: https://issues.apache.org/jira/browse/NIFI-12529 > Project: Apache NiFi > Issue Type: Sub-task > Components: Core UI >Reporter: Matt Gilman >Assignee: Matt Gilman >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Add support to enable and disable controller services. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12542 Refactor zendesk bundle to use updated APIs [nifi]
EndzeitBegins commented on PR #8170: URL: https://github.com/apache/nifi/pull/8170#issuecomment-1868063097 Thank you for review & merge @exceptionfactory. I wasn't sure whether additional Jira tickets are over the top. I'll open separate sub-tasks for any further adjustments. Thanks for pointing that out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12236 Improving fault tolerancy of the QuestDB backed metrics repository [nifi]
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1435328555
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb-status-history/src/main/java/org/apache/nifi/controller/status/history/questdb/EmbeddedQuestDbStatusHistoryRepositoryDefinitions.java:
##
@@ -0,0 +1,343 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.controller.status.history.questdb;
+
+import org.apache.nifi.controller.status.ConnectionStatus;
+import org.apache.nifi.controller.status.NodeStatus;
+import org.apache.nifi.controller.status.ProcessGroupStatus;
+import org.apache.nifi.controller.status.ProcessorStatus;
+import org.apache.nifi.controller.status.RemoteProcessGroupStatus;
+import org.apache.nifi.controller.status.history.ConnectionStatusDescriptor;
+import org.apache.nifi.controller.status.history.GarbageCollectionStatus;
+import org.apache.nifi.controller.status.history.MetricDescriptor;
+import org.apache.nifi.controller.status.history.NodeStatusDescriptor;
+import org.apache.nifi.controller.status.history.ProcessGroupStatusDescriptor;
+import org.apache.nifi.controller.status.history.ProcessorStatusDescriptor;
+import
org.apache.nifi.controller.status.history.RemoteProcessGroupStatusDescriptor;
+import org.apache.nifi.controller.status.history.StandardMetricDescriptor;
+import org.apache.nifi.controller.status.history.StandardStatusSnapshot;
+import org.apache.nifi.questdb.InsertRowDataSource;
+import org.apache.nifi.questdb.QueryResultProcessor;
+import org.apache.nifi.questdb.mapping.RequestMapping;
+import org.apache.nifi.questdb.mapping.RequestMappingBuilder;
+
+import java.time.ZoneId;
+import java.time.format.DateTimeFormatter;
+import java.util.Collection;
+import java.util.Date;
+import java.util.HashMap;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.TimeUnit;
+
+final class EmbeddedQuestDbStatusHistoryRepositoryDefinitions {
+/**
+ * Date format expected by the storage.
+ */
+static final String CAPTURE_DATE_FORMAT = "-MM-dd:HH:mm:ss Z";
+
+/**
+ * Date formatter for the database fields.
+ */
+static final DateTimeFormatter DATE_FORMATTER =
DateTimeFormatter.ofPattern(CAPTURE_DATE_FORMAT).withZone(ZoneId.systemDefault());
+
+// General component
+
+static final String COMPONENT_STATUS_QUERY =
+"SELECT * FROM %s " +
+"WHERE componentId = '%s' " +
+"AND capturedAt > to_timestamp('%s', '" + CAPTURE_DATE_FORMAT + "') " +
+"AND capturedAt < to_timestamp('%s', '" + CAPTURE_DATE_FORMAT + "') " +
+"ORDER BY capturedAt ASC";
+
+// Connection
+
+static final String TABLE_NAME_CONNECTION_STATUS = "connectionStatus";
+
+static final String CREATE_CONNECTION_STATUS =
+"CREATE TABLE " + TABLE_NAME_CONNECTION_STATUS + " (" +
+"capturedAt TIMESTAMP," +
+"componentId SYMBOL capacity 2000 nocache index capacity 1500," +
+"inputBytes LONG," +
+"inputCount LONG," +
+"outputBytes LONG," +
+"outputCount LONG," +
+"queuedBytes LONG," +
+"queuedCount LONG," +
+"totalQueuedDuration LONG," +
+"maxQueuedDuration LONG," +
+"averageQueuedDuration LONG" +
+") TIMESTAMP(capturedAt) PARTITION BY DAY";
+
+private static final Map>
CONNECTION_METRICS = new HashMap<>() {{
+put(2, ConnectionStatusDescriptor.INPUT_BYTES.getDescriptor());
+put(3, ConnectionStatusDescriptor.INPUT_COUNT.getDescriptor());
+put(4, ConnectionStatusDescriptor.OUTPUT_BYTES.getDescriptor());
+put(5, ConnectionStatusDescriptor.OUTPUT_COUNT.getDescriptor());
+put(6, ConnectionStatusDescriptor.QUEUED_BYTES.getDescriptor());
+put(7, ConnectionStatusDescriptor.QUEUED_COUNT.getDescriptor());
+put(8,
ConnectionStatusDescriptor.TOTAL_QUEUED_DURATION.getDescriptor());
+put(9, ConnectionStatusDescriptor.MAX_QUEUED_DURATION.getDescriptor());
+put(10,
ConnectionStatusDescriptor.AVERAGE_QUEUED_DURATION.getDescriptor());
+}};
Review Comment:
Although not all of the bullet points may be applicable,
Re: [PR] NIFI-12236 Improving fault tolerancy of the QuestDB backed metrics repository [nifi]
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1435326266
##
nifi-nar-bundles/nifi-questdb-bundle/nifi-questdb-status-history/src/main/java/org/apache/nifi/controller/status/history/questdb/CapturedStatus.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.controller.status.history.questdb;
+
+import java.time.Instant;
+import java.util.Objects;
+
+final class CapturedStatus {
+private final T status;
+private final Instant capturedAt;
Review Comment:
Taking the `nifi-client-dto` as an example, timestamp properties in those
classes due not have the `At` suffix, and include properties such as `created`
and `lastUpdated`. Following that convention, I recommend removing all
occurrences of the `At` suffix from property names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-12236 Improving fault tolerancy of the QuestDB backed metrics repository [nifi]
exceptionfactory commented on code in PR #8152:
URL: https://github.com/apache/nifi/pull/8152#discussion_r1435323896
##
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/retry/NoReturnCallable.java:
##
@@ -14,25 +14,16 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.nifi.controller.status.history.storage;
-
-import org.apache.nifi.controller.status.history.GarbageCollectionHistory;
-import org.apache.nifi.controller.status.history.GarbageCollectionStatus;
-
-import java.time.Instant;
+package org.apache.nifi.retry;
/**
- * Readable status storage for garbage collection status entries.
+ * Represents a portion of callable code without expected return value.
*/
-public interface GarbageCollectionStatusStorage extends
StatusStorage {
+@FunctionalInterface
+public interface NoReturnCallable {
Review Comment:
Thanks for the additional background. With that in mind, it seems like
having the custom `Callable` as a nested interface on the RetryTemplate would
be a better approach.
Did you consider using
[spring-retry](https://www.baeldung.com/spring-retry#retrytemplate) instead?
Since the abstraction applies to QuestDB, it seems worth considering as it has
a minimal number of dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799924#comment-17799924
]
David Handermann commented on NIFI-12513:
-
It would be helpful to mention in the JavaDoc that it is derived from Spring
UriComponentsBuilder, but the main thing is the reference in the NOTICE.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799922#comment-17799922
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:50 PM:
---
[~exceptionfactory] That is what exactly I have done except I called the
utility class UriUtils. Do I have to mention in the UrlUtils class where I got
the regular expressions or is it enough the change to the NOTICE file stating
that there are derived works from
https://github.com/spring-projects/spring-framework/blob/main/spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
?
was (Author: JIRAUSER294662):
[~exceptionfactory] That is what exactly I have done. Do I have to mention in
the UrlUtils class where I got the regular expressions or is it enough the
change to the NOTICE file stating that there are derived works from
https://github.com/spring-projects/spring-framework/blob/main/spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
?
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799922#comment-17799922
]
Daniel Stieglitz commented on NIFI-12513:
-
[~exceptionfactory] That is what exactly I have done. Do I have to mention in
the UrlUtils class where I got the regular expressions or is enough the change
to the NOTICE file stating that there are derived works from
https://github.com/spring-projects/spring-framework/blob/main/spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
?
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799922#comment-17799922
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:49 PM:
---
[~exceptionfactory] That is what exactly I have done. Do I have to mention in
the UrlUtils class where I got the regular expressions or is it enough the
change to the NOTICE file stating that there are derived works from
https://github.com/spring-projects/spring-framework/blob/main/spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
?
was (Author: JIRAUSER294662):
[~exceptionfactory] That is what exactly I have done. Do I have to mention in
the UrlUtils class where I got the regular expressions or is enough the change
to the NOTICE file stating that there are derived works from
https://github.com/spring-projects/spring-framework/blob/main/spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java
?
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:45 PM:
---
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using 'URI.create' would pose a problem since there
may be unquoted/unescaped characters in its query and/or fragments sections? I
am not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] and all those places in the
code which use StandardValidators#URL_VALIDATOR need this change similar to
InvokeHttp since they may not have any characters which need to be
quoted/escaped. I am not familiar enough with the form of URLs these components
use, Please advise. Thanks!
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using 'URI.create' would pose a problem since there
may be unquoted/unescaped characters in its query and/or fragments sections? I
am not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] and all
those places in the code which use StandardValidators#URL_VALIDATOR need this
change similar to InvokeHttp since they may not have any characters which need
to be quoted/escaped. I am not familiar enough with the form of URLs these
components use, Please advise. Thanks!
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:45 PM:
---
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using 'URI.create' would pose a problem since there
may be unquoted/unescaped characters in its query and/or fragments sections? I
am not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] and all
those places in the code which use StandardValidators#URL_VALIDATOR need this
change similar to InvokeHttp since they may not have any characters which need
to be quoted/escaped. I am not familiar enough with the form of URLs these
components use, Please advise. Thanks!
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using 'URI.create' would pose a problem since there
may be unquoted/unescaped characters in its query and/or fragments sections? I
am not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
Do all those places in the code which use StandardValidators#URL_VALIDATOR need
this change similar to InvokeHttp. I am not familiar enough with the form of
URLs these components use, Please advise. Thanks!
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:44 PM:
---
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using 'URI.create' would pose a problem since there
may be unquoted/unescaped characters in its query and/or fragments sections? I
am not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
Do all those places in the code which use StandardValidators#URL_VALIDATOR need
this change similar to InvokeHttp. I am not familiar enough with the form of
URLs these components use, Please advise. Thanks!
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there may
be unquoted/unescaped characters in its query and/or fragments sections? I am
not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
Do all those places in the code which use StandardValidators#URL_VALIDATOR need
this change similar to InvokeHttp. I am not familiar enough with the form of
URLs these components use, Please advise. Thanks!
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799919#comment-17799919
]
David Handermann commented on NIFI-12513:
-
Thanks for working on this [~dstiegli1].
To answer your licensing question, yes, ASLv2 is short for Apache License,
Version 2.0.
Based on a cursory review, most other places that were changed probably don't
need the additional parsing, since the URLs would not contain fragment
sections. A closer review may be necessary to be sure. If you are able to
implement a reusable UrlUtils class in the {{nifi-utils}} module, that sounds
like a great solution, and would provide potential support for other changes if
needed.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:43 PM:
---
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there may
be unquoted/unescaped characters in its query and/or fragments sections? I am
not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
Do all those places in the code which use StandardValidators#URL_VALIDATOR need
this change similar to InvokeHttp. I am not familiar enough with the form of
URLs these components use, Please advise. Thanks!
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there may
be unquoted/unescaped characters in its query and/or fragments sections? I am
not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped. Please advise.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:41 PM:
---
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there may
be unquoted/unescaped characters in its query and/or fragments sections? I am
not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped. Please advise.
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there may
be unquoted/unescaped characters in its query and/or fragments sections? I am
not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:41 PM:
---
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there may
be unquoted/unescaped characters in its query and/or fragments sections? I am
not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there
maybe unquoted/unescaped characters in its query and/or fragments sections? I
am not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:41 PM:
---
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there
maybe unquoted/unescaped characters in its query and/or fragments sections? I
am not sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there be
unquoted/unescaped characters in its query and/or fragments sections? I am not
sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:40 PM:
---
[~exceptionfactory] [~pvillard] I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there be
unquoted/unescaped characters in its query and/or fragments sections? I am not
sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] So I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there be
unquoted/unescaped characters in its query and/or fragments sections? I am not
sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12441 Added No Tracking listing strategy to ListS3 [nifi]
exceptionfactory commented on code in PR #8088:
URL: https://github.com/apache/nifi/pull/8088#discussion_r1435309260
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java:
##
@@ -451,11 +456,92 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
listByTrackingTimestamps(context, session);
} else if (BY_ENTITIES.equals(listingStrategy)) {
listByTrackingEntities(context, session);
+} else if (NO_TRACKING.equals(listingStrategy)) {
+listNoTracking(context, session);
} else {
throw new ProcessException("Unknown listing strategy: " +
listingStrategy);
}
}
+private void listNoTracking(ProcessContext context, ProcessSession
session) {
+final AmazonS3 client = getClient(context);
+
+S3BucketLister bucketLister = getS3BucketLister(context, client);
+
+final long startNanos = System.nanoTime();
+final long minAgeMilliseconds =
context.getProperty(MIN_AGE).asTimePeriod(TimeUnit.MILLISECONDS);
+final Long maxAgeMilliseconds = context.getProperty(MAX_AGE) != null ?
context.getProperty(MAX_AGE).asTimePeriod(TimeUnit.MILLISECONDS) : null;
+final long listingTimestamp = System.currentTimeMillis();
+
+final String bucket =
context.getProperty(BUCKET_WITHOUT_DEFAULT_VALUE).evaluateAttributeExpressions().getValue();
+final int batchSize = context.getProperty(BATCH_SIZE).asInteger();
+
+int listCount = 0;
+int totalListCount = 0;
+
+getLogger().trace("Start listing, listingTimestamp={}", new
Object[]{listingTimestamp});
+
+final S3ObjectWriter writer;
+final RecordSetWriterFactory writerFactory =
context.getProperty(RECORD_WRITER).asControllerService(RecordSetWriterFactory.class);
+if (writerFactory == null) {
+writer = new AttributeObjectWriter(session);
+} else {
+writer = new RecordObjectWriter(session, writerFactory,
getLogger(), context.getProperty(S3_REGION).getValue());
+}
+
+try {
+writer.beginListing();
+
+do {
+VersionListing versionListing = bucketLister.listVersions();
+for (S3VersionSummary versionSummary :
versionListing.getVersionSummaries()) {
+long lastModified =
versionSummary.getLastModified().getTime();
+if ((maxAgeMilliseconds != null && (lastModified <
(listingTimestamp - maxAgeMilliseconds)))
+|| lastModified > (listingTimestamp -
minAgeMilliseconds)) {
+continue;
+}
+
+getLogger().trace("Listed key={}, lastModified={}", new
Object[]{versionSummary.getKey(), lastModified});
Review Comment:
```suggestion
getLogger().trace("Listed key={}, lastModified={}",
versionSummary.getKey(), lastModified);
```
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/ListS3.java:
##
@@ -451,11 +456,92 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
listByTrackingTimestamps(context, session);
} else if (BY_ENTITIES.equals(listingStrategy)) {
listByTrackingEntities(context, session);
+} else if (NO_TRACKING.equals(listingStrategy)) {
+listNoTracking(context, session);
} else {
throw new ProcessException("Unknown listing strategy: " +
listingStrategy);
}
}
+private void listNoTracking(ProcessContext context, ProcessSession
session) {
+final AmazonS3 client = getClient(context);
+
+S3BucketLister bucketLister = getS3BucketLister(context, client);
+
+final long startNanos = System.nanoTime();
+final long minAgeMilliseconds =
context.getProperty(MIN_AGE).asTimePeriod(TimeUnit.MILLISECONDS);
+final Long maxAgeMilliseconds = context.getProperty(MAX_AGE) != null ?
context.getProperty(MAX_AGE).asTimePeriod(TimeUnit.MILLISECONDS) : null;
+final long listingTimestamp = System.currentTimeMillis();
+
+final String bucket =
context.getProperty(BUCKET_WITHOUT_DEFAULT_VALUE).evaluateAttributeExpressions().getValue();
+final int batchSize = context.getProperty(BATCH_SIZE).asInteger();
+
+int listCount = 0;
+int totalListCount = 0;
+
+getLogger().trace("Start listing, listingTimestamp={}", new
Object[]{listingTimestamp});
Review Comment:
The `Object[]` wrapper is not necessary for log arguments, although not all
components have been updated to reflect the recommended usage, new code should
follow the pattern.
```suggestion
getLogger().trace("Start listing, listingTimestamp={}",
listingTimestamp);
```
##
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:39 PM:
---
[~exceptionfactory] [~pvillard] So I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there be
unquoted/unescaped characters in its query and/or fragments sections? I am not
sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this since they may not
have any characters which need to be quoted/escaped.
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] So I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there be
unquoted/unescaped characters in its query and/or fragments sections? I am not
sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:39 PM:
---
[~exceptionfactory] [~pvillard] So I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there be
unquoted/unescaped characters in its query and/or fragments sections? I am not
sure all of the places changed in
[#7771|https://github.com/apache/nifi/pull/7771] need this.
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard] So I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there be
unquoted/unescaped characters in its query and/or fragments sections? I am not
sure all of the places changed in #7771 need this.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799917#comment-17799917
]
Daniel Stieglitz commented on NIFI-12513:
-
[~exceptionfactory] [~pvillard] So I have developed a utility method which now
uses a regular expression to parse the 7 parts of the URI and instantiates a
URI object with those seven pieces as I had suggested earlier. I modified the
StandardValidators#URL_VALIDATOR and InvokeHttp (when creating the java.net.URI
object from the value entered in the 'HTTP_URL' property) to now use the
utility method. My question is where else would this change apply? What other
places that are currently using URI.create would pose a problem since there be
unquoted/unescaped characters in its query and/or fragments sections? I am not
sure all of the places changed in #7771 need this.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-12334) Implement GCS option for FileResourceService
[ https://issues.apache.org/jira/browse/NIFI-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12334. - Fix Version/s: 2.0.0 Resolution: Fixed > Implement GCS option for FileResourceService > > > Key: NIFI-12334 > URL: https://issues.apache.org/jira/browse/NIFI-12334 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Mark Bathori >Assignee: Mark Bathori >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Add GCS based implementation for the FileResourceService interface to be able > to fetch data directly from Google Cloud Storage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12334) Implement GCS option for FileResourceService
[ https://issues.apache.org/jira/browse/NIFI-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799915#comment-17799915 ] ASF subversion and git services commented on NIFI-12334: Commit 69df3f0f66c62677edf4d7e931f80f66e142830a in nifi's branch refs/heads/main from Mark Bathori [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=69df3f0f66 ] NIFI-12334 Added GCSFileResourceService This closes #7999 Signed-off-by: David Handermann > Implement GCS option for FileResourceService > > > Key: NIFI-12334 > URL: https://issues.apache.org/jira/browse/NIFI-12334 > Project: Apache NiFi > Issue Type: New Feature >Reporter: Mark Bathori >Assignee: Mark Bathori >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Add GCS based implementation for the FileResourceService interface to be able > to fetch data directly from Google Cloud Storage. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12334: Implement GCS option for FileResourceService [nifi]
exceptionfactory closed pull request #7999: NIFI-12334: Implement GCS option for FileResourceService URL: https://github.com/apache/nifi/pull/7999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12296 Write the data to Apache Doris in a StreamLoad fashion [nifi]
exceptionfactory commented on PR #8003: URL: https://github.com/apache/nifi/pull/8003#issuecomment-1868012023 @wanghangyu817 Are you still planning on revisiting this pull request? If you do not expect to get to it for some time, it would be best to close it for now and open it again when you are ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11627 Added an in memory JSON schema registry which ValidationJson can now use to retrieve JSON schemas from for validation. [nifi]
exceptionfactory commented on code in PR #8005:
URL: https://github.com/apache/nifi/pull/8005#discussion_r1435301326
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java:
##
@@ -79,65 +92,69 @@
}
)
public class ValidateJson extends AbstractProcessor {
-public enum SchemaVersion implements DescribedValue {
-DRAFT_4("Draft Version 4", "Draft 4", VersionFlag.V4),
-DRAFT_6("Draft Version 6", "Draft 6", VersionFlag.V6),
-DRAFT_7("Draft Version 7", "Draft 7", VersionFlag.V7),
-DRAFT_2019_09("Draft Version 2019-09", "Draft 2019-09",
VersionFlag.V201909),
-DRAFT_2020_12("Draft Version 2020-12", "Draft 2020-12",
VersionFlag.V202012);
-
-private final String description;
-private final String displayName;
-private final VersionFlag versionFlag;
-
-SchemaVersion(String description, String displayName, VersionFlag
versionFlag) {
-this.description = description;
-this.displayName = displayName;
-this.versionFlag = versionFlag;
-}
-@Override
-public String getValue() {
-return name();
-}
+public static final String SCHEMA_NAME_PROPERTY_NAME = "Schema Name";
+public static final String SCHEMA_CONTENT_PROPERTY_NAME = "JSON Schema";
+public static final String ERROR_ATTRIBUTE_KEY = "json.validation.errors";
+public static final AllowableValue SCHEMA_NAME_PROPERTY = new
AllowableValue("schema-name", "Use '" + SCHEMA_NAME_PROPERTY_NAME + "'
Property",
+"The name of the Schema to use is specified by the '" +
SCHEMA_NAME_PROPERTY_NAME +
+"' Property. The value of this property is used to lookup
the Schema in the configured JSON Schema Registry service.");
+public static final AllowableValue SCHEMA_CONTENT_PROPERTY = new
AllowableValue("schema-content-property", "Use '" +
SCHEMA_CONTENT_PROPERTY_NAME + "' Property",
+"A URL or file path to the JSON schema or the actual JSON schema
is specified by the '" + SCHEMA_CONTENT_PROPERTY_NAME + "' Property. " +
+"No matter how the JSON schema is specified, it must be a
valid JSON schema");
Review Comment:
It would be helpful to switch from the `AllowableValue` class definition to
an enum that implements `DescribedValue`, making it easier to work with
selected values in the component itself.
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java:
##
@@ -79,65 +92,69 @@
}
)
public class ValidateJson extends AbstractProcessor {
-public enum SchemaVersion implements DescribedValue {
-DRAFT_4("Draft Version 4", "Draft 4", VersionFlag.V4),
-DRAFT_6("Draft Version 6", "Draft 6", VersionFlag.V6),
-DRAFT_7("Draft Version 7", "Draft 7", VersionFlag.V7),
-DRAFT_2019_09("Draft Version 2019-09", "Draft 2019-09",
VersionFlag.V201909),
-DRAFT_2020_12("Draft Version 2020-12", "Draft 2020-12",
VersionFlag.V202012);
-
-private final String description;
-private final String displayName;
-private final VersionFlag versionFlag;
-
-SchemaVersion(String description, String displayName, VersionFlag
versionFlag) {
-this.description = description;
-this.displayName = displayName;
-this.versionFlag = versionFlag;
-}
-@Override
-public String getValue() {
-return name();
-}
+public static final String SCHEMA_NAME_PROPERTY_NAME = "Schema Name";
+public static final String SCHEMA_CONTENT_PROPERTY_NAME = "JSON Schema";
+public static final String ERROR_ATTRIBUTE_KEY = "json.validation.errors";
+public static final AllowableValue SCHEMA_NAME_PROPERTY = new
AllowableValue("schema-name", "Use '" + SCHEMA_NAME_PROPERTY_NAME + "'
Property",
+"The name of the Schema to use is specified by the '" +
SCHEMA_NAME_PROPERTY_NAME +
+"' Property. The value of this property is used to lookup
the Schema in the configured JSON Schema Registry service.");
+public static final AllowableValue SCHEMA_CONTENT_PROPERTY = new
AllowableValue("schema-content-property", "Use '" +
SCHEMA_CONTENT_PROPERTY_NAME + "' Property",
+"A URL or file path to the JSON schema or the actual JSON schema
is specified by the '" + SCHEMA_CONTENT_PROPERTY_NAME + "' Property. " +
+"No matter how the JSON schema is specified, it must be a
valid JSON schema");
-@Override
-public String getDisplayName() {
-return displayName;
-}
+private static final List STRATEGY_LIST =
Arrays.asList(SCHEMA_NAME_PROPERTY, SCHEMA_CONTENT_PROPERTY);
-@Override
-public String getDescription() {
-
[jira] [Updated] (NIFI-12504) Remaining Summary Pages (tabs)
[ https://issues.apache.org/jira/browse/NIFI-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12504: --- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) > Remaining Summary Pages (tabs) > -- > > Key: NIFI-12504 > URL: https://issues.apache.org/jira/browse/NIFI-12504 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > The initial effort was getting quite large, so this story was meant to > capture the remaining work: > * input ports > * output ports > * remote process groups > * process groups > * connections > * -support for cluster-specific ui elements- NIFI-12537 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12504) Remaining Summary Pages (tabs)
[ https://issues.apache.org/jira/browse/NIFI-12504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799914#comment-17799914 ] ASF subversion and git services commented on NIFI-12504: Commit 30419c8dd863a25869e7778de8335ad27b4b5fb5 in nifi's branch refs/heads/main from Rob Fellows [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=30419c8dd8 ] [NIFI-12504] Remaining views on Summary page (#8174) * [NIFI-12504] process group summary tab * ellipsify data/headers in table * input and output port summary tabs * connections summary tab * rpg summary tab * address review feedback including a filtering approach that doesn't rely on splitting strings by some arbitray character. * remove unnecessary try/catch blocks This closes #8174 > Remaining Summary Pages (tabs) > -- > > Key: NIFI-12504 > URL: https://issues.apache.org/jira/browse/NIFI-12504 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Rob Fellows >Assignee: Rob Fellows >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > The initial effort was getting quite large, so this story was meant to > capture the remaining work: > * input ports > * output ports > * remote process groups > * process groups > * connections > * -support for cluster-specific ui elements- NIFI-12537 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12504] Remaining views on Summary page [nifi]
mcgilman merged PR #8174: URL: https://github.com/apache/nifi/pull/8174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799845#comment-17799845
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:16 PM:
---
[~exceptionfactory] [~pvillard]
I am still working out the regular expression. In the meantime there is a
workaround for at least InvokeHttp. For the 'HTTP URL' property use NIFI
Expression Language and before the InvokeHttp processor use an UpdateAttribute
processor to set an attribute with the value of getUri from the NIFI Expression
Language. The value with the URL specified in the description would like
{code:java}
${getUri('https', null, 'en.wikipedia.org', -1, '/w/api.php',
'action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags',
null)}
{code}
Another option is to escape/quote by hand any illegal character(s) found in the
query and/or fragment sections of the URL. See the [URI
javadocs|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/net/URI.html]
for more details.
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard]
I am still working out the regular expression. In the meantime there is a
workaround for at least InvokeHttp. For the 'HTTP URL' property use NIFI
Expression Language and before the InvokeHttp processor use an UpdateAttribute
processor to set an attribute with the value of getUri from the NIFI Expression
Language. The value with the URL specified in the description would like
{code:java}
${getUri('https', null, 'en.wikipedia.org', -1, '/w/api.php',
'action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags',
null)}
{code}
Another option is to escape/quote by hand any illegal character(s) found in the
query and/or fragment sections of the URI. See the [URI
javadocs|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/net/URI.html]
for more details.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799845#comment-17799845
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 7:15 PM:
---
[~exceptionfactory] [~pvillard]
I am still working out the regular expression. In the meantime there is a
workaround for at least InvokeHttp. For the 'HTTP URL' property use NIFI
Expression Language and before the InvokeHttp processor use an UpdateAttribute
processor to set an attribute with the value of getUri from the NIFI Expression
Language. The value with the URL specified in the description would like
{code:java}
${getUri('https', null, 'en.wikipedia.org', -1, '/w/api.php',
'action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags',
null)}
{code}
Another option is to escape/quote by hand any illegal character(s) found in the
query and/or fragment sections of the URI. See the [URI
javadocs|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/net/URI.html]
for more details.
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard]
I am still working out the regular expression. In the meantime there is a
workaround for at least InvokeHttp. For the 'HTTP URL' property use NIFI
Expression Language and before the InvokeHttp processor use an UpdateAttribute
processor to set an attribute with the value of getUri from the NIFI Expression
Language. The value with the URL specified in the description would like
{code:java}
${getUri('https', null, 'en.wikipedia.org', -1, '/w/api.php',
'action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags',
null)}
{code}
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12542 Refactor zendesk bundle to use updated APIs [nifi]
exceptionfactory closed pull request #8170: NIFI-12542 Refactor zendesk bundle to use updated APIs URL: https://github.com/apache/nifi/pull/8170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12542) Update Zendesk Components using Current API Methods
[
https://issues.apache.org/jira/browse/NIFI-12542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799913#comment-17799913
]
ASF subversion and git services commented on NIFI-12542:
Commit 553a36c0880714b13420be0773247ba5e46c4348 in nifi's branch
refs/heads/main from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=553a36c088 ]
NIFI-12542 Updated Zendesk Components using Current APIs
This closes #8170
Signed-off-by: David Handermann
> Update Zendesk Components using Current API Methods
> ---
>
> Key: NIFI-12542
> URL: https://issues.apache.org/jira/browse/NIFI-12542
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: David Handermann
>Assignee: endzeit
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Based on improvements to support for {{DescribedValue}} in NiFi API and other
> improvements in Java 21, Zendesk components should be updated to use current
> methods.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-12542) Update Zendesk Components using Current API Methods
[
https://issues.apache.org/jira/browse/NIFI-12542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-12542.
-
Fix Version/s: 2.0.0
Resolution: Fixed
> Update Zendesk Components using Current API Methods
> ---
>
> Key: NIFI-12542
> URL: https://issues.apache.org/jira/browse/NIFI-12542
> Project: Apache NiFi
> Issue Type: Sub-task
>Reporter: David Handermann
>Assignee: endzeit
>Priority: Minor
> Fix For: 2.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Based on improvements to support for {{DescribedValue}} in NiFi API and other
> improvements in Java 21, Zendesk components should be updated to use current
> methods.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12542) Update Zendesk Components using Current API Methods
David Handermann created NIFI-12542:
---
Summary: Update Zendesk Components using Current API Methods
Key: NIFI-12542
URL: https://issues.apache.org/jira/browse/NIFI-12542
Project: Apache NiFi
Issue Type: Sub-task
Reporter: David Handermann
Assignee: endzeit
Based on improvements to support for {{DescribedValue}} in NiFi API and other
improvements in Java 21, Zendesk components should be updated to use current
methods.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (NIFI-12533) Add environment variable in Docker for nifi.cluster.load.balance.host
[
https://issues.apache.org/jira/browse/NIFI-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-12533.
-
Fix Version/s: 1.25.0
2.0.0
Resolution: Fixed
> Add environment variable in Docker for nifi.cluster.load.balance.host
> -
>
> Key: NIFI-12533
> URL: https://issues.apache.org/jira/browse/NIFI-12533
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Dominique Jean-Prost
>Assignee: Dominique Jean-Prost
>Priority: Major
> Fix For: 1.25.0, 2.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There should be a env variable something like
> {{NIFI_CLUSTER_LOAD_BALANCE_HOST}} to populate
> {{nifi.cluster.load.balance.host}}.
> Currently there is no one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (NIFI-12533) Add environment variable in Docker for nifi.cluster.load.balance.host
[
https://issues.apache.org/jira/browse/NIFI-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann reassigned NIFI-12533:
---
Assignee: Dominique Jean-Prost
> Add environment variable in Docker for nifi.cluster.load.balance.host
> -
>
> Key: NIFI-12533
> URL: https://issues.apache.org/jira/browse/NIFI-12533
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Dominique Jean-Prost
>Assignee: Dominique Jean-Prost
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There should be a env variable something like
> {{NIFI_CLUSTER_LOAD_BALANCE_HOST}} to populate
> {{nifi.cluster.load.balance.host}}.
> Currently there is no one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12533) No environment variable is available to define nifi.cluster.load.balance.host
[
https://issues.apache.org/jira/browse/NIFI-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799909#comment-17799909
]
ASF subversion and git services commented on NIFI-12533:
Commit 02a7d53f97b4d949ab8d158ad6ce7b0804f81de1 in nifi's branch
refs/heads/support/nifi-1.x from Dominique Jean-Prost
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=02a7d53f97 ]
NIFI-12533 Allow usage of NIFI_CLUSTER_LOAD_BALANCE_HOST in Docker
This closes #8177
Signed-off-by: David Handermann
(cherry picked from commit 470406c13a7854ad7c73a1471b0f79d611037cb1)
> No environment variable is available to define nifi.cluster.load.balance.host
> -
>
> Key: NIFI-12533
> URL: https://issues.apache.org/jira/browse/NIFI-12533
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Dominique Jean-Prost
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There should be a env variable something like
> {{NIFI_CLUSTER_LOAD_BALANCE_HOST}} to populate
> {{nifi.cluster.load.balance.host}}.
> Currently there is no one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12533) Add environment variable in Docker for nifi.cluster.load.balance.host
[
https://issues.apache.org/jira/browse/NIFI-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12533:
Summary: Add environment variable in Docker for
nifi.cluster.load.balance.host (was: No environment variable is available to
define nifi.cluster.load.balance.host)
> Add environment variable in Docker for nifi.cluster.load.balance.host
> -
>
> Key: NIFI-12533
> URL: https://issues.apache.org/jira/browse/NIFI-12533
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Dominique Jean-Prost
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There should be a env variable something like
> {{NIFI_CLUSTER_LOAD_BALANCE_HOST}} to populate
> {{nifi.cluster.load.balance.host}}.
> Currently there is no one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] NIFI-12533 : allow usage of NIFI_CLUSTER_LOAD_BALANCE_HOST [nifi]
exceptionfactory closed pull request #8177: NIFI-12533 : allow usage of NIFI_CLUSTER_LOAD_BALANCE_HOST URL: https://github.com/apache/nifi/pull/8177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-12533) No environment variable is available to define nifi.cluster.load.balance.host
[
https://issues.apache.org/jira/browse/NIFI-12533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799908#comment-17799908
]
ASF subversion and git services commented on NIFI-12533:
Commit 470406c13a7854ad7c73a1471b0f79d611037cb1 in nifi's branch
refs/heads/main from Dominique Jean-Prost
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=470406c13a ]
NIFI-12533 Allow usage of NIFI_CLUSTER_LOAD_BALANCE_HOST in Docker
This closes #8177
Signed-off-by: David Handermann
> No environment variable is available to define nifi.cluster.load.balance.host
> -
>
> Key: NIFI-12533
> URL: https://issues.apache.org/jira/browse/NIFI-12533
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Dominique Jean-Prost
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There should be a env variable something like
> {{NIFI_CLUSTER_LOAD_BALANCE_HOST}} to populate
> {{nifi.cluster.load.balance.host}}.
> Currently there is no one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799898#comment-17799898
]
Daniel Stieglitz commented on NIFI-12513:
-
[~joewitt] Just to clarify when the file has
??Licensed under the Apache License, Version 2.0 (the "License");??
that is the same as ASLv2?
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12540) Restructure Pages and Add Rewrite Rules for Website Redesign
[ https://issues.apache.org/jira/browse/NIFI-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-12540: Status: Patch Available (was: In Progress) > Restructure Pages and Add Rewrite Rules for Website Redesign > > > Key: NIFI-12540 > URL: https://issues.apache.org/jira/browse/NIFI-12540 > Project: Apache NiFi > Issue Type: Improvement > Components: Documentation Website >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The Rewrite Rule configuration should be updated to provide automatic > redirect for popular pages such and documentation and security reporting. The > new design removes the HTML file extension from URLs and also provides the > opportunity to restructure some pages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-12540 Restructure Documentation and Guides [nifi-site]
exceptionfactory opened a new pull request, #81: URL: https://github.com/apache/nifi-site/pull/81 [NIFI-12540](https://issues.apache.org/jira/browse/NIFI-12540) Restructures Documentation and Guides pages to streamline menu navigation. Signing and Release Guides are moved under a `Guides` page in the `Documentation` menu, instead of appearing directly under the `Development` menu. Additional changes include adding HTTP Rewrite Rules for historical links, removing download links for individual project pages, and adding deep-linking to sections of the main Download page. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12541 - Add a mobile menu to the NiFi site for smaller screens [nifi-site]
exceptionfactory commented on PR #80: URL: https://github.com/apache/nifi-site/pull/80#issuecomment-1867942678 Merged to main-staging in commit https://github.com/apache/nifi-site/commit/cc0af16b34d4ebb90ba1f73e2c132b54fc122ef5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12541 - Add a mobile menu to the NiFi site for smaller screens [nifi-site]
exceptionfactory closed pull request #80: NIFI-12541 - Add a mobile menu to the NiFi site for smaller screens URL: https://github.com/apache/nifi-site/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12541) Add a mobile menu to the NiFi site for smaller screens
[ https://issues.apache.org/jira/browse/NIFI-12541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12541. - Assignee: James Elliott Resolution: Fixed > Add a mobile menu to the NiFi site for smaller screens > -- > > Key: NIFI-12541 > URL: https://issues.apache.org/jira/browse/NIFI-12541 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: James Elliott >Assignee: James Elliott >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-12541) Add a mobile menu to the NiFi site for smaller screens
James Elliott created NIFI-12541: Summary: Add a mobile menu to the NiFi site for smaller screens Key: NIFI-12541 URL: https://issues.apache.org/jira/browse/NIFI-12541 Project: Apache NiFi Issue Type: Sub-task Reporter: James Elliott -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-12504] Remaining views on Summary page [nifi]
rfellows commented on PR #8174: URL: https://github.com/apache/nifi/pull/8174#issuecomment-1867852929 recheck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-12394 when synching to a VersionedFlow, make sure processor references to new controller services are valid [nifi]
mosermw opened a new pull request, #8184: URL: https://github.com/apache/nifi/pull/8184 NIFI-12394 when synching to a VersionedFlow, make sure processor references to new controller services are valid after the processor migrates the configuration of its properties. This change is to update controller service references in the CreatedExtension properties. This is important when calling migrateConfiguration on the component, because that uses the CreatedExtension properties as its "original" properties to migrate. - made sure CreatedExtension was created before the component is updated - made controller service reference value "final" so I can use it inside lambda function - fixed an unrelated but minor log INFO message problem - added unit test for synchronizing a new process group with an external flow definition # Summary [NIFI-12394](https://issues.apache.org/jira/browse/NIFI-12394) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [x] Pull Request based on current revision of the `main` branch - [x] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [x] Build completed using `mvn clean install -P contrib-check` - [x] JDK 21 ### Licensing - [x] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [x] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [x] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-12394) when importing versioned flow with component that migrates properties, controller service reference is invalid
[
https://issues.apache.org/jira/browse/NIFI-12394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael W Moser updated NIFI-12394:
---
Status: Patch Available (was: Open)
> when importing versioned flow with component that migrates properties,
> controller service reference is invalid
> --
>
> Key: NIFI-12394
> URL: https://issues.apache.org/jira/browse/NIFI-12394
> Project: Apache NiFi
> Issue Type: Bug
> Components: Flow Versioning
>Reporter: Michael W Moser
>Assignee: Michael W Moser
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I built a Process Group containing one StandardRestrictedSSLContextService
> that is referenced by one InvokeHTTP processor. I downloaded that Process
> Group as a flow definition {*}with external services{*}. I also versioned
> that Process Group in NiFi Registry.
> Inside the flow definition file, I see the
> StandardRestrictedSSLContextService with
> "identifier":"d7d70b6c-abe4-3564-a219-b289cb7f25d2" and InvokeHTTP references
> that UUID.
> When I create a new Process Group using either the downloaded flow definition
> or the NiFi Registry flow, a new StandardRestrictedSSLContextService is
> created and it has a new UUID as expected. The InvokeHTTP processor is
> invalid because it references the proposed
> StandardRestrictedSSLContextService UUID d7d70b6c-abe4-3564-a219-b289cb7f25d2
> which does not exist.
> The service and processor are created and references are updated, but when
> migrating processor properties and any change occurs, the service reference
> is reverted back to what was in proposedProperties.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799865#comment-17799865
]
Joe Witt commented on NIFI-12513:
-
Code that is released under ASLv2 we can quite literally copy as-is in whole or
part generally. We do have some such code in our codebase today. Anything
considered under a Category-A license in ASF terms is fair game for this. We
just need to carry forward any copyright mechanisms and I think we continue the
good form whereby we list in our notice code we have copied.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799863#comment-17799863
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 3:46 PM:
---
[~exceptionfactory] I found the following [Stackoverflow
Post|https://stackoverflow.com/questions/60324474/how-to-parse-any-url-uri-in-java]
where the question seems to have had the exact problem in the description of
this ticket (i.e. the part about URI construction failing when there are
illegal characters). The suggestion in that post is the use of Spring's
[UriComponentsBuilder|https://github.com/spring-projects/spring-framework/blob/main/spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java].
The questioner responded
??If you are on a non-Spring application the library
org.springframework:spring-web and it's dependencies are a big bunch of code
(~3.4MB at the moment for 5.2.3) just for parsing URIs. But the Regex pattern
URI_PATTERN in the linked code and the fromUriString(String) method seems to be
of great value. And it is under Apache 2 license??
If its under Apache License can we take advantage of the code in a different
form as the questioner seemed to imply? He is right the Regex pattern
URI_PATTERN in the linked code and the fromUriString(String) method seems to be
of great value.
was (Author: JIRAUSER294662):
[~exceptionfactory] I found the following [Stackoverflow
Post|https://stackoverflow.com/questions/60324474/how-to-parse-any-url-uri-in-java]
where the question seems to be the exact problem in the description of this
ticket (i.e. the part about URI construction failing when there are illegal
characters). The suggestion in that post is the use of Spring's
[UriComponentsBuilder|https://github.com/spring-projects/spring-framework/blob/main/spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java].
The questioner responded
??If you are on a non-Spring application the library
org.springframework:spring-web and it's dependencies are a big bunch of code
(~3.4MB at the moment for 5.2.3) just for parsing URIs. But the Regex pattern
URI_PATTERN in the linked code and the fromUriString(String) method seems to be
of great value. And it is under Apache 2 license??
If its under Apache License can we take advantage of the code in a different
form as the questioner seemed to imply? He is right the Regex pattern
URI_PATTERN in the linked code and the fromUriString(String) method seems to be
of great value.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799863#comment-17799863
]
Daniel Stieglitz commented on NIFI-12513:
-
[~exceptionfactory] I found the following [Stackoverflow
Post|https://stackoverflow.com/questions/60324474/how-to-parse-any-url-uri-in-java]
where the question seems to be the exact problem in the description of this
ticket (i.e. the part about URI construction failing when there are illegal
characters). The suggestion in that post is the use of Spring's
[UriComponentsBuilder|https://github.com/spring-projects/spring-framework/blob/main/spring-web/src/main/java/org/springframework/web/util/UriComponentsBuilder.java].
The questioner responded
??If you are on a non-Spring application the library
org.springframework:spring-web and it's dependencies are a big bunch of code
(~3.4MB at the moment for 5.2.3) just for parsing URIs. But the Regex pattern
URI_PATTERN in the linked code and the fromUriString(String) method seems to be
of great value. And it is under Apache 2 license??
If its under Apache License can we take advantage of the code in a different
form as the questioner seemed to imply? He is right the Regex pattern
URI_PATTERN in the linked code and the fromUriString(String) method seems to be
of great value.
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework
[ https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-12400: --- Description: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) *** Add pagination * Counters (NIFI-12415) * Bulletin Board * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Flow Analysis Rules * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * Prevent navigate to Service when configuration form is dirty * Introduce header in new pages to unify with canvas and offer better navigation. * Prompt user to save Parameter Context when Edit form is dirty [1] [https://github.com/apache/nifi/pull/8053] was: The purpose of this Jira is to track all remaining items following the initial commit [1] for NIFI-11481. The description will be kept up to date with remaining features, tasks, and improvements. As each items is worked, a new sub task Jira will be created and referenced in this description. * Support Parameters in Properties with Allowable Values (NIFI-12401) * Summary (NIFI-12437) ** Remaining work not addressed in initial Jira: *** input ports (NIFI-12504) *** output ports (NIFI-12504) *** remote process groups (NIFI-12504) *** process groups (NIFI-12504) *** connections (NIFI-12504) *** System Diagnostics (NIFI-12505) *** support for cluster-specific ui elements (NIFI-12537) * Counters (NIFI-12415) * Bulletin Board * Provenance (NIFI-12445) ** Event Listing (NIFI-12445) ** Search (NIFI-12445) ** Event Dialog (NIFI-12445) ** Lineage (NIFI-12485) ** Replay from context menu (NIFI-12445) * Flow Analysis Rules * Registry Clients (NIFI-12486) * Import from Registry * Parameter Providers * Cluster * Flow Configuration History * Node Status History * Users * Policies * Help * About * Show Upstream/Downstream * Align * List Queue * Empty [all] Queue * View Content * View State * Change Version * PG Version ** Start ** Commit ** Force Commit ** Show changes ** Revert changes ** Change Flow version ** Stop * Configure PG (NIFI-12417) * Process Group Services (NIFI-12425) ** Listing (NIFI-12425) ** Create (NIFI-12425) ** Configure (NIFI-12425) ** Delete (NIFI-12425) ** Enable (NIFI-12529) ** Disable (NIFI-12529) ** Improve layout and breadcrumbs * Configure Processor ** Service Link (NIFI-12425) ** Create inline Service (NIFI-12425) ** Parameter Link (NIFI-12502) ** Convert to Parameter (NIFI-12502) * Download Flow * Create RPG * Configure RPG * RPG Remote Ports * RPG Go To * Color * Move to Front * Copy/Paste * Run unit tests are part of standard build * Update all API calls to consider disconnect node confirmation * Update API calls to use uiOnly flag * Routing error handling * Prevent navigate to Service when configuration form is dirty * Introduce header in new pages to unify with canvas and offer better navigation. * Prompt user to save Parameter Context when Edit form is dirty [1] [https://github.com/apache/nifi/pull/8053] > Remaining items to migrate UI to currently supported/active framework
[jira] [Comment Edited] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799845#comment-17799845
]
Daniel Stieglitz edited comment on NIFI-12513 at 12/22/23 2:10 PM:
---
[~exceptionfactory] [~pvillard]
I am still working out the regular expression. In the meantime there is a
workaround for at least InvokeHttp. For the 'HTTP URL' property use NIFI
Expression Language and before the InvokeHttp processor use an UpdateAttribute
processor to set an attribute with the value of getUri from the NIFI Expression
Language. The value with the URL specified in the description would like
{code:java}
${getUri('https', null, 'en.wikipedia.org', -1, '/w/api.php',
'action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags',
null)}
{code}
was (Author: JIRAUSER294662):
[~exceptionfactory] [~pvillard]
I am still working out the regular expression. In the meantime there is a
workaround for at least InvokeHttp. For the 'HTTP URL' property use NIFI
Expression Language and before the InvokeHttp use UpdateAttribute to set an
attribute with the value of getUri from the NIFI Expression Language. The value
with the URL specified in the description would like
{code:java}
${getUri('https', null, 'en.wikipedia.org', -1, '/w/api.php',
'action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags',
null)}
{code}
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-12513) Regression in InvokeHTTP - Not a valid URL
[
https://issues.apache.org/jira/browse/NIFI-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799845#comment-17799845
]
Daniel Stieglitz commented on NIFI-12513:
-
[~exceptionfactory] [~pvillard]
I am still working out the regular expression. In the meantime there is a
workaround for at least InvokeHttp. For the 'HTTP URL' property use NIFI
Expression Language and before the InvokeHttp use UpdateAttribute to set an
attribute with the value of getUri from the NIFI Expression Language. The value
with the URL specified in the description would like
{code:java}
${getUri('https', null, 'en.wikipedia.org', -1, '/w/api.php',
'action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags',
null)}
{code}
> Regression in InvokeHTTP - Not a valid URL
> --
>
> Key: NIFI-12513
> URL: https://issues.apache.org/jira/browse/NIFI-12513
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 2.0.0-M1, 1.24.0
>Reporter: Pierre Villard
>Assignee: Daniel Stieglitz
>Priority: Major
>
> On NiFi 1.24 and NiFi 2.0-M1, the below URL
> {code:java}
> https://en.wikipedia.org/w/api.php?action=query=recentchanges=json=user|comment|parsedcomment|timestamp|title|sizes|tags{code}
> Is no longer considered as valid but it was a valid one before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12540) Restructure Pages and Add Rewrite Rules for Website Redesign
David Handermann created NIFI-12540: --- Summary: Restructure Pages and Add Rewrite Rules for Website Redesign Key: NIFI-12540 URL: https://issues.apache.org/jira/browse/NIFI-12540 Project: Apache NiFi Issue Type: Improvement Components: Documentation Website Reporter: David Handermann Assignee: David Handermann The Rewrite Rule configuration should be updated to provide automatic redirect for popular pages such and documentation and security reporting. The new design removes the HTML file extension from URLs and also provides the opportunity to restructure some pages. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-12539) Nifi Registry not accept connection in secure mode
[
https://issues.apache.org/jira/browse/NIFI-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799840#comment-17799840
]
David Handermann commented on NIFI-12539:
-
Thanks for highlighting this problem on the current main branch [~taz1988].
Additional changes to upgrade the remainder of the system to Spring Framework 6
and Jetty 12 will address this problem, removing the need for the custom ALPN
Processor.
As an interim workaround, removing {{h2}} from the application protocols
property in {{nifi-registry.properties}} allows Registry to start and run with
HTTPS enabled.
> Nifi Registry not accept connection in secure mode
> --
>
> Key: NIFI-12539
> URL: https://issues.apache.org/jira/browse/NIFI-12539
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Reporter: Zoltán Kornél Török
>Priority: Critical
> Fix For: 2.0.0
>
>
> h3. Problem description
> When you configure nifi-registry to be secure and try to connect to it via
> [https://127.0.0.1:18443/nifi-registry] it will throw the following
> exceptions in the log (and not load the ui and also api calls not works):
> {code:java}
> 2023-12-22 10:48:14,340 WARN [NiFi Registry Web Server-46]
> org.eclipse.jetty.io.ManagedSelector Could not accept
> java.nio.channels.SocketChannel[closed]: java.lang.NoClassDefFoundError:
> org/eclipse/jetty/io/ssl/SslConnection$DecryptedEndPoint {code}
> h3. What cause the problem?
> The problem exists since
> [https://issues.apache.org/jira/projects/NIFI/issues/NIFI-12434] is merged.
> In that ticket the spring version is increased and also the Jetty from
> 11.0.18 to 12.0.3. That cause the problem, because in case of nifi the jetty
> version remained 11.0.18 and there is a code which use
> {color:#00}SslConnection{color}.{color:#00}DecryptedEndPoint{color}
> class:
> [https://github.com/apache/nifi/blob/main/nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/alpn/StandardALPNProcessor.java#L62]
> In case of nifi this is working fine, but the same maven module used in
> nifi-registry as well and in Jetty 12.0.3 the
> {color:#00}SslConnection{color}.{color:#00}DecryptedEndPoint{color}
> class is removed, that is why we got the NoClassDefFoundError and see this.
> h3. Possible solutions?
> * increase jetty version in nifi and refactor code to support new version
> * Duplicate code for nifi-registry and modify for it (not recommended as
> code duplication later could cause trouble)
> * Revert back code change (not recommended as sooner / later definitly need
> to increase versions)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12539) Nifi Registry not accept connection in secure mode
[
https://issues.apache.org/jira/browse/NIFI-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12539:
Affects Version/s: (was: 2.0.0-M1)
> Nifi Registry not accept connection in secure mode
> --
>
> Key: NIFI-12539
> URL: https://issues.apache.org/jira/browse/NIFI-12539
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Affects Versions: 2.0.0
>Reporter: Zoltán Kornél Török
>Priority: Critical
>
> h3. Problem description
> When you configure nifi-registry to be secure and try to connect to it via
> [https://127.0.0.1:18443/nifi-registry] it will throw the following
> exceptions in the log (and not load the ui and also api calls not works):
> {code:java}
> 2023-12-22 10:48:14,340 WARN [NiFi Registry Web Server-46]
> org.eclipse.jetty.io.ManagedSelector Could not accept
> java.nio.channels.SocketChannel[closed]: java.lang.NoClassDefFoundError:
> org/eclipse/jetty/io/ssl/SslConnection$DecryptedEndPoint {code}
> h3. What cause the problem?
> The problem exists since
> [https://issues.apache.org/jira/projects/NIFI/issues/NIFI-12434] is merged.
> In that ticket the spring version is increased and also the Jetty from
> 11.0.18 to 12.0.3. That cause the problem, because in case of nifi the jetty
> version remained 11.0.18 and there is a code which use
> {color:#00}SslConnection{color}.{color:#00}DecryptedEndPoint{color}
> class:
> [https://github.com/apache/nifi/blob/main/nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/alpn/StandardALPNProcessor.java#L62]
> In case of nifi this is working fine, but the same maven module used in
> nifi-registry as well and in Jetty 12.0.3 the
> {color:#00}SslConnection{color}.{color:#00}DecryptedEndPoint{color}
> class is removed, that is why we got the NoClassDefFoundError and see this.
> h3. Possible solutions?
> * increase jetty version in nifi and refactor code to support new version
> * Duplicate code for nifi-registry and modify for it (not recommended as
> code duplication later could cause trouble)
> * Revert back code change (not recommended as sooner / later definitly need
> to increase versions)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12539) Nifi Registry not accept connection in secure mode
[
https://issues.apache.org/jira/browse/NIFI-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12539:
Affects Version/s: (was: 2.0.0)
> Nifi Registry not accept connection in secure mode
> --
>
> Key: NIFI-12539
> URL: https://issues.apache.org/jira/browse/NIFI-12539
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Reporter: Zoltán Kornél Török
>Priority: Critical
>
> h3. Problem description
> When you configure nifi-registry to be secure and try to connect to it via
> [https://127.0.0.1:18443/nifi-registry] it will throw the following
> exceptions in the log (and not load the ui and also api calls not works):
> {code:java}
> 2023-12-22 10:48:14,340 WARN [NiFi Registry Web Server-46]
> org.eclipse.jetty.io.ManagedSelector Could not accept
> java.nio.channels.SocketChannel[closed]: java.lang.NoClassDefFoundError:
> org/eclipse/jetty/io/ssl/SslConnection$DecryptedEndPoint {code}
> h3. What cause the problem?
> The problem exists since
> [https://issues.apache.org/jira/projects/NIFI/issues/NIFI-12434] is merged.
> In that ticket the spring version is increased and also the Jetty from
> 11.0.18 to 12.0.3. That cause the problem, because in case of nifi the jetty
> version remained 11.0.18 and there is a code which use
> {color:#00}SslConnection{color}.{color:#00}DecryptedEndPoint{color}
> class:
> [https://github.com/apache/nifi/blob/main/nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/alpn/StandardALPNProcessor.java#L62]
> In case of nifi this is working fine, but the same maven module used in
> nifi-registry as well and in Jetty 12.0.3 the
> {color:#00}SslConnection{color}.{color:#00}DecryptedEndPoint{color}
> class is removed, that is why we got the NoClassDefFoundError and see this.
> h3. Possible solutions?
> * increase jetty version in nifi and refactor code to support new version
> * Duplicate code for nifi-registry and modify for it (not recommended as
> code duplication later could cause trouble)
> * Revert back code change (not recommended as sooner / later definitly need
> to increase versions)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-12539) Nifi Registry not accept connection in secure mode
[
https://issues.apache.org/jira/browse/NIFI-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann updated NIFI-12539:
Fix Version/s: 2.0.0
> Nifi Registry not accept connection in secure mode
> --
>
> Key: NIFI-12539
> URL: https://issues.apache.org/jira/browse/NIFI-12539
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Registry
>Reporter: Zoltán Kornél Török
>Priority: Critical
> Fix For: 2.0.0
>
>
> h3. Problem description
> When you configure nifi-registry to be secure and try to connect to it via
> [https://127.0.0.1:18443/nifi-registry] it will throw the following
> exceptions in the log (and not load the ui and also api calls not works):
> {code:java}
> 2023-12-22 10:48:14,340 WARN [NiFi Registry Web Server-46]
> org.eclipse.jetty.io.ManagedSelector Could not accept
> java.nio.channels.SocketChannel[closed]: java.lang.NoClassDefFoundError:
> org/eclipse/jetty/io/ssl/SslConnection$DecryptedEndPoint {code}
> h3. What cause the problem?
> The problem exists since
> [https://issues.apache.org/jira/projects/NIFI/issues/NIFI-12434] is merged.
> In that ticket the spring version is increased and also the Jetty from
> 11.0.18 to 12.0.3. That cause the problem, because in case of nifi the jetty
> version remained 11.0.18 and there is a code which use
> {color:#00}SslConnection{color}.{color:#00}DecryptedEndPoint{color}
> class:
> [https://github.com/apache/nifi/blob/main/nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/alpn/StandardALPNProcessor.java#L62]
> In case of nifi this is working fine, but the same maven module used in
> nifi-registry as well and in Jetty 12.0.3 the
> {color:#00}SslConnection{color}.{color:#00}DecryptedEndPoint{color}
> class is removed, that is why we got the NoClassDefFoundError and see this.
> h3. Possible solutions?
> * increase jetty version in nifi and refactor code to support new version
> * Duplicate code for nifi-registry and modify for it (not recommended as
> code duplication later could cause trouble)
> * Revert back code change (not recommended as sooner / later definitly need
> to increase versions)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (NIFI-12539) Nifi Registry not accept connection in secure mode
Zoltán Kornél Török created NIFI-12539:
--
Summary: Nifi Registry not accept connection in secure mode
Key: NIFI-12539
URL: https://issues.apache.org/jira/browse/NIFI-12539
Project: Apache NiFi
Issue Type: Bug
Components: NiFi Registry
Affects Versions: 2.0.0-M1, 2.0.0
Reporter: Zoltán Kornél Török
h3. Problem description
When you configure nifi-registry to be secure and try to connect to it via
[https://127.0.0.1:18443/nifi-registry] it will throw the following exceptions
in the log (and not load the ui and also api calls not works):
{code:java}
2023-12-22 10:48:14,340 WARN [NiFi Registry Web Server-46]
org.eclipse.jetty.io.ManagedSelector Could not accept
java.nio.channels.SocketChannel[closed]: java.lang.NoClassDefFoundError:
org/eclipse/jetty/io/ssl/SslConnection$DecryptedEndPoint {code}
h3. What cause the problem?
The problem exists since
[https://issues.apache.org/jira/projects/NIFI/issues/NIFI-12434] is merged. In
that ticket the spring version is increased and also the Jetty from 11.0.18 to
12.0.3. That cause the problem, because in case of nifi the jetty version
remained 11.0.18 and there is a code which use
{color:#00}SslConnection{color}.{color:#00}DecryptedEndPoint{color}
class:
[https://github.com/apache/nifi/blob/main/nifi-commons/nifi-jetty-configuration/src/main/java/org/apache/nifi/jetty/configuration/connector/alpn/StandardALPNProcessor.java#L62]
In case of nifi this is working fine, but the same maven module used in
nifi-registry as well and in Jetty 12.0.3 the
{color:#00}SslConnection{color}.{color:#00}DecryptedEndPoint{color}
class is removed, that is why we got the NoClassDefFoundError and see this.
h3. Possible solutions?
* increase jetty version in nifi and refactor code to support new version
* Duplicate code for nifi-registry and modify for it (not recommended as code
duplication later could cause trouble)
* Revert back code change (not recommended as sooner / later definitly need to
increase versions)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
