Re: [PR] NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL. [nifi]

2024-03-05 Thread via GitHub
exceptionfactory commented on code in PR #8458: URL: https://github.com/apache/nifi/pull/8458#discussion_r1513778626 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java: ## @@ -1012,7 +1013,7 @@

Re: [PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]

2024-03-05 Thread via GitHub
exceptionfactory commented on PR #8476: URL: https://github.com/apache/nifi/pull/8476#issuecomment-1980030839 I also recommend separating out any GraphClientService changes to their own pull request, as they should be more straightforward to review. -- This is an automated message from

Re: [PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]

2024-03-05 Thread via GitHub
exceptionfactory commented on PR #8476: URL: https://github.com/apache/nifi/pull/8476#issuecomment-198002 I agree that the FlowFile Repository only has part of the information as well, so an end-to-end solution would require some intermediate layer for sending some metadata elsewhere

Re: [PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]

2024-03-05 Thread via GitHub
mattyb149 commented on PR #8476: URL: https://github.com/apache/nifi/pull/8476#issuecomment-1979963149 True, I considered that approach but it relies on the FlowFile repository to be as complete as the provenance repository but doesn't it usually "expire" earlier? That's also why I didn't

Re: [PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]

2024-03-05 Thread via GitHub
mattyb149 commented on PR #8476: URL: https://github.com/apache/nifi/pull/8476#issuecomment-1979923174 If a processor issues an event for each FlowFile or for a whole set, they should all go to the relationship. Without having the relationship name you can still link the events but you

[jira] [Updated] (NIFI-12855) Add more information to provenance events to facilitate full graph traversal

2024-03-05 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-12855: Status: Patch Available (was: In Progress) > Add more information to provenance events to

[PR] NIFI-12855: Add more information to provenance events to facilitate full graph traversal [nifi]

2024-03-05 Thread via GitHub
mattyb149 opened a new pull request, #8476: URL: https://github.com/apache/nifi/pull/8476 # Summary [NIFI-12855](https://issues.apache.org/jira/browse/NIFI-12855) This PR adds additional information to provenance events (such as previous event IDs) to help facilitate its

[jira] [Commented] (NIFI-12630) NPE getLogger in ConsumeSlack

2024-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823812#comment-17823812 ] ASF subversion and git services commented on NIFI-12630: Commit

[jira] [Updated] (NIFI-12630) NPE getLogger in ConsumeSlack

2024-03-05 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-12630: Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available)

Re: [PR] NIFI-12630 Fix NPE getLogger in ConsumeSlack and PublishSlack [nifi]

2024-03-05 Thread via GitHub
mattyb149 closed pull request #8474: NIFI-12630 Fix NPE getLogger in ConsumeSlack and PublishSlack URL: https://github.com/apache/nifi/pull/8474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] NIFI-12630 Fix NPE getLogger in ConsumeSlack and PublishSlack [nifi]

2024-03-05 Thread via GitHub
mattyb149 commented on PR #8474: URL: https://github.com/apache/nifi/pull/8474#issuecomment-1979867767 +1 LGTM, thanks for the fix! Merging to only main until #7673 is backported to support/nifi-1x.x -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (NIFI-12630) NPE getLogger in ConsumeSlack

2024-03-05 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-12630: Affects Version/s: (was: 2.0.0-M1) (was: 1.24.0)

Re: [PR] NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL. [nifi]

2024-03-05 Thread via GitHub
dan-s1 commented on code in PR #8458: URL: https://github.com/apache/nifi/pull/8458#discussion_r1513620936 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java: ## @@ -1012,7 +1013,7 @@ public void

Re: [PR] NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL. [nifi]

2024-03-05 Thread via GitHub
dan-s1 commented on code in PR #8458: URL: https://github.com/apache/nifi/pull/8458#discussion_r1513620936 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java: ## @@ -1012,7 +1013,7 @@ public void

Re: [PR] NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL. [nifi]

2024-03-05 Thread via GitHub
dan-s1 commented on code in PR #8458: URL: https://github.com/apache/nifi/pull/8458#discussion_r1513620936 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java: ## @@ -1012,7 +1013,7 @@ public void

Re: [PR] NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL. [nifi]

2024-03-05 Thread via GitHub
dan-s1 commented on code in PR #8458: URL: https://github.com/apache/nifi/pull/8458#discussion_r1513620936 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java: ## @@ -1012,7 +1013,7 @@ public void

Re: [PR] NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL. [nifi]

2024-03-05 Thread via GitHub
exceptionfactory commented on code in PR #8458: URL: https://github.com/apache/nifi/pull/8458#discussion_r1513612159 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java: ## @@ -1012,7 +1013,7 @@

Re: [PR] NIFI-12721 Button UX [nifi]

2024-03-05 Thread via GitHub
scottyaslan commented on code in PR #8464: URL: https://github.com/apache/nifi/pull/8464#discussion_r1513589282 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss: ## @@ -393,7 +393,7 @@

Re: [PR] NIFI-12721 Button UX [nifi]

2024-03-05 Thread via GitHub
scottyaslan commented on code in PR #8464: URL: https://github.com/apache/nifi/pull/8464#discussion_r1513589096 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/styles.scss: ## @@ -317,7 +317,7 @@ $appFontPath:

Re: [PR] NIFI-12720 BUG - Dark mode skeleton loader styles [nifi]

2024-03-05 Thread via GitHub
james-elliott commented on code in PR #8465: URL: https://github.com/apache/nifi/pull/8465#discussion_r1513571432 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/styles.scss: ## @@ -334,6 +335,9 @@ $appFontPath:

[jira] [Resolved] (NIFI-11446) Better handling for cases where Python process dies

2024-03-05 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-11446. --- Fix Version/s: 2.0.0 Assignee: Mark Payne Resolution: Fixed > Better handling for

[jira] [Resolved] (NIFI-11444) Improve FlowFileTransform to allow returning a String for the content instead of byte[]

2024-03-05 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne resolved NIFI-11444. --- Fix Version/s: 2.0.0 Resolution: Fixed > Improve FlowFileTransform to allow returning a

[jira] [Updated] (NIFI-11443) Setup proper logging for Python framework

2024-03-05 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-11443: -- Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Commented] (NIFI-11443) Setup proper logging for Python framework

2024-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823784#comment-17823784 ] ASF subversion and git services commented on NIFI-11443: Commit

Re: [PR] NIFI-11443 Route Python Framework Logging to SLF4J [nifi]

2024-03-05 Thread via GitHub
markap14 merged PR #8407: URL: https://github.com/apache/nifi/pull/8407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] NIFI-11443 Route Python Framework Logging to SLF4J [nifi]

2024-03-05 Thread via GitHub
markap14 commented on PR #8407: URL: https://github.com/apache/nifi/pull/8407#issuecomment-1979701945 Thanks @exceptionfactory all seems to be working well now. This is a huge improvement! +1 will merge to main -- This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (NIFI-12866) DataTypeUtils long to Timestamp conversion may not handle historical dates correctly

2024-03-05 Thread Jira
Lehel Boér created NIFI-12866: - Summary: DataTypeUtils long to Timestamp conversion may not handle historical dates correctly Key: NIFI-12866 URL: https://issues.apache.org/jira/browse/NIFI-12866

Re: [PR] NIFI-12862 FlowAnalysisResults should not leak anauthorized component details [nifi]

2024-03-05 Thread via GitHub
sardell commented on PR #8475: URL: https://github.com/apache/nifi/pull/8475#issuecomment-1979517205 @tpalfy My mistake. I missed the subjectPermission property in the already-implemented response. Disregard. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513383264 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerServiceResource.java: ## @@ -680,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513382206 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerServiceResource.java: ## @@ -680,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on PR #7734: URL: https://github.com/apache/nifi/pull/7734#issuecomment-1979482152 @markap14 Thank you for the feedback. I've addressed all the changes and concerns provided. The process will now fail if there is a referencing component scope conflict and an error

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513378795 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-service.js: ## @@ -2624,6 +2788,26 @@

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513377994 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerServiceResource.java: ## @@ -680,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513377110 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java: ## @@ -2939,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513376790 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java: ## @@ -2939,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513375471 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java: ## @@ -2939,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513374784 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java: ## @@ -2939,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513374477 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java: ## @@ -2939,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513374037 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java: ## @@ -2939,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513373146 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java: ## @@ -2939,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513373492 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java: ## @@ -2939,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513372649 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java: ## @@ -2939,6

Re: [PR] NIFI-3785 Added feature to move a controller service to it's parent o… [nifi]

2024-03-05 Thread via GitHub
Freedom9339 commented on code in PR #7734: URL: https://github.com/apache/nifi/pull/7734#discussion_r1513372161 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java: ## @@ -2939,6

Re: [PR] NIFI-12862 FlowAnalysisResults should not leak anauthorized component details [nifi]

2024-03-05 Thread via GitHub
tpalfy commented on PR #8475: URL: https://github.com/apache/nifi/pull/8475#issuecomment-1979418892 > @tpalfy Thanks for the quick turnaround. How would the client know if a user has read access permission to a component? By checking all those field returns on each violation and implicitly

Re: [PR] NIFI-12721 Button UX [nifi]

2024-03-05 Thread via GitHub
scottyaslan commented on PR #8464: URL: https://github.com/apache/nifi/pull/8464#issuecomment-1979364266 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] NIFI-12720 BUG - Dark mode skeleton loader styles [nifi]

2024-03-05 Thread via GitHub
scottyaslan commented on code in PR #8465: URL: https://github.com/apache/nifi/pull/8465#discussion_r1513275440 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/styles.scss: ## @@ -334,6 +335,9 @@ $appFontPath:

Re: [PR] NIFI-12862 FlowAnalysisResults should not leak anauthorized component details [nifi]

2024-03-05 Thread via GitHub
sardell commented on PR #8475: URL: https://github.com/apache/nifi/pull/8475#issuecomment-1979342161 @tpalfy Thanks for the quick turnaround. How would the client know if a user has read access permission to a component? By checking all those field returns on each violation and implicitly

Re: [PR] NIFI-11520: Add a menu to display Flow Analysis report results [nifi]

2024-03-05 Thread via GitHub
tpalfy commented on code in PR #8273: URL: https://github.com/apache/nifi/pull/8273#discussion_r1513231844 ## nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js: ## @@ -400,6

[PR] NIFI-12862 FlowAnalysisResults should not leak anauthorized component details [nifi]

2024-03-05 Thread via GitHub
tpalfy opened a new pull request, #8475: URL: https://github.com/apache/nifi/pull/8475 When building FlowAnalysisRuleViolationDTO objects (in StandardNiFiServiceFacade), violating component details will be left blank when user has no read permission for that component.

Re: [PR] MINIFICPP-2283 Create tool to encrypt sensitive properties in config.yml [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
fgerlits commented on code in PR #1725: URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1513225896 ## libminifi/include/core/ProcessGroup.h: ## @@ -205,6 +205,8 @@ class ProcessGroup : public CoreComponent { */ std::shared_ptr

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1513224888 ## extensions/python/PythonScriptEngine.cpp: ## @@ -68,6 +67,73 @@ void initThreads() { #pragma warning(pop) #endif } + +std::string

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1513218719 ## docker/python-verify/conda.Dockerfile: ## @@ -31,14 +31,12 @@ USER root RUN wget https://repo.anaconda.com/archive/Anaconda3-2023.09-0-Linux-x86_64.sh

[jira] [Updated] (MINIFICPP-2312) Do not return shared_ptrs unnecessarily in ControllerServiceMap and ControllerServiceNode

2024-03-05 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-2312: -- Description: There are several functions in and around Controller Service storage

[jira] [Updated] (MINIFICPP-2312) Do not return shared_ptrs unnecessarily in ControllerServiceMap and ControllerServiceNode

2024-03-05 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-2312: -- Description: There are several functions in and around Controller Service storage

[jira] [Created] (MINIFICPP-2312) Do not return shared_ptrs unnecessarily in ControllerServiceMap and ControllerServiceNode

2024-03-05 Thread Ferenc Gerlits (Jira)
Ferenc Gerlits created MINIFICPP-2312: - Summary: Do not return shared_ptrs unnecessarily in ControllerServiceMap and ControllerServiceNode Key: MINIFICPP-2312 URL:

Re: [PR] MINIFICPP-2283 Create tool to encrypt sensitive properties in config.yml [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
szaszm commented on code in PR #1725: URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1513209019 ## libminifi/src/core/json/JsonFlowSerializer.cpp: ## @@ -47,14 +47,21 @@ void JsonFlowSerializer::encryptSensitiveProperties(rapidjson::Value _j }

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
fgerlits commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1512842925 ## extensions/python/PYTHON.md: ## @@ -155,10 +158,33 @@ In the flow configuration these Python processors can be referenced by their ful Due to some

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
lordgamez commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1509271721 ## cmake/MiNiFiOptions.cmake: ## @@ -82,6 +80,8 @@ list(APPEND STRICT_GSL_CHECKS_Values AUDIT ON DEBUG_ONLY OFF) set_property(CACHE STRICT_GSL_CHECKS

[jira] [Commented] (NIFI-12630) NPE getLogger in ConsumeSlack

2024-03-05 Thread Jim Steinebrey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823702#comment-17823702 ] Jim Steinebrey commented on NIFI-12630: --- FYI:  AbstractSessionFactoryProcessor.getLogger() can not

[jira] [Assigned] (NIFI-12630) NPE getLogger in ConsumeSlack

2024-03-05 Thread Jim Steinebrey (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Steinebrey reassigned NIFI-12630: - Assignee: Jim Steinebrey > NPE getLogger in ConsumeSlack >

[PR] NIFI-12630 Fix NPE getLogger in ConsumeSlack and PublishSlack [nifi]

2024-03-05 Thread via GitHub
jrsteinebrey opened a new pull request, #8474: URL: https://github.com/apache/nifi/pull/8474 # Summary [NIFI-12630](https://issues.apache.org/jira/browse/NIFI-12630) # Tracking Please complete the following tracking

Re: [PR] MINIFICPP-2203 Add support for building Windows MSI without any redistributables included [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
martinzink commented on code in PR #1734: URL: https://github.com/apache/nifi-minifi-cpp/pull/1734#discussion_r1513120771 ## cmake/MiNiFiOptions.cmake: ## @@ -82,6 +80,8 @@ list(APPEND STRICT_GSL_CHECKS_Values AUDIT ON DEBUG_ONLY OFF) set_property(CACHE STRICT_GSL_CHECKS

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
martinzink commented on PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#issuecomment-1979056150 > In the same Windows environment I had issues with `vswhere`, I also had issue with the compiler command line after installing vswhere with scoop and refusing the offered

Re: [PR] NIFI-12720 BUG - Dark mode skeleton loader styles [nifi]

2024-03-05 Thread via GitHub
scottyaslan commented on PR #8465: URL: https://github.com/apache/nifi/pull/8465#issuecomment-1979055485 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINIFICPP-1797 Python bootstrap (part 1) [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
martinzink commented on code in PR #1681: URL: https://github.com/apache/nifi-minifi-cpp/pull/1681#discussion_r1513040448 ## bootstrap/package_manager.py: ## @@ -0,0 +1,259 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[jira] [Assigned] (NIFI-12860) Null exception from ExtensionMetadata caused by NIFI-12113

2024-03-05 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann reassigned NIFI-12860: --- Assignee: Peter Radden > Null exception from ExtensionMetadata caused by NIFI-12113

[jira] [Resolved] (NIFI-12860) Null exception from ExtensionMetadata caused by NIFI-12113

2024-03-05 Thread David Handermann (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann resolved NIFI-12860. - Fix Version/s: 2.0.0 1.26.0 Resolution: Fixed > Null exception

[jira] [Commented] (NIFI-12860) Null exception from ExtensionMetadata caused by NIFI-12113

2024-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823677#comment-17823677 ] ASF subversion and git services commented on NIFI-12860: Commit

Re: [PR] NIFI-12860 Null exception from ExtensionMetadata caused by NIFI-12113 [nifi]

2024-03-05 Thread via GitHub
exceptionfactory commented on PR #8467: URL: https://github.com/apache/nifi/pull/8467#issuecomment-1979032317 Thanks @pradden, merged in commit https://github.com/apache/nifi/commit/785039e1d0d9e33875622be0d7cfb2d4d42a2b37 -- This is an automated message from the Apache Git Service. To

Re: [PR] NIFI-12860 Null exception from ExtensionMetadata caused by NIFI-12113 [nifi]

2024-03-05 Thread via GitHub
exceptionfactory closed pull request #8467: NIFI-12860 Null exception from ExtensionMetadata caused by NIFI-12113 URL: https://github.com/apache/nifi/pull/8467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (NIFI-12860) Null exception from ExtensionMetadata caused by NIFI-12113

2024-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823673#comment-17823673 ] ASF subversion and git services commented on NIFI-12860: Commit

Re: [PR] NIFI-12860 Null exception from ExtensionMetadata caused by NIFI-12113 [nifi]

2024-03-05 Thread via GitHub
exceptionfactory closed pull request #8468: NIFI-12860 Null exception from ExtensionMetadata caused by NIFI-12113 URL: https://github.com/apache/nifi/pull/8468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (NIFI-12846) AWS Assume Role Credentials with VPCE Endpoint URL cannot handle the Region

2024-03-05 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-12846: -- Fix Version/s: 1.26.0 Resolution: Fixed Status: Resolved (was: Patch

[jira] [Commented] (NIFI-12846) AWS Assume Role Credentials with VPCE Endpoint URL cannot handle the Region

2024-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823651#comment-17823651 ] ASF subversion and git services commented on NIFI-12846: Commit

Re: [PR] NIFI-12846 Fixed Region handling for AWS Assume Role Credentials with… [nifi]

2024-03-05 Thread via GitHub
pvillard31 commented on PR #8473: URL: https://github.com/apache/nifi/pull/8473#issuecomment-1978920487 Merged in 1.x via 436f63c52b62a37c256a272b107cce380414df25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] NIFI-12846 Fixed Region handling for AWS Assume Role Credentials with… [nifi]

2024-03-05 Thread via GitHub
pvillard31 closed pull request #8473: NIFI-12846 Fixed Region handling for AWS Assume Role Credentials with… URL: https://github.com/apache/nifi/pull/8473 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] NIFI-11443 Route Python Framework Logging to SLF4J [nifi]

2024-03-05 Thread via GitHub
exceptionfactory commented on PR #8407: URL: https://github.com/apache/nifi/pull/8407#issuecomment-1978901124 Thanks for the feedback @markap14, I rebased to incorporate the recent Python framework improvements, and also addressed the comments regarding log writing and exception handling.

Re: [PR] NIFI-11443 Route Python Framework Logging to SLF4J [nifi]

2024-03-05 Thread via GitHub
exceptionfactory commented on code in PR #8407: URL: https://github.com/apache/nifi/pull/8407#discussion_r1512922173 ## nifi-nar-bundles/nifi-py4j-bundle/nifi-py4j-bridge/src/main/java/org/apache/nifi/py4j/PythonProcessLogReader.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to

Re: [PR] MINIFICPP-2283 Create tool to encrypt sensitive properties in config.yml [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
szaszm commented on code in PR #1725: URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1512874899 ## libminifi/src/core/json/JsonFlowSerializer.cpp: ## @@ -47,14 +47,21 @@ void JsonFlowSerializer::encryptSensitiveProperties(rapidjson::Value _j }

Re: [PR] MINIFICPP-2283 Create tool to encrypt sensitive properties in config.yml [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
szaszm commented on code in PR #1725: URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1512869627 ## libminifi/include/core/ProcessGroup.h: ## @@ -205,6 +205,8 @@ class ProcessGroup : public CoreComponent { */ std::shared_ptr

[jira] [Resolved] (NIFI-10883) SnowflakeComputingConnectionPool fails on Java 21

2024-03-05 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi resolved NIFI-10883. Resolution: Information Provided > SnowflakeComputingConnectionPool fails on Java 21 >

[jira] [Updated] (NIFI-12760) [MiNiFi] MiNiFi toolkit encrypt config should support encrypting flow.json.raw file

2024-03-05 Thread Ferenc Erdei (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Erdei updated NIFI-12760: Fix Version/s: 2.0.0 Resolution: Fixed Status: Resolved (was: Patch Available)

Re: [PR] NIFI-11107 In ConsumeIMAP and ConsumePOP3 added support for OAUTH based authorization. [nifi]

2024-03-05 Thread via GitHub
AnTu2702 commented on PR #6900: URL: https://github.com/apache/nifi/pull/6900#issuecomment-1978792542 @tpalfy You may be right. I just tested the refresh mechanism (not did not wait the 3600 s until the first access token really expired) with my intended fix that morning. But the

[jira] [Commented] (NIFI-12760) [MiNiFi] MiNiFi toolkit encrypt config should support encrypting flow.json.raw file

2024-03-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823619#comment-17823619 ] ASF subversion and git services commented on NIFI-12760: Commit

Re: [PR] NIFI-12760 Flow sensitive properties encryption support in toolkit [nifi]

2024-03-05 Thread via GitHub
ferencerdei closed pull request #8430: NIFI-12760 Flow sensitive properties encryption support in toolkit URL: https://github.com/apache/nifi/pull/8430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (NIFI-10883) SnowflakeComputingConnectionPool fails on Java 21

2024-03-05 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-10883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823618#comment-17823618 ] Peter Turcsanyi commented on NIFI-10883:

Re: [PR] NIFI-11107 In ConsumeIMAP and ConsumePOP3 added support for OAUTH based authorization. [nifi]

2024-03-05 Thread via GitHub
tpalfy commented on PR #6900: URL: https://github.com/apache/nifi/pull/6900#issuecomment-1978692871 Thanks @AnTu2702 and @RomanOttGmx for the explanaion. As for your fix @AnTu2702 I'm a bit confused though. If we only refresh the token but don't rebuild the url I don't see how that

[jira] [Updated] (NIFI-12846) AWS Assume Role Credentials with VPCE Endpoint URL cannot handle the Region

2024-03-05 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-12846: --- Status: Patch Available (was: Open) > AWS Assume Role Credentials with VPCE Endpoint URL

[PR] NIFI-12846 Fixed Region handling for AWS Assume Role Credentials with… [nifi]

2024-03-05 Thread via GitHub
turcsanyip opened a new pull request, #8473: URL: https://github.com/apache/nifi/pull/8473 … VPCE Endpoint URL # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request

Re: [PR] NIFI-11107 In ConsumeIMAP and ConsumePOP3 added support for OAUTH based authorization. [nifi]

2024-03-05 Thread via GitHub
AnTu2702 commented on PR #6900: URL: https://github.com/apache/nifi/pull/6900#issuecomment-1978453332 I was able to build and deploy a local nar file... ![image](https://github.com/apache/nifi/assets/5054213/e928c7a9-a80a-4f24-8aea-643e1cb03ebf) ...working fine with the patch!

[jira] [Created] (MINIFICPP-2311) Initial support for recordset readers and writers

2024-03-05 Thread Martin Zink (Jira)
Martin Zink created MINIFICPP-2311: -- Summary: Initial support for recordset readers and writers Key: MINIFICPP-2311 URL: https://issues.apache.org/jira/browse/MINIFICPP-2311 Project: Apache NiFi

Re: [PR] MINIFICPP-2282 Support re-encryption of sensitive properties [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
fgerlits commented on code in PR #1739: URL: https://github.com/apache/nifi-minifi-cpp/pull/1739#discussion_r1512504892 ## encrypt-config/FlowConfigEncryptor.cpp: ## @@ -61,114 +62,150 @@ std::vector listSensitiveProperties(const minifi::core::Proce std::vector

Re: [PR] MINIFICPP-2283 Create tool to encrypt sensitive properties in config.yml [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
fgerlits commented on code in PR #1725: URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1512455086 ## libminifi/src/core/json/JsonFlowSerializer.cpp: ## @@ -47,14 +47,21 @@ void JsonFlowSerializer::encryptSensitiveProperties(rapidjson::Value _j }

Re: [PR] MINIFICPP-2283 Create tool to encrypt sensitive properties in config.yml [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
fgerlits commented on code in PR #1725: URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1512449471 ## libminifi/src/core/json/JsonFlowSerializer.cpp: ## @@ -47,14 +47,21 @@ void JsonFlowSerializer::encryptSensitiveProperties(rapidjson::Value _j }

Re: [PR] MINIFICPP-2283 Create tool to encrypt sensitive properties in config.yml [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
fgerlits commented on code in PR #1725: URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1512442049 ## libminifi/include/core/ProcessGroup.h: ## @@ -205,6 +205,8 @@ class ProcessGroup : public CoreComponent { */ std::shared_ptr

Re: [PR] NIFI-11107 In ConsumeIMAP and ConsumePOP3 added support for OAUTH based authorization. [nifi]

2024-03-05 Thread via GitHub
AnTu2702 commented on PR #6900: URL: https://github.com/apache/nifi/pull/6900#issuecomment-1978198291 > @AnTu2702 The `oauth2AccessTokenProviderOptional` field is used in the `buildUrl` method where we call `oauth2AccessTokenProvider.getAccessDetails().getAccessToken()`. The

[jira] [Commented] (NIFI-12859) OAUTH2 Token Refresh not working in AbstractEmailProcessor

2024-03-05 Thread Andreas Tully (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823484#comment-17823484 ] Andreas Tully commented on NIFI-12859: -- There is already an ongoing discussion about this here:

[jira] [Comment Edited] (NIFI-12859) OAUTH2 Token Refresh not working in AbstractEmailProcessor

2024-03-05 Thread Andreas Tully (Jira)
[ https://issues.apache.org/jira/browse/NIFI-12859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823131#comment-17823131 ] Andreas Tully edited comment on NIFI-12859 at 3/5/24 8:14 AM: -- I debugged

Re: [PR] NIFI-11107 In ConsumeIMAP and ConsumePOP3 added support for OAUTH based authorization. [nifi]

2024-03-05 Thread via GitHub
AnTu2702 commented on PR #6900: URL: https://github.com/apache/nifi/pull/6900#issuecomment-1978169106 Overview: ![image](https://github.com/apache/nifi/assets/5054213/6609d552-3cb7-4992-904e-f81c9bf0f5ae) ConsumeImap: