date:20240412



mcgilman commented on code in PR #8273:
URL: https://github.com/apache/nifi/pull/8273#discussion_r1563327796


##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/flow-analysis-drawer.jsp:
##
@@ -0,0 +1,84 @@
+<%--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+  contributor license agreements.  See the NOTICE file distributed with
+  this work for additional information regarding copyright ownership.
+  The ASF licenses this file to You under the Apache License, Version 2.0
+  (the "License"); you may not use this file except in compliance with
+  the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+--%>
+<%@ page contentType="text/html" pageEncoding="UTF-8" session="false" %>
+
+
+
+Rules analysis pending...
+
+
+
+Flow Guide
+
+
+
+Show enforced violations
+
+
+
+Show warning violations
+
+
+
+NiFi Flow
+
+
+
+
+
+Enforced Rules 
+
+
+
+
+
+
+
+Warning Rules 
+
+
+
+
+
+
+Enforced Violations 
+
+
+
+
+
+
+Warning Violations 
+
+
+
+
+
+
+View Documentation
+Edit Rule
+
+
+
+
+
+Violation details
+Go to 
component

Review Comment:
   Minor but I noticed inconsistent enabled states on the icons in the context 
menu.
   
   https://github.com/apache/nifi/assets/123395/460a95c2-c84b-46e0-9c1e-c9854efec757;>
   
   https://github.com/apache/nifi/assets/123395/2ca6f9bd-ef6c-4426-ae4a-0aed7b2a02d9;>
   



##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/controllers/nf-ng-canvas-flow-status-controller.js:
##
@@ -400,6 +406,562 @@
 }
 }
 
+/**
+ * The flow analysis controller.
+ */
+
+this.flowAnalysis = {
+
+/**
+ * Create the list of rule violations
+ */
+buildRuleViolationsList: function(rules, violationsAndRecs) {
+var ruleViolationCountEl = $('#rule-violation-count');
+var ruleViolationListEl = $('#rule-violations-list');
+var ruleWarningCountEl = $('#rule-warning-count');
+var ruleWarningListEl = $('#rule-warnings-list');
+var violations = violationsAndRecs.filter(function 
(violation) {
+return violation.enforcementPolicy === 'ENFORCE'
+});
+var warnings = violationsAndRecs.filter(function 
(violation) {
+return violation.enforcementPolicy === 'WARN'
+});
+ruleViolationCountEl.empty().text('(' + violations.length 
+ ')');
+ruleWarningCountEl.empty().text('(' + warnings.length + 
')');
+ruleViolationListEl.empty();
+ruleWarningListEl.empty();
+violations.forEach(function(violation) {
+var rule = rules.find(function(rule) {
+return rule.id === violation.ruleId;
+});
+// create DOM elements
+var violationListItemEl = $('');
+var violationEl = $('');
+var violationListItemWrapperEl = $('');
+var violationRuleEl = $('');
+var violationListItemNameEl = $('');
+var violationListItemIdEl = $('');
+var violationInfoButtonEl = $('');
+
+// add text content and button data
+$(violationRuleEl).text(rule.name);
+violation.subjectPermissionDto.canRead ? 
$(violationListItemNameEl).text(violation.subjectDisplayName) : 
$(violationListItemNameEl).text('Unauthorized').addClass('unauthorized');
+

[jira] [Updated] (NIFI-13042) Support Python 3.12 for Python Processors



 [ 
https://issues.apache.org/jira/browse/NIFI-13042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13042:

Status: Patch Available  (was: Open)

> Support Python 3.12 for Python Processors
> -
>
> Key: NIFI-13042
> URL: https://issues.apache.org/jira/browse/NIFI-13042
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0-M3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> NiFi 2.0.0-M1 and M2 support Python Processors with Python 3.11, but 
> attempting to start NiFi with Python 3.12 results in the following error:
> {noformat}
> ERROR [python-log-29812] py4j.java_gateway Error while waiting for a 
> connection.
> Traceback (most recent call last):
>   File "nifi-2.0.0-SNAPSHOT/python/framework/py4j/java_gateway.py", line 
> 2304, in run
> connection.start()
>   File "python3.12/threading.py", line 992, in start
> _start_new_thread(self._bootstrap, ())
> RuntimeError: can't create new thread at interpreter shutdown
> {noformat}
> This issue follows the pattern of [CPython Issue 
> 115533|https://github.com/python/cpython/issues/115533], which describes 
> changes in Python 3.12 to prevent spawning new threads when the main Python 
> process has finalized.
> In the context of the NiFi Python Framework, this applies to the 
> Controller.py main method, which is responsible for starting the Py4J gateway 
> to communicate between Java and Python processes.
> Following the workaround proposed in the CPython issue discussion, the main 
> function in Controller.py can be adjusted to join to non-daemon threads. This 
> maintains the association between the Python main function and threads spawn 
> for Py4J socket communication.
> In addition to this thread issue, the Python FileFinder 
> [find_module|https://docs.python.org/3.10/library/importlib.html#importlib.abc.PathEntryFinder.find_module]
>  has been deprecated since Python 3.4 and was removed in Python 3.12. Usage 
> of {{find_module}} in ExtensionsManager.py should be replaced with 
> {{find_spec}} which provide equivalent functionality.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] NIFI-13042 Support Python 3.12 for Python Processors [nifi]



exceptionfactory opened a new pull request, #8644:
URL: https://github.com/apache/nifi/pull/8644

   # Summary
   
   [NIFI-13042](https://issues.apache.org/jira/browse/NIFI-13042) Updates 
`Controller.py` and `ExtensionManager.py` to provide framework compatibility 
with Python 3.12.
   
   Updates to `Controller.py` include joining to non-daemon threads at the 
conclusion of the `main` function, avoiding a `RuntimeError` thrown in Python 
3.12 as a result of increased protections against spawning new child threads 
after finalization of the main process. This approach follows the 
recommendation from [CPython Issue 
115533](https://github.com/python/cpython/issues/115533#issuecomment-1959143451).
 This is necessary for the NiFi `Controller.py` because the `main` function 
otherwise completes, but Py4J socket threads must continue running.
   
   Updates to `ExtensionManager.py` include replacing the deprecated 
[find_module](https://docs.python.org/3.10/library/importlib.html#importlib.machinery.PathFinder.find_module)
 method with the recommend 
[find_spec](https://docs.python.org/3.10/library/importlib.html#importlib.machinery.PathFinder.find_spec)
 method. The `find_spec` method was added in Python 3.4 and `find_module` was 
removed in Python 3.12.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (NIFI-13042) Support Python 3.12 for Python Processors

David Handermann created NIFI-13042:
---

 Summary: Support Python 3.12 for Python Processors
 Key: NIFI-13042
 URL: https://issues.apache.org/jira/browse/NIFI-13042
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework
Reporter: David Handermann
Assignee: David Handermann
 Fix For: 2.0.0-M3


NiFi 2.0.0-M1 and M2 support Python Processors with Python 3.11, but attempting 
to start NiFi with Python 3.12 results in the following error:

{noformat}
ERROR [python-log-29812] py4j.java_gateway Error while waiting for a connection.
Traceback (most recent call last):
  File "nifi-2.0.0-SNAPSHOT/python/framework/py4j/java_gateway.py", line 2304, 
in run
connection.start()
  File "python3.12/threading.py", line 992, in start
_start_new_thread(self._bootstrap, ())
RuntimeError: can't create new thread at interpreter shutdown
{noformat}

This issue follows the pattern of [CPython Issue 
115533|https://github.com/python/cpython/issues/115533], which describes 
changes in Python 3.12 to prevent spawning new threads when the main Python 
process has finalized.

In the context of the NiFi Python Framework, this applies to the Controller.py 
main method, which is responsible for starting the Py4J gateway to communicate 
between Java and Python processes.

Following the workaround proposed in the CPython issue discussion, the main 
function in Controller.py can be adjusted to join to non-daemon threads. This 
maintains the association between the Python main function and threads spawn 
for Py4J socket communication.

In addition to this thread issue, the Python FileFinder 
[find_module|https://docs.python.org/3.10/library/importlib.html#importlib.abc.PathEntryFinder.find_module]
 has been deprecated since Python 3.4 and was removed in Python 3.12. Usage of 
{{find_module}} in ExtensionsManager.py should be replaced with {{find_spec}} 
which provide equivalent functionality.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (NIFI-13041) UI - Birdseye should honor color

2024-04-12 Thread Scott Aslan (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-13041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Scott Aslan updated NIFI-13041:
---
Status: Patch Available  (was: In Progress)

> UI - Birdseye should honor color
> 
>
> Key: NIFI-13041
> URL: https://issues.apache.org/jira/browse/NIFI-13041
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (NIFI-13041) UI - Birdseye should honor color

2024-04-12 Thread Scott Aslan (Jira)

Scott Aslan created NIFI-13041:
--

 Summary: UI - Birdseye should honor color
 Key: NIFI-13041
 URL: https://issues.apache.org/jira/browse/NIFI-13041
 Project: Apache NiFi
  Issue Type: Sub-task
Reporter: Scott Aslan
Assignee: Scott Aslan






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (NIFI-12970) Generate documentation for Python processors

2024-04-12 Thread ASF subversion and git services (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-12970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-12970.
-
Fix Version/s: 2.0.0-M3
   Resolution: Fixed

> Generate documentation for Python processors
> 
>
> Key: NIFI-12970
> URL: https://issues.apache.org/jira/browse/NIFI-12970
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mark Bathori
>Assignee: Mark Bathori
>Priority: Major
> Fix For: 2.0.0-M3
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently there is no documentation generation for Python processors and the 
> existing logic relies on Java defined code. The java side representation of 
> Python processors is the *PythonProcessorDetails* class which is used to 
> access the processor's data. Since the current implementation of the document 
> generator requires the processor class to be inherited from the 
> *ConfigurableComponent* class, we need an additional implementation for the 
> Python processors that is based on the *PythonProcessorDetails* class. 
> Additionally the list of the Python processors needs to be passed to the UI 
> to make the documentations accessible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (NIFI-12970) Generate documentation for Python processors



[ 
https://issues.apache.org/jira/browse/NIFI-12970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836742#comment-17836742
 ] 

ASF subversion and git services commented on NIFI-12970:


Commit 26e5f5a565950a4de8ded985df549c5b659a68a1 in nifi's branch 
refs/heads/main from Mark Bathori
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=26e5f5a565 ]

NIFI-12970 Generate documentation for Python Processors

This closes #8579

Signed-off-by: David Handermann 


> Generate documentation for Python processors
> 
>
> Key: NIFI-12970
> URL: https://issues.apache.org/jira/browse/NIFI-12970
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mark Bathori
>Assignee: Mark Bathori
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Currently there is no documentation generation for Python processors and the 
> existing logic relies on Java defined code. The java side representation of 
> Python processors is the *PythonProcessorDetails* class which is used to 
> access the processor's data. Since the current implementation of the document 
> generator requires the processor class to be inherited from the 
> *ConfigurableComponent* class, we need an additional implementation for the 
> Python processors that is based on the *PythonProcessorDetails* class. 
> Additionally the list of the Python processors needs to be passed to the UI 
> to make the documentations accessible.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] NIFI-12970: Generate documentation for Python processors [nifi]



exceptionfactory closed pull request #8579: NIFI-12970: Generate documentation 
for Python processors
URL: https://github.com/apache/nifi/pull/8579


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-13040) Upgrade Commons IO to 2.16.1



 [ 
https://issues.apache.org/jira/browse/NIFI-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13040:

Status: Patch Available  (was: Open)

> Upgrade Commons IO to 2.16.1
> 
>
> Key: NIFI-13040
> URL: https://issues.apache.org/jira/browse/NIFI-13040
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Labels: backport-needed
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Apache Commons IO should be upgraded to 
> [2.16.1|https://commons.apache.org/proper/commons-io/changes-report.html#a2.16.1]
>  to incorporate a number of bug fixes and improvements.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (NIFI-13040) Upgrade Commons IO to 2.16.1



 [ 
https://issues.apache.org/jira/browse/NIFI-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13040:

Priority: Minor  (was: Major)

> Upgrade Commons IO to 2.16.1
> 
>
> Key: NIFI-13040
> URL: https://issues.apache.org/jira/browse/NIFI-13040
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
>  Labels: backport-needed
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Apache Commons IO should be upgraded to 
> [2.16.1|https://commons.apache.org/proper/commons-io/changes-report.html#a2.16.1]
>  to incorporate a number of bug fixes and improvements.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] NIFI-13040 Upgrade Commons IO from 2.15.1 to 2.16.1 [nifi]



exceptionfactory opened a new pull request, #8642:
URL: https://github.com/apache/nifi/pull/8642

   # Summary
   
   [NIFI-13040](https://issues.apache.org/jira/browse/NIFI-13040) Upgrades 
Apache Commons IO from 2.15.1 to 
[2.16.1](https://commons.apache.org/proper/commons-io/changes-report.html#a2.16.1)
 incorporating a number of bug fixes and improvements.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (NIFI-13040) Upgrade Commons IO to 2.16.1

David Handermann created NIFI-13040:
---

 Summary: Upgrade Commons IO to 2.16.1
 Key: NIFI-13040
 URL: https://issues.apache.org/jira/browse/NIFI-13040
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework, Extensions
Reporter: David Handermann
Assignee: David Handermann


Apache Commons IO should be upgraded to 
[2.16.1|https://commons.apache.org/proper/commons-io/changes-report.html#a2.16.1]
 to incorporate a number of bug fixes and improvements.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (NIFI-13039) Provide default implementations for method overloads in ProcessSession

2024-04-12 Thread endzeit (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

endzeit updated NIFI-13039:
---
Description: 
While going through the JavaDoc of ProcessSession in NIFI-12986, I noticed that 
_void commitAsync();_ and _FlowFile merge(Collection sources, 
FlowFile destination);_ are overloads of their respective "sibling" functions.
As discussed in the [PR 
#8620|https://github.com/apache/nifi/pull/8620#issuecomment-2050053994], it 
makes sense to provide default implementations that utilize the "sibling" 
functions with more parameters and remove the existing implementations.


  was:
While going through the JavaDoc of ProcessSession in NIFI-12986, I noticed that 
_void commitAsync();_ and _FlowFile merge(Collection sources, 
FlowFile destination);_ are overloads of their respective "sibling" functions.
As discussed in the [PR #8620|https://github.com/apache/nifi/pull/8620], it 
makes sense to provide default implementations that utilize the "sibling" 
functions with more parameters and remove the existing implementations.



> Provide default implementations for method overloads in ProcessSession
> --
>
> Key: NIFI-13039
> URL: https://issues.apache.org/jira/browse/NIFI-13039
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: endzeit
>Priority: Major
>
> While going through the JavaDoc of ProcessSession in NIFI-12986, I noticed 
> that _void commitAsync();_ and _FlowFile merge(Collection sources, 
> FlowFile destination);_ are overloads of their respective "sibling" functions.
> As discussed in the [PR 
> #8620|https://github.com/apache/nifi/pull/8620#issuecomment-2050053994], it 
> makes sense to provide default implementations that utilize the "sibling" 
> functions with more parameters and remove the existing implementations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (NIFI-13039) Provide default implementations for method overloads in ProcessSession

2024-04-12 Thread endzeit (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-13039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

endzeit updated NIFI-13039:
---
Description: 
While going through the JavaDoc of ProcessSession in NIFI-12986, I noticed that 
_void commitAsync();_ and _FlowFile merge(Collection sources, 
FlowFile destination);_ are overloads of their respective "sibling" functions.
As discussed in the [PR #8620|https://github.com/apache/nifi/pull/8620], it 
makes sense to provide default implementations that utilize the "sibling" 
functions with more parameters and remove the existing implementations.


  was:
While going through the JavaDoc of ProcessSession in NIFI-12986, I noticed that 
_void commitAsync();_ and _FlowFile merge(Collection sources, 
FlowFile destination);_ are overloads of their respective "sibling" functions.
As discussed in the PR with more parameters but do not define a default 
implementation.



> Provide default implementations for method overloads in ProcessSession
> --
>
> Key: NIFI-13039
> URL: https://issues.apache.org/jira/browse/NIFI-13039
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: endzeit
>Priority: Major
>
> While going through the JavaDoc of ProcessSession in NIFI-12986, I noticed 
> that _void commitAsync();_ and _FlowFile merge(Collection sources, 
> FlowFile destination);_ are overloads of their respective "sibling" functions.
> As discussed in the [PR #8620|https://github.com/apache/nifi/pull/8620], it 
> makes sense to provide default implementations that utilize the "sibling" 
> functions with more parameters and remove the existing implementations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (NIFI-13039) Provide default implementations for method overloads in ProcessSession

2024-04-12 Thread endzeit (Jira)

endzeit created NIFI-13039:
--

 Summary: Provide default implementations for method overloads in 
ProcessSession
 Key: NIFI-13039
 URL: https://issues.apache.org/jira/browse/NIFI-13039
 Project: Apache NiFi
  Issue Type: Sub-task
Reporter: endzeit


While going through the JavaDoc of ProcessSession in NIFI-12986, I noticed that 
_void commitAsync();_ and _FlowFile merge(Collection sources, 
FlowFile destination);_ are overloads of their respective "sibling" functions.
As discussed in the PR with more parameters but do not define a default 
implementation.




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] [NIFI-13035] remove angular2jwt and update to node 21 except in registry [nifi]



scottyaslan opened a new pull request, #8641:
URL: https://github.com/apache/nifi/pull/8641

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-13038) Upgrade Groovy to 4.0.21



 [ 
https://issues.apache.org/jira/browse/NIFI-13038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13038:

Status: Patch Available  (was: Open)

> Upgrade Groovy to 4.0.21
> 
>
> Key: NIFI-13038
> URL: https://issues.apache.org/jira/browse/NIFI-13038
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0-M3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Groovy dependencies should be upgraded to 
> [4.0.21|http://groovy-lang.org/changelogs/changelog-4.0.21.html] to 
> incorporate several transitive dependency upgrades.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] NIFI-13038 Upgrade Groovy from 4.0.20 to 4.0.21 [nifi]



exceptionfactory opened a new pull request, #8640:
URL: https://github.com/apache/nifi/pull/8640

   # Summary
   
   [NIFI-13038](https://issues.apache.org/jira/browse/NIFI-13038) Upgrades 
Groovy from 4.0.20 to 
[4.0.21](http://groovy-lang.org/changelogs/changelog-4.0.21.html) incorporating 
several transitive dependency upgrades.
   
   This upgrade applies to the main branch only.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (NIFI-13038) Upgrade Groovy to 4.0.21

David Handermann created NIFI-13038:
---

 Summary: Upgrade Groovy to 4.0.21
 Key: NIFI-13038
 URL: https://issues.apache.org/jira/browse/NIFI-13038
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Extensions
Reporter: David Handermann
Assignee: David Handermann
 Fix For: 2.0.0-M3


Groovy dependencies should be upgraded to 
[4.0.21|http://groovy-lang.org/changelogs/changelog-4.0.21.html] to incorporate 
several transitive dependency upgrades.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (NIFI-5519) Allow ListDatabaseTables to accept incoming connections

2024-04-12 Thread Jim Steinebrey (Jira)



[ 
https://issues.apache.org/jira/browse/NIFI-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836733#comment-17836733
 ] 

Jim Steinebrey commented on NIFI-5519:
--

https://github.com/apache/nifi/pull/8639

> Allow ListDatabaseTables to accept incoming connections
> ---
>
> Key: NIFI-5519
> URL: https://issues.apache.org/jira/browse/NIFI-5519
> Project: Apache NiFi
>  Issue Type: Wish
>Reporter: Matt Burgess
>Assignee: Jim Steinebrey
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> As of [NIFI-5229|https://issues.apache.org/jira/browse/NIFI-5229], 
> DBCPConnectionPoolLookup allows the dynamic selection of a DBCPConnectionPool 
> by name. This allows processors who are to perform the same work on multiple 
> databases to be able to do so by providing individual flow files upstream 
> with the database.name attribute set.
> However ListDatabaseTables does not accept incoming connections, so you 
> currently need 1 DBCPConnectionPool per database, plus 1 ListDatabaseTables 
> per database, each using a corresponding DBCPConnectionPool. It would be nice 
> if ListDatabaseTables could accept incoming connection(s), if only to provide 
> attributes for selecting the DBCPConnectionPool.
> I propose the behavior be like other processors that can generate data with 
> or without an incoming connection (such as GenerateTableFetch, see 
> [NIFI-2881|https://issues.apache.org/jira/browse/NIFI-2881] for details). In 
> general that means if there is an incoming non-loop connection, it becomes 
> more "event-driven" in the sense that it will not execute if there is no 
> FlowFile on which to work. If there is no incoming connection, then it would 
> run as it always has, on its Run Schedule and with State Management, so as 
> not to re-list the same tables every time it executes. 
> However with an incoming connection and an available FlowFile, the behavior 
> could be that all tables for that database are listed, meaning that processor 
> state would not be updated nor queried, making it fully "event-driven". If 
> the tables for a database are not to be re-listed, the onus would be on the 
> upstream flow to not send a flow file for that database. This is not a 
> requirement, just a suggestion; it could be more flexible by honoring 
> processor state if the Refresh Interval is non-zero, but I think that adds 
> too much complexity for the user, for little payoff.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]



jrsteinebrey opened a new pull request, #8639:
URL: https://github.com/apache/nifi/pull/8639

   …nc up code in GenerateTableFetch to have its incoming connection work 
better like ListDatabaseTables.
   
   
   
   
   
   
   
   
   
   
   
   
   
   
   # Summary
   
   [NIFI-5519](https://issues.apache.org/jira/browse/NIFI-5519)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI-5519) 
issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-5519`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-5519`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   I added new unit tests for incoming flow files for ListDatabaseTables.
   I also tested ListDatabaseTables and GenerateTableFetch in the NiFi UI.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 21
   
   ### Licensing
   
   No new dependencies
   
   ### Documentation
   
   - [X] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-13037) Upgrade Spring Framework to 5.3.34 on Support Branch



 [ 
https://issues.apache.org/jira/browse/NIFI-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13037:

Status: Patch Available  (was: Open)

> Upgrade Spring Framework to 5.3.34 on Support Branch
> 
>
> Key: NIFI-13037
> URL: https://issues.apache.org/jira/browse/NIFI-13037
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, MiNiFi, NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.26.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Spring Framework dependencies on the support branch should be upgraded to 
> version 
> [5.3.34|https://github.com/spring-projects/spring-framework/releases/tag/v5.3.34]
>  to resolve several flagged vulnerabilities. Spring Security should be 
> upgraded to 5.8.11 and Jetty should be upgraded to 
> [9.4.54|https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.54.v20240208]
>  to resolve CVE-2024-22201 related to HTTP/2 connection closing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (NIFI-5519) Allow ListDatabaseTables to accept incoming connections

2024-04-12 Thread Jim Steinebrey (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-5519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jim Steinebrey reassigned NIFI-5519:


Assignee: Jim Steinebrey

> Allow ListDatabaseTables to accept incoming connections
> ---
>
> Key: NIFI-5519
> URL: https://issues.apache.org/jira/browse/NIFI-5519
> Project: Apache NiFi
>  Issue Type: Wish
>Reporter: Matt Burgess
>Assignee: Jim Steinebrey
>Priority: Major
>
> As of [NIFI-5229|https://issues.apache.org/jira/browse/NIFI-5229], 
> DBCPConnectionPoolLookup allows the dynamic selection of a DBCPConnectionPool 
> by name. This allows processors who are to perform the same work on multiple 
> databases to be able to do so by providing individual flow files upstream 
> with the database.name attribute set.
> However ListDatabaseTables does not accept incoming connections, so you 
> currently need 1 DBCPConnectionPool per database, plus 1 ListDatabaseTables 
> per database, each using a corresponding DBCPConnectionPool. It would be nice 
> if ListDatabaseTables could accept incoming connection(s), if only to provide 
> attributes for selecting the DBCPConnectionPool.
> I propose the behavior be like other processors that can generate data with 
> or without an incoming connection (such as GenerateTableFetch, see 
> [NIFI-2881|https://issues.apache.org/jira/browse/NIFI-2881] for details). In 
> general that means if there is an incoming non-loop connection, it becomes 
> more "event-driven" in the sense that it will not execute if there is no 
> FlowFile on which to work. If there is no incoming connection, then it would 
> run as it always has, on its Run Schedule and with State Management, so as 
> not to re-list the same tables every time it executes. 
> However with an incoming connection and an available FlowFile, the behavior 
> could be that all tables for that database are listed, meaning that processor 
> state would not be updated nor queried, making it fully "event-driven". If 
> the tables for a database are not to be re-listed, the onus would be on the 
> upstream flow to not send a flow file for that database. This is not a 
> requirement, just a suggestion; it could be more flexible by honoring 
> processor state if the Refresh Interval is non-zero, but I think that adds 
> too much complexity for the user, for little payoff.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] NIFI-13037 Upgrade Spring Framework from 5.3.31 to 5.3.34 [nifi]



exceptionfactory opened a new pull request, #8638:
URL: https://github.com/apache/nifi/pull/8638

   # Summary
   
   [NIFI-13037](https://issues.apache.org/jira/browse/NIFI-13037) Upgrades 
Spring Framework dependencies on the support branch from 5.3.31 to 
[5.3.34](https://github.com/spring-projects/spring-framework/releases/tag/v5.3.34).
   
   Additional upgrades include related dependencies:
   
   - Upgraded Spring Boot from 2.7.16 to 
[2.7.18](https://github.com/spring-projects/spring-boot/releases/tag/v2.7.18) 
for Registry
   - Upgraded Spring Security from 5.8.7 to 
[5.8.11](https://github.com/spring-projects/spring-security/releases/tag/5.8.11)
   - Upgraded Jetty from 9.4.53 to 
[9.4.54](https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.54.v20240208)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [ ] Build completed using `mvn clean install -P contrib-check`
 - [ ] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-13037) Upgrade Spring Framework to 5.3.34 on Support Branch



 [ 
https://issues.apache.org/jira/browse/NIFI-13037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13037:

Description: Spring Framework dependencies on the support branch should be 
upgraded to version 
[5.3.34|https://github.com/spring-projects/spring-framework/releases/tag/v5.3.34]
 to resolve several flagged vulnerabilities. Spring Security should be upgraded 
to 5.8.11 and Jetty should be upgraded to 
[9.4.54|https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.54.v20240208]
 to resolve CVE-2024-22201 related to HTTP/2 connection closing.  (was: Spring 
Framework dependencies on the support branch should be upgraded to version 
[5.3.34|https://github.com/spring-projects/spring-framework/releases/tag/v5.3.34]
 to resolve several flagged vulnerabilities. Spring Security should be upgraded 
to 5.8.11 and Jetty should be upgraded to 
[9.5.54|https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.54.v20240208]
 to resolve CVE-2024-22201 related to HTTP/2 connection closing.)

> Upgrade Spring Framework to 5.3.34 on Support Branch
> 
>
> Key: NIFI-13037
> URL: https://issues.apache.org/jira/browse/NIFI-13037
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, MiNiFi, NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 1.26.0
>
>
> Spring Framework dependencies on the support branch should be upgraded to 
> version 
> [5.3.34|https://github.com/spring-projects/spring-framework/releases/tag/v5.3.34]
>  to resolve several flagged vulnerabilities. Spring Security should be 
> upgraded to 5.8.11 and Jetty should be upgraded to 
> [9.4.54|https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.54.v20240208]
>  to resolve CVE-2024-22201 related to HTTP/2 connection closing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (NIFI-13037) Upgrade Spring Framework to 5.3.34 on Support Branch

David Handermann created NIFI-13037:
---

 Summary: Upgrade Spring Framework to 5.3.34 on Support Branch
 Key: NIFI-13037
 URL: https://issues.apache.org/jira/browse/NIFI-13037
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework, MiNiFi, NiFi Registry
Reporter: David Handermann
Assignee: David Handermann
 Fix For: 1.26.0


Spring Framework dependencies on the support branch should be upgraded to 
version 
[5.3.34|https://github.com/spring-projects/spring-framework/releases/tag/v5.3.34]
 to resolve several flagged vulnerabilities. Spring Security should be upgraded 
to 5.8.11 and Jetty should be upgraded to 
[9.5.54|https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.54.v20240208]
 to resolve CVE-2024-22201 related to HTTP/2 connection closing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Resolved] (NIFI-12986) Tidy up JavaDoc of ProcessSession

2024-04-12 Thread ASF subversion and git services (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann resolved NIFI-12986.
-
Fix Version/s: 2.0.0-M3
   Resolution: Fixed

> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
> Fix For: 2.0.0-M3
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}} 
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current 
> {{ProcessSession}} specification more consistent. The specified contract must 
> not be altered. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (NIFI-12986) Tidy up JavaDoc of ProcessSession



[ 
https://issues.apache.org/jira/browse/NIFI-12986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836727#comment-17836727
 ] 

ASF subversion and git services commented on NIFI-12986:


Commit d3ff1f53c473e021933fd15b45d0c61ff0a6269b in nifi's branch 
refs/heads/main from EndzeitBegins
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=d3ff1f53c4 ]

NIFI-12986 Cleaned up JavaDoc in ProcessSession

This closes #8620

Signed-off-by: David Handermann 


> Tidy up JavaDoc of ProcessSession
> -
>
> Key: NIFI-12986
> URL: https://issues.apache.org/jira/browse/NIFI-12986
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: endzeit
>Assignee: endzeit
>Priority: Major
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> While working on NIFI-12982 I noticed that the JavaDoc of {{ProcessSession}} 
> has some minor typos and documentation drifts between method overloads.
> The goal of this ticket is to aim make the JavaDoc for the current 
> {{ProcessSession}} specification more consistent. The specified contract must 
> not be altered. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] NIFI-12986 Tidy up JavaDoc of ProcessSession [nifi]



exceptionfactory closed pull request #8620: NIFI-12986 Tidy up JavaDoc of 
ProcessSession
URL: https://github.com/apache/nifi/pull/8620


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] NIFI-13035 Upgrade Logback from 1.4.14 to 1.5.5 [nifi]



exceptionfactory opened a new pull request, #8637:
URL: https://github.com/apache/nifi/pull/8637

   # Summary
   
   [NIFI-13035](https://issues.apache.org/jira/browse/NIFI-13035) Upgrades 
Logback from 1.4.14 to [1.5.5](https://logback.qos.ch/news.html#1.5.5). Logback 
1.5.0 and later require Java 11 as the minimum version, but otherwise retain 
compatibility with Logback 1.4.
   
   Additional changes include upgrading SLF4J from 2.0.12 to 
[2.0.13](https://www.slf4j.org/news.html#2.0.13) incorporating a minor bug fix 
over version 2.0.12.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (NIFI-13036) Upgrade Logback to 1.5.5 and SLF4J to 2.0.13

2024-04-12 Thread ASF subversion and git services (Jira)

David Handermann created NIFI-13036:
---

 Summary: Upgrade Logback to 1.5.5 and SLF4J to 2.0.13
 Key: NIFI-13036
 URL: https://issues.apache.org/jira/browse/NIFI-13036
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework, MiNiFi, NiFi Registry
Reporter: David Handermann
 Fix For: 2.0.0-M3


Logback dependencies should be upgraded to 
[1.5.5|https://logback.qos.ch/news.html#1.5.5] and SLF4J should be upgraded to 
[2.0.13|https://www.slf4j.org/news.html#2.0.13] to incorporate several minor 
improvements.

The Logback 1.5 release series requires Java 11, so it applies only to the main 
branch of Apache NiFi and cannot be backported to the support branch. Logback 
1.5 decouples the core implementation from the {{logback-access}} module, which 
NiFi does not use, and is otherwise compatible with Logback 1.4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (NIFI-13029) Download Flow Definition

2024-04-12 Thread Matt Gilman (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Gilman updated NIFI-13029:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Download Flow Definition
> 
>
> Key: NIFI-13029
> URL: https://issues.apache.org/jira/browse/NIFI-13029
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Rob Fellows
>Assignee: Rob Fellows
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (NIFI-13029) Download Flow Definition



[ 
https://issues.apache.org/jira/browse/NIFI-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836724#comment-17836724
 ] 

ASF subversion and git services commented on NIFI-13029:


Commit 4e4c1ed80379d64e5faeb40146968897f01b3ce7 in nifi's branch 
refs/heads/main from Rob Fellows
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=4e4c1ed803 ]

[NIFI-13029] - Download Flow (#8634)

This closes #8634 

> Download Flow Definition
> 
>
> Key: NIFI-13029
> URL: https://issues.apache.org/jira/browse/NIFI-13029
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Rob Fellows
>Assignee: Rob Fellows
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [NIFI-13029] download flow [nifi]



mcgilman merged PR #8634:
URL: https://github.com/apache/nifi/pull/8634


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (NIFI-13035) UI - remove angular2jwt from Nifi Registry

2024-04-12 Thread Scott Aslan (Jira)

Scott Aslan created NIFI-13035:
--

 Summary: UI - remove angular2jwt from Nifi Registry
 Key: NIFI-13035
 URL: https://issues.apache.org/jira/browse/NIFI-13035
 Project: Apache NiFi
  Issue Type: Improvement
Reporter: Scott Aslan
Assignee: Scott Aslan






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] MINIFICPP-2325 Add missing compiler flags [nifi-minifi-cpp]



szaszm commented on code in PR #1755:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1755#discussion_r1562992485


##
minifi_main/CMakeLists.txt:
##
@@ -74,12 +74,10 @@ if (WIN32)
 target_compile_definitions(minifiexe PUBLIC SERVICE_NAME="Apache NiFi 
MINiFi")
 endif()
 
-if (NOT WIN32)
-add_custom_command(TARGET minifiexe POST_BUILD
-COMMAND cat ${CMAKE_BINARY_DIR}/all.log)
+if (WIN32)
+add_custom_command(TARGET minifiexe POST_BUILD COMMAND ${CMAKE_COMMAND} -E 
copy $ ${CMAKE_BINARY_DIR}/minifi_main/)
 else()
-#add_custom_command(TARGET minifiexe POST_BUILD
-#   COMMAND type ${CMAKE_BINARY_DIR}/all.log)
+add_custom_command(TARGET minifiexe POST_BUILD COMMAND cat 
${CMAKE_BINARY_DIR}/all.log)

Review Comment:
   I think this `cat` can go, the contents of that log file is bogus anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (NIFI-12917) Content repository claim is being zero'd out

2024-04-12 Thread Evan F. (Jira)



[ 
https://issues.apache.org/jira/browse/NIFI-12917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836723#comment-17836723
 ] 

Evan F. commented on NIFI-12917:


I got a copy of NiFi 1.25 a bit late in the week but I have a test harness 
configured and running over the weekend. I'm going to let it run until Tuesday 
or Wednesday to see if I can recreate the issue. 

> Content repository claim is being zero'd out
> 
>
> Key: NIFI-12917
> URL: https://issues.apache.org/jira/browse/NIFI-12917
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.19.1
> Environment: Red Hat 7 running Apache NiFi 1.19.1 with no custom 
> NARs. 
>Reporter: Evan F.
>Priority: Critical
> Attachments: example_MergeContent.txt
>
>
> I've had rare but consistent instances of MergeContent processors merging 
> files and losing the content claim/payload while merging. I've pasted an 
> example log entry below where there's a size to the file pre-merge and the 
> post-merge content claim becomes zero. I've attached a text file with the 
> configuration of my MergeContent processor as well. This happens a fraction 
> of a percent of the time but it happens daily, somewhere around 10 times a 
> day. I scoured forums and previous tickets but I wasn't able to find a 
> relevant issue. I'm hoping someone can tell me if this has already been 
> addressed. 
>  
> INFO [Timer-Driven Process Thread-7] o.a.n.processors.standard.MergeContent 
> Merge Content[id=e6f460da-018d-1000-1c97-a6bd946d4f61] Merged 
> [StandardFlowFileRecord[uuid=0e5b7c30-021d-4bd9-9edb-1681c9c14d4e,claim=StandardContentClaim
>  [resourceClaim=StandardRe         sourceClaim[id=1710769372188-3700202, 
> container=default, section=490], offset=0, 
> length=52430102],offset=0,name=testFile,size=52430102]] into 
> StandardFlowFileRecord[uuid=536bf8e4-915b-4dad-9e16-063b35e834c1,claim=,offset=0,
>          name=testFile.pkg,size=0]. Reason for merging: Maximum number of 
> entries reached



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (NIFI-12400) Remaining items to migrate UI to currently supported/active framework



 [ 
https://issues.apache.org/jira/browse/NIFI-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Fellows updated NIFI-12400:
---
Description: 
The purpose of this Jira is to track all remaining items following the initial 
commit [1] for NIFI-11481. The description will be kept up to date with 
remaining features, tasks, and improvements. As each items is worked, a new sub 
task Jira will be created and referenced in this description.
 * Support Parameters in Properties with Allowable Values (NIFI-12401)
 * Summary (NIFI-12437)
 ** Remaining work not addressed in initial Jira:
 *** input ports (NIFI-12504)
 *** output ports (NIFI-12504)
 *** remote process groups (NIFI-12504)
 *** process groups (NIFI-12504)
 *** connections (NIFI-12504)
 *** System Diagnostics (NIFI-12505)
 *** support for cluster-specific ui elements (NIFI-12537)
 *** Add pagination (NIFI-12552)
 * Counters (NIFI-12415)
 ** Counter table has extra unnecessary can modify check (NIFI-12948)
 * Bulletin Board (NIFI-12560)
 * Provenance (NIFI-12445)
 ** Event Listing (NIFI-12445)
 ** Search (NIFI-12445)
 ** Event Dialog (NIFI-12445)
 ** Lineage (NIFI-12485)
 ** Replay from context menu (NIFI-12445)
 ** Clustering (NIFI-12807)

 * Configure Reporting Task (NIFI-12563)
 * Flow Analysis Rules (NIFI-12588)
 * Registry Clients (NIFI-12486)
 * Import from Registry (NIFI-12734)
 * Parameter Providers (NIFI-12622)
 ** Fetch parameters from provider, map to parameter context (dialog) - 
(NIFI-12665)
 * Cluster
 ** Node table (Disconnect/Connect/Load Balance/Etc) 
 ** Status History - node specific values (NIFI-12848)
 * Flow Configuration History (NIFI-12754)
 ** ActionEntity.action should be optional (NIFI-12948)
 * Node Status History (NIFI-12553)
 * Status history for components from canvas context menu (NIFI-12553)
 * Users (NIFI-12543)
 ** Don't show users or groups in create/edit dialog is there are none 
(NIFI-12948)
 * Policies (NIFI-12548)
 ** Overridden policy Empty or Copy (NIFI-12679)
 ** Select Empty by default (NIFI-12948)
 * Help (NIFI-12795)
 * About
 * Show Upstream/Downstream
 * Align
 * Replay last event
 * List Queue (NIFI-12589)
 ** Clustering (NIFI-12807)
 * Empty [all] Queue (NIFI-12604)
 * View Content (NIFI-12589 and NIFI-12445)
 * View State (NIFI-12611)
 ** Clustering (NIFI-13005)
 * Change Component Version (NIFI-13034)
 * Consider PG permissions in Toolbox (NIFI-12683)
 * Handle linking to components that are not on the canvas
 * PG Version (NIFI-12963 & NIFI-12995)
 ** Start (NIFI-12963)
 ** Commit (NIFI-12963)
 ** Force Commit (NIFI-12963)
 ** Show changes (NIFI-12995)
 ** Revert changes (NIFI-12995)
 ** Change Flow version (NIFI-12995)
 ** Stop (NIFI-12963)

 * Configure PG (NIFI-12417)
 * Process Group Services (NIFI-12425)
 ** Listing (NIFI-12425)
 ** Create (NIFI-12425)
 ** Configure (NIFI-12425)
 ** Delete (NIFI-12425)
 ** Enable (NIFI-12529)
 ** Disable (NIFI-12529)
 ** Improve layout and breadcrumbs
 ** Disable and Configure
 * Configure Processor
 ** Service Link (NIFI-12425)
 ** Create inline Service (NIFI-12425)
 ** Parameter Link (NIFI-12502)
 ** Convert to Parameter (NIFI-12502)
 ** Fix issue with Property Editor width (NIFI-12547)
 ** Stop and Configure
 ** Open Custom UI (NIFI-12958)
 ** Property History
 ** Unable to re-add any removed Property (NIFI-12743)
 ** Shift-Enter new line when editing Property (NIFI-12743)
 * Property Verification
 * More Details (Processor, Controller Service, Reporting Task)

 * Download Flow (NIFI-13029)
 * Create RPG (NIFI-12758)
 * Configure RPG (NIFI-12774)
 * RPG Remote Ports (NIFI-12778)
 * RPG Go To (NIFI-12759)
 * RPG Refresh (NIFI-12761)
 * Color
 * Move to Front
 * Copy/Paste
 * Add/Update Info Icons in dialogs throughout the application
 * Set viewport earlier when loading a Process Group (NIFI-12737)
 * Canvas global menu item should navigate user back to where they were on the 
canvas (NIFI-12737)
 * Better theme support (NIFI-12655)
 * Set up development/production environments files
 * Run unit tests are part of standard build (NIFI-12941)
 * Update all API calls to consider disconnect node confirmation (NIFI-13001)
 * Update API calls to use uiOnly flag (NIFI-12950)
 * Use polling interval from API
 * Load FlowConfiguration in guard (NIFI-12948)
 * Routing error handling
 * General API response error handling
 ** Management CS (NIFI-12663)
 ** Canvas CS (NIFI-12684)
 ** Remainder of Settings (NIFI-12723)
 ** Counters (NIFI-12723)
 ** Bulletins (NIFI-12723)
 ** Flow Designer
 ** Parameter Contexts (NIFI-12937)
 ** Parameter
 ** Provenance (NIFI-12767)
 ** Queue Listing (NIFI-12742)
 ** Summary (NIFI-12742)
 ** Users (NIFI-12742)
 ** Policies
 ** Status History
 * Introduce header in new pages to unify with canvas and offer better 
navigation. (NIFI-12597)
 * Theme docs, view flow file, and custom ui's
 * Prompt user to save Parameter Context when Edit form is dirty
 * Upgrade to Angular 17

[jira] [Created] (NIFI-13034) Change Component Version

Rob Fellows created NIFI-13034:
--

 Summary: Change Component Version
 Key: NIFI-13034
 URL: https://issues.apache.org/jira/browse/NIFI-13034
 Project: Apache NiFi
  Issue Type: Sub-task
  Components: Core UI
Reporter: Rob Fellows
Assignee: Rob Fellows






--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] NIFI-12986 Tidy up JavaDoc of ProcessSession [nifi]



exceptionfactory commented on PR #8620:
URL: https://github.com/apache/nifi/pull/8620#issuecomment-2052116435

   Thanks for taking the time to research and evaluate current approaches 
@EndzeitBegins. I believe this ultimately goes back to the roots of HTML where 
the `` is not required in most cases, since HTML is not a subset of XML, 
requiring properly closed elements.
   
   I lean in the direction of clarity, including the closing tag, but given 
that fact that it is valid without, and the example from the Oracle 
documentation, I am fine with leaving it as it stands, without the closing tag 
so we can proceed.
   
   Thanks again for the thoughtful interaction.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-13033) Upgrade Jetty to 12.0.8



 [ 
https://issues.apache.org/jira/browse/NIFI-13033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13033:

Status: Patch Available  (was: Open)

> Upgrade Jetty to 12.0.8
> ---
>
> Key: NIFI-13033
> URL: https://issues.apache.org/jira/browse/NIFI-13033
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, Extensions, NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0-M3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Jetty dependencies should be upgraded to 
> [12.0.8|https://github.com/jetty/jetty.project/releases/tag/jetty-12.0.8] to 
> incorporate various bug fixes and feature improvements.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] NIFI-12986 Tidy up JavaDoc of ProcessSession [nifi]

EndzeitBegins commented on PR #8620:
URL: https://github.com/apache/nifi/pull/8620#issuecomment-2052096719

To be honest I was (and still am really) somewhat confused regarding the
paragraphs. 

I've seen both styles applied throughout the NiFi codebase, e.g.
[here](https://github.com/apache/nifi/blob/cc7af91f97dd1844cc6c8d30bd47d6865cb20aaa/nifi-api/src/main/java/org/apache/nifi/time/DurationFormat.java#L62-L85)
vs.
[here](https://github.com/apache/nifi/blob/62a4ece55d08d5488e42819f27bbecd864e9e7dc/nifi-api/src/main/java/org/apache/nifi/reporting/ReportingTask.java#L24-L58).
A web search didn't help that much either as it yielded ambiguous results.
This [article from
Oracle](https://www.oracle.com/de/technical-resources/articles/java/javadoc-tool.html#format)
uses single `` notation. Others suggested that that wouldn't be valid due
to the closing tag missing.

I don't have hard feelings about that. 路‍♂️ I just took the less verbose
option.

Regardless of what we choose to use, it may be a good idea to unify on one
declaration style inside NiFi, not in this PR of course, to avoid that
confusion in the future.

Do you have a verdict on what style should be preferred for NiFi
@exceptionfactory?

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] NIFI-13033 Upgrade Jetty from 12.0.7 to 12.0.8 [nifi]



exceptionfactory opened a new pull request, #8636:
URL: https://github.com/apache/nifi/pull/8636

   # Summary
   
   [NIFI-13033](https://issues.apache.org/jira/browse/NIFI-13033) Upgrades 
Jetty dependencies from 12.0.7 to 
[12.0.8](https://github.com/jetty/jetty.project/releases/tag/jetty-12.0.8) 
incorporating several bug fixes and feature improvements.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (NIFI-13033) Upgrade Jetty to 12.0.8

David Handermann created NIFI-13033:
---

 Summary: Upgrade Jetty to 12.0.8
 Key: NIFI-13033
 URL: https://issues.apache.org/jira/browse/NIFI-13033
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework, Extensions, NiFi Registry
Reporter: David Handermann
Assignee: David Handermann
 Fix For: 2.0.0-M3


Jetty dependencies should be upgraded to 
[12.0.8|https://github.com/jetty/jetty.project/releases/tag/jetty-12.0.8] to 
incorporate various bug fixes and feature improvements.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (NIFI-13032) Upgrade Spring Framework to 6.1.6



 [ 
https://issues.apache.org/jira/browse/NIFI-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13032:

Status: Patch Available  (was: Open)

> Upgrade Spring Framework to 6.1.6
> -
>
> Key: NIFI-13032
> URL: https://issues.apache.org/jira/browse/NIFI-13032
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework, MiNiFi, NiFi Registry
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0-M3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Spring Framework dependencies should be upgraded to 
> [6.1.6|https://github.com/spring-projects/spring-framework/releases/tag/v6.1.6]
>  to incorporate several bug fixes and improvements. Bug fixes include a 
> resolution for CVE-2024-22262, which relates to parsing URLs using the Spring 
> {{UriComponentsBuilder}} class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[PR] NIFI-13032 Upgrade Spring Framework from 6.1.5 to 6.1.6 [nifi]



exceptionfactory opened a new pull request, #8635:
URL: https://github.com/apache/nifi/pull/8635

   # Summary
   
   [NIFI-13032](https://issues.apache.org/jira/browse/NIFI-13032) Upgrades 
Spring Framework dependencies from 6.1.5 to 
[6.1.6](https://github.com/spring-projects/spring-framework/releases/tag/v6.1.6)
 incorporating several bug fixes and improvements, including a mitigation for 
CVE-2024-22262 related to URI parsing with `UriComponentsBuilder`. Additional 
changes include upgrading Spring Boot from 3.2.3 to 3.2.4 for Registry.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue 
created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as 
`NIFI-0`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, 
as such `NIFI-0`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing 
changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request 
creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
 - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 
2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License 
Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` 
files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Created] (NIFI-13032) Upgrade Spring Framework to 6.1.6

David Handermann created NIFI-13032:
---

 Summary: Upgrade Spring Framework to 6.1.6
 Key: NIFI-13032
 URL: https://issues.apache.org/jira/browse/NIFI-13032
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework, MiNiFi, NiFi Registry
Reporter: David Handermann
Assignee: David Handermann
 Fix For: 2.0.0-M3


Spring Framework dependencies should be upgraded to 
[6.1.6|https://github.com/spring-projects/spring-framework/releases/tag/v6.1.6] 
to incorporate several bug fixes and improvements. Bug fixes include a 
resolution for CVE-2024-22262, which relates to parsing URLs using the Spring 
{{UriComponentsBuilder}} class.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (NIFI-13001) Disconnected Node Acknowledgement

2024-04-12 Thread ASF subversion and git services (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-13001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Fellows updated NIFI-13001:
---
Fix Version/s: 2.0.0-M3
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Disconnected Node Acknowledgement
> -
>
> Key: NIFI-13001
> URL: https://issues.apache.org/jira/browse/NIFI-13001
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Major
> Fix For: 2.0.0-M3
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> When a node that is serving the UI for a client get's disconnected from the 
> cluster the user must acknowledge that they are disconnected prior to be able 
> to submit flow changes. Once they acknowledge the change, this acknowledge 
> must be sent in all mutable requests to the API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (NIFI-13001) Disconnected Node Acknowledgement



[ 
https://issues.apache.org/jira/browse/NIFI-13001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836669#comment-17836669
 ] 

ASF subversion and git services commented on NIFI-13001:


Commit 36d95c5c3bf7bc4871512433acdd2a0c8a05a347 in nifi's branch 
refs/heads/main from Matt Gilman
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=36d95c5c3b ]

NIFI-13001: Allowing the user to acknowledge changes to the cluster connection 
state (#8606)

* NIFI-13001:
- Allowing the user to acknowledge changes to the cluster connection state.

* NIFI-13001:
- Addressing review feedback.

This closes #8606 

> Disconnected Node Acknowledgement
> -
>
> Key: NIFI-13001
> URL: https://issues.apache.org/jira/browse/NIFI-13001
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> When a node that is serving the UI for a client get's disconnected from the 
> cluster the user must acknowledge that they are disconnected prior to be able 
> to submit flow changes. Once they acknowledge the change, this acknowledge 
> must be sent in all mutable requests to the API.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (NIFI-13005) Update Component State Dialog for Clustering

2024-04-12 Thread ASF subversion and git services (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-13005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Fellows updated NIFI-13005:
---
Fix Version/s: 2.0.0-M3
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Update Component State Dialog for Clustering
> 
>
> Key: NIFI-13005
> URL: https://issues.apache.org/jira/browse/NIFI-13005
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Major
> Fix For: 2.0.0-M3
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When the component state dialog was introduced the clustering details were 
> not included. These need to be added.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (NIFI-13005) Update Component State Dialog for Clustering



[ 
https://issues.apache.org/jira/browse/NIFI-13005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836670#comment-17836670
 ] 

ASF subversion and git services commented on NIFI-13005:


Commit 62a4ece55d08d5488e42819f27bbecd864e9e7dc in nifi's branch 
refs/heads/main from Matt Gilman
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=62a4ece55d ]

NIFI-13005: (#8609)

- Adding support for showing cluster state in the component state dialog.

This closes #8609 

> Update Component State Dialog for Clustering
> 
>
> Key: NIFI-13005
> URL: https://issues.apache.org/jira/browse/NIFI-13005
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Matt Gilman
>Assignee: Matt Gilman
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When the component state dialog was introduced the clustering details were 
> not included. These need to be added.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] NIFI-13005: Cluster State in Component State Dialog [nifi]



rfellows merged PR #8609:
URL: https://github.com/apache/nifi/pull/8609


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-13029) Download Flow Definition



 [ 
https://issues.apache.org/jira/browse/NIFI-13029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Fellows updated NIFI-13029:
---
Status: Patch Available  (was: In Progress)

> Download Flow Definition
> 
>
> Key: NIFI-13029
> URL: https://issues.apache.org/jira/browse/NIFI-13029
> Project: Apache NiFi
>  Issue Type: Sub-task
>  Components: Core UI
>Reporter: Rob Fellows
>Assignee: Rob Fellows
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] NIFI-13001: Allowing the user to acknowledge changes to the cluster connection state [nifi]

2024-04-12 Thread ASF subversion and git services (Jira)



rfellows merged PR #8606:
URL: https://github.com/apache/nifi/pull/8606


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (NIFI-12998) nifi-nar-bundle has improper dependencies - the full source tree needs dependency cleanup and management

2024-04-12 Thread Joe Witt (Jira)



[ 
https://issues.apache.org/jira/browse/NIFI-12998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836665#comment-17836665
 ] 

Joe Witt commented on NIFI-12998:
-

This started in an effort to remove a couple clearly extraneous entries in the 
nifi-nar-bundle pom.  What I found as I pulled the thread was that our repo 
holistically has grown very messy and tangled in ways that make adding 
capabilities and maintenance much harder.  Some members of the community have 
done tremendous work to improve the situation by moving more things to the top 
level pom dependency management section and introducing BOMs where available 
for things like Jetty and various others.  These all help and are part of the 
strategy but several challenges remain due to years of technical debt accrual.

1. We have made the 'nifi-nar-bundles' module into a frankenstein of awkward 
inter dependencies between the framework, actual extensions, etc.. You really 
can't build components outside of that with the way it works right now without 
a lot of manual work.
2. We have no clear delineation of what is actually provided in the application 
of NiFi (or minifi java or stateless for that matter) when build extension nars 
on top.
3. Related to 2 it isn't clear or obvious to users actually how any of our 
classloading magic truly works.  Which artifacts are you actually having to 
contend with being in a parent classloader and which ones are you free to take 
a different version/approach with?
4.  If you want to build a new nar or modify one which exists you really don't 
know and frankly don't have much options what you can use.  The parent modules 
have forced dependencies (not managed dependencies but hard dependencies) which 
complicate things.  You also effectively have to build them within the 
nifi-nar-bundles module hierarchy to have it work for now.  Going forward there 
should be in effect three patterns we enable.  (a) you want to build a nar and 
you only need base/root dependencies which you cannot ovveride.   (b) you want 
to build a nar and you're going to leverage one or more standard service apis.  
(c) you want to build a nar and you're going to leverage standard shared 
libraries and service apis.   Nars should be free to choose whichever level of 
integration/tie in they want and they should be able to live easily wherever 
they need in the nifi codebase or in anyone elses repo.  It was always supposed 
to be dead simple to build extensions.
5. If you analyze dependency trees POMs are riddled with absurd inclusions that 
have absolutely nothing to do with the component involved.  Lots of copy and 
paste is clearly a factor but also inclusion of dependencies because you think 
some upstream user would need those.  Dependencies which got left around after 
various refactorings.  Dependencies which are marked as provided but not 
actually provided/etc.. I envision various devs playing dependency bingo until 
the build works.  We are fighting maven and its great powers instead of letting 
it do the hard work for us.

The PR associated with the above will be very large as it unwinds these various 
complexities.  The result should be far more maintainable and easier to reason 
over.  It heavily leverages the BOM pattern both for external dependencies but 
also within NiFi.  It moves modules to their more logical/independent spot.  It 
goes module by module and does full dependency analysis to eliminate any 
incorrect dependencies either from things being listed as dependencies which 
aren't actually used as well as things which override parent managed versions 
when it should not as well.


> nifi-nar-bundle has improper dependencies - the full source tree needs 
> dependency cleanup and management
> 
>
> Key: NIFI-12998
> URL: https://issues.apache.org/jira/browse/NIFI-12998
> Project: Apache NiFi
>  Issue Type: Task
>Affects Versions: 2.0.0-M2
>Reporter: Joe Witt
>Assignee: Joe Witt
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> found in nifi-nar-bundles pom
>   
> com.maxmind.geoip2
> geoip2
> 4.2.0
> 
> This should not be here.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (NIFI-13025) NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service



[ 
https://issues.apache.org/jira/browse/NIFI-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836647#comment-17836647
 ] 

ASF subversion and git services commented on NIFI-13025:


Commit 0e4b33ce4c7db001d746fc61b94170752fd67987 in nifi's branch 
refs/heads/support/nifi-1.x from Pierre Villard
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=0e4b33ce4c ]

NIFI-13025 Removed custom validation from NifiRegistryFlowRegistryClient

- NiFi Registry REST API enforces TLS handshake requirements

This closes #8629

Signed-off-by: David Handermann 
(cherry picked from commit cc7af91f97dd1844cc6c8d30bd47d6865cb20aaa)


> NifiRegistryFlowRegistryClient to allow for truststore only SSL Context 
> Service
> ---
>
> Key: NIFI-13025
> URL: https://issues.apache.org/jira/browse/NIFI-13025
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>  Labels: backport-needed
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Right now the NifiRegistryFlowRegistryClient Registry Client, when configured 
> with an SSL Context Service, requires the SSL CS to be configured with both a 
> keystore and a truststore. However, there are valid deployment scenarios 
> where only a truststore should be configured in case anonymous access to the 
> Registry is desired.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (NIFI-13025) NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service

2024-04-12 Thread ASF subversion and git services (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Handermann updated NIFI-13025:

Fix Version/s: 2.0.0-M3
   1.26.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> NifiRegistryFlowRegistryClient to allow for truststore only SSL Context 
> Service
> ---
>
> Key: NIFI-13025
> URL: https://issues.apache.org/jira/browse/NIFI-13025
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>  Labels: backport-needed
> Fix For: 2.0.0-M3, 1.26.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Right now the NifiRegistryFlowRegistryClient Registry Client, when configured 
> with an SSL Context Service, requires the SSL CS to be configured with both a 
> keystore and a truststore. However, there are valid deployment scenarios 
> where only a truststore should be configured in case anonymous access to the 
> Registry is desired.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (NIFI-13025) NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service



[ 
https://issues.apache.org/jira/browse/NIFI-13025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836646#comment-17836646
 ] 

ASF subversion and git services commented on NIFI-13025:


Commit cc7af91f97dd1844cc6c8d30bd47d6865cb20aaa in nifi's branch 
refs/heads/main from Pierre Villard
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=cc7af91f97 ]

NIFI-13025 Removed custom validation from NifiRegistryFlowRegistryClient

- NiFi Registry REST API enforces TLS handshake requirements

This closes #8629

Signed-off-by: David Handermann 


> NifiRegistryFlowRegistryClient to allow for truststore only SSL Context 
> Service
> ---
>
> Key: NIFI-13025
> URL: https://issues.apache.org/jira/browse/NIFI-13025
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Pierre Villard
>Assignee: Pierre Villard
>Priority: Major
>  Labels: backport-needed
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Right now the NifiRegistryFlowRegistryClient Registry Client, when configured 
> with an SSL Context Service, requires the SSL CS to be configured with both a 
> keystore and a truststore. However, there are valid deployment scenarios 
> where only a truststore should be configured in case anonymous access to the 
> Registry is desired.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] NIFI-13025 - NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service [nifi]

2024-04-12 Thread ASF subversion and git services (Jira)



exceptionfactory closed pull request #8629: NIFI-13025 - 
NifiRegistryFlowRegistryClient to allow for truststore only SSL Context Service
URL: https://github.com/apache/nifi/pull/8629


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-13031) /flow/process-groups/{id}/status rest api call will return aggregate metrics for connections for one of the nodes, even when nodewise query parameter is set to true

2024-04-12 Thread Nissim Shiman (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-13031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nissim Shiman updated NIFI-13031:
-
Description: 
The rest api call:
/flow/process-groups/\{id}/status (with nodewise set to true) 
will return aggregate metrics for connections found in the process group as 
well as nodewise metrics for those connections as well.

One of the nodewise connections will be the same as the aggregate (i.e. instead 
of just reporting the metrics for the connection on that node, it will report 
the metrics across all nodes for that connection). The other nodewise 
connections will report what the connection status is for that node.

Behavior should be modified so all nodewise connection reporting is just for 
that node.

  was:
The rest api call:
/flow/process-groups/{id}/status (with nodewise set to true) will return 
aggregate metrics for connections found in the process group as well as 
nodewise metrics for those connections as well.

One of the nodewise connections will be the same as the aggregate (i.e. instead 
of just reporting the metrics for the connection on that node, it will report 
the metrics across all nodes for that connection).   The other nodewise 
connections will report what the connection status is for that node.

Behavior should be modified so all nodewise connection reporting is just for 
that node.


> /flow/process-groups/{id}/status rest api call will return aggregate metrics 
> for connections for one of the nodes, even when nodewise query parameter is 
> set to true
> 
>
> Key: NIFI-13031
> URL: https://issues.apache.org/jira/browse/NIFI-13031
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.24.0, 2.0.0-M2
>Reporter: Nissim Shiman
>Assignee: Nissim Shiman
>Priority: Major
>
> The rest api call:
> /flow/process-groups/\{id}/status (with nodewise set to true) 
> will return aggregate metrics for connections found in the process group as 
> well as nodewise metrics for those connections as well.
> One of the nodewise connections will be the same as the aggregate (i.e. 
> instead of just reporting the metrics for the connection on that node, it 
> will report the metrics across all nodes for that connection). The other 
> nodewise connections will report what the connection status is for that node.
> Behavior should be modified so all nodewise connection reporting is just for 
> that node.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (NIFI-13031) /flow/process-groups/{id}/status rest api call will return aggregate metrics for connections for one of the nodes, even when nodewise query parameter is set to true

2024-04-12 Thread Nissim Shiman (Jira)



 [ 
https://issues.apache.org/jira/browse/NIFI-13031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nissim Shiman reassigned NIFI-13031:


Assignee: Nissim Shiman

> /flow/process-groups/{id}/status rest api call will return aggregate metrics 
> for connections for one of the nodes, even when nodewise query parameter is 
> set to true
> 
>
> Key: NIFI-13031
> URL: https://issues.apache.org/jira/browse/NIFI-13031
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.24.0, 2.0.0-M2
>Reporter: Nissim Shiman
>Assignee: Nissim Shiman
>Priority: Major
>
> The rest api call:
> /flow/process-groups/{id}/status (with nodewise set to true) will return 
> aggregate metrics for connections found in the process group as well as 
> nodewise metrics for those connections as well.
> One of the nodewise connections will be the same as the aggregate (i.e. 
> instead of just reporting the metrics for the connection on that node, it 
> will report the metrics across all nodes for that connection).   The other 
> nodewise connections will report what the connection status is for that node.
> Behavior should be modified so all nodewise connection reporting is just for 
> that node.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (NIFI-13031) /flow/process-groups/{id}/status rest api call will return aggregate metrics for connections for one of the nodes, even when nodewise query parameter is set to true

2024-04-12 Thread Nissim Shiman (Jira)

Nissim Shiman created NIFI-13031:


 Summary: /flow/process-groups/{id}/status rest api call will 
return aggregate metrics for connections for one of the nodes, even when 
nodewise query parameter is set to true
 Key: NIFI-13031
 URL: https://issues.apache.org/jira/browse/NIFI-13031
 Project: Apache NiFi
  Issue Type: Bug
Affects Versions: 2.0.0-M2, 1.24.0
Reporter: Nissim Shiman


The rest api call:
/flow/process-groups/{id}/status (with nodewise set to true) will return 
aggregate metrics for connections found in the process group as well as 
nodewise metrics for those connections as well.

One of the nodewise connections will be the same as the aggregate (i.e. instead 
of just reporting the metrics for the connection on that node, it will report 
the metrics across all nodes for that connection).   The other nodewise 
connections will report what the connection status is for that node.

Behavior should be modified so all nodewise connection reporting is just for 
that node.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (NIFI-13028) UI - processor color should be based on theme



[ 
https://issues.apache.org/jira/browse/NIFI-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836608#comment-17836608
 ] 

ASF subversion and git services commented on NIFI-13028:


Commit 2cae3fec112713e8cd1c95199f4169138d919bc3 in nifi's branch 
refs/heads/main from Scott Aslan
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=2cae3fec11 ]

[NIFI-13028] theme the processor icon color (#8633)

* [NIFI-13028] theme the processor icon color

* prettier and lint updates

* add missing color to table action icon

* review feedback
This closes #8633 

> UI - processor color should be based on theme
> -
>
> Key: NIFI-13028
> URL: https://issues.apache.org/jira/browse/NIFI-13028
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] [NIFI-13028] theme the processor icon color [nifi]



rfellows merged PR #8633:
URL: https://github.com/apache/nifi/pull/8633


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (NIFI-13028) UI - processor color should be based on theme



 [ 
https://issues.apache.org/jira/browse/NIFI-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Fellows updated NIFI-13028:
---
Fix Version/s: 2.0.0-M3
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> UI - processor color should be based on theme
> -
>
> Key: NIFI-13028
> URL: https://issues.apache.org/jira/browse/NIFI-13028
> Project: Apache NiFi
>  Issue Type: Sub-task
>Reporter: Scott Aslan
>Assignee: Scott Aslan
>Priority: Major
> Fix For: 2.0.0-M3
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] NIFI-12801 Add local file upload option in PutHDFS processor [nifi]



shubhluck commented on PR #8415:
URL: https://github.com/apache/nifi/pull/8415#issuecomment-2051465897

   Thank you @Lehel44 for reviewing and testing, I've fixed unused imports and 
wildcard imports.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Assigned] (MINIFICPP-2295) Support controller services when using NiFi Python processors

2024-04-12 Thread Jira



 [ 
https://issues.apache.org/jira/browse/MINIFICPP-2295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gábor Gyimesi reassigned MINIFICPP-2295:


Assignee: Gábor Gyimesi

> Support controller services when using NiFi Python processors
> -
>
> Key: MINIFICPP-2295
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2295
> Project: Apache NiFi MiNiFi C++
>  Issue Type: New Feature
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Minor
>
> NiFi python processors support controller service properties, that can be 
> retrieved using 
> context.getProperty().asControllerService() and used in the 
> processor. Although MiNiFi does not have all controller services that NiFi 
> has, we should support the same syntax for the controllers that are available 
> in MiNiFi C++ as well.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]



martinzink commented on PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#issuecomment-2051331071

   > Do you want to fix the clang-tidy warnings?
   
   These wouldnt be trivial changes so Id rather not do these here from 
https://issues.apache.org/jira/browse/MINIFICPP-2247 
   
   > libminifi/src/utils/StringUtils.cpp contains a couple of functions that 
use c style arrays which should be replaced by std::array, the changes are not 
trivial so we probably want to create a separate PR instead of doing in 
whichever PR that touches the file
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINIFICPP-2323 ListenTCP custom delimiter [nifi-minifi-cpp]



martinzink commented on code in PR #1753:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1753#discussion_r1562258847


##
libminifi/test/unit/StringUtilsTests.cpp:
##
@@ -615,6 +615,16 @@ TEST_CASE("string::parseCharacter tests") {
   CHECK(string::parseCharacter("") == std::nullopt);
 }
 
+TEST_CASE("string::replaceEscapedCharacters tests") {
+  CHECK(string::replaceEscapedCharacters("a") == "a");
+  CHECK(string::replaceEscapedCharacters(R"(\n)") == "\n");
+  CHECK(string::replaceEscapedCharacters(R"(\t)") == "\t");
+  CHECK(string::replaceEscapedCharacters(R"(\r)") == "\r");
+  CHECK(string::replaceEscapedCharacters(R"(\\s)") == "s");

Review Comment:
   I've changed these based on your suggestion: 
https://github.com/apache/nifi-minifi-cpp/pull/1753/commits/3b6a8c40b0f991513b71e3c2a53bef7b6a088acc
 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] MINIFICPP-2309 Add JSON flow config examples [nifi-minifi-cpp]