fgerlits commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559390975
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -134,8 +135,8 @@ core::Property ConsumeWindowsEventLog::OutputFormat(
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559395057
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -134,8 +135,8 @@ core::Property ConsumeWindowsEventLog::OutputForm
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559396721
##
File path: extensions/windows-event-log/wel/JSONUtils.cpp
##
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559396721
##
File path: extensions/windows-event-log/wel/JSONUtils.cpp
##
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
humpfhumpf commented on pull request #4167:
URL: https://github.com/apache/nifi/pull/4167#issuecomment-762165905
> @humpfhumpf the conflicts has been resolved.
Thank you!
For an unknown reason (to me), github still detects a conflict on these 2
files:
```
nifi-nar-bundles/n
lordgamez commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559525228
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -692,6 +734,42 @@ void
ConsumeWindowsEventLog::putEventRenderFlowFile
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559559336
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.h
##
@@ -133,17 +141,29 @@ class ConsumeWindowsEventLog : public core::Proce
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559559336
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.h
##
@@ -133,17 +141,29 @@ class ConsumeWindowsEventLog : public core::Proce
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559559634
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -692,6 +734,42 @@ void
ConsumeWindowsEventLog::putEventRenderFlow
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559559897
##
File path: extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp
##
@@ -300,53 +330,249 @@ TEST_CASE("ConsumeWindowsEventLog o
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559560737
##
File path: extensions/windows-event-log/tests/ConsumeWindowsEventLogTests.cpp
##
@@ -41,6 +48,29 @@ void reportEvent(const std::string& cha
fgerlits commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559576916
##
File path: extensions/windows-event-log/tests/CWELCustomProviderTests.cpp
##
@@ -0,0 +1,132 @@
+/**
+ * Licensed to the Apache Software Foundati
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559587373
##
File path: extensions/windows-event-log/tests/CWELCustomProviderTests.cpp
##
@@ -0,0 +1,132 @@
+/**
+ * Licensed to the Apache Software Fou
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r559588214
##
File path: extensions/windows-event-log/tests/CWELCustomProviderTests.cpp
##
@@ -0,0 +1,132 @@
+/**
+ * Licensed to the Apache Software Fou
fgerlits commented on a change in pull request #973:
URL: https://github.com/apache/nifi-minifi-cpp/pull/973#discussion_r559595576
##
File path: cmake/BundledOSSPUUID.cmake
##
@@ -21,8 +21,11 @@ function(use_bundled_osspuuid SOURCE_DIR BINARY_DIR)
message("Using bundled os
szaszm commented on a change in pull request #973:
URL: https://github.com/apache/nifi-minifi-cpp/pull/973#discussion_r559617910
##
File path: cmake/BundledOSSPUUID.cmake
##
@@ -21,8 +21,11 @@ function(use_bundled_osspuuid SOURCE_DIR BINARY_DIR)
message("Using bundled ossp
asfgit closed pull request #4762:
URL: https://github.com/apache/nifi/pull/4762
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pvillard31 commented on pull request #4762:
URL: https://github.com/apache/nifi/pull/4762#issuecomment-762635597
Nice catch, thanks @ChrisSamo632 !
This is an automated message from the Apache Git Service.
To respond to the m
pvillard31 commented on pull request #4761:
URL: https://github.com/apache/nifi/pull/4761#issuecomment-762636743
If we're doing this, shouldn't we do it for all the "scripted" components?
This is an automated message from the
ChrisSamo632 commented on pull request #4761:
URL: https://github.com/apache/nifi/pull/4761#issuecomment-762640426
> If we're doing this, shouldn't we do it for all the "scripted" components?
I did wonder that myself after committing this change (I only really use the
ExecuteGroovySc
pvillard31 commented on pull request #4761:
URL: https://github.com/apache/nifi/pull/4761#issuecomment-762655718
Yep makes sense.
@mattyb149 - any thoughts on this?
This is an automated message from the Apache Git Service.
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560091816
##
File path: extensions/aws/s3/S3Wrapper.cpp
##
@@ -30,46 +37,253 @@ namespace minifi {
namespace aws {
namespace s3 {
-minifi::utils::option
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560091935
##
File path: extensions/aws/processors/ListS3.cpp
##
@@ -0,0 +1,296 @@
+/**
+ * @file ListS3.cpp
+ * ListS3 class implementation
+ *
+ * Licensed
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560092138
##
File path: extensions/aws/processors/ListS3.cpp
##
@@ -0,0 +1,296 @@
+/**
+ * @file ListS3.cpp
+ * ListS3 class implementation
+ *
+ * Licensed
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560092319
##
File path: extensions/aws/processors/ListS3.cpp
##
@@ -0,0 +1,296 @@
+/**
+ * @file ListS3.cpp
+ * ListS3 class implementation
+ *
+ * Licensed
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560092694
##
File path: extensions/aws/s3/S3Wrapper.h
##
@@ -31,11 +47,190 @@ namespace minifi {
namespace aws {
namespace s3 {
-class S3Wrapper : publi
humpfhumpf commented on pull request #4167:
URL: https://github.com/apache/nifi/pull/4167#issuecomment-762768283
Hi @pvillard31 ,
This PR is now stucked, in my opinion, on a CICD workflow error.
Could you please advise?
ChrisSamo632 commented on pull request #4761:
URL: https://github.com/apache/nifi/pull/4761#issuecomment-762779571
Took a quick look at this and actually most of the Scripted
processors/controllers/reporting tasks are already covered by the
`org.apache.nifi` @ INFO entry in the `logback.xm
szaszm closed pull request #973:
URL: https://github.com/apache/nifi-minifi-cpp/pull/973
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
adamdebreceni commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560111930
##
File path: extensions/aws/s3/S3Wrapper.h
##
@@ -31,11 +47,190 @@ namespace minifi {
namespace aws {
namespace s3 {
-class S3Wrapper : p
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560123974
##
File path: extensions/aws/s3/S3Wrapper.h
##
@@ -31,11 +47,190 @@ namespace minifi {
namespace aws {
namespace s3 {
-class S3Wrapper : publi
lordgamez commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560129087
##
File path: extensions/aws/s3/S3Wrapper.h
##
@@ -31,11 +47,190 @@ namespace minifi {
namespace aws {
namespace s3 {
-class S3Wrapper : publi
adamdebreceni commented on a change in pull request #976:
URL: https://github.com/apache/nifi-minifi-cpp/pull/976#discussion_r560177595
##
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##
@@ -134,8 +135,8 @@ core::Property ConsumeWindowsEventLog::OutputForm
bbende closed pull request #4758:
URL: https://github.com/apache/nifi/pull/4758
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
markap14 opened a new pull request #4763:
URL: https://github.com/apache/nifi/pull/4763
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
markap14 commented on a change in pull request #4734:
URL: https://github.com/apache/nifi/pull/4734#discussion_r560315700
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1040,6 +1049,93 @@ private static
arpadboda commented on a change in pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#discussion_r560320178
##
File path: libminifi/src/FlowController.cpp
##
@@ -360,6 +360,33 @@ int16_t FlowController::start() {
}
}
+int16_t FlowController::pause(
asfgit closed pull request #4759:
URL: https://github.com/apache/nifi/pull/4759
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pvillard31 commented on pull request #4759:
URL: https://github.com/apache/nifi/pull/4759#issuecomment-762994291
Merged to main, thanks @eduardofontes
This is an automated message from the Apache Git Service.
To respond to t
jfrazee commented on a change in pull request #4753:
URL: https://github.com/apache/nifi/pull/4753#discussion_r560378813
##
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/state/server/ZooKeeperStateServer.j
mattyb149 commented on pull request #4763:
URL: https://github.com/apache/nifi/pull/4763#issuecomment-763033574
+1 LGTM, test failures are from Checkstyle which I will fix on merge. Ran
contrib-check and tried on a live system with Postgres and Oracle DBs, with the
statement type both insi
mattyb149 closed pull request #4763:
URL: https://github.com/apache/nifi/pull/4763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mattyb149 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560392427
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml
##
@@ -196,7 +196,7 @@
ChrisSamo632 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560396671
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml
##
@@ -196,7 +196,7 @@
mattyb149 commented on pull request #4761:
URL: https://github.com/apache/nifi/pull/4761#issuecomment-763055762
Currently the only exceptions to the WARN level for processors are the ones
that only log information (LogAttribute and LogMessage). Not sure why the
scripting processors should
markap14 opened a new pull request #4764:
URL: https://github.com/apache/nifi/pull/4764
…y they were merged by MergeContent. Also updated logs to indicate the
reason and added additional documentation for processor
Thank you for submitting a contribution to Apache NiFi.
Please
ChrisSamo632 commented on pull request #4761:
URL: https://github.com/apache/nifi/pull/4761#issuecomment-763068680
> Currently the only exceptions to the WARN level for processors are the
ones that only log information (LogAttribute and LogMessage). Not sure why the
scripting processors sh
mattyb149 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560426686
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/groovy/org/apache/nifi/elasticsearch/integration/ElasticSearch
mattyb149 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560432077
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceI
mattyb149 commented on pull request #4761:
URL: https://github.com/apache/nifi/pull/4761#issuecomment-763087937
Split record indeed logs stuff like record counts at the INFO level, but the
default logback.xml settings should suppress those like they would with any
other processor. Are you
ChrisSamo632 commented on pull request #4761:
URL: https://github.com/apache/nifi/pull/4761#issuecomment-763092626
> Split record indeed logs stuff like record counts at the INFO level, but
the default logback.xml settings should suppress those like they would with any
other processor. Are
mattyb149 commented on pull request #4764:
URL: https://github.com/apache/nifi/pull/4764#issuecomment-763093981
Reviewing...
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
ChrisSamo632 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560466124
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/groovy/org/apache/nifi/elasticsearch/integration/ElasticSea
ChrisSamo632 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560474183
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServi
ChrisSamo632 commented on pull request #4761:
URL: https://github.com/apache/nifi/pull/4761#issuecomment-763128157
@pvillard31 / @markap14 based on teh above discussion, should we
reject/close this PR and Jira?
This is an au
ChrisSamo632 edited a comment on pull request #4761:
URL: https://github.com/apache/nifi/pull/4761#issuecomment-763128157
@pvillard31 / @markap14 based on the above discussion, should we
reject/close this PR and Jira?
This i
markap14 commented on pull request #4730:
URL: https://github.com/apache/nifi/pull/4730#issuecomment-763142346
@urbandan @heritamas let me know if there's anything else that you noticed
that I missed. Otherwise, I think we can probably get this merged in shortly.
-
ChrisSamo632 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560499832
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServi
markap14 closed pull request #4745:
URL: https://github.com/apache/nifi/pull/4745
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
markap14 commented on pull request #4745:
URL: https://github.com/apache/nifi/pull/4745#issuecomment-763151510
Thanks @s9514171. This looks good to me now. I was able to test and
everything looks good. +1 merged to main.
Thi
mattyb149 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560508878
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/groovy/org/apache/nifi/elasticsearch/integration/ElasticSearch
mattyb149 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560510439
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceI
mattyb149 commented on pull request #4764:
URL: https://github.com/apache/nifi/pull/4764#issuecomment-763178513
+1 LGTM, exercised different configurations to cause the various merge
reasons. Also the documentation is very thorough and the behaviors are
explained clearly and well. Thanks f
mattyb149 closed pull request #4764:
URL: https://github.com/apache/nifi/pull/4764
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
markap14 opened a new pull request #4765:
URL: https://github.com/apache/nifi/pull/4765
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
asfgit closed pull request #4587:
URL: https://github.com/apache/nifi/pull/4587
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
andrewmlim opened a new pull request #4766:
URL: https://github.com/apache/nifi/pull/4766
…s groups
Changed the UI text labels and also updated the related docs:
-User Guide updated for the "Download flow definition" functionality
-Admin Guide updated to remove references to
mattyb149 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560577910
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceI
mtien-apache opened a new pull request #4767:
URL: https://github.com/apache/nifi/pull/4767
…ly-generate temporary certificates, Keystores, and Truststores and return
it wrapped in a TLS configuration. This is to avoid maintaining expiring
certificates in test classes.
Updated TestI
ChrisSamo632 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560717188
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServi
urbandan commented on pull request #4730:
URL: https://github.com/apache/nifi/pull/4730#issuecomment-763393295
@markap14 Sorry I haven't managed to finish reviewing yet, but I think there
are a few issues we should discuss - will try to complete the review ASAP
---
asfgit closed pull request #4765:
URL: https://github.com/apache/nifi/pull/4765
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordgamez commented on a change in pull request #974:
URL: https://github.com/apache/nifi-minifi-cpp/pull/974#discussion_r560807808
##
File path: libminifi/src/FlowController.cpp
##
@@ -360,6 +360,33 @@ int16_t FlowController::start() {
}
}
+int16_t FlowController::pause(
ChrisSamo632 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560819377
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServi
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560819443
##
File path: extensions/librdkafka/ConsumeKafka.cpp
##
@@ -0,0 +1,569 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560831601
##
File path: extensions/librdkafka/rdkafka_utils.cpp
##
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560850272
##
File path: extensions/librdkafka/rdkafka_utils.cpp
##
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560854446
##
File path: extensions/librdkafka/rdkafka_utils.h
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560856528
##
File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp
##
@@ -0,0 +1,590 @@
+
+/**
+ * Licensed to the Apache Software Foundation (ASF)
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560859704
##
File path: extensions/librdkafka/rdkafka_utils.cpp
##
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one o
hunyadi-dev commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560860773
##
File path: extensions/librdkafka/tests/ConsumeKafkaTests.cpp
##
@@ -0,0 +1,590 @@
+
+/**
+ * Licensed to the Apache Software Foundation (ASF)
pvillard31 opened a new pull request #4768:
URL: https://github.com/apache/nifi/pull/4768
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
pvillard31 commented on pull request #4768:
URL: https://github.com/apache/nifi/pull/4768#issuecomment-763565886
https://user-images.githubusercontent.com/11541012/105173772-eac5e280-5b3a-11eb-8967-377826c2b043.png";>
Thi
pvillard31 opened a new pull request #4769:
URL: https://github.com/apache/nifi/pull/4769
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
_Enables X functionality; fixes bug NIFI-._
adamdebreceni commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560938789
##
File path: extensions/aws/processors/ListS3.cpp
##
@@ -0,0 +1,294 @@
+/**
+ * @file ListS3.cpp
+ * ListS3 class implementation
+ *
+ * Lice
ChrisSamo632 commented on a change in pull request #4755:
URL: https://github.com/apache/nifi/pull/4755#discussion_r560939470
##
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/test/groovy/org/apache/nifi/elasticsearch/integration/ElasticSea
exceptionfactory commented on a change in pull request #4734:
URL: https://github.com/apache/nifi/pull/4734#discussion_r560951664
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1040,6 +1049,93 @@ private
pvillard31 closed pull request #4769:
URL: https://github.com/apache/nifi/pull/4769
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pvillard31 commented on pull request #4769:
URL: https://github.com/apache/nifi/pull/4769#issuecomment-763599719
Tests are failing, will need to revisit when time permits.
This is an automated message from the Apache Git Serv
exceptionfactory commented on a change in pull request #4734:
URL: https://github.com/apache/nifi/pull/4734#discussion_r560952390
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1085,6 +1180,31 @@ private
exceptionfactory commented on pull request #4734:
URL: https://github.com/apache/nifi/pull/4734#issuecomment-763605759
@markap14 Thanks for the review and additional feedback, I pushed an update
to address your comments. There still appear to be some edge cases for some
record-oriented pr
adamdebreceni commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560970459
##
File path: extensions/aws/s3/S3Wrapper.cpp
##
@@ -30,46 +37,253 @@ namespace minifi {
namespace aws {
namespace s3 {
-minifi::utils::op
markap14 opened a new pull request #4770:
URL: https://github.com/apache/nifi/pull/4770
…ement objects in finally blocks or try-with-resources
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of P
adamdebreceni commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560982313
##
File path: extensions/aws/s3/S3Wrapper.cpp
##
@@ -30,46 +37,253 @@ namespace minifi {
namespace aws {
namespace s3 {
-minifi::utils::op
szaszm commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r558340027
##
File path: libminifi/src/core/logging/LoggerConfiguration.cpp
##
@@ -85,6 +108,7 @@ LoggerConfiguration::LoggerConfiguration()
void LoggerConfigu
szaszm commented on a change in pull request #940:
URL: https://github.com/apache/nifi-minifi-cpp/pull/940#discussion_r560987064
##
File path: extensions/librdkafka/rdkafka_utils.h
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
adamdebreceni commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r560987684
##
File path: extensions/aws/s3/S3Wrapper.cpp
##
@@ -30,46 +37,253 @@ namespace minifi {
namespace aws {
namespace s3 {
-minifi::utils::op
adamdebreceni commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r560993751
##
File path: libminifi/src/core/logging/LoggerConfiguration.cpp
##
@@ -85,6 +108,7 @@ LoggerConfiguration::LoggerConfiguration()
void Logger
szaszm commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r560995043
##
File path: libminifi/src/core/logging/LoggerConfiguration.cpp
##
@@ -85,6 +108,7 @@ LoggerConfiguration::LoggerConfiguration()
void LoggerConfigu
adamdebreceni commented on a change in pull request #955:
URL: https://github.com/apache/nifi-minifi-cpp/pull/955#discussion_r561008200
##
File path: libminifi/include/core/logging/internal/LogBuffer.h
##
@@ -0,0 +1,62 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation
801 - 900 of 40640 matches
Mail list logo
