[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-06 Thread JohannesDaniel
GitHub user JohannesDaniel opened a pull request: https://github.com/apache/nifi/pull/2199 NIFI-3248: Improvement of GetSolr Processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi pull request #2196: NIFI-3248

2017-10-06 Thread JohannesDaniel
Github user JohannesDaniel closed the pull request at: https://github.com/apache/nifi/pull/2196 ---

[GitHub] nifi pull request #2196: NIFI-3248

2017-10-05 Thread JohannesDaniel
GitHub user JohannesDaniel opened a pull request: https://github.com/apache/nifi/pull/2196 NIFI-3248 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-19 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145612359 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -126,6 +126,14

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-18 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145404225 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -172,157 +203,196

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-18 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145403415 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -66,42 +79,64

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-18 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145405902 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrProcessor.java --- @@ -275,7

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-18 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145404160 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -138,10 +168,11

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-18 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145403786 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -66,42 +79,64

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-18 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145408461 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/test/resources/solr/testCollection/conf/schema.xml --- @@ -16,6 +16,16

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-18 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145415068 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrProcessor.java --- @@ -275,7

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-20 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145946147 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -66,42 +79,72

[GitHub] nifi issue #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-19 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2199 I dont think that the timezone and the commit issues are still important. GetSolr now takes the timestamp directly from the results. Commit delays wont be a problem as the state is only

[GitHub] nifi pull request #2285: NIFI-4583 Restructure nifi-solr-processors

2017-11-21 Thread JohannesDaniel
GitHub user JohannesDaniel opened a pull request: https://github.com/apache/nifi/pull/2285 NIFI-4583 Restructure nifi-solr-processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

2017-11-21 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 Restructured the methods as discussed in JIRA. Additionally, I improved the unit tests for GetSolr ---

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

2017-11-21 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 (tested both processors in local build) ---

[GitHub] nifi pull request #2285: NIFI-4583 Restructure nifi-solr-processors

2017-12-03 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2285#discussion_r154523361 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java --- @@ -0,0 +1,202

[GitHub] nifi pull request #2700: NIFI-5189 Schema name is not available for RecordSc...

2018-05-14 Thread JohannesDaniel
GitHub user JohannesDaniel opened a pull request: https://github.com/apache/nifi/pull/2700 NIFI-5189 Schema name is not available for RecordSchema Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #2700: NIFI-5189 Schema name is not available for RecordSchema

2018-05-14 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2700 @markap14 I wanted to fix this before finishing the XMLRecordSetWriter. I especially expect beginners to use the schema access via the text property - they should not run into this problem. ---

[GitHub] nifi issue #2700: NIFI-5189 Schema name is not available for RecordSchema

2018-05-14 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2700 Discussion related to this ticket: https://github.com/apache/nifi/pull/2675#discussion_r186106245 ---

[GitHub] nifi issue #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-14 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2675 @markap14 implemented changes as discussed ---

[GitHub] nifi pull request #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-11 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2675#discussion_r187592686 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-11 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2675#discussion_r187549020 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-11 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2675#discussion_r187560805 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-04 Thread JohannesDaniel
GitHub user JohannesDaniel opened a pull request: https://github.com/apache/nifi/pull/2675 NIFI-5113 Add XMLRecordSetWriter Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi issue #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-04 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2675 Hi @markap14 here we go! Initially, I planned to enable this writer also to write XML attributes, but that would have required a complex workaround. Furthermore, it would

[GitHub] nifi pull request #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-04 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2675#discussion_r186106598 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-04 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2675#discussion_r186106245 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2736: NIFI-5223 Allow the usage of expression language fo...

2018-05-23 Thread JohannesDaniel
GitHub user JohannesDaniel opened a pull request: https://github.com/apache/nifi/pull/2736 NIFI-5223 Allow the usage of expression language for properties of Re… …cordSetWriters Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-19 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145712892 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -66,42 +79,72

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-19 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145719121 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -66,42 +79,72

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-19 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145720938 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -66,42 +79,72

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-19 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145721674 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -66,42 +79,72

[GitHub] nifi pull request #2199: NIFI-3248: Improvement of GetSolr Processor

2017-10-19 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2199#discussion_r145727845 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/GetSolr.java --- @@ -170,159 +210,213

[GitHub] nifi pull request #2285: NIFI-4583 Restructure nifi-solr-processors

2017-12-30 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2285#discussion_r159122676 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrProcessor.java --- @@ -34,39

[GitHub] nifi pull request #2285: NIFI-4583 Restructure nifi-solr-processors

2017-12-30 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2285#discussion_r159122738 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrProcessor.java --- @@ -34,39

[GitHub] nifi pull request #2285: NIFI-4583 Restructure nifi-solr-processors

2017-12-30 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2285#discussion_r159122745 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrProcessor.java --- @@ -34,39

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

2017-12-30 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 I replaced the values by static imports ---

[GitHub] nifi pull request #2285: NIFI-4583 Restructure nifi-solr-processors

2017-12-30 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2285#discussion_r159123401 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrProcessor.java --- @@ -34,39

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

2017-12-30 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 I made TestGetSolr a bit more simpler by adding a method for the generic creation of TestRunners. I moved all remaining PropertyDescriptors from SolrProcessor to SolrUtils

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

2018-01-03 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 @ijokarumawak not too important, but do you know why this commit is not linked to my account? it is linked to "U-WOODMARK\johannes.peter" ---

[GitHub] nifi issue #2285: NIFI-4583 Restructure nifi-solr-processors

2018-01-03 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2285 Ah I see. Sorry for this. Will we leave it as it (for this commit) is or can we fix this? ---

[GitHub] nifi pull request #2516: Nifi 4516

2018-03-06 Thread JohannesDaniel
GitHub user JohannesDaniel opened a pull request: https://github.com/apache/nifi/pull/2516 Nifi 4516 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken

[GitHub] nifi issue #2516: Nifi 4516

2018-03-06 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2516 @ijokarumawak To be aligned with processor GetSolr I implemented two options for the data format of Solr results: Solr XML and record functions. However, facets and stats are written

[GitHub] nifi pull request #2516: NIFI-4516 FetchSolr Processor

2018-03-06 Thread JohannesDaniel
Github user JohannesDaniel closed the pull request at: https://github.com/apache/nifi/pull/2516 ---

[GitHub] nifi pull request #2517: NIFI-4516 FetchSolr Processor

2018-03-06 Thread JohannesDaniel
GitHub user JohannesDaniel opened a pull request: https://github.com/apache/nifi/pull/2517 NIFI-4516 FetchSolr Processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-03-06 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @ijokarumawak To be aligned with processor GetSolr I implemented two options for the data format of Solr results: Solr XML and record functions. However, facets and stats are written

[GitHub] nifi pull request #2517: NIFI-4516 FetchSolr Processor

2018-03-09 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2517#discussion_r173530358 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/test/java/org/apache/nifi/processors/solr/TestFetchSolr.java --- @@ -0,0 +1,380

[GitHub] nifi pull request #2517: NIFI-4516 FetchSolr Processor

2018-03-09 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2517#discussion_r173530516 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/FetchSolr.java --- @@ -0,0 +1,401

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-03-09 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 Tested the processor in a local build where it worked as expected. ---

[GitHub] nifi pull request #2517: NIFI-4516 FetchSolr Processor

2018-03-09 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2517#discussion_r173614856 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/FetchSolr.java --- @@ -0,0 +1,401

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-03-10 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 Refactored the treatment of flowfiles routed to relationship ORIGINAL. More attributes are added to flowfiles for better descriptions of requests / responses. Additionally, I adjusted some

[GitHub] nifi pull request #2517: NIFI-4516 FetchSolr Processor

2018-03-09 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2517#discussion_r173516051 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java --- @@ -66,6 +67,15

[GitHub] nifi pull request #2517: NIFI-4516 FetchSolr Processor

2018-03-09 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2517#discussion_r173515717 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/FetchSolr.java --- @@ -0,0 +1,401

[GitHub] nifi pull request #2517: NIFI-4516 FetchSolr Processor

2018-03-09 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2517#discussion_r173516196 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/FetchSolr.java --- @@ -0,0 +1,401

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-11 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen Yeah, this time I looked at this, but haven't had time to fix this. I think I have to merge master into the branch due to updates. Local build worked. But thanks for the ping :) ---

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen omg. now there are commits of others in the branch?? maybe I should simply close this PR and insert the code into a new branch. ---

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen or is this a normal thing that the commits of others are shown here after the rebase? ---

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-11 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen rebased everything, build for solr processors works without any problems. however, when I try to build the whole application, I receive the following error: [ERROR] Failed

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen done :) ---

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r181213403 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r181215801 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r181217494 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r181213473 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r181215337 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi issue #2587: NIFI-4185 Add XML Record Reader

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2587 @markap14 thank you for the comprehensive review. I will start refactoring the implementations with respect to the improvements that are clear. ---

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r181218609 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r181221789 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen Thank you for your help with Git!! @bbende - Solr core is a test dependency again (I actually had a reason to add this as a non-test dependency, but it was not a good

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @ottobackwards deep paging should be done with scrolling using cursor marks (as it is done in GetSolr). simple paging can be done by sucessively increasing the offset (start parameter

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-12 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r181218182 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2517: NIFI-4516 FetchSolr Processor

2018-04-13 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2517#discussion_r181483327 --- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/QuerySolr.java --- @@ -0,0 +1,584

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-13 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @ottobackwards you made my day! ---

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-13 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen There are two tests that test Solr result paging: ``` testRetrievalOfFullResults() testRetrievalOfFullResults2() ``` What do you mean exactly? A test

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-13 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @ottobackwards When I try this I always run into the same problem: [ERROR] Failed to execute goal on project nifi-livy-processors: Could not resolve dependencies for project

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-13 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen I'm still impeded, because my Maven does not download the NIFI-SNAPSHOTS. It downloads all dependencies except the SNAPSHOTS. When I follow the links (e. g. https

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-17 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 (means in 5-6 hous) ---

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-17 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 hi @MikeThomsen I will upload the changes this evening. ---

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-04-17 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen - added provenance receive notifications - added tests for attributes - added upper limit of solr start parameter (1) - enhanced documentation for upper limit

[GitHub] nifi issue #2587: NIFI-4185 Add XML Record Reader

2018-04-20 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2587 @markap14 thank you for the response. I will simply remove that record tag validation as there are indeed many ways to do that before the data is processed by this reader

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-16 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r181851731 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-16 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r181653767 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi issue #2650: NIFI-5106 Add provenance reporting to GetSolr

2018-04-22 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2650 @MikeThomsen Hi, just saw that GetSolr does not create receive provenance events when data is retrieved and written into flowfiles. Added that. ---

[GitHub] nifi pull request #2650: NIFI-5106 Add provenance reporting to GetSolr

2018-04-22 Thread JohannesDaniel
GitHub user JohannesDaniel opened a pull request: https://github.com/apache/nifi/pull/2650 NIFI-5106 Add provenance reporting to GetSolr Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #2587: NIFI-4185 Add XML Record Reader

2018-04-23 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2587 @markap14 thanks for the help with the patch file. I am fine with it :) If you have not planned to do that yourself, I would start implementing a XMLWriter as soon as this has been

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-23 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r183489279 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi issue #2587: NIFI-4185 Add XML Record Reader

2018-04-22 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2587 @markap14 - Added EL for record format property - Removed record tag validation ---

[GitHub] nifi issue #2587: NIFI-4185 Add XML Record Reader

2018-04-19 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2587 @markap14 @pvillard31 - I refactored some code as the cases (coerce==true && drop==false) and (coerce==false && drop==true) in some cases showed an unexpected behavior

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-03-24 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen I will keep an eye on the CI tests in the future, thanks for the advice. Actually, I did not take them into account as they frequently appear to fail for no reason... I tested

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-01 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r178470648 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/resources/docs

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-01 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r178470638 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-04-01 Thread JohannesDaniel
Github user JohannesDaniel commented on a diff in the pull request: https://github.com/apache/nifi/pull/2587#discussion_r178470625 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/resources/docs

[GitHub] nifi issue #2587: NIFI-4185 Add XML Record Reader

2018-04-01 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2587 Hi @pvillard31 thank you for your comments! I realized all your suggestions. I like your news regarding the performance :-) Which kind of transformation did you test? XML => Rec

[GitHub] nifi issue #2587: NIFI-4185 Add XML Record Reader

2018-04-01 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2587 Can you maybe post the XML that led to the empty record? ---

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-03-27 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 Hi @MikeThomsen travic-ci test failed due to "The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and

[GitHub] nifi pull request #2587: NIFI-4185 Add XML Record Reader

2018-03-27 Thread JohannesDaniel
GitHub user JohannesDaniel opened a pull request: https://github.com/apache/nifi/pull/2587 NIFI-4185 Add XML Record Reader Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi issue #2587: NIFI-4185 Add XML Record Reader

2018-03-27 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2587 @pvillard31 here we go :) ---

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-03-16 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 Oh, sorry. Done. ---

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-03-23 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen any news? ---

[GitHub] nifi issue #2517: NIFI-4516 FetchSolr Processor

2018-03-16 Thread JohannesDaniel
Github user JohannesDaniel commented on the issue: https://github.com/apache/nifi/pull/2517 @MikeThomsen Any news? ---

  1   2   >