Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2894
No problem, looks good and going to merge, thanks!
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2894#discussion_r202777026
--- Diff:
nifi-toolkit/nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/client/nifi/impl/JerseyFlowClient.java
---
@@ -217,4 +217,12 @@ public
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2894#discussion_r202776797
--- Diff:
nifi-toolkit/nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/client/nifi/FlowClient.java
---
@@ -97,4 +97,10
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2820#discussion_r204390557
--- Diff:
nifi-nar-bundles/nifi-network-bundle/nifi-network-processors/src/main/resources/docs/org.apache.nifi.processors.network.ParseNetflowv5
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2816#discussion_r202687489
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2816
Everything looks good, going to merge shortly, thanks!
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2894#discussion_r202741535
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/entity/ClusterSummaryEntity.java
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2995
I believe the existing code in the finally block was there as a result of
an older approach where locking was being performed in the revision manager,
but since that is no longer needed, I believe
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2995
NIFI-5577 Fixing update method in NaiveRevisionManager so that failedâ¦
⦠updates don't change the revision
Thank you for submitting a contribution to Apache NiFi.
In order
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2816
Started reviewing this yesterday, but may take me some time to finish up,
preliminary review looks good though
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2816#discussion_r202165722
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2816#discussion_r202109378
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2406
+1 looks good and verified that versioned flows can roll back required
properties to be empty, merging
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2419
Looks good, mergin
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2423
Looks good, will merge
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/94
NIFIREG-125 Adding bucket id and item id to droplet details in grid list
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2512
+1 for the HBase processors, did a quick test of Put/Get against secure and
unsecure HBase and everything worked fine, bundled dependencies look good
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2527
I think when I initially implemented this processor I was assuming someone
would be fetching rows that were expected to be there, so if it wasn't there
then it would be more an error scenario
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2532
Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/97
Tested this locally and verified the security of the actuator end-point,
everything looks good to me, nice work! Will merge.
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2498
[WIP] NIFI-4915 - Creating new nifi-hbase_2-client-service-bundle to use
HBâ¦
â¦ase 2.0.0 client
This is a copy/paste/rename of the 1.1.2 client service, but with the
dependency change
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2470
@zenfenan this seems to be working well, I had a few minor changes I posted
here:
https://github.com/bbende/nifi/commits/NIFI-4864
If you are good with that last commit I made then I
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2478
Latest update looks good, going to merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2533
The TestRunner should have the methods you are looking for...
/**
* Copies the content from the given byte array into memory and creates
a
* FlowFile from this content
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2539
NIFI-4969 Fixing error when importing versioned flow with a processorâ¦
⦠that uses event driven scheduling
You can merge this pull request into a Git repository by running:
$ git pull
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2523#discussion_r174888711
--- Diff:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/StandardSchemaIdentifier.java
---
@@ -64,6 +75,49 @@ public boolean
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2523#discussion_r174888759
--- Diff:
nifi-nar-bundles/nifi-confluent-platform-bundle/nifi-confluent-schema-registry-service/src/main/java/org/apache/nifi/confluent/schemaregistry
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2523#discussion_r174895242
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2523#discussion_r174895925
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2523
@markap14 pushed another commit that addresses 3 of the 4 comments, I
didn't add the branch option to the attributes access strategy, let me know if
you think we need to do that.
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2523
NIFI-4935 Support Schema Branches when using HWX Schema Registry
This PR adds optional "Schema Branch" and "Schema Version" properties to
the readers/writers which can be used wh
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/105
NIFIREG-144 Fixing NPE when retrieving latest snapshot when no versioâ¦
â¦ns exist
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2478
@bdesert thanks for the updates, there is one error case I think we need to
handle and then we should be good to go...
The case is if an exception happens half-way through handling the results
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/98
Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/103
Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/98
@kevdoran I messed up the magic commit message so this didn't auto-close,
it is merged now if you can close it, thanks.
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/108
NIFIREG-158 Added ability to retrieve flow directly by id without knoâ¦
â¦wing the bucket
You can merge this pull request into a Git repository by running:
$ git pull https
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2582
Will review this soon...
@MikeThomsen I think the intent here is to move master to use Hadoop 3.0.0
dependencies (3.1.0 is even out now)... If anyone needs to continue using the
Hadoop 2.x
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
Thanks @ijokarumawak ! Will review this soon.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/108
@kevdoran good idea, I pushed up another commit that wraps the exception
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2610
+1 Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/108
@kevdoran thanks, I have some more stuff to push up that I kept working on
after submitting, incoming shortly...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2604
@pvillard31 I just rebased and forced push, can you give this another try?
The main changes since what you last tried this morning are the following...
- In standalone you can use -verbose
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/108
@kevdoran ok good to go now, ended up adding all of the GET operations from
BucketFlowResource that could be done without a bucket id...
```
/flows/{flowId}
/flows/{flowId
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2518#discussion_r182801262
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/test/java/org/apache/nifi/hbase/VisibilityIT.java
---
@@ -0,0 +1,510
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2518
@MikeThomsen @ijokarumawak I haven't looked at how Hbase visibility labels
work compared to Accumulo, but in Accumulo you pass in the authorizations for
an operations which are then compared against
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2518
I think we are saying the same thing, the authorizations can come from
anywhere, but I was just using end-user as an example.
In Accumulo you would issue an operation and pass in an array
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2561
I was able to resolve the conflicts and everything looks good now, going to
merge, thanks!
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2586
NIFI-5021 Moving nifi-elasticsearch-client-service-api to nifi-elastiâ¦
â¦csearch-bundle and creating NAR for the API
Thank you for submitting a contribution to Apache NiFi
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2585#discussion_r177489251
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
---
@@ -213,6
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-minifi/pull/121
MINIFI-449 Support for converting VersionedFlowSnapshot to YAML via mâ¦
â¦inifi-toolkit
- Upgrading Jackson databind to 2.9.1 for consistency with other Jackson
modules
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2583
Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2581
Not sure what others do, but I can't remember doing anything in my IDE
(IntelliJ) other than changing the new Java class template to have the Apache
License at the top by default.
I just run
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2581
It's in the root pom as part of the plugin... the contrib-check Maven
profile enables checkstyle and RAT checks, this is what Travis is doing.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2579
Looks good, merging
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2568
This may need to be updated based on the recent changes in master that were
just made today, basically the reloadIfNecessary method is going to return
immediately if the component has a null
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2547#discussion_r177119368
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractSyslogProcessor.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2547#discussion_r177121695
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractSyslogProcessor.java
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2581
This looks good, verified it resolves the issue and is no longer reloading
any components except those that have the classpath property descriptors, going
to merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2547
Thanks, looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2586
Agreed, will merge
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2599
NIFI-5035 Moving MongoDB services out of standard services
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r178643485
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0 +1,373
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r178643917
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0 +1,373
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r178644667
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/test/java/org/apache/nifi/processors/solr/TestPutSolrRecord.java
---
@@ -0,0 +1,643
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r178643673
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0 +1,373
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r178644182
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/resources/docs/org.apache.nifi.processors.solr.PutSolrRecord/additionalDetails.html
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2561
Nested records and arrays of nested records are not working correctly...
**Scenario 1 - Nested Record**
Schema:
```
{
"type": "record",
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2604
NIFI-5027 Adding pg-get-services command
NIFI-5027 Adding pg-enable-services command
NIFI-5027 Adding pg-disable-services command
Thank you for submitting a contribution to Apache
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2604
@pvillard31 thanks for the very thorough review, I'll take a look at some
of these tomorrow and see what improvements can be made.
Regarding the lack of feedback on some commands
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2561
Thanks, will try to take a look in a few days, unless someone gets to it
first.
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r17418
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/FetchSolr.java
---
@@ -0,0 +1,401
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r14022
--- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/pom.xml ---
@@ -74,6 +75,22 @@
nifi-ssl-context-service-api
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r14826
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/FetchSolr.java
---
@@ -0,0 +1,432
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2517#discussion_r18458
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/FetchSolr.java
---
@@ -0,0 +1,432
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/120#discussion_r177766828
--- Diff: minifi-c2/pom.xml ---
@@ -37,10 +37,30 @@ limitations under the License.
minifi-c2-framework
minifi-c2-integration
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/120#discussion_r177763765
--- Diff:
minifi-c2/minifi-c2-framework/src/main/java/org/apache/nifi/minifi/c2/api/provider/device/DevicePersistenceProvider.java
---
@@ -0,0 +1,78
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/120#discussion_r177765399
--- Diff:
minifi-c2/minifi-c2-framework/src/main/java/org/apache/nifi/minifi/c2/core/service/StandardC2Service.java
---
@@ -0,0 +1,494
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2586
Thanks for reviewing, I'm going to wait til 1.6.0 release finalizes before
merging this because there will likely be conflicts when the poms get updated
to 1.7.0-SNAPSHOT.
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/107
NIFIREG-157 Adding boolean to VersionedPropertyDescriptor to indicateâ¦
⦠if sensitive or not
You can merge this pull request into a Git repository by running:
$ git pull https
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175764796
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -280,5 +291,115
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175760215
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0 +1,351
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175761850
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0 +1,351
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175809550
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -280,5 +291,115
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175818379
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -280,5 +291,115
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r175810746
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java
---
@@ -280,5 +291,115
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2533
@kai5263499 can this be closed?
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2561#discussion_r176411279
--- Diff:
nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/PutSolrRecord.java
---
@@ -0,0 +1,351
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/106
Looks good, will merge
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2552#discussion_r175534750
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/firewall/impl
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2552#discussion_r175535507
--- Diff: nifi-nar-bundles/pom.xml ---
@@ -207,6 +207,11 @@
1.6.0-SNAPSHOT
provided
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2552#discussion_r175528010
--- Diff: nifi-nar-bundles/nifi-standard-services/pom.xml ---
@@ -43,5 +43,6 @@
nifi-hwx-schema-registry-bundle
nifi-mongodb-client
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2561
I would try doing a rebase against master to see what happens. In the worst
case situation you would have to create another branch off latest master, and
then individually cherry-pick your commits
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2552
Several of the HDFS & Parquet processors still have the
`@Restriction(requiredPermission = RequiredPermission.ACCESS_KEYTAB` which I
believe shouldn't be there anymore.
- Delete
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2552
@claudiu-stanciu since the principal property supports expression language,
can you just do this?
`foo/${hostname(true)}@ABC.COM`
The parameter to the hostname function indicates
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2561
Yea when you update your branch you should be doing something like the
following...
```
git fetch upstream
git rebase upstream/master
```
This assumes "upstream" points
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2573
Reviewing...
---
Github user bbende closed the pull request at:
https://github.com/apache/nifi-minifi/pull/119
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2561
I tried to re-base this against master so I could squash it down to a
single commit, but the re-base is encountering a lot of conflicts, which really
shouldn't be happening because its conflicting
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2579
Will review...
---
701 - 800 of 897 matches
Mail list logo
