Github user colindean commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r231654261
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
Github user colindean commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r231660071
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
> If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
I added properties but I used a readable string for `.n
GitHub user colindean opened a pull request:
https://github.com/apache/nifi/pull/3133
NIFI-5790: Exposes 6 commons-dbcp options in DBCPConnectionPool
These six options support the eviction and passivation of idle
connections.
This adds the feature described in NIFI-5790
Github user colindean commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r230935621
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
> What about making all of the new fields not required? `required(false)`.
Then, if a value is provided, you override, otherwise you leave it be. You
could call out the default values, or defa
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
Ah, I did that through checking the minIdle and maxIdle properties.
---
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
Test failure now seems to be a timeout in another module:
```
[ERROR] Tests run: 5, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:
30.287 s <<<
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
> What if you exposed the number of active and idle connections in the
connection pool as properties on the DBCPConnectionPool? These are available by
calling getNumActive() and getNumI
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
> an Idle connection was one that had been returned to the pool?
That's what I would think, but I couldn't seem to actually trigger it.
Reading through the API docs some more
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
ð
@patricker @mattyb149 How often and for what reasons does NiFi issue patch
releases? Looking through the release history, it seems pretty rare and saved
for regressions only. More
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
Thank you for confirming. Looks like my team will have some work to do
next week!
---
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
I'll squash once travis says ð
---
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
Squash incomingâ¦
---
GitHub user colindean opened a pull request:
https://github.com/apache/nifi/pull/3172
NIFI-5823: Fixes typo in min idle connections property name
So many people missed it :-(
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user colindean commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3156#discussion_r231993409
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
Test failure is on the Japanese build.
---
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3133
Very strange⦠it's there in the PR's commit and my local copy and Travis
built fine:
https://github.com/apache/nifi/blob/a3868928e278dc6797367f97d1d84eebcf1aad38/nifi-nar-bundles/nifi
Github user colindean commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3156#discussion_r231993705
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
Github user colindean commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3156#discussion_r231993492
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractExecuteSQL.java
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3032
That's fair. I feel like a release is coming up. Looking at the calendar,
it seems like it happens in the first two weeks of each quarter. There's a been
a lot of commits since 1.7.1! We're OK
GitHub user colindean opened a pull request:
https://github.com/apache/nifi/pull/3032
NIFI-5612: Support JDBC drivers that return Long for unsigned ints
Refactors tests in order to share code repeated in tests and to enable some
parameterized testing.
MySQL Connector/J 5.1
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3032
The test failure seems to be a timeout from a test unrelated to what I
changed but still within the nifi-standard-processors maven component:
```
[ERROR] Tests run: 3, Failures: 0
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3032
@mattyb149 Thoughts?
---
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3022
:tada:
---
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3032
I'll note that I built this NAR and used it for a job running against the
production server in which I originally observed the problem. That job did not
display the behavior and seems to have
Github user colindean commented on the issue:
https://github.com/apache/nifi/pull/3032
Awesome! @mattyb149, where you able to reproduce the bug on other database
software/driver combinations?
Was this behavior unique to MySQL 5.0.x and driver 5.1.x?
I wasn't able
GitHub user colindean opened a pull request:
https://github.com/apache/nifi/pull/3177
NIFI-5828: Documents behavior of ExecuteSQL attrs when Max Rows Per Flow
File is enabled
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
28 matches
Mail list logo
