[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

2016-07-14 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/583 I did not push my updates correctly yesterday, I just fixed the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #853: NIFI-2563 Fixing User Guide Label Icon

2016-08-12 Thread jvwing
GitHub user jvwing opened a pull request: https://github.com/apache/nifi/pull/853 NIFI-2563 Fixing User Guide Label Icon Fix to the image in the User Guide section for the toolbar's Label control. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

2016-07-13 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/583 I force-pushed a substantial update/rewrite. Changes from the previous implementation include: * Moving most of the logic to the nifi-assembly pom rather than the parent pom * Including

[GitHub] nifi issue #801: NIFI-2507 Added Canned ACL support to PutS3Object

2016-08-08 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/801 @tequalsme, thanks for contributing this, I think it's a great idea. I will review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #801: NIFI-2507 Added Canned ACL support to PutS3Object

2016-08-08 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/801 @tequalsme , would you please update the integration test `ITPutS3Object.testGetPropertyDescriptors()` (from ITPutS3Object.java:314)? The test currently fails on line 317 after finding 26 property

[GitHub] nifi pull request #801: NIFI-2507 Added Canned ACL support to PutS3Object

2016-08-08 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/801#discussion_r73953981 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/AbstractS3Processor.java --- @@ -184,35 +194,59

[GitHub] nifi issue #801: NIFI-2507 Added Canned ACL support to PutS3Object

2016-08-09 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/801 Thanks for the update, @tequalsme, I verified: * Property descriptor name/displayName updated * Reformated createCannedACL is appreciated, thanks * Exception error message from bad canned ACL

[GitHub] nifi issue #1461: NIFI-3426: Add dynamic property support to DBCPConnectionP...

2017-02-03 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1461 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1461: NIFI-3426: Add dynamic property support to DBCPConnectionP...

2017-02-03 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1461 @mattyb149 This looks very good, I will merge. Thanks for adding this feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #1465: NIFI-3427 Fix Provenance DateTime Sorting

2017-02-01 Thread jvwing
GitHub user jvwing opened a pull request: https://github.com/apache/nifi/pull/1465 NIFI-3427 Fix Provenance DateTime Sorting Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi issue #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-08 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1482 @gene-telligent, Thanks for addressing those build issues, it's much improved. I'll move on to more exciting testing. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #1465: NIFI-3427 Fix Provenance DateTime Sorting

2017-02-06 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1465 Thanks, @pvillard31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-07 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1482 Reviewing... It will take a bit to get a full review, but I have a couple of quick comments: 1. Thanks for contributing to NiFi, this looks like a very complete and carefully crafted

[GitHub] nifi pull request #1437: NIFI-3382 New test keystore, truststore

2017-01-22 Thread jvwing
GitHub user jvwing opened a pull request: https://github.com/apache/nifi/pull/1437 NIFI-3382 New test keystore, truststore Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] nifi pull request #1416: NIFI-3350 optimized documentation extraction to red...

2017-01-22 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1416#discussion_r97235889 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/NarUnpacker.java --- @@ -264,7 +264,9

[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...

2017-01-24 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1399 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1439: NIFI-3382 New test keystore, truststore (0.x branch)

2017-01-23 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1439 Thank you, @alopresto. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1439: NIFI-3382 New test keystore, truststore (0.x branch)

2017-01-23 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1439 No problem, I'll close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1439: NIFI-3382 New test keystore, truststore (0.x branch...

2017-01-23 Thread jvwing
Github user jvwing closed the pull request at: https://github.com/apache/nifi/pull/1439 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1399: NIFI-3251: Updating authorization requirements for removin...

2017-01-24 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1399 @mcgilman I think this looks good, it worked well in my testing. The integration tests are passing again. These changes didn't break any tests, but none of the tests in nifi-web-api really exercise

[GitHub] nifi issue #1430: NIFI-3301: Fix cursor style over event type text in lineag...

2017-01-20 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1430 Thanks, @mcgilman , the update looks good. I squashed and merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1430: NIFI-3301: Fix cursor style over event type text in lineag...

2017-01-20 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1430 @mcgilman - Thank you for making this more elaborate fix, I like the way it both looks and works. I have a question about the code diffs, though, it looks like there is a lot of whitespace-only

[GitHub] nifi issue #239: Nifi 1540 - AWS Kinesis Put Processor

2017-02-22 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/239 The JIRA ticket is [NIFI-2892](https://issues.apache.org/jira/browse/NIFI-2892). I don't see recent progress on it, but would that be something you are interested in working on? --- If your project

[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...

2017-02-25 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 Thanks, @jdye64, this is clearly a big improvement. I will continue reviewing the functionality. Some of the issues identified above are still in the latest commit, and should still be addressed

[GitHub] nifi issue #1126: NIFI-1769: Implemented SSE with KMS.

2017-02-21 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1126 Thanks for taking a go at this, @miquillo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1526: NIFI-3514 - Ensures ListGCPBucket triggers serially and fo...

2017-02-22 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1526 @trixpan - Good catch. I had asked @gene-telligent to remove INPUT_ALLOWED, but explicitly declaring INPUT_FORBIDDEN is a best practice. I will review. --- If your project is set up for it, you

[GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-09 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1482#discussion_r100464227 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/credentials/factory/strategies

[GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-09 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1482#discussion_r100472194 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/StorageAttributes.java --- @@ -0,0 +1,98

[GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-09 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1482#discussion_r100471948 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/PutGCSObject.java --- @@ -0,0 +1,523

[GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-09 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1482#discussion_r100463954 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/credentials/factory/strategies

[GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-09 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1482#discussion_r100469527 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/FetchGCSObject.java --- @@ -0,0 +1,340

[GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-09 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1482#discussion_r100469488 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/FetchGCSObject.java --- @@ -0,0 +1,340

[GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-09 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1482#discussion_r100469820 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/ListGCSBucket.java --- @@ -0,0 +1,407

[GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-09 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1482#discussion_r100471880 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/PutGCSObject.java --- @@ -0,0 +1,523

[GitHub] nifi pull request #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-09 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1482#discussion_r100471403 --- Diff: nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/credentials/factory/strategies

[GitHub] nifi issue #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-09 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1482 It looks like the unit tests are failing with the addition of expression language to properties in AbstractGCPProcessor. I thought it was just me, but TravisCI seems to have the same issue

[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...

2017-02-14 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 @joewitt Yes, thanks for getting us moving, I'll continue reviewing. @jdye64 Thanks for the updates, I'll take another look shortly. --- If your project is set up for it, you can reply

[GitHub] nifi issue #1482: NIFI-3449: Adding GCP Framework and GCS Processors

2017-02-12 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1482 @gene-telligent, everything looks good to me, I merged to master. Thanks again for putting together such a great PR. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...

2017-02-15 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 @jdye64 I'm still confused by the disparity between the annotation docs and the behavior of the processor, especially with respect to multiple sheets in the incoming spreadsheet. From the annotations

[GitHub] nifi pull request #929: NIFI-2613 - Apache POI processor to convert Excel do...

2017-02-15 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/929#discussion_r101416263 --- Diff: nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/test/java/org/apache/nifi/processors/poi/ConvertExcelToCSVProcessorTest.java --- @@ -0,0

[GitHub] nifi pull request #929: NIFI-2613 - Apache POI processor to convert Excel do...

2017-02-15 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/929#discussion_r101391692 --- Diff: nifi-assembly/NOTICE --- @@ -541,6 +541,11 @@ The following binary components are provided under the Apache Software License v Apache

[GitHub] nifi pull request #929: NIFI-2613 - Apache POI processor to convert Excel do...

2017-02-15 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/929#discussion_r101393025 --- Diff: nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/main/java/org/apache/nifi/processors/poi/ConvertExcelToCSVProcessor.java --- @@ -0,0 +1,393

[GitHub] nifi pull request #929: NIFI-2613 - Apache POI processor to convert Excel do...

2017-02-15 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/929#discussion_r101391900 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/main/resources/META-INF/services/org.apache.nifi.processor.Processor --- @@ -13,6 +13,7

[GitHub] nifi pull request #929: NIFI-2613 - Apache POI processor to convert Excel do...

2017-02-15 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/929#discussion_r101416358 --- Diff: nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/test/java/org/apache/nifi/processors/poi/ConvertExcelToCSVProcessorTest.java --- @@ -0,0

[GitHub] nifi pull request #929: NIFI-2613 - Apache POI processor to convert Excel do...

2017-02-15 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/929#discussion_r101392180 --- Diff: pom.xml --- @@ -1002,6 +1002,12 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1439: NIFI-3382 New test keystore, truststore (0.x branch...

2017-01-23 Thread jvwing
GitHub user jvwing opened a pull request: https://github.com/apache/nifi/pull/1439 NIFI-3382 New test keystore, truststore (0.x branch) Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #1437: NIFI-3382 New test keystore, truststore

2017-01-23 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1437 I'm sorry I didn't find that earlier, @mcgilman. I would still like to fix this for the 0.x branch. I'll close this PR and open a new PR that is focused only on the certs for 0.x. --- If your

[GitHub] nifi pull request #1437: NIFI-3382 New test keystore, truststore

2017-01-23 Thread jvwing
Github user jvwing closed the pull request at: https://github.com/apache/nifi/pull/1437 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1437: NIFI-3382 New test keystore, truststore

2017-01-23 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1437 The proposed 0.x change is in PR #1439. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1430: NIFI-3301: Fix cursor style over event type text in lineag...

2017-01-18 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1430 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1430: NIFI-3301: Fix cursor style over event type text in lineag...

2017-01-18 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1430 @mcgilman - I certainly don't object to this change, but I'm not convinced it resolves a lot of friction in the lineage graph. On Chrome and Firefox, removing the "pointer" style results in

[GitHub] nifi issue #1416: NIFI-3350 optimized documentation extraction to reduce sta...

2017-01-20 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1416 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1430: NIFI-3301: Fix cursor style over event type text in lineag...

2017-01-19 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1430 @mcgilman Your argument for consistency is very persuasive, and I would agree that adding the move/grab cursor is inconsistent. A brief comparison with the flow canvas: - Arrow/default

[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...

2017-02-27 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 Thanks, @jdye64, that got it. I was able to build just fine with contrib-check and everything. On to new topics: * **License/Notice** - We need a separate LICENSE and NOTICE files for nifi

[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...

2017-02-27 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 @jdye64 Thanks for the update. I'll look into why I'm seeing the POM issue. Don't worry about squashing, I'll take care of that when we're ready to merge. --- If your project is set up for it, you

[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...

2017-02-27 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 @jdye64, I am still having trouble with the root `pom.xml` file. The version number is still `1.0.0-SNAPSHOT` [on line 1006](https://github.com/apache/nifi/pull/929/files

[GitHub] nifi issue #917: NIFI-2631: Adding 'Commit Mode' and 'Use Versions' to ListS...

2016-08-31 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/917 @gresockj, would it be OK if we review/polish this PR first and leave the 0.x PR #916 unit we're finished? I don't want you to have to duplicate effort -- I believe the branches are fairly similar

[GitHub] nifi issue #917: NIFI-2631: Adding 'Commit Mode' and 'Use Versions' to ListS...

2016-09-02 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/917 @gresockj No, I have not noticed that, and I've been viewing and clearing the state along with my testing. Are there javascript errors in your browser? Are you familiar with browser debugging tools

[GitHub] nifi issue #917: NIFI-2631: Adding 'Commit Mode' and 'Use Versions' to ListS...

2016-09-02 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/917 I tried a simple cluster running in a docker container, and state seemed to work just fine. I tested ListS3 running both on the primary node only and across the cluster nodes. The state API json

[GitHub] nifi issue #917: NIFI-2631: Adding 'Commit Mode' and 'Use Versions' to ListS...

2016-09-03 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/917 Thanks for the test upgrades, @gresockj, they look good. I will merge shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1008: NIFI-2763 S3 processors do not work with older S3-compatib...

2016-09-13 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1008 @baank , what would you think about moving the PropertyDescriptor and the configuration code to the AbstractS3Processor class rather than AWSAbstractProcessor? --- If your project is set up

[GitHub] nifi issue #239: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-09-23 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/239 @mans2singh, I agree the licensing issues prevent it from being bundled with NiFi as-is. But there might be a few options to move forward and keep the benefits of your work: * Publish

[GitHub] nifi issue #1042: NIFI-2795 Sys Diagnostics in Cluster UI

2016-09-26 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1042 @mcgilman Your changes look good to me. I had noticed that filter behavior, but I wasn't sure how intentional it was. Your fix does allow filtering by the full address or status text as displayed

[GitHub] nifi issue #1076: NIFI-2763: S3 processors do not work with older S3-compati...

2016-09-28 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1076 Thanks, @baank. The updates look good, I like the drop-down solution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

2016-09-29 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/583 I pushed another update to rebase on the latest master, and add a Versions tab to the Cluster UI using the version-enriched system diagnostics data. --- If your project is set up for it, you can reply

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-07 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1112#discussion_r82451044 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies

[GitHub] nifi pull request #267: NIFI-1614 File Identity Provider implementation

2016-10-07 Thread jvwing
Github user jvwing closed the pull request at: https://github.com/apache/nifi/pull/267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #267: NIFI-1614 File Identity Provider implementation

2016-10-07 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/267 Sorry, I have not kept this up to date with changes in master. I will close this PR for now. It may be a better fit for a future extension repository. --- If your project is set up for it, you can

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-06 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1112#discussion_r82326589 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-06 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1112#discussion_r82326547 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-06 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1112#discussion_r82327829 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies

[GitHub] nifi issue #239: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-09-23 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/239 @mans2singh, do you plan to continue working on this PR? If not, would you please close it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #1042: NIFI-2795 Sys Diagnostics in Cluster UI

2016-09-23 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1042 I added server- and client-side modifications to pre-authorize the system diagnostics API call, and removed the unnecessary error handling code. --- If your project is set up for it, you can reply

[GitHub] nifi issue #1008: NIFI-2763 S3 processors do not work with older S3-compatib...

2016-09-16 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1008 Our current intentions are specific to S3, as are the implementation and tests, so I would prefer starting with S3 alone and refactoring later if/when there is demand for a wider option. Also, I

[GitHub] nifi pull request #1042: NIFI-2795 Sys Diagnostics in Cluster UI

2016-09-21 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1042#discussion_r79936607 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/cluster/nf-cluster-table.js --- @@ -24,13 +24,275

[GitHub] nifi pull request #1042: NIFI-2795 Sys Diagnostics in Cluster UI

2016-09-21 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1042#discussion_r79936555 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/cluster/nf-cluster-table.js --- @@ -377,190 +952,45

[GitHub] nifi issue #1042: NIFI-2795 Sys Diagnostics in Cluster UI

2016-09-27 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1042 Thank you, @mcgilman. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #239: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-10-02 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/239 @mans2singh - that sounds great to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #1125: NIFI-2872 Create PutCloudwatchMetric Processor

2016-10-12 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1125#discussion_r83091812 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java --- @@ -0,0

[GitHub] nifi pull request #1125: NIFI-2872 Create PutCloudwatchMetric Processor

2016-10-12 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1125#discussion_r83092101 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java --- @@ -0,0

[GitHub] nifi issue #1125: NIFI-2872 Create PutCloudwatchMetric Processor

2016-10-12 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1125 @vegaed Thanks for the updated code. The situation with AbstractAWSProcessor is a bit odd. It's deprecated in that you should not derive directly from it, but it still has live code we're definitely

[GitHub] nifi pull request #1112: NIFI-2799: AWS Credentials for Assume Role Need Pro...

2016-10-10 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1112#discussion_r82635524 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies

[GitHub] nifi pull request #1126: NIFI-1769: Implemented SSE with KMS.

2016-10-18 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1126#discussion_r83902231 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/test/java/org/apache/nifi/processors/aws/s3/ITPutS3Object.java --- @@ -50,14 +44,19

[GitHub] nifi pull request #1126: NIFI-1769: Implemented SSE with KMS.

2016-10-18 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1126#discussion_r83904222 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java --- @@ -458,6 +471,13

[GitHub] nifi pull request #1126: NIFI-1769: Implemented SSE with KMS.

2016-10-18 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1126#discussion_r83904288 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java --- @@ -551,6 +571,13

[GitHub] nifi pull request #1126: NIFI-1769: Implemented SSE with KMS.

2016-10-18 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1126#discussion_r83901899 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java --- @@ -200,15 +201,24

[GitHub] nifi pull request #1126: NIFI-1769: Implemented SSE with KMS.

2016-10-18 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1126#discussion_r83904092 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java --- @@ -458,6 +471,13

[GitHub] nifi pull request #1126: NIFI-1769: Implemented SSE with KMS.

2016-10-18 Thread jvwing
Github user jvwing commented on a diff in the pull request: https://github.com/apache/nifi/pull/1126#discussion_r83901386 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java --- @@ -39,47 +80,6

[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...

2016-10-18 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 @jdye64 I still had trouble building and running NiFi with this PR. * root POM still references nifi-poi-bundle version "1.0-SNAPSHOT" * nifi-poi-nar still has a dependency o

[GitHub] nifi issue #929: NIFI-2613 - Apache POI processor to convert Excel documents...

2016-10-18 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/929 I have a few more comments from running the processor and reviewing the code: **Processor Annotations** * The CapabilityDescription says this processor transfers one flowfile for each

[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

2016-10-24 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/583 I pushed another update with changes from feedback: - Removed OS/JVM information from the AboutDTO and About Dialog - Updated the layout of the About Dialog to always show the additional

[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

2016-10-20 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/583 @mcgilman Thanks, I had not considered the API access distinction, and that sounds like a sensible split between system diagnostics and the about dialog. I'll try that out with an adjusted about

[GitHub] nifi issue #1222: NIFI-3033 GenerateFlowFile Dynamic Properties

2016-11-17 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1222 Thanks for merging, @ijokarumawak --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #1222: NIFI-3033 GenerateFlowFile Dynamic Properties

2016-11-14 Thread jvwing
GitHub user jvwing opened a pull request: https://github.com/apache/nifi/pull/1222 NIFI-3033 GenerateFlowFile Dynamic Properties Updated GenerateFlowFile for dynamic properties: * Enable dynamic properties with expression language * Apply dynamic property values

[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

2016-11-02 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/583 @mcgilman You caught me :), sorry, I did miss your previous comment. Let me see what I can do. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

2016-11-03 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/583 Thanks for your help, @mcgilman. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

2016-11-02 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/583 @mcgilman - I fixed two issues that you pointed out: 1. The About dialog no longer shows the "Tagged" label when there is nothing in nifi.properties 2. I added "

[GitHub] nifi pull request #1182: NIFI-2948 Fix DynamoDB Cached Credentials

2016-11-03 Thread jvwing
GitHub user jvwing opened a pull request: https://github.com/apache/nifi/pull/1182 NIFI-2948 Fix DynamoDB Cached Credentials This is a minimal change to clear the cached DynamoDB Document Client containing credentials when the processor is stopped. --- Thank you

[GitHub] nifi issue #1182: NIFI-2948 Fix DynamoDB Cached Credentials

2016-11-04 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/1182 Thank you, @olegz --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #239: Nifi 1540 - AWS Kinesis Put Processor

2016-10-11 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/239 @miquillo, would you please expand on your comment on Kinesis Stream limits? I believe the code so far respects the batch limits for both records and bytes. The BATCH_SIZE property is validated for 1

  1   2   3   >