[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197459885 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarConsumerProcessor.java

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197451729 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197465732 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarProducerProcessor.java

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197459415 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarConsumerProcessor.java

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197461736 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarProducerProcessor.java

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197460837 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarProcessor.java

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197519036 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarConsumerProcessor.java

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-22 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197519282 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-client-service/src/main/java/org/apache/nifi/pulsar/StandardPulsarClientService.java --- @@ -0,0

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-25 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197786403 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarConsumerProcessor.java

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-25 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197786927 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/ConsumePulsar.java --- @@ -0,0

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-25 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197787589 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/pubsub/PublishPulsar.java --- @@ -0,0

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-25 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197788509 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarProducerProcessor.java

[GitHub] nifi pull request #2702: Added Apache Pulsar processors

2018-06-25 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2702#discussion_r197906886 --- Diff: nifi-nar-bundles/nifi-pulsar-bundle/nifi-pulsar-processors/src/main/java/org/apache/nifi/processors/pulsar/AbstractPulsarProducerProcessor.java

[GitHub] nifi pull request #2831: NIFI-5361: When submitting many processors to start...

2018-07-02 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2831 NIFI-5361: When submitting many processors to start, calculate the 't… …imeout timestamp' immediately before calling @OnScheduled method, after the task has been scheduled to run,

[GitHub] nifi pull request #2832: NIFI-5362: When a processor is terminated and has n...

2018-07-02 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2832 NIFI-5362: When a processor is terminated and has no more active thre… …ads, ensure that we set this.hasActiveThreads = false Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi pull request #2867: NIFI-5394: Ensure that we wait for service to be fu...

2018-07-09 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2867 NIFI-5394: Ensure that we wait for service to be fully enabled when e… …nabling a group, before moving on to the next in the list Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #2869: NIFI-5370 Resolve wildcard certificate issue in secure clu...

2018-07-10 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2869 @alopresto Thanks. The code change makes sense. Was able to verify behavior. I definitely agree with your assessment above for the pros and cons of wildcard certs. +1 merged to master ---

[GitHub] nifi issue #2873: NIFI-5368 controller services validated prior to enabling;...

2018-07-10 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2873 @markobean Thanks for the fix! Code looks good. Verified that all builds as expected. +1 merged to master. ---

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202705819 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/AbstractListProcessor.java

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202721147 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/ListedEntityTracker.java --- @@ -0,0

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202720481 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/ListedEntityTracker.java --- @@ -0,0

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202722240 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/ListedEntity.java --- @@ -0,0 +1,44

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202716202 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/ListedEntityTracker.java --- @@ -0,0

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202719150 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/ListedEntityTracker.java --- @@ -0,0

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202715409 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/ListedEntityTracker.java --- @@ -0,0

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202714807 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/ListedEntityTracker.java --- @@ -0,0

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202719634 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/ListedEntityTracker.java --- @@ -0,0

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202714356 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/ListedEntityTracker.java --- @@ -0,0

[GitHub] nifi pull request #2876: NIFI-5406: Adding new listing strategy to List proc...

2018-07-16 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2876#discussion_r202748684 --- Diff: nifi-nar-bundles/nifi-extension-utils/nifi-processor-utils/src/main/java/org/apache/nifi/processor/util/list/ListedEntityTracker.java --- @@ -0,0

[GitHub] nifi pull request #2897: NIFI-4407: Updated Expression Language Guide to pro...

2018-07-16 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2897 NIFI-4407: Updated Expression Language Guide to provide details about… … how escaping $ is accomplished, and when the $ character should and should not be escaped. Fixed bug in the Query

[GitHub] nifi pull request #2897: NIFI-4407: Updated Expression Language Guide to pro...

2018-07-16 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/2897 ---

[GitHub] nifi pull request #2898: NIFI-4407: Updated Expression Language Guide to pro...

2018-07-16 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2898 NIFI-4407: Updated Expression Language Guide to provide details about… … how escaping $ is accomplished, and when the $ character should and should not be escaped. Fixed bug in the Query

[GitHub] nifi issue #2876: NIFI-5406: Adding new listing strategy to List processors.

2018-07-17 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2876 @ijokarumawak thanks for the updates! Code looks good! I will run a few tests and if all looks good will merge to master. Thanks! ---

[GitHub] nifi issue #2876: NIFI-5406: Adding new listing strategy to List processors.

2018-07-17 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2876 All of my testing looks good as well. +1 merged to master. Thanks for the improvement, @ijokarumawak ! ---

[GitHub] nifi pull request #2918: NIFI-5465: Set the Idle Timeout on jetty connectors...

2018-07-26 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2918 NIFI-5465: Set the Idle Timeout on jetty connectors to the same as th… …e Request Timeout. Thank you for submitting a contribution to Apache NiFi. In order to streamline the

[GitHub] nifi issue #2918: NIFI-5465: Set the Idle Timeout on jetty connectors to the...

2018-07-26 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2918 An easy way to test the PR is to try running the following code (updating the URL in the second line of code to point to a running HandleHttpRequest processor): ``` public static void

[GitHub] nifi issue #2909: NIFI-5445 changing property for listen processors to allow...

2018-07-27 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2909 @nicholasmhughes This isn't really something that we can do right now, as it would be a breaking change. Also, it takes away some important functionality for some users. In a clustered enviro

[GitHub] nifi issue #2886: NIFI-5420: Allow StandardProcessSession to calculate durat...

2018-07-27 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2886 Reviewing... ---

[GitHub] nifi issue #2886: NIFI-5420: Allow StandardProcessSession to calculate durat...

2018-07-27 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2886 +1 from me, code looks good. All unit tests pass. Did a quick sanity check testing and all appears to work as expected. Minor change but definitely will have a positive impact. Thanks, @mattyb149 ! ---

[GitHub] nifi pull request #2932: NIFI-5480: Use FlowController's maps of components ...

2018-08-01 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2932 NIFI-5480: Use FlowController's maps of components in order to look u… …p component by ID rather than iterating recursively through all Process Groups to find the component Than

[GitHub] nifi pull request #2918: NIFI-5465: Set the Idle Timeout on jetty connectors...

2018-08-06 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/2918 ---

[GitHub] nifi pull request #2938: NIFI-5491: Fixed PutHive3Streaming handling of Byte...

2018-08-06 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2938#discussion_r207986292 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/hive/streaming/NiFiRecordSerDe.java --- @@ -227,8 +236,32

[GitHub] nifi pull request #2938: NIFI-5491: Fixed PutHive3Streaming handling of Byte...

2018-08-06 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2938#discussion_r207981236 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/hive/streaming/NiFiRecordSerDe.java --- @@ -227,8 +236,32

[GitHub] nifi pull request #2938: NIFI-5491: Fixed PutHive3Streaming handling of Byte...

2018-08-06 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2938#discussion_r207985881 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/hive/streaming/NiFiRecordSerDe.java --- @@ -205,7 +212,9

[GitHub] nifi pull request #2938: NIFI-5491: Fixed PutHive3Streaming handling of Byte...

2018-08-06 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2938#discussion_r207985525 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/hive/streaming/NiFiRecordSerDe.java --- @@ -227,8 +236,32

[GitHub] nifi pull request #2939: NIFI-5466: Keep a running total of stats for each c...

2018-08-07 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2939 NIFI-5466: Keep a running total of stats for each component. Refactor… …ed FlowFileEvent and repository in order to provide more efficient storage of objects on Java heap by allowing the same

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-08-14 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2947 [WIP] NIFI-5516: Implement Load-Balanced Connections This is a very involved new feature. At this point, it is functioning well but has the following caveats: - We need to do a better job of

[GitHub] nifi-registry pull request #136: NIFIREG-194: Updated VersionedConnection to...

2018-08-14 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi-registry/pull/136 NIFIREG-194: Updated VersionedConnection to support load balancing co… …nfiguration You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] nifi-registry issue #136: NIFIREG-194: Updated VersionedConnection to suppor...

2018-08-14 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi-registry/pull/136 @bbende good catch. Yes, there should be allowable values added there. Just pushed another commit to address. ---

[GitHub] nifi pull request #2948: NIFI-5518: Added processors for integrating with Ap...

2018-08-14 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2948 NIFI-5518: Added processors for integrating with Apache Kafka 2.0 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #2833: NIFI-5353: Add JoltTransformRecord processor

2018-08-14 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2833#discussion_r210045133 --- Diff: nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/main/java/org/apache/nifi/processors/jolt/record/JoltTransformRecord.java

[GitHub] nifi pull request #2833: NIFI-5353: Add JoltTransformRecord processor

2018-08-14 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2833#discussion_r210048593 --- Diff: nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/main/java/org/apache/nifi/processors/jolt/record/JoltTransformRecord.java

[GitHub] nifi pull request #2833: NIFI-5353: Add JoltTransformRecord processor

2018-08-14 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2833#discussion_r210043658 --- Diff: nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/main/java/org/apache/nifi/processors/jolt/record/JoltTransformRecord.java

[GitHub] nifi pull request #2929: NIFI-5474 ReplaceText RegexReplace evaluates payloa...

2018-08-14 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2929#discussion_r210061986 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java --- @@ -701,6

[GitHub] nifi pull request #2929: NIFI-5474 ReplaceText RegexReplace evaluates payloa...

2018-08-14 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2929#discussion_r210062380 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java

[GitHub] nifi pull request #2929: NIFI-5474 ReplaceText RegexReplace evaluates payloa...

2018-08-14 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2929#discussion_r210062603 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java

[GitHub] nifi pull request #2929: NIFI-5474 ReplaceText RegexReplace evaluates payloa...

2018-08-15 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2929#discussion_r210253136 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java --- @@ -701,6

[GitHub] nifi pull request #2951: NIFI-5474: When using Regex Replace with ReplaceTex...

2018-08-15 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2951 NIFI-5474: When using Regex Replace with ReplaceText, and there are capturing groups, ensure that we populate the 'additionalVariables' map for each match of the regex. This allows Expressio

[GitHub] nifi issue #2929: NIFI-5474 ReplaceText RegexReplace evaluates payload as Ex...

2018-08-15 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2929 @ottobackwards see https://github.com/apache/nifi/pull/2951 - I think this gives us what we need as alternative approach to NIFI-4272 so that we never need to evaluate Expression Language against

[GitHub] nifi pull request #2952: NIFI-5331: When checkpointing SequentialAccessWrite...

2018-08-15 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2952 NIFI-5331: When checkpointing SequentialAccessWriteAheadLog, if the j… …ournal is not healthy, ensure that we roll it over and ensure that if an Exception is thrown when attempting to fsync

[GitHub] nifi issue #2951: NIFI-5474: When using Regex Replace with ReplaceText, and ...

2018-08-15 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2951 @mosermw ha! It's *really* easy to miss these things when reviewing! @ottobackwards for what it's worth, I learned some new things about the Pattern/Matcher API as well, when looking in

[GitHub] nifi pull request #2954: NIFI-5514: Fixed bugs in MergeRecord around minimum...

2018-08-16 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2954 NIFI-5514: Fixed bugs in MergeRecord around minimum thresholds not be… …ing honored and validation not being performed to ensure that minimum threshold is smaller than max threshold (would

[GitHub] nifi pull request #2955: NIFI-5527: Refactored unit test to make member vari...

2018-08-16 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2955 NIFI-5527: Refactored unit test to make member variables for 'delay t… …olerances' so that they are easier to update in the future. Increased delay tolerances so that tests pass

[GitHub] nifi issue #2939: NIFI-5466: Keep a running total of stats for each componen...

2018-08-21 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2939 Thanks @bbende - I fixed the missing headers and merged to master. ---

[GitHub] nifi pull request #2960: NIFI-5482: Made WriteAheadProvenanceRepository the ...

2018-08-22 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2960 NIFI-5482: Made WriteAheadProvenanceRepository the default implementa… …tion Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the

[GitHub] nifi issue #2961: NIFI-5479: Upgrade Jetty

2018-08-23 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2961 @mcgilman I was able to verify that the HandleHttpRequest and HandleHttpResponse processors still work - and in fact work better! This appears to have addressed NIFI-5522. ---

[GitHub] nifi issue #2961: NIFI-5479: Upgrade Jetty

2018-08-23 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2961 Of note, I was also able to verify PostHTTP, ListenHTTP, and HandleHttpRequest/Response both using SSL Context and without SSLContext. ---

[GitHub] nifi issue #2961: NIFI-5479: Upgrade Jetty

2018-08-23 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2961 @ijokarumawak as far as I'm concerned, I'm a +1 on this. If you're also happy with it, please feel free to go ahead and merge to master & mark as resolved. Thanks! And thanks @

[GitHub] nifi pull request #2964: NIFI-5551: If session.get() returns null, then retu...

2018-08-24 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2964 NIFI-5551: If session.get() returns null, then return fron onTrigger … …instead of assuming that the FlowFile is non-null Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #2833: NIFI-5353: Add JoltTransformRecord processor

2018-08-28 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2833 @mattyb149 thanks for the updates! This is looking much better now. Was able to run through some simple test cases and everything appears to work as expected. +1 merged to master! ---

[GitHub] nifi issue #2966: NIFI-5552 - Add option to normalize header column names in...

2018-08-29 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2966 Hey @pvillard31 thanks for putting up a PR! I looked through it, and I do believe that it would resolve the issue that is being described in NIFI-5552. However, I'm not entirely sure that th

[GitHub] nifi pull request #2974: NIFI-5533: Be more efficient with heap utilization

2018-08-29 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2974 NIFI-5533: Be more efficient with heap utilization Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] nifi issue #2966: NIFI-5552 - Add option to normalize header column names in...

2018-08-30 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2966 @pvillard31 we don't want to change `recordField.getFieldName()` - that is the NiFi class and has nothing to do with Avro. We really want to avoid enforcing any Avro naming peculiarities on

[GitHub] nifi pull request #2979: [WIP] An experiment that I am looking at to elimina...

2018-08-30 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2979 [WIP] An experiment that I am looking at to eliminate what appears to be unneeded synchronization in the WriteAheadProvenanceRepository. Not ready to be merged to master yet. …. Also, unclear if

[GitHub] nifi pull request #2920: NIFI-5449: Added Base64 Encode/Decode functions to ...

2018-09-05 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2920#discussion_r215409006 --- Diff: nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/functions/Base64Encode.java --- @@ -0,0 +1,58 @@ +/* + * Licensed

[GitHub] nifi pull request #2996: NIFI-5581: Disable connection pooling for OkHttpRep...

2018-09-07 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/2996 NIFI-5581: Disable connection pooling for OkHttpReplicationClient. We… … should revisit this in the future, but for now, it appears that Jetty is having problems with the connections if they

[GitHub] nifi pull request #2986: NIFI-3425: Provide ability to cache CQL statements

2018-09-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2986#discussion_r216411646 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraQL.java

[GitHub] nifi pull request #2986: NIFI-3425: Provide ability to cache CQL statements

2018-09-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2986#discussion_r216411528 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/main/java/org/apache/nifi/processors/cassandra/PutCassandraQL.java

[GitHub] nifi pull request #2986: NIFI-3425: Provide ability to cache CQL statements

2018-09-10 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2986#discussion_r21640 --- Diff: nifi-nar-bundles/nifi-cassandra-bundle/nifi-cassandra-processors/src/test/java/org/apache/nifi/processors/cassandra/PutCassandraQLTest.java

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-12 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r217047466 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ConnectionDTO.java --- @@ -231,6

[GitHub] nifi issue #2947: [WIP] NIFI-5516: Implement Load-Balanced Connections

2018-09-12 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2947 @ijokarumawak The scenario that you laid out to drop flowfiles should work just fine. I have tested it several times and just tested again. All FlowFiles were successfully dropped for me. Can you

[GitHub] nifi pull request #3001: NIFI-5592: If an Exception is thrown by RecordReade...

2018-09-13 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3001 NIFI-5592: If an Exception is thrown by RecordReader.read() from Cons… …umeKafkaRecord, route Record to parse.failure relationship Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #2948: NIFI-5518: Added processors for integrating with Apache Ka...

2018-09-13 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2948 @pvillard31 that's a good catch. I pushed a new update that addresses NIFI-5592 and NIFI-5388 for the 2.0 processors. ---

[GitHub] nifi pull request #3004: NIFI-5597: Restored FreeFormTextRecordSetWriter to ...

2018-09-14 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3004 NIFI-5597: Restored FreeFormTextRecordSetWriter to the META-INF servi… …ces file Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of

[GitHub] nifi pull request #3005: NIFI-5598: Allow JMS Processors to lookup Connectio...

2018-09-14 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3005 NIFI-5598: Allow JMS Processors to lookup Connection Factory via JNDI Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi issue #2995: NIFI-5577 Fixing update method in NaiveRevisionManager so ...

2018-09-14 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2995 Reviewing... ---

[GitHub] nifi issue #2995: NIFI-5577 Fixing update method in NaiveRevisionManager so ...

2018-09-14 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2995 @bbende thanks for the fix! All looks good to me. +1 merged to master. ---

[GitHub] nifi issue #2986: NIFI-3425: Provide ability to cache CQL statements

2018-09-14 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2986 Thanks @mattyb149 , all looks good to me now. +1 merged to master. ---

[GitHub] nifi issue #2947: [WIP] NIFI-5516: Implement Load-Balanced Connections

2018-09-15 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2947 @ijokarumawak thanks for that update, very cool! Will definitely make it easier to test. ---

[GitHub] nifi issue #2947: [WIP] NIFI-5516: Implement Load-Balanced Connections

2018-09-15 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/2947 @jtstorck correct, the position in the queue is per-node. It is not intended to be unique and is not an identifier. Rather, it shows -for this node - how far is this FlowFile from the top of the

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-18 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r218436154 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/partition

[GitHub] nifi pull request #3005: NIFI-5598: Allow JMS Processors to lookup Connectio...

2018-09-18 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3005#discussion_r218438047 --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/cf/JndiJmsConnectionFactoryProvider.java --- @@ -0,0

[GitHub] nifi pull request #3005: NIFI-5598: Allow JMS Processors to lookup Connectio...

2018-09-18 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/3005#discussion_r218439155 --- Diff: nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/cf/JndiJmsConnectionFactoryProvider.java --- @@ -0,0

[GitHub] nifi issue #3005: NIFI-5598: Allow JMS Processors to lookup Connection Facto...

2018-09-18 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3005 @bdesert fair enough re: sensitive property & credentials. ---

[GitHub] nifi issue #3005: NIFI-5598: Allow JMS Processors to lookup Connection Facto...

2018-09-18 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/3005 @bdesert thanks for the great feedback. I have pushed another commit. ---

[GitHub] nifi pull request #2947: [WIP] NIFI-5516: Implement Load-Balanced Connection...

2018-09-18 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2947#discussion_r218448137 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/partition

[GitHub] nifi pull request #2991: NIFI-3469: multipart request support added to Handl...

2018-09-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2991#discussion_r218798942 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java

[GitHub] nifi pull request #2991: NIFI-3469: multipart request support added to Handl...

2018-09-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2991#discussion_r218799259 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java

[GitHub] nifi pull request #2991: NIFI-3469: multipart request support added to Handl...

2018-09-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2991#discussion_r218816915 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java

[GitHub] nifi pull request #3012: NIFI-5609: Fixed NullPointer when attempting to vie...

2018-09-19 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/3012 NIFI-5609: Fixed NullPointer when attempting to view status history f… …or a component that has not yet run Thank you for submitting a contribution to Apache NiFi. In order to

<    5   6   7   8   9   10   11   12   13   14   >