GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/727
NIFI-1663: Add ConvertAvroToORC processor
This PR is based on #706 which removed the ConvertAvroToORC processor using
Hive 2.x and Apache ORC 1.x. This PR replaces that processor with one that uses
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/642
NIFI-2156: Add ListDatabaseTables processor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2156
Alternatively you can
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/649
+1 LGTM built (against latest master) and tested. Want to rebase the
commits or push as is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/254#discussion_r71980920
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONtoCSV.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/254#discussion_r71980929
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONtoCSV.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/254#discussion_r71981018
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONtoCSV.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/254#discussion_r71981054
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONtoCSV.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/254#discussion_r71980960
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONtoCSV.java
---
@@ -0,0
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/744
NIFI-2422: Fix SelectHiveQL handling of Number types
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2422
Alternatively
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/706#discussion_r72797764
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java
---
@@ -0,0 +1,657
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/706#discussion_r72871651
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java
---
@@ -0,0 +1,657
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/547
+1 LGTM, ran tests with Hadoop 2.6.2 and 2.7.0, all passed. Merging to
master, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/706
Per an offline discussion with @bbende, we decided a good way to handle the
outgoing flow files is to have a "success", "failure", and "retry"
relationship. If a
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/777
yes please :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/823
NIFI-2531: Fixed JdbcCommon handling of BigInteger objects for Avro
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-2531
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/823
Good point, let me see if I can use the column width (for BIGINT types) to
determine whether to expect a long or string in the value.
---
If your project is set up for it, you can reply
Github user mattyb149 closed the pull request at:
https://github.com/apache/nifi/pull/830
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/777#discussion_r74322615
--- Diff: nifi-docs/src/main/asciidoc/expression-language-guide.adoc ---
@@ -993,6 +954,229 @@ Expressions will provide the following results
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/777
Either is good, a new PR on a new branch would just get you in the habit of
using a "feature branch" for development versus the local master branch.
---
If your project is set up for i
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/706
Yeah I think that's a bug in this version of Hive:
https://issues.apache.org/jira/browse/HIVE-13725
For now I'd like to make the processor TriggerSerially (unless there are
any objections
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/710#discussion_r73515360
--- Diff:
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/AbstractEmailProcessor.java
---
@@ -0,0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/710#discussion_r73515235
--- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/pom.xml
---
@@ -1,73 +1,84 @@
-
-http://maven.apache.org/POM/4.0.0
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/727#discussion_r73520631
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/hadoop/hive/ql/io/orc/NiFiOrcUtils.java
---
@@ -0,0 +1,466
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/710
I ran ConsumePop3 against GMail but hadn't seen your comment on all the
dynamic properties that need to be set. I started and stopped the processor,
but there is a thread continuing to run. Stopped
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/710#discussion_r73518325
--- Diff:
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ConsumeIMAP.java
---
@@ -0,0 +1,91
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/710
+1 to the "Additional Details" file for all the dynamic properties, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/727#discussion_r73331884
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/hadoop/hive/ql/io/orc/NiFiOrcUtils.java
---
@@ -0,0 +1,466
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/727
I see a few comments about PutHiveStreaming, that is part of a previous
commit that is being handled under #706, it's just in here in order to inherit
the downgrade of Hive. Only the last commit
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/777
#833 has been merged (thanks again!) Would you mind closing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/833
+1 Great job! I built, ran, and tested the functions with escaped/unescaped
inputs and empty strings, everything works well. Thanks again for the
contribution! Will merge to master.
---
If your
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/564
I had forgotten about the checked exception thing. If the lamdbas/streams
are just as awkward as Java 7 code (due to the exceptions, etc.) then there's
probably no need to force it. Everything else
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/645
NIFI-2157: Add GenerateTableFetch processor
Refactored common code out of QueryDatabaseTable into an Abstract base
class, which involved some refactor of QueryDatabaseTable as well as the added
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/475
Since other Apache projects are taking the stance of including the
repositories in the top-level POM, I think NiFi should too. These would include
(at a minimum) the MapR, Cloudera, and Hortonworks
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/596
+1 LGTM, built and ran with a 3-node cluster. Took one node offline,
changed it's template information, then restarted and it reconnected
successfully. Would be nice to have an integration test
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/642
Yes, at one point I had a "Refresh Interval" property but I think that was
in another branch, will restore it. Also, currently any change to properties
will reset the state (since the tabl
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/645#discussion_r71087671
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/642#discussion_r71091826
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/642#discussion_r71093459
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/645#discussion_r71074368
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/629
+1 LGTM, reproduced the issue then tested with the fix, verified the error
is no longer present
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/616
NIFI-1998: Update Cassandra processor docs to include 3.0.x clusters
Compatibility matrix here:
http://datastax.github.io/java-driver/manual/native_protocol/
You can merge this pull request
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/564#discussion_r70156828
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-jolt-transform-json-ui/src/main/java/org/apache/nifi/web/standard/api/transformjson
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/564#discussion_r70156926
--- Diff:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/file/classloader/ClassLoaderUtils.java
---
@@ -0,0 +1,66 @@
+/*
+ * Licensed
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/564#discussion_r70157498
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoltTransformJSON.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/564#discussion_r70157576
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoltTransformJSON.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/564#discussion_r70157635
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/JoltTransformJSON.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/710#discussion_r73770089
--- Diff:
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/resources/docs/org.apache.nifi.processors.email.ConsumePOP3/additionalDetails.html
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/710#discussion_r73769802
--- Diff:
nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/resources/docs/org.apache.nifi.processors.email.ConsumeIMAP/additionalDetails.html
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/710
+1 LGTM, ran tests and verified comments were incorporated, merging to
master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/699
+1 LGTM, was able to build and run with various vendor-specific Hadoop
versions (after some small tweaks I'll add to the PR before merging). Merging
to master
---
If your project is set up
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/727
Closing the PR and cancelling the current patch as there are issues with
complex types, will reopen once fixed
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/812
NIFI-2026: Moved vendor repositories into Maven profiles
@trixpan Basically moved the repos into profiles and added default
properties so users can see the naming pattern (might help them select
Github user mattyb149 closed the pull request at:
https://github.com/apache/nifi/pull/727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/818
NIFI-2520: Added attribution for storm-hive and other Hive dependencies to
NOTICEs
Also removed Apache ORC as it is not used (hive-orc within the Apache Hive
project is used instead)
You can
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/821
NIFI-2518: Added support for fractional seconds to
AbstractDatabaseFetchProcessor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/706
Yes that's a good idea, will update, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/813
+1 LGTM, merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/727#discussion_r73331820
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/hadoop/hive/ql/io/orc/NiFiOrcUtils.java
---
@@ -0,0 +1,466
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/872#discussion_r74981298
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/test/groovy/org/apache/nifi/web/security/x509/ocsp
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/865
NIFI-2552: Updated Curator for HiveQL processors using Zookeeper quorum in
URL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75051154
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75051588
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75051737
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75051357
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75051853
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75051917
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/QueryDatabaseTableTest.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/850#discussion_r75044228
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/DeleteHDFS.java
---
@@ -0,0 +1,161
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/850#discussion_r75044175
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/DeleteHDFS.java
---
@@ -0,0 +1,161
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75114893
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
Everything looks good and works well, thanks! @patricker what do you think
about adding fragment.count? Could be a later improvement but I think it'd be a
good thing to add if not too troublesome
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75120131
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75114294
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/877#discussion_r75114562
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
Your second commit is labelled NIFI-2584, but I believe it's for NIFI-2583.
Would you mind re-submitting with the new commit label? Just want to make sure
when the merge happens that the Jira trail
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/877
+1 LGTM, thanks again for the great contribution! Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/850
Just a couple of minor comments; otherwise looks great, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/850#discussion_r75044365
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestDeleteHDFS.java
---
@@ -0,0 +1,187
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1407#discussion_r98680344
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1407#discussion_r98680239
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1407#discussion_r98684537
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1407#discussion_r98898226
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/1461
NIFI-3426: Add dynamic property support to DBCPConnectionPool
Unit test adds "create=true" as a Derby property (instead of via the URL),
written in Groovy to leverage the recursive
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1450
My use case is a third-party library that takes the same information you
might put into a DBCPControllerService, either in the URL and/or the
username/password, etc. I was hoping to avoid trying
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1407#discussion_r99111299
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractDatabaseFetchProcessor.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1450
Koji has a good point about managing the actual DataSource instance
internally, if your use case can be accomplished without needing access to this
object, then I would tend to agree that we
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1455
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1455#discussion_r98484332
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java
---
@@ -218,6 +218,16
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1455
+1 LGTM, ran full Maven build (with CheckStyle, made a minor edit) and
tested on a running NiFi instance connected to a HDP Sandbox. Thank you for
your contribution! Merging to master
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1382
@pvillard31 It might be in the 0.x branch but I wouldn't expect it in
master since that's on Java 8
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1367
@pvillard31 I forgot to put the magic string in the commit, do you mind
closing this PR? Please and thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1367
+1 LGTM, ran contrib-check and tests on all the affected modules,
everything looks good, thank you! Merging to master
---
If your project is set up for it, you can reply to this email and have
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1471#discussion_r101091944
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -192,31
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1471#discussion_r101078853
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteSQL.java
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/709
@trixpan I'll take this one. The code LGTM, just needs a rebase and I will
fix the typo and add the test validation(s) I mentioned in the comments.
Thank you for the contribution
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1471#discussion_r101091302
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -192,31
Github user mattyb149 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1471#discussion_r101081936
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteSQL.java
---
@@ -192,31
Github user mattyb149 closed the pull request at:
https://github.com/apache/nifi/pull/988
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/988
Closing for now, rework is needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mattyb149 closed the pull request at:
https://github.com/apache/nifi/pull/1199
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1471
I just noticed in the added unit test that one of the examples of a "query"
that returns no ResultSets is an "UPDATE". Are you proposing that ExecuteSQL be
able to handle these
1 - 100 of 1344 matches
Mail list logo
