[GitHub] nifi issue #1367: NIFI-3139 Added host:port list and non empty EL validators...

2017-02-10 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1367 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1407: NIFI-2881: Added EL support to DB Fetch processors, allow ...

2017-01-23 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1407 I ran into a snag when trying to add incoming flow file support to QueryDatabaseTable. For GenerateTableFetch, a SQL query is made to the database to get the max values (and column types

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

2017-02-10 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1436 Do we need the ViaSchemaRegistry on the names of these processors? Seems like the name without that postfix is still unique, and we don't refer to other controller services in the names

[GitHub] nifi issue #1407: NIFI-2881: Added EL support to DB Fetch processors, allow ...

2017-01-17 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1407 If we going to add the ability to keep track of dynamic max-value properties in GenerateTableFetch, then there's really no reason why we can't do the same for QueryDatabaseTable. I left it out

[GitHub] nifi pull request #1407: NIFI-2881: Added EL support to DB Fetch processors,...

2017-01-17 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1407#discussion_r96434505 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java

[GitHub] nifi issue #883: NIFI-2591 - PutSQL has no handling for Binary data types

2016-08-18 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/883 A complex problem for sure. Certainly you are right with the Jira that Binary types are currently not supported, and if the use case you describe (coming from Avro) is the most common

[GitHub] nifi pull request #883: NIFI-2591 - PutSQL has no handling for Binary data t...

2016-08-18 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/883#discussion_r75413240 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java --- @@ -787,6 +792,12

[GitHub] nifi pull request #898: NIFI-2602: Fixed NPE in SelectHiveQL when CSV output...

2016-08-18 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/898 NIFI-2602: Fixed NPE in SelectHiveQL when CSV output and null column value You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI

[GitHub] nifi issue #883: NIFI-2591 - PutSQL has no handling for Binary data types

2016-08-19 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/883 That sounds good. We should move the discussion into an email thread on the users or dev list? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #870: NIFI-2577: Increased default stripe size in ConvertA...

2016-08-15 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/870 NIFI-2577: Increased default stripe size in ConvertAvroToORC to 64MB This one's pretty straightforward ;) You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request #872: NIFI-2574 checkpoint commit to allow 1831 progress

2016-08-16 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/872#discussion_r74976276 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/test/groovy/org/apache/nifi/web/security/x509/ocsp

[GitHub] nifi pull request #850: NIFI-2547: Add DeleteHDFS Processor

2016-08-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/850#discussion_r75594156 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestDeleteHDFS.java --- @@ -0,0 +1,198

[GitHub] nifi pull request #850: NIFI-2547: Add DeleteHDFS Processor

2016-08-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/850#discussion_r75594158 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/TestDeleteHDFS.java --- @@ -0,0 +1,198

[GitHub] nifi issue #850: NIFI-2547: Add DeleteHDFS Processor

2016-08-21 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/850 +1 LGTM, built and ran the tests, and tried on a live system with and without incoming flow files, using different glob patterns, files and directories, etc. Great job, thanks! Merging to master

[GitHub] nifi issue #896: NIFI-2600: Ensure that we do not close Index Searchers prem...

2016-08-22 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/896 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #907: NIFI-2619: Added logic to ClassLoaderUtils to trim m...

2016-08-22 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/907 NIFI-2619: Added logic to ClassLoaderUtils to trim module paths and accept URLs You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi

[GitHub] nifi issue #896: NIFI-2600: Ensure that we do not close Index Searchers prem...

2016-08-22 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/896 +1 LGTM to me, tested with and without fixes, verified problem is resolved. Merging to master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #889: NIFI-2598: Fixed issue with static init of propertie...

2016-08-18 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/889 NIFI-2598: Fixed issue with static init of properties in HiveConnectionPool Should be tested/merged after #887 is merged, that is the PR that brings the issue to light. You can merge this pull

[GitHub] nifi pull request #891: NIFI-2593: Fixed handling of nested records/structs ...

2016-08-18 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/891 NIFI-2593: Fixed handling of nested records/structs in ConvertAvroToORC You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI

[GitHub] nifi pull request #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-03 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/727#discussion_r73332095 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java --- @@ -160,22 +162,9

[GitHub] nifi issue #769: how to kafka data to hive

2016-08-04 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/769 this looks like a merge between two existing branches (an RC candidate and master). Is there a code change you are trying to submit? --- If your project is set up for it, you can reply

[GitHub] nifi pull request #912: NIFI-2604: Added validators & logic for multiple URL...

2016-08-22 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/912 NIFI-2604: Added validators & logic for multiple URLs/files/folders for DB driver location You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] nifi pull request #1547: NIFI-3540 - QueryDatabaseTable Failing to Track MS ...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1547#discussion_r103546463 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/QueryDatabaseTable.java

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103834515 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java --- @@ -0,0 +1,217

[GitHub] nifi issue #1418: NIFI-3238 - Introduce ListenBeats processor and deprecates...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1418 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1418: NIFI-3238 - Introduce ListenBeats processor and deprecates...

2017-03-01 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1418 +1 LGTM, ran tests and tried with a live NiFi using metricbeat and filebeat. Thanks very much for the great contribution! Merging to master --- If your project is set up for it, you can reply

[GitHub] nifi issue #1544: NIFI-3530 - Ensuring configuration and ugi information is ...

2017-02-27 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1544 +1 LGTM, thanks for this fix! Merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103595420 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java --- @@ -0,0 +1,216

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103596699 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java --- @@ -0,0 +1,216

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103597456 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/pom.xml --- @@ -0,0 +1,76 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103596545 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java --- @@ -0,0 +1,216

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103597193 --- Diff: nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/ListenLumberjack.java

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103597989 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,233

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103597308 --- Diff: nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/event/LumberjackEvent.java

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103595838 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java --- @@ -0,0

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103595712 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java --- @@ -0,0

[GitHub] nifi issue #918: NIFI-2610 annotated unstable tests with @Ignore

2016-08-23 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/918 +1 LGTM, ran all unit tests without failures (and Travis passed). Merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #922: NIFI-2622: Added support for complex types in Select...

2016-08-23 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/922 NIFI-2622: Added support for complex types in SelectHiveQL You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-2622

[GitHub] nifi pull request #709: NIFI-2369 - Added EL support to CSV properties

2016-08-22 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/709#discussion_r75773261 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestCSVToAvroProcessor.java --- @@ -191,57

[GitHub] nifi pull request #709: NIFI-2369 - Added EL support to CSV properties

2016-08-22 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/709#discussion_r75773057 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/src/test/java/org/apache/nifi/processors/kite/TestCSVToAvroProcessor.java --- @@ -191,57

[GitHub] nifi issue #883: NIFI-2591 - PutSQL has no handling for Binary data types

2016-08-24 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/883 +1 LGTM, tested all the logic. Thanks for the great contribution! Merging to master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-02 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/785 Will do. Although I'm sure you meant "thread concurrency", I always keep an eye out for threat concurrency ;) I've just started a long holiday weekend so I may not be able to take a look

[GitHub] nifi pull request #988: NIFI-2735: Add AggregateValues processor for aggrega...

2016-09-07 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/988#discussion_r77811419 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AggregateValues.java --- @@ -0,0

[GitHub] nifi pull request #976: NIFI-2712: Fixed Fetch processors for multiple max-v...

2016-08-31 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/976 NIFI-2712: Fixed Fetch processors for multiple max-value columns You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-2712

[GitHub] nifi pull request #1012: NIFI-2765: Fixed Kerberos support for PutHiveStream...

2016-09-13 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/1012 NIFI-2765: Fixed Kerberos support for PutHiveStreaming You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-2765 Alternatively

[GitHub] nifi issue #1052: NIFI-2803 The pagination of GenerateTableFetch has a sort ...

2016-09-26 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1052 This commit breaks some unit tests that check the SQL statement(s) being generated, I will fix the tests before merging. Otherwise +1 LGTM, merging to master, thanks much for your contribution

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r80535718 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java --- @@ -819,7 +819,7

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r80535990 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestParseCEF.java --- @@ -0,0

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-26 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r80535518 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java --- @@ -0,0 +1,323

[GitHub] nifi issue #1052: NIFI-2803 The pagination of GenerateTableFetch has a sort ...

2016-09-26 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1052 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1035: NIFI-1841: Fixed support for CLOB/BLOB types

2016-09-20 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/1035 NIFI-1841: Fixed support for CLOB/BLOB types You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-1841 Alternatively you can

[GitHub] nifi pull request #1037: NIFI-1893 Add processor for validating JSON

2016-09-20 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1037#discussion_r79657612 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java --- @@ -0,0

[GitHub] nifi pull request #1037: NIFI-1893 Add processor for validating JSON

2016-09-20 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1037#discussion_r79657850 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java --- @@ -0,0

[GitHub] nifi pull request #1037: NIFI-1893 Add processor for validating JSON

2016-09-20 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1037#discussion_r79656833 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateJson.java --- @@ -0,0

[GitHub] nifi pull request #733: NIFI-2417: Implementing QueryElasticsearchHttp and S...

2016-09-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/733#discussion_r79826318 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #733: NIFI-2417: Implementing QueryElasticsearchHttp and S...

2016-09-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/733#discussion_r79826524 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #733: NIFI-2417: Implementing QueryElasticsearchHttp and S...

2016-09-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/733#discussion_r79832704 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #733: NIFI-2417: Implementing QueryElasticsearchHttp and S...

2016-09-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/733#discussion_r79831856 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #733: NIFI-2417: Implementing QueryElasticsearchHttp and S...

2016-09-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/733#discussion_r79831289 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #733: NIFI-2417: Implementing QueryElasticsearchHttp and S...

2016-09-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/733#discussion_r79827737 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #1004: NIFI-2756 - Add displayName to maven archetypes

2016-09-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1004#discussion_r79869645 --- Diff: nifi-maven-archetypes/nifi-processor-bundle-archetype/src/main/resources/archetype-resources/nifi-__artifactBaseName__-processors/src/main/java

[GitHub] nifi pull request #1004: NIFI-2756 - Add displayName to maven archetypes

2016-09-21 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1004#discussion_r79869457 --- Diff: nifi-maven-archetypes/nifi-processor-bundle-archetype/src/main/resources/archetype-resources/nifi-__artifactBaseName__-processors/src/main/java

[GitHub] nifi issue #997: NIFI-2749

2016-09-21 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/997 +1 LGTM, verified the problem exists, the unit tests show the problem, and the fix corrects the problem. Merging to master. --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #1055: NIFI-2815: Fixed InvokeScriptedProcessor to allow c...

2016-09-23 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/1055 NIFI-2815: Fixed InvokeScriptedProcessor to allow changes to script engine type You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149

[GitHub] nifi pull request #733: NIFI-2417: Implementing QueryElasticsearchHttp and S...

2016-09-22 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/733#discussion_r80098194 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #733: NIFI-2417: Implementing QueryElasticsearchHttp and S...

2016-09-22 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/733#discussion_r80096977 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #733: NIFI-2417: Implementing QueryElasticsearchHttp and S...

2016-09-22 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/733#discussion_r80101565 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #1046: NIFI-2805: Add fragment attributes to SplitAvro

2016-09-22 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/1046 NIFI-2805: Add fragment attributes to SplitAvro Same idea as #919 but for SplitAvro You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149

[GitHub] nifi pull request #733: NIFI-2417: Implementing QueryElasticsearchHttp and S...

2016-09-22 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/733#discussion_r80112353 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi issue #733: NIFI-2417: Implementing QueryElasticsearchHttp and ScrollEl...

2016-09-22 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/733 Oops, forgot to rebase and add the comment that auto-closes this PR. Do you mind closing it? I'll Resolve the Jira. Thanks! --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #994: NIFI-2262: Added Avro-normalization of table/column ...

2016-09-07 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/994 NIFI-2262: Added Avro-normalization of table/column names in SQL processors Affected processors are QueryDatabaseTable and ExecuteSQL, since they generate Avro output. GenerateTableFetch

[GitHub] nifi pull request #1045: NIFI-1458: Added ScriptedReportingTask

2016-09-22 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/1045 NIFI-1458: Added ScriptedReportingTask I refactored AbstractScriptProcessor into ScriptUtils, so the functionality could be shared between scripting processors and scripting reporting tasks. I

[GitHub] nifi pull request #919: NIFI-2632: Added fragment attributes to SplitJson an...

2016-08-23 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/919#discussion_r75937909 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitJson.java --- @@ -61,6

[GitHub] nifi pull request #919: NIFI-2632: Added fragment attributes to SplitJson an...

2016-08-23 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/919 NIFI-2632: Added fragment attributes to SplitJson and SplitXml You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-2632

[GitHub] nifi pull request #907: NIFI-2619: Added logic to ClassLoaderUtils to trim m...

2016-08-22 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/907#discussion_r75730484 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/file/classloader/ClassLoaderUtils.java --- @@ -21,45 +21,59 @@ import

[GitHub] nifi pull request #920: NIFI-2623: Fixed support for binary types in SelectH...

2016-08-23 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/920 NIFI-2623: Fixed support for binary types in SelectHiveQL This code was originally copied from JdbcCommon, where arrays are treated as binary (byte array, e.g.) and getBytes() is called

[GitHub] nifi pull request #911: NIFI-2610 added initial support for categorizing tes...

2016-08-22 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/911#discussion_r75755578 --- Diff: nifi-api/src/main/java/org/apache/nifi/testutil/IntegrationTest.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software

[GitHub] nifi pull request #948: NIFI-2668: Replaced JSR-107 JCache API JAR w Geronim...

2016-08-25 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/948 NIFI-2668: Replaced JSR-107 JCache API JAR w Geronimo version, updated notices You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi

[GitHub] nifi pull request #912: NIFI-2604: Added validators & logic for multiple URL...

2016-08-25 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/912#discussion_r76333878 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/StandardValidators.java --- @@ -379,6 +381,68 @@ public

[GitHub] nifi pull request #912: NIFI-2604: Added validators & logic for multiple URL...

2016-08-25 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/912#discussion_r76333907 --- Diff: nifi-commons/nifi-processor-utilities/src/test/java/org/apache/nifi/processor/util/TestStandardValidators.java --- @@ -100,4 +100,105 @@ public

[GitHub] nifi pull request #948: NIFI-2668: Replaced JSR-107 JCache API JAR w Geronim...

2016-08-25 Thread mattyb149
Github user mattyb149 closed the pull request at: https://github.com/apache/nifi/pull/948 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #883: NIFI-2591 - PutSQL has no handling for Binary data t...

2016-08-24 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/883#discussion_r76068439 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java --- @@ -787,6 +802,29

[GitHub] nifi issue #883: NIFI-2591 - PutSQL has no handling for Binary data types

2016-08-24 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/883 That part makes sense, but what about when I put three emoticons in the UpdateAttribute processor to set the value, then I get three bytes in the table, all value 63. I would've expected 6 bytes

[GitHub] nifi issue #883: NIFI-2591 - PutSQL has no handling for Binary data types

2016-08-24 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/883 Sounds good. Yeah I used the hex and base64 stuff with no issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #928: NIFI-2641: Add max values as attributes to QueryData...

2016-08-24 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/928 NIFI-2641: Add max values as attributes to QueryDatabaseTable You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-2641

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-29 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r76610727 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java --- @@ -0,0 +1,172

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-29 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r76612149 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java --- @@ -0,0 +1,172

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-29 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r76611496 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java --- @@ -0,0 +1,172

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-27 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r80703541 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestParseCEF.java --- @@ -0,0

[GitHub] nifi issue #1053: NIFI-2811 JdbcCommon doesn't convert bigint(20) column.

2016-09-27 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1053 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-27 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r80709952 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml --- @@ -254,6 +254,17 @@ language governing permissions and limitations

[GitHub] nifi issue #1053: NIFI-2811 JdbcCommon doesn't convert bigint(20) column.

2016-09-27 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1053 +1 Looks good to me, thank you for the fix! It's been very frustrating trying to find out how each database handles various types, some return a different JDBC type than the corresponding Java type

[GitHub] nifi pull request #1075: NIFI-2828: Fix Hive NAR dependencies

2016-09-27 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/1075 NIFI-2828: Fix Hive NAR dependencies The approach is to remove the parent dependency and put all Hadoop/Hive dependencies in the Hive NAR instead of expecting them in a parent classloader. You

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-30 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/785 Sounds good thanks, will take a look soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

2016-10-26 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1108 Looks like there are new merge issues, do you mind rebasing against the latest master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #1179: NIFI-969 Added support for standard JSON

2016-11-07 Thread mattyb149
Github user mattyb149 commented on a diff in the pull request: https://github.com/apache/nifi/pull/1179#discussion_r86877725 --- Diff: nifi-nar-bundles/nifi-avro-bundle/nifi-avro-processors/src/test/java/org/apache/nifi/processors/avro/TestConvertAvroToJSON.java --- @@ -239,6

[GitHub] nifi issue #1179: NIFI-969 Added support for standard JSON

2016-11-07 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1179 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1187: NIFI-2998: Add validator to Avro Record Name in Inf...

2016-11-08 Thread mattyb149
GitHub user mattyb149 opened a pull request: https://github.com/apache/nifi/pull/1187 NIFI-2998: Add validator to Avro Record Name in InferAvroSchema You can merge this pull request into a Git repository by running: $ git pull https://github.com/mattyb149/nifi NIFI-2998

[GitHub] nifi issue #952: Nifi 2673: Add MERGE support on processor ConvertJSONTOSQL

2016-11-08 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/952 It's a real bummer that an ANSI "standard" such as MERGE is done differently by so many databases :( If there isn't an application of the standard MERGE syntax that applies to many

[GitHub] nifi issue #1009: NIFI-2764 - MS SQL TINYINT Avro Issue

2016-11-08 Thread mattyb149
Github user mattyb149 commented on the issue: https://github.com/apache/nifi/pull/1009 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

<    1   2   3   4   5   6   7   8   9   10   >