GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/3102
NIFI-5737: Removing need client auth property as cluster communications no
longer support it
NIFI-5737:
- Removing needClientAuth property since cluster comms now requires two way
ssl. Jetty
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3076
Thanks @mattyb149! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/3087
NIFI-5715: Updating allow values of runStatus for swagger spec
NIFI-5715:
- Updating the allowable values for the runStatus.
You can merge this pull request into a Git repository by running
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3083
Thanks @markap14! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3083
Will review...
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/3082
NIFI-375: Ensuring the run status endpoints are properly merged
NIFI-375:
- Ensuring the run status endpoints are properly merged.
You can merge this pull request into a Git repository
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2977
Happy to help review this PR once it's ready.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3069
Thanks @joewitt
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3067
Thanks @thenatog! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/3069
NIFI-4806: Bumping to tika 1.19.1
NIFI-4806:
- Bumping to tika 1.19.1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3067
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3066
It appears that the nifi-aws-nar was already including the newer versions
of jackson. However, the nifi-aws-service-api-nar was not. There is no
implementations in the service api, however
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3066
Attaching to files showing the effects the proposed pom changes has on the
artifacts bundled.
[5691-sorted.txt](https://github.com/apache/nifi/files/2473454/5691-sorted.txt)
[master
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/3066
NIFI-5691: Overriding the version of jackson in aws java sdk
NIFI-5691:
- Overriding the version of jackson in aws java sdk.
You can merge this pull request into a Git repository by running
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3064
Thanks @markap14! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3064
Will review..
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/3063
NIFI-5661: Always showing load balance settings
NIFI-5661:
- Allowing the load balance configuration to be shown/edited in both
clustered and standalone mode.
You can merge this pull request
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3034
Thanks @thenatog @joewitt. This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3034
@thenatog @joewitt Happy to continue reviewing here...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3046
Thanks @ijokarumawak! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3037
Thanks @ijokarumawak! This has been merged to master.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3037#discussion_r224205359
--- Diff:
nifi-nar-bundles/nifi-windows-event-log-bundle/nifi-windows-event-log-processors/src/main/java/org/apache/nifi/processors/windows/event/log
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3037
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3046
Thanks for the update. We do not want to reference another module directly
via `nf.`. This would only be working currently because we have not enabled a
module loader yet. However, the codebase
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3054
Thanks @markap14. This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3054
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3052
Thanks @joewitt. This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3021
Provided an alternate solution here:
https://github.com/apache/nifi/pull/3055
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/3055
NIFI-5600: Fixing columns in queue listing and component state
NIFI-5600:
- Recalculating the available columns for the queue listing and component
state because they contain conditions which
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3021
@pvillard31 Thanks for the PR! I can see what is happening here and I think
a slightly different solution is required. With the introduction of NIFI-5208
we should be watching the cluster status
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3046#discussion_r223727659
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/nf-connection-details.js
---
@@ -521,6 +524,27
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3021
Sorry for missing the mention... Will review
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3052
Will review...
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3046#discussion_r223116414
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/css/connection-configuration.css
---
@@ -122,4 +122,16
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3046#discussion_r223115867
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-connection.js
---
@@ -1341,6 +1363,52
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3046
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3044
Thanks @ijokarumawak! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3044
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3018
Thanks @alopresto! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3028
Thanks @joewitt! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3028
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3035
Thanks @alopresto! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3035
Thanks @thenatog! I'll also have a look.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3030
Thanks @markap14! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3030
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/3035
Will review...
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi-registry/pull/141
NIFIREG-186 - Referencing the correct parent artifact
NIFIREG-186:
- Referencing the correct parent artifact
You can merge this pull request into a Git repository by running:
$ git
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2990
@ijokarumawak Thanks this looks good. I'm going to squash and merged to
master. I've created two new JIRAs that are related to this effort but separate
from the initial concern. Thanks again
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2990
@ijokarumawak This is looking really good! Just seeing a couple minor
things aside from the NPE I commented in the code.
It looks like the `operatePermissions` were added
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r218531396
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/dto/DtoFactory.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217816900
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-settings.js
---
@@ -1045,29 +1041,38
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217390883
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-authorization/src/main/java/org/apache/nifi/authorization/resource
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217390667
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-authorization/src/main/java/org/apache/nifi/authorization/resource
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217387530
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217415480
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-settings.js
---
@@ -1045,29 +1041,38
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217401802
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-remote-process-group.js
---
@@ -741,8
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217387691
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217405219
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-remote-process-group.js
---
@@ -741,8
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2990
@ijokarumawak I see. You're correct that the existing codebase also
exhibits this behavior. However, I think that its an issue we should consider
fixing separately from this. Generally speaking, I
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217134368
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ControllerServiceResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217134851
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/OutputPortResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217135024
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessorResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217140684
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager/ComponentEntityMerger.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217134678
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/InputPortResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217135735
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217135560
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217135375
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217136120
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ReportingTaskResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2990#discussion_r217121570
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/manager
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2990
@ijokarumawak Thanks for the update. I'm still in the process of reviewing
but one thing that concerns me is where we've identified Service Only in the
scenarios above. Currently (before the PR
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2990
@ijokarumawak Thanks for the additional commits! Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2996
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2990
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2981
Thanks @ijokarumawak! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2981
Reviewing...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2957
Thanks @markobean! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2961
NIFI-5479: Upgrade Jetty
Upgrading Jetty. Including a commit that @joewitt had provided in PR #2933.
I have provided an additional commit that addresses a behavioral change in
Jetty's
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2957
@markobean I've replicated the behavior and believe there is a bug here.
However, I don't think the proposed solution is the proper way to address it.
The points in question are `visibility: hidden
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/135
Thanks @scottyaslan! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/135
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2899
Thanks @patricker! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2941
Thanks @scottyaslan! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2941
@scottyaslan I believe we also need to update the package-lock.json that is
checked into source control. I noticed the package-lock.json is updated in the
front end working directory.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2941
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2935
Thanks for the contributions @alopresto and @pepov! I'm also a +1 on the
changes proposed here.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2933
@joewitt Thanks for the PR! When starting up in secure mode using a
configuration that works with current master branch, I received some stack
traces regarding the initialization of the `SSLContext
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2934
Thanks @mattyb149! This has been merged to master.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2934#discussion_r207559164
--- Diff:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/processor/util/StandardValidators.java
---
@@ -390,6 +391,19 @@ public ValidationResult
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2934
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2932
Sounds good thanks!
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2932
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2928
Thanks @mattyb149! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2928
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2908
Thanks again for the PR and reviews! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2908
@alopresto I'm a +1 with the addition of the most recent commit. I'll wait
until tomorrow to merge it in just in case anyone else engaged here [@danfike
@mcg30005] wants to check it out.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2908
Thanks for the PR! I'm happy to help get this merged in. I tried out the
proposed patch locally and it does address the issue in the case identified.
However, I tried to run in some of the other
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2899
@patricker Just had another look. I think there is one case that still
hasn't been addressed. When a user has been granted permissions to the root
group, the document title does update to the root
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2914
Looking at the changeset I see that a property was added to allow the user
to opt-in to the new behavior. That should alleviate my concerns. Sorry for the
confusion.
Only other suggestion
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2914
I would be very careful taking that option. Yes, it would ensure that users
flows remain valid. However, I would question if that is the behavior that
those users actually want. If the new
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2899#discussion_r202814854
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-canvas.js
---
@@ -167,12 +167,14
1 - 100 of 1112 matches
Mail list logo
