[GitHub] nifi issue #710: NIFI-1148 added IMAP/POP3 support

2016-07-24 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/710 @trixpan Well, I am not sure what that is (will be looking) and how reliable mailtrap.io is for such testing giving it's description "Fake smtp testing server. Dummy smtp email testing". I

[GitHub] nifi issue #710: NIFI-1148 added IMAP/POP3 support

2016-07-24 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/710 Digging into the source code for it looks like something is out of compliance with POP3 protocol ```java if (line.startsWith("+OK")) r.ok = true; else if (line.

[GitHub] nifi issue #710: NIFI-1148 added IMAP/POP3 support

2016-07-24 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/710 One advise though is that there are additional JavaMail properties that one may need to provide to accomodate specific servers. For example in Gmail you need to specify ```mail.pop3.socketFactory.class

[GitHub] nifi issue #563: NIFI-2078, 2363, 2364: External state management. CLUSTER s...

2016-07-27 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/563 @JPercivall +1 on Kafka stuff --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #687: NIFI-2298 added Kafka consume attributes to a FlowFile

2016-07-21 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/687 @xmlking Back Pressure is the function of all processors so there is nothing specific required in ConsumeKafka to handle it. Does that answer your question? --- If your project is set up for it, you

[GitHub] nifi pull request #741: NIFI-2322, NIFI-2423, NIFI-2412 Kafka improvements

2016-07-29 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/741 NIFI-2322, NIFI-2423, NIFI-2412 Kafka improvements - Fixed KafkaConsumer's connection block when broker is not available - Fixed Serializer/Deserializer configs in both Consume/Publish Kafka

[GitHub] nifi pull request #739: NIFI-2419: Ensure that if a node is disconnected tha...

2016-07-29 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/739#discussion_r72802000 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java --- @@ -3279,14

[GitHub] nifi pull request #718: NIFI-2366 - Fixed ID generation semantics in cluster...

2016-07-29 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/718#discussion_r72811314 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/util/SnippetUtilsTest.java --- @@ -0,0

[GitHub] nifi pull request #758: NIFI-2444 NIFI-2445 fixed PublishKafka

2016-08-01 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/758 NIFI-2444 NIFI-2445 fixed PublishKafka - fixed the logging issue NIFI-2444 by ensuring the ProcessLog is added to KafkaPublisher - fixed KafkaPublisher's isAllAcked operation to ensure

[GitHub] nifi pull request #761: NIFI-2444 NIFI-2445 fixed PublishKafka

2016-08-01 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/761 NIFI-2444 NIFI-2445 fixed PublishKafka - fixed the logging issue NIFI-2444 by ensuring the ProcessLog is added to KafkaPublisher - fixed KafkaPublisher's isAllAcked operation to ensure

[GitHub] nifi issue #828: NIFI-2540: Exclude from templates the parts of property des...

2016-08-10 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/828 Looks pretty straight forward. Validated that it did not break the correctness of template import/export. Merging --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #828: NIFI-2540: Exclude from templates the parts of property des...

2016-08-10 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/828 Reviewing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #770: NIFI-2425 REVIEW ONLY

2016-08-02 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/770 NIFI-2425 REVIEW ONLY You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-2425B Alternatively you can review and apply these changes

[GitHub] nifi pull request #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/727#discussion_r73254929 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java --- @@ -0,0 +1,657

[GitHub] nifi pull request #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/727#discussion_r73254901 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java --- @@ -0,0 +1,657

[GitHub] nifi issue #741: NIFI-2322, NIFI-2423, NIFI-2412 Kafka improvements

2016-08-02 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/741 ouch, the code that provided the fix for connection broke the test. Argh Give me a min --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #761: NIFI-2444 NIFI-2445 fixed PublishKafka

2016-08-02 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/761 @markap14 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/727#discussion_r73254533 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java --- @@ -160,22 +162,9

[GitHub] nifi pull request #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/727#discussion_r73253954 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/hadoop/hive/ql/io/orc/NiFiOrcUtils.java --- @@ -0,0 +1,466

[GitHub] nifi pull request #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/727#discussion_r73254202 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/hadoop/hive/ql/io/orc/NiFiOrcUtils.java --- @@ -0,0 +1,466

[GitHub] nifi issue #761: NIFI-2444 NIFI-2445 fixed PublishKafka

2016-08-02 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/761 @markap14 @brosander done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/727#discussion_r73255530 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java --- @@ -0,0 +1,657

[GitHub] nifi pull request #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/727#discussion_r73255367 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java --- @@ -0,0 +1,657

[GitHub] nifi pull request #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-02 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/727#discussion_r73252749 --- Diff: nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/hadoop/hive/ql/io/orc/NiFiOrcUtils.java --- @@ -0,0 +1,466

[GitHub] nifi issue #727: NIFI-1663: Add ConvertAvroToORC processor

2016-08-02 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/727 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #821: NIFI-2518: Added support for fractional seconds to Abstract...

2016-08-10 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/821 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #821: NIFI-2518: Added support for fractional seconds to Abstract...

2016-08-10 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/821 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74417054 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -135,29 +89,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74418537 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74422525 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74421827 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -135,29 +89,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74425869 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -135,29 +89,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74425691 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 i see now. Putting it in --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 Ok @joewitt @trixpan latest comments are addressed in the latest commit. Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 @trixpan i think you've closed client while it was in he middle of reading InputStream. If that's the case then yes the stack trace above is exactly what one would expect. --- If your project is set

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 The above is actually correct and is exactly what we were aiming for. No data loss. There is actually new test that validates for that exact message. So all is good. User is notified that something went

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 @trixpan just confirmed, the "Read timed out" exception is the correct behavior, but I will wrap it into a nicer log message. But just to confirm the behavior is expected --- If your project

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 @trixpan could you please describe scenario that triggered the above exception? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/827 @trixpan with regard to "Read timeout" I've just added better exception handling to notify user https://github.com/apache/nifi/pull/827/commits/406b37b249e487f73bae5a260bd5aed05d3

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74361483 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi pull request #741: NIFI-2322, NIFI-2423, NIFI-2412 Kafka improvements

2016-08-03 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/741#discussion_r73352158 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-pubsub-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/AbstractKafkaProcessor.java

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-12 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74527137 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +90,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-14 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/827 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #836: NIFI-2545: Ensure that when @OnUnscheduled and @OnSt...

2016-08-14 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/836#discussion_r74704476 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java

[GitHub] nifi pull request #836: NIFI-2545: Ensure that when @OnUnscheduled and @OnSt...

2016-08-14 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/836#discussion_r74704726 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java

[GitHub] nifi issue #856: NIFI-2519 aligned processor to leverage the subethasmtp thr...

2016-08-14 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/856 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74362408 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -166,317 +108,158

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74361725 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -13,89 +13,52

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74361819 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -166,317 +108,158

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74362947 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -166,317 +108,158

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74361967 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -166,317 +108,158

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74362870 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -13,89 +13,52

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74362934 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi issue #830: NIFI-1663: Adding attribution for derived work for OrcFlowF...

2016-08-10 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/830 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #851: NIFI-2560 added connection timeout to IMAP/POP3

2016-08-12 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/851 NIFI-2560 added connection timeout to IMAP/POP3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-2560 Alternatively you can review

[GitHub] nifi pull request #679: NIFI-826 (part 3)

2016-07-19 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/679 NIFI-826 (part 3) - fixed ID generation routine that was causing miss-identification of the components You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request #679: NIFI-826 (part 3)

2016-07-19 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/679 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #687: NIFI-2298 added Kafka consume attributes to a FlowFi...

2016-07-20 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/687 NIFI-2298 added Kafka consume attributes to a FlowFile You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-2298 Alternatively you can

[GitHub] nifi issue #563: NIFI-2078: External state management.

2016-07-07 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/563 @ijokarumawak I am not yet done, but good that you have rebased. I am just tied up with another thing at the moment, but will be reviewing later on --- If your project is set up for it, you can reply

[GitHub] nifi issue #617: NIFI-826 Added deterministic template support

2016-07-07 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/617 @mcgilman @jtstorck could you please look at the second commit where I had to ignore two Spoke tests. Basically two issues there. 1. Components are created without ID. With new code changes it now

[GitHub] nifi issue #710: NIFI-1148 added IMAP/POP3 support

2016-08-05 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/710 @mattyb149 I was just trying to reproduce the issue with the hanging thread you described above in relation to ConsumePop3, but I can't. Are you sure that what you saw is related to this processor

[GitHub] nifi pull request #741: NIFI-2322, NIFI-2423, NIFI-2412 Kafka improvements

2016-08-05 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/741 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #710: NIFI-1148 added IMAP/POP3 support

2016-08-05 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/710 @mattyb149 all the suggested changes have been addressed in the last commit. I've also included in the additional documentation sample configuration for GMail, so you can use it to play around/test

[GitHub] nifi issue #814: NIFI-2515 fixed Kafka serialization/deserialization setting...

2016-08-08 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/814 NOTE: Verified that this commit is cherry-pickable to 0.x branch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #814: NIFI-2515 fixed Kafka serialization/deserialization ...

2016-08-08 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/814 NIFI-2515 fixed Kafka serialization/deserialization settings You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-2515B Alternatively

[GitHub] nifi pull request #810: NIFI-2504 fixed template export for RPG

2016-08-08 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/810 NIFI-2504 fixed template export for RPG - ensured that RPG and connections to it are treated as special case where instance ID is preserved You can merge this pull request into a Git repository

[GitHub] nifi pull request #804: NIFI-2508 fixed compilation errors in AbstractKafkaP...

2016-08-07 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/804 NIFI-2508 fixed compilation errors in AbstractKafkaProcessor NOTE: This is for 0.x only You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi

[GitHub] nifi pull request #710: NIFI-1148 added IMAP/POP3 support

2016-08-07 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/710#discussion_r73805385 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/resources/docs/org.apache.nifi.processors.email.ConsumeIMAP/additionalDetails.html

[GitHub] nifi issue #710: NIFI-1148 added IMAP/POP3 support

2016-08-07 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/710 @mattyb149 your comments are addressed in the last commit. Thanks for reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi pull request #710: NIFI-1148 added IMAP/POP3 support

2016-08-07 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/710#discussion_r73805537 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/resources/docs/org.apache.nifi.processors.email.ConsumeIMAP/additionalDetails.html

[GitHub] nifi pull request #805: NIFI-2509 fixed NPE condition in KafkaConsumer

2016-08-07 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/805 NIFI-2509 fixed NPE condition in KafkaConsumer You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz/nifi NIFI-2509 Alternatively you can review

[GitHub] nifi issue #805: NIFI-2509 fixed NPE condition in KafkaConsumer

2016-08-07 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/805 NOTE: This PR must be applied to both master and 0.x branch. I've verified that it is cherry-pickable. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #710: NIFI-1148 added IMAP/POP3 support

2016-07-23 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/710#discussion_r71973578 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/AbstractEmailProcessor.java --- @@ -0,0 +1,391

[GitHub] nifi pull request #710: NIFI-1148 added IMAP/POP3 support

2016-07-23 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/710#discussion_r71975039 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/AbstractEmailProcessor.java --- @@ -0,0 +1,391

[GitHub] nifi pull request #710: NIFI-1148 added IMAP/POP3 support

2016-07-23 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/710#discussion_r71975032 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/AbstractEmailProcessor.java --- @@ -0,0 +1,391

[GitHub] nifi pull request #710: NIFI-1148 added IMAP/POP3 support

2016-07-23 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/710#discussion_r71975044 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/AbstractEmailProcessor.java --- @@ -0,0 +1,391

[GitHub] nifi pull request #718: NIFI-2366 - Fixed ID generation semantics in cluster...

2016-07-29 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/718#discussion_r72815141 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/test/java/org/apache/nifi/web/util/SnippetUtilsTest.java --- @@ -0,0

[GitHub] nifi pull request #804: NIFI-2508 fixed compilation errors in AbstractKafkaP...

2016-08-09 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/804 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #840: NIFI-2524 - Fixes to improve handling of missing journal fi...

2016-08-15 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/840 Revewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #840: NIFI-2524 - Fixes to improve handling of missing jou...

2016-08-15 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/840#discussion_r74786994 --- Diff: nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance

[GitHub] nifi pull request #859: NIFI-2546 fixed NPE in FlowSnippetDTO

2016-08-15 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/859 NIFI-2546 fixed NPE in FlowSnippetDTO fixed NPE caused by non-configured ControllerService You can merge this pull request into a Git repository by running: $ git pull https://github.com/olegz

[GitHub] nifi issue #840: NIFI-2524 - Fixes to improve handling of missing journal fi...

2016-08-15 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/840 @YolandaMDavis That said, please ignore the above comments for now since they are really improvements of the existing code and are not related to the problem at hand. I'll raise a separate JIRA

[GitHub] nifi issue #864: [NIFI-2559] UI - Controller Service update missing icons

2016-08-15 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/864 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #840: NIFI-2524 - Fixes to improve handling of missing journal fi...

2016-08-15 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/840 +1. Merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #864: [NIFI-2559] UI - Controller Service update missing icons

2016-08-15 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/864 +1 Verified font changes, icons, alignment. Merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #871: NIFI-2519 - ListenSMTP addresses mismatch between sm...

2016-08-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/871#discussion_r75180197 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/smtp/SmtpConsumer.java --- @@ -149,7 +149,7

[GitHub] nifi pull request #871: NIFI-2519 - ListenSMTP addresses mismatch between sm...

2016-08-17 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/871#discussion_r75184556 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/smtp/SmtpConsumer.java --- @@ -149,7 +149,7

[GitHub] nifi issue #1449: NIFI-3223 added support for expression language

2017-01-31 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/1449 @pvillard31 yes you can ``` runner.setProperty(MyProcessor.SOME_PROPERTY, "${some.attribute.key}"); Map<String, String> attributes = new HashMap<>(); attributes.p

[GitHub] nifi pull request #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON tr...

2017-02-07 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/1436#discussion_r99842926 --- Diff: nifi-nar-bundles/nifi-registry-bundle/nifi-registry-processors/src/main/java/org/apache/nifi/schemaregistry/processors

[GitHub] nifi pull request #1435: NIFI-3345 Added support for simple AVRO/CSV/JSON tr...

2017-01-22 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/1435 NIFI-3345 Added support for simple AVRO/CSV/JSON transformers that ut… …ilize external Schema Added support for simple Key/Value Schema Registry as Controller Service Added support

[GitHub] nifi issue #1435: NIFI-3345 Added support for simple AVRO/CSV/JSON transform...

2017-01-22 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/1435 Closing due to wrong commit message, will resubmit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1435: NIFI-3345 Added support for simple AVRO/CSV/JSON tr...

2017-01-22 Thread olegz
Github user olegz closed the pull request at: https://github.com/apache/nifi/pull/1435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi pull request #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON tr...

2017-01-22 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/1436 NIFI-3354 Added support for simple AVRO/CSV/JSON transformers that ut… …ilize external Schema Added support for simple Key/Value Schema Registry as Controller Service Added support

[GitHub] nifi pull request #1434: NIFI-2615 Adding GetTCP processor

2017-01-23 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/1434#discussion_r97349937 --- Diff: nifi-nar-bundles/nifi-tcp-bundle/nifi-tcp-processors/src/main/java/org/apache/nifi/processors/gettcp/DisconnectListener.java --- @@ -0,0 +1,6

[GitHub] nifi pull request #1434: NIFI-2615 Adding GetTCP processor

2017-01-23 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/1434#discussion_r97348509 --- Diff: nifi-nar-bundles/nifi-tcp-bundle/nifi-tcp-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,24 @@ +nifi-gettcp-nar --- End diff

[GitHub] nifi pull request #1434: NIFI-2615 Adding GetTCP processor

2017-01-23 Thread olegz
Github user olegz commented on a diff in the pull request: https://github.com/apache/nifi/pull/1434#discussion_r97348408 --- Diff: nifi-nar-bundles/nifi-tcp-bundle/.gitignore --- @@ -0,0 +1,16 @@ +target +.project +.settings +.classpath +nbactions.xml +nb

[GitHub] nifi issue #1425: NIFI-3363: PutKafka NPE with User-Defined partition

2017-01-26 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/1425 Reviewing. . . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1449: NIFI-3223 added support for expression language

2017-01-27 Thread olegz
GitHub user olegz opened a pull request: https://github.com/apache/nifi/pull/1449 NIFI-3223 added support for expression language - EXCHANGE - ROUTING_KEY Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #1436: NIFI-3354 Added support for simple AVRO/CSV/JSON transform...

2017-01-27 Thread olegz
Github user olegz commented on the issue: https://github.com/apache/nifi/pull/1436 @joewitt copyrights are fixed. Please see the latest commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

  1   2   3   4   >