Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
Rebased and squashed commits
---
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2747#discussion_r195301228
--- Diff: nifi-docker/dockermaven/Dockerfile ---
@@ -26,23 +26,33 @@ ARG NIFI_BINARY
ENV NIFI_BASE_DIR /opt/nifi
ENV NIFI_HOME $NIFI_BASE_DIR
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2747#discussion_r195311227
--- Diff: nifi-docker/dockermaven/Dockerfile ---
@@ -26,23 +26,33 @@ ARG NIFI_BINARY
ENV NIFI_BASE_DIR /opt/nifi
ENV NIFI_HOME $NIFI_BASE_DIR
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2747#discussion_r195312869
--- Diff: nifi-docker/dockermaven/Dockerfile ---
@@ -26,23 +26,33 @@ ARG NIFI_BINARY
ENV NIFI_BASE_DIR /opt/nifi
ENV NIFI_HOME $NIFI_BASE_DIR
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
yes, working on it
---
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/2746
NIFI-5247 NiFi toolkit signal handling changes, Dockerfile enhancements
nifi-toolkit bash entry points should leverage exec to replace bash with
the current java process in order to handle signals
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2746#discussion_r191668440
--- Diff: nifi-toolkit/nifi-toolkit-assembly/src/main/resources/bin/cli.sh
---
@@ -111,8 +111,7 @@ run() {
export NIFI_TOOLKIT_HOME="$NIFI_TOOLKIT
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/2747
NIFI-5249 Dockerfile enhancements
- Createdata repository and log directories
- Add explicit environment variable declarations to replace nifi-env.sh
- Remove obsolete chown commands after user
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2746#discussion_r191681207
--- Diff: nifi-toolkit/nifi-toolkit-assembly/src/main/resources/bin/cli.sh
---
@@ -111,8 +111,7 @@ run() {
export NIFI_TOOLKIT_HOME="$NIFI_TOOLKIT
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2746
Added some integration tests, to cover exit codes and some basic tls
toolkit functionality through docker
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2746
added test files to rat exclude, also rebased and squashed commits
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
No, sorry! I meant integration-test not package. I beleive this would do
it, at least works for me, just tested:
```
mvn package -pl nifi-assembly
cd nifi-docker
mvn integration-test -P
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2747#discussion_r192981828
--- Diff: nifi-docker/dockerhub/Dockerfile ---
@@ -25,28 +25,37 @@ ARG GID=1000
ARG NIFI_VERSION=1.7.0
ARG MIRROR=https://archive.apache.org/dist
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
Are there any issues left I did not address?
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
To reply to my own question: I think we should also test the dockerhub
image almost the same way we test the maven one. We just have to use the latest
public nifi archive to do that.
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2747
Now all the above described test steps can be executed with `mvn package -P
docker` from the `nifi-docker` folder
---
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2747#discussion_r192781212
--- Diff: nifi-docker/dockerhub/Dockerfile ---
@@ -25,28 +25,37 @@ ARG GID=1000
ARG NIFI_VERSION=1.7.0
ARG MIRROR=https://archive.apache.org/dist
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2747#discussion_r192787369
--- Diff: nifi-docker/dockermaven/pom.xml ---
@@ -44,7 +44,6 @@
apache/nifi
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2866#discussion_r206873952
--- Diff: nifi-docker/dockerhub/README.md ---
@@ -124,6 +124,33 @@ volume to provide certificates on the host system to
the container instance.
-e
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2866#discussion_r206875134
--- Diff: nifi-docker/dockerhub/README.md ---
@@ -124,6 +124,33 @@ volume to provide certificates on the host system to
the container instance.
-e
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2866#discussion_r206872507
--- Diff: nifi-docker/dockerhub/README.md ---
@@ -124,6 +124,33 @@ volume to provide certificates on the host system to
the container instance.
-e
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2866#discussion_r206872145
--- Diff: nifi-docker/dockerhub/sh/start.sh ---
@@ -54,6 +54,11 @@ case ${AUTH} in
. "${scripts_dir}/secure.sh"
. &quo
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2866#discussion_r206872323
--- Diff: nifi-docker/dockerhub/README.md ---
@@ -124,6 +124,33 @@ volume to provide certificates on the host system to
the container instance.
-e
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2935
I've tested it manually and ran the unit tests as well. I wanted to ask
whether we could make the error message more user friendly but then found
myself trying to find out whether we can make life
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2927#discussion_r207532732
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -281,6 +281,272 @@ After running the client you will have the CAâs
certificate
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206107007
--- Diff: nifi-docker/dockerhub/pom.xml ---
@@ -39,7 +39,7 @@
1000
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206107302
--- Diff: nifi-docker/dockerhub/Dockerfile ---
@@ -23,11 +23,15 @@ LABEL site="https://nifi.apache.org;
ARG UID=1000
ARG GID=1000
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2921#discussion_r206107026
--- Diff: nifi-docker/dockerhub/pom.xml ---
@@ -61,7 +61,7
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2866
hey, I have some experience with the kerberos setup in kubernetes and I can
check this, but I need a day or too
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2866
To clarify, I didn't want to ask to extend the existing docker-compose file
but to create one that can be used to test the user authentication through
Kerberos. However it's not necessarily a problem
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2927#discussion_r206802784
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -281,6 +281,272 @@ After running the client you will have the CAâs
certificate
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2921
@apiri or @jtstorck if you may have any comments I would appreciate that
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2866
Don't we have to provide the Service Principal Name and the service keytab?
I don't understand how we can be authenticated to NiFi without specifying those.
Could you provide a docker compose
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2866
I didn't mean to involve Zookeeper in this.
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2866
Yes, so I was confused because I supposed single sign on is the default way
we wan't to configure kerberos authentication:
https://nifi.apache.org/docs/nifi-docs/html/administration-guide.html
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2866
All in all if I was right in the previous comment I would highlight that
this is the convenience method and is not the most secure way to authenticate
against Kerberos since it requires the users
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2927#discussion_r206437727
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -281,6 +281,272 @@ After running the client you will have the CAâs
certificate
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2927#discussion_r206455424
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -281,6 +281,272 @@ After running the client you will have the CAâs
certificate
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2927#discussion_r206455131
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -281,6 +281,272 @@ After running the client you will have the CAâs
certificate
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2927#discussion_r206439675
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -281,6 +281,272 @@ After running the client you will have the CAâs
certificate
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/2921
NIFI-5468 Add toolkit to NiFi docker image and use zip archive
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2940
Ran `mvn integration-test -P docker` from nifi-docker after built all the
necessary binaries in `nifi-assembly` and `nifi-toolkit/nifi-toolkit-assembly`.
---
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/2940
NIFI-5487 Move the packages to a version agnostic path and create symâ¦
â¦links in place, add tests to cover, add missing docs on nifi-toolkit
Thank you for submitting a contribution
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2866
@SarthakSahu we didn't mean to discourage you, I beleive it would be great
to have the SPNEGO setup working and it's not far from the proposed changeset
at all. When you create the user principal you
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2970
+1 looks good to me now
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2970
Thanks for pointing this out! Of course we need identity here, but if I'm
right `identity` is called `name` in case of groups.
---
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2965#discussion_r212879535
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/FileAccessPolicyProvider.java
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2970
I'm not trying to suggest naming just to point out that the Group has the
`name` property instead of the `identity` that the User has. The workaround
should be as simple as looping through the groups
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/2905
NIFI-5438 volume support for the NiFi docker containers
Create all volume directories for chowning properly, then create proper
volumes for persistence. Notes:
* Create conf instead of conf
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2894
Pushed a revert and fixed missing imports, however github seems to have
issues, will trigger a new build later.
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2894
had a hard time triggering a build with the import fixes due to github
issues, sorry @bbende , it should be better now
---
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2894#discussion_r202762452
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/entity/ClusterSummaryEntity.java
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/2894
CLI tool extension for cluster summary
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2905
@MikeThomsen sure! If you run the integrations tests you will have the
following images available:
```
docker images | grep nifi | grep 1.8.0-SNAPSHOT
apache/nifi
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2985#discussion_r214943927
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi-env.sh
---
@@ -16,16 +16,38
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2985#discussion_r214952384
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi-env.sh
---
@@ -16,16 +16,38
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2985#discussion_r216244697
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi-env.sh
---
@@ -16,16 +16,38
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2970
Nitpicking but now we do 2 lookups. First we look up the group to get the
identifier then we lookup the same group using that identifier. I beleive it
would be enough to store the group name property
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2870#discussion_r201242505
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -164,6 +164,16 @@ accomplished by setting the `nifi.remote.input.secure
Github user pepov commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2985#discussion_r216688824
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi-env.sh
---
@@ -16,16 +16,38
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/3043
Fixed that and also a checkstyle error that broke the build, hopefully will
pass this time, thanks!
---
GitHub user pepov opened a pull request:
https://github.com/apache/nifi/pull/3043
NIFI-5656 Remove "Node Group" from the default FileAccessPolicyProvider
propertâ¦
â¦er properties, extend the docs, add more logs to help debugging, add
test for the empty case.
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/3043
I didn't think about considering an empty group as not set, but now I can
see that initial admin is treated the same, so will update the PR to work like
that.
I used custom because I
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2970
@kevdoran @achristianson created a follow up PR to avoid an issue with the
default empty "Node Group" in authorizers.xml:
https://github.com/apache/nifi/pull/3043
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/3043
@kevdoran changes are in
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2970
Some unit tests are failing according to the travis build that are relevant:
```
[ERROR]
testOnConfiguredWhenInitialAdminAndLegacyUsersProvided
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2970
Even better, thanks!
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2970
yes
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2866
Sorry I don't have the time to check this right now, need to get back to
this later. What did you use to setup KDC for testing?
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2866
sorry, I was busy lately, but will try to get to this as soon as I can
---
Github user pepov commented on the issue:
https://github.com/apache/nifi/pull/2970
@kevdoran Are you okay with the current state? Also @mcgilman can you take
a look at this?
---
71 matches
Mail list logo
