Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2799
+1, merging to master, thanks @mattyb149
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2558#discussion_r195999042
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2800
+1, merging to master, thanks @dtrodrigues @ottobackwards
---
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2785
NIFI-5296 - Add EL Support with Variable Registry scope on SSL contexâ¦
â¦t service
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2785
@alopresto - could you have a look? I want to be sure I'm not doing
something that would not be allowed for some reasons (I removed unit tests
specifically checking that EL was not allowed, I hope
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2786
NIFI-5297 - EL support in ScanAttribute
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2781
+1, merging to master, thanks @junegunn
---
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2783
NIFI-5293 - add merge.uuid to MergeRecord processor
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2783#discussion_r194400940
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MergeRecord.java
---
@@ -89,6
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2663#discussion_r191668970
--- Diff:
nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/main/resources/docs
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2724
Yeah... I have similar throughput on my side. It sounds really low to me
but have no similar experience so... If I have time, I'll do a test with
Kinesis on AWS side. Anyway, code looks good to me
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2724
Thanks for the update @zenfenan - I've played a bit with it and have two
questions:
- does it make sense to expose both fetch count and batch size for the
publish processor? Do we expect
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r191744175
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r191742961
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r191742124
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml
---
@@ -127,8 +133,104 @@
5.6.8
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r191744098
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2615#discussion_r191741767
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/pom.xml
---
@@ -120,6 +132,22 @@
1.7.0-SNAPSHOT
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2762
+1, merging to master, thanks @ijokarumawak
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2764
Tested the command reported in the JIRA, working as expected, merging to
master, thanks @bbende
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2756
reviewing...
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2756
+1, working as expected, merging to master, thanks @mcgilman
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2754
Code LGTM, full build OK, merging to master, thanks @mgaido91
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2754
@zenfenan - I've tested the change with a simple flow. Are you thinking
about a specific edge case? I'm not sure to see how this would affect the logic.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2728
Code LGTM. I won't be a position to test all the adapters but will do some
tests later (I'm in the middle of something else right now but should be able
to get back on this tomorrow).
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2724
Out of curiosity, what kind of performance do you get in your testing?
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2835
+1, merging to master, thanks @mattyb149
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2833#discussion_r199728163
--- Diff:
nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/main/java/org/apache/nifi/processors/jolt/record/JoltTransformRecord.java
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2833#discussion_r199727643
--- Diff:
nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/main/java/org/apache/nifi/processors/jolt/record/JoltTransformRecord.java
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2833#discussion_r199728490
--- Diff:
nifi-nar-bundles/nifi-jolt-record-bundle/nifi-jolt-record-processors/src/main/java/org/apache/nifi/processors/jolt/record/JoltTransformRecord.java
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2829
+1, confirmed the change is working as expected, merging to master, thanks
@MikeThomsen
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2828
@MikeThomsen - could you rebase against master? thanks!
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2832
reviewing...
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2832
+1, ran a build with the fix and confirmed expected behavior, merging to
master, thanks @markap14
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2828
Thanks @MikeThomsen - will wait for a final review from @apiri.
Out of curiosity, any reason why to use ``bitnami/zookeeper``?
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2221
Just a quick comment: would it make sense to also add support for time zone
as we do in expression language? Can be done in a separate JIRA though.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2229
Thanks @patricker, full build with contrib check raised two issues:
[WARNING] src/main/java/org/apache/nifi/csv/CSVReader.java[36:8] (imports)
UnusedImports: Unused import
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2225
+1, LGTM, did a full build with contrib-check and few tests against
Postgres database. Merging to master, thanks @mattyb149
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2037
Hey @markap14, I finally found some time to get back on this guy. I added
the "split" mode as you suggested with some unit tests and an example in the
additional details doc. L
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2214
Ran few builds and confirmed the issue without the fix. Then applied the
fix and didn't get any exception after few builds. Merging to master. Thanks!
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2205
Thanks for the feedback @markap14! I'll have a look for variables at
processor level (never noticed it to be honest). Regarding the mock framework,
I added some changes
[here](https://github.com
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2357
+1, merging to master, thanks @apiri
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r160465819
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java
---
@@ -232,6 +233,13
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2391
NIFI-4747 - Removed directory existence check in GetHDFS
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r160459279
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java
---
@@ -75,6
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r160469685
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveQL.java
---
@@ -232,6 +233,13
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2402
Thanks @zenfenan, +1, merging to master
---
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi-registry/pull/92
NIFIREG-122 - add build status to main README
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi-registry NIFIREG-122
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2056
Hey @markap14, I rebased against master and followed your recommandations.
Let me know if I missed something! Thanks for the review!
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2413
+1, merging to master, thanks @andrewmlim
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2391#discussion_r162701033
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFS.java
---
@@ -220,16 +220,6
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2399
+1, merging to master, thanks @jfrazee
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2401
+1, LGTM, thanks for the PR @MikeThomsen and thanks for the review @mgaido91
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2336
Hey @panelladavide - I think the last version of your PR is missing some
parts of your code. Can you take a look? Could you rebase it against master and
squash commits into a single one?
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2310
Hi guys,
@joewitt - are you a +1 on the L part?
I'm a +1 on the code and can take care of merging it.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2431
Yes you're right, I'll add the UUID as well!
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2431
Yep, there could be some situations where it would be useful. Added! Thanks!
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2431
Good catch, I didn't try that. Probably best to fix the issue before,
otherwise it could be confusing if users change the reporting task name after
they created it. Do you want to raise a JIRA
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2432
NIFI-4815 - Add EL support to ExecuteProcess
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2431
NIFI-4814 - Add distinctive attribute to S2S reporting tasks
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2426#discussion_r163554236
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -213,11
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2426#discussion_r163572837
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
---
@@ -213,11
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2431
I'll need to update this PR if #2430 is merged first.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2426
+1, merging to master, thanks @mgaido91 @ijokarumawak
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2398
+1, merging to master, thanks @markap14
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2440#discussion_r165665991
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureBlobStorage.java
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2440
LGTM, merging to master, thanks @zenfenan
---
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi-minifi/pull/114
MINIFI-434 - PullHttpChangeIngestor should preserve security properties
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi-minifi/pull/113
MINIFI-435 - updated httpcomponents versions to match NiFi dependencies
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2440#discussion_r165593121
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureBlobStorage.java
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi-minifi/pull/115
MINIFI-433 - PG Variable Registry support in templates
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2436#discussion_r167655116
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/DeleteAzureBlobStorage.java
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2436#discussion_r167655333
--- Diff:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/DeleteAzureBlobStorage.java
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2433
Code LGTM, ran few tests successfully, merging to master.
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2449#discussion_r167647277
--- Diff: nifi-docs/src/main/asciidoc/expression-language-guide.adoc ---
@@ -1644,9 +1644,9 @@ Divide. This is to preserve backwards compatibility
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2449
+1, merging to master, thanks @Leah-Anderson @zenfenan
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2457
+1, merging to master, ran some tests on a local Mongo, all looks good.
Thanks!
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2226
+1 as well, merging to master, thanks guys
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2436
+1, thanks for the changes @zenfenan, merging to master.
---
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r168924543
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/SelectHiveQL.java
---
@@ -310,6 +311,15
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2447
Thanks @mattyb149 and @MikeThomsen - ran some tests on large tables and
observed the expected behavior. +1, merging to master.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2475
Few suggestions regarding existing processors: ExtractText and ReplaceText
can also be CPU intensive when using some tricky regular expressions. Same goes
for grok processors as well
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2138#discussion_r168924048
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHiveQLProcessor.java
---
@@ -75,6
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2481
@e-kolpakov fair points. I added a commit to address your comments and
check how we process header and valid rows when we have escaped fields. This
change means that we will always keep escaping
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2477
Played a bit with the cli and it's really cool. Amazing job @bbende &
@aperepel!
Can we consider adding an online documentation for it (in addition to the
README)? I think @andrew
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/2481
NIFI-4892 - ValidateCSV: no doublequote escaping in invalid output
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2488
+1, merging to master, thanks @mattyb149
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2101
It looks OK to me, I'd just suggest allowing EL on username/password. Will
probably be useful with the Registry stuff. I know sensitive properties are not
handled by the registry work yet
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2101
Did some additional local tests. LGTM.
+1, merging to master, thank you all.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2490
@david-streamlio - just in case you didn't notice, the PR is now closed,
you can reopen it or open a new one and add NIFI-4908 in the commit message.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2477
@bbende agree with your points: we can keep things as-is for now and have a
larger effort for documentation with follow-up JIRAs.
@aperepel I *really* believe that online documentation
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2101#discussion_r169635658
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/pom.xml ---
@@ -0,0 +1,88 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2101#discussion_r169969726
--- Diff:
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/pom.xml ---
@@ -0,0 +1,88 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2219
@mcgilman - when adding a variable to a versioned PG, it does not show
changes to be committed. Is it expected?
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2219
@bbende - let's say I create a PG with a processor ListHDFS and I set
``${principal}`` and ``${keytab}`` for Kerberos properties. If I start
versioning and then add the variables
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2219
@bbende @mcgilman - I just did few tests with latest changes and I want to
confirm this is the expected behaviour: if versioning a process groups with
defined variables that are used in processors
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2354
+1, confirmed that default system timestamp precision is set as expected,
merging to master, thanks @ijokarumawak
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2355
+1, merging to master, thanks @ijokarumawak
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2310
OK... So I've been doing some tests and it's working as I'd expect. The
only remark I have is in terms of performances: ingestion rate is very low (and
creating a lot of "dropped") bu
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2219
> When a version of a PG is saved to the registry it does capture all of
the variables and their values at that point in time. So in a PG that already
has v1 saved to the registry, if you
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2138
Hey @mattyb149, I rebased against master to account for the changes made by
Mark in the test framework. Let me know if there is something else.
---
701 - 800 of 1144 matches
Mail list logo
